July 2014 - Wine-Devel - list.winehq.org

Re: shell32: Implement IEnumShellItems for IShellItemArray.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8193 Your paranoid android. === w7u (32 bit shlfolder) === shlfolder.c:3688: Test failed: Got 00000000 === w8 (32 bit shlfolder) === shlfolder.c:3688: Test failed: Got 00000000

July 30, 2014

Re: (Retry)[4/5] imm32: Restrict crossthread Association and destruction

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8186 Your paranoid android. === wvistau64 (32 bit imm32) === imm32.c:629: Test failed: ImmGetCandidateWindow should succeed === w2008s64 (32 bit imm32) === imm32.c:629: Test failed: ImmGetCandidateWindow should succeed === wvistau64 (64 bit imm32) === imm32.c:629: Test failed: ImmGetCandidateWindow should succeed === w2008s64 (64 bit imm32) === imm32.c:629: Test failed: ImmGetCandidateWindow should succeed

July 30, 2014

Re: (Retry)[6/6]imm32: limit cross thread access to ImmSet* functions

by Aric Stewart

Sorry this patch is mislabeled as [6/6] it should be [5/5] -aric On 7/30/14, 3:32 PM, Aric Stewart wrote: > Resolves bug 35361 > --- > dlls/imm32/imm.c | 21 +++++++++++++++++++++ > dlls/imm32/tests/imm32.c | 28 ++++++++++++++-------------- > 2 files changed, 35 insertions(+), 14 deletions(-) > > > > >

July 30, 2014

Re: [PATCH] riched20: Stub for ITextRange interface and implement ITextDocument::Range.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8174 Your paranoid android. === w2000pro (32 bit richole) === The test timed out

July 30, 2014

Re: shell32: Create profile directories available in Vista and above

by Alexandre Julliard

Michael Müller <michael(a)fds-team.de> writes: > diff --git a/include/shlobj.h b/include/shlobj.h > index 9025a73..dcea14e 100644 > --- a/include/shlobj.h > +++ b/include/shlobj.h > @@ -1529,6 +1529,15 @@ HRESULT WINAPI SHGetFolderPathW(HWND hwnd, int nFolder, HANDLE hToken, DWORD dwF > #define CSIDL_CDBURN_AREA 0x003b > #define CSIDL_COMPUTERSNEARME 0x003d > #define CSIDL_PROFILES 0x003e > + > +/* Wine internal CSIDLs */ > +#define CSIDL_WINE_CONTACTS 0x0043 > +#define CSIDL_WINE_DOWNLOADS 0x0047 > +#define CSIDL_WINE_LINKS 0x004d > +#define CSIDL_WINE_APPDATA_LOCALLOW 0x004e > +#define CSIDL_WINE_SAVED_GAMES 0x0062 > +#define CSIDL_WINE_SEARCHES 0x0063 This should be private to shell32. Also please avoid the WINE_ prefix, that makes it sound like they are Wine extensions (the defines may not exist on Windows, but the folders do). -- Alexandre Julliard julliard(a)winehq.org

July 30, 2014

Re: Confusion with submitting changes

by Michael Stefaniuc

On 07/30/2014 05:44 AM, Kyle Marek wrote: > On 07/29/2014 11:31 PM, Nikolay Sivov wrote: >>> Can I not make a pull request on my changes? >> >> No. >> >>> I also noticed that it said that not everyone can submit patches and i >>> inferred by the linked pages that it's to prevent legal trouble. How can >>> I become eligible to submit changes? >> >> There are certain rules to that, wiki probably has that information >> already. For example your patches will be rejected automatically if >> you had/have access to MS source code, doesn't matter if it's >> available for general public or not. Also you can't use implementation >> details information extracted using Wine's tracing. You can't >> disassemble native modules of course. Maybe there's more but these are >> the most important. > I've read these rules. Is this it? I haven't had access to Microsoft > source code nor do I plan to use wine's tracking or plan to disassemble > anything; It's pretty much legal common sense to avoid that. So, I am > pretty much eligible to submit changes? Then you should be fine. bye michael

July 30, 2014

Re: Regarding DXVA support in Wine (DXVA2 -> VA_API)

by Jaeyong Yoo

Oops sorry, the mail sent while I'm writing... Here goes again: Hello Wine I’ve seen Michael Muller is writing DXVA2 -> VA_API conversion in the following link: http://www.winehq.org/pipermail/wine-devel/2014-March/103687.html I'm wondering the current status of Michael's work. Is there more progress, such as supporting MPEG4 APIs? Best regards, Jaeyong

July 30, 2014

Regarding DXVA support in Wine (DXVA2 -> VA_API)

by Jaeyong Yoo

Hello Wine, I've seen Michael Muller is writing DXVA2 -> VA_API conversion in the following link:

July 30, 2014

Re: Confusion with submitting changes

by Kyle Marek

On 07/29/2014 11:31 PM, Nikolay Sivov wrote: >> Can I not make a pull request on my changes? > > No. > >> I also noticed that it said that not everyone can submit patches and i >> inferred by the linked pages that it's to prevent legal trouble. How can >> I become eligible to submit changes? > > There are certain rules to that, wiki probably has that information > already. For example your patches will be rejected automatically if > you had/have access to MS source code, doesn't matter if it's > available for general public or not. Also you can't use implementation > details information extracted using Wine's tracing. You can't > disassemble native modules of course. Maybe there's more but these are > the most important. I've read these rules. Is this it? I haven't had access to Microsoft source code nor do I plan to use wine's tracking or plan to disassemble anything; It's pretty much legal common sense to avoid that. So, I am pretty much eligible to submit changes?

July 30, 2014

Re: Confusion with submitting changes

by Nikolay Sivov

> Can I not make a pull request on my changes? No. > I also noticed that it said that not everyone can submit patches and i > inferred by the linked pages that it's to prevent legal trouble. How can > I become eligible to submit changes? There are certain rules to that, wiki probably has that information already. For example your patches will be rejected automatically if you had/have access to MS source code, doesn't matter if it's available for general public or not. Also you can't use implementation details information extracted using Wine's tracing. You can't disassemble native modules of course. Maybe there's more but these are the most important.

July 30, 2014