July 2014 - Wine-Devel - list.winehq.org

Re: [1/9] wined3d: Make the card selection for binary drivers depend only on gl_renderer like it already is for the mesa drivers and remove the gl_info parameter from the select_card callback.

by Henri Verbeet

On 4 July 2014 00:40, Andrei Slăvoiu <andrei.slavoiu(a)gmail.com> wrote: > + /*Direct 3D 9 SM3*/ This is pretty minor, but could you please make that "/* Direct3D 9 SM3 */", etc.? > + {"HD 6770M",CARD_AMD_RADEON_HD6600M}, > + {"HD 6750M",CARD_AMD_RADEON_HD6600M}, Since you're touching the entire table anyway, please add some extra space here, preferably enough to make the "Radeon Xpress" entry from the next patch fit as well. > +···· > + /* Radeon R5xx */ Trailing whitespace. You missed select_card_nvidia_mesa(): directx.c:2270:5: warning: initialization from incompatible pointer type [enabled by default] directx.c:2270:5: warning: (near initialization for ‘nvidia_gl_vendor_table[1].select_card’) [enabled by default]

July 7, 2014

Re: [0/9] wined3d: Rework card pci id selection mechanism

by Henri Verbeet

> Question: is it intended to return an AMD card as fall-back for VMware? > Sort of. You could probably make an argument for always returning e.g. CARD_VMWARE_SVGA3D as fallback for VMware, but returning an AMD card is probably as good as any other.

July 7, 2014

Re: [1/6] ntdll: refactor NTDLL_create_struct_sd and NTDLL_free_struct_sd so that other modules are able to use them

by Alexandre Julliard

Joris van der Wel <joris(a)jorisvanderwel.com> writes: > So should I instead copy paste those 2 functions into kernel32 (with > NTDLL renamed to KERNEL32)? Possibly, though there may be better ways to do that. -- Alexandre Julliard julliard(a)winehq.org

July 7, 2014

Re: [1/6] ntdll: refactor NTDLL_create_struct_sd and NTDLL_free_struct_sd so that other modules are able to use them

by Joris van der Wel

So should I instead copy paste those 2 functions into kernel32 (with NTDLL renamed to KERNEL32)? On Mon, Jul 7, 2014 at 9:15 AM, Alexandre Julliard <julliard(a)winehq.org> wrote: > Joris van der Wel <joris(a)jorisvanderwel.com> writes: > >> ntdll: refactor NTDLL_create_struct_sd and NTDLL_free_struct_sd so >> that other modules are able to use them (extern). New names are >> wine_server_create_struct_sd and wine_server_free_struct_sd. > > That's not used enough to warrant new private exports from ntdll. > > -- > Alexandre Julliard > julliard(a)winehq.org

July 7, 2014

Re: [PATCH 1/2] riched20: Implement ITextSelection::GetText. (try 3)

by Huw Davies

On Fri, Jul 04, 2014 at 07:00:16PM +0800, Jactry Zeng wrote: > A few weeks ago, I have made some tests about this problem. And it seem is an > unimplement feature of Rich edit control and should not be fixed in ME_GetTextW > or ITextSeletction::GetText simply: > > 1. end-of-story is different from end-of-paragraph > From document of ITextDocument::GetStoryCount: Rich edit controls have only one > story.[1] > So ‘story’ may is an unit like 'paragraph' in Rich edit control. We may need > add a MERF_ENDSTORY to implement it.[2] > > 2. What does the end-of-story looks like? > When we run the wordpad with native riched20, we can use ‘ctrl + shitf + →’ to > select the ‘space’ at the end of the Rich edit control. But we cannot set the > cursor behind it.(a picture here[3]) > And wine’s riched20 didn’t implement this ‘space’. This 'space' may is the end- > of-story. > > A crash will happen when we copy the ‘space’ from a native Rich edit control to > a builtin one.(backtrace.txt[4]) > > BTW, there is a know bug of EM_SETSEL: cannot select the last character of Rich > edit control.[5] > > 3. > From the last paragraph of this blog: http://blogs.msdn.com/b/murrays/archive/ > 2008/11/22/paragraphs-and-paragraph-formatting.aspx > It is sure there is a final EOP in a Rich edit control. > > There seems to be every indication that we should implement the final EOP of > Rich edit control rather than just append a ‘\r’ in ITextSelection::GetText. > So I just let a FIXME comment there. I am not sure if I am right. > Do you have any suggestion? Well first of all, if there are bugs with the underlying richedit, these need fixing first. Note, that every richedit consists of at least one paragraph (and hence one final EOP). I was suggesting adding to ME_GetTextW the ability to append a '\r' if it were passed an appropriate flag, of course this wouldn't be the behaviour used for its current callers. There's already a diTextEnd item in the display list to mark the end of the document, so there should be no need to add a new end-of-story marker. Most of the iterator functions stop when this is reached, so you tend not to actually see it, but that shouldn't be a problem. Huw.

July 7, 2014

Re: [1/6] ntdll: refactor NTDLL_create_struct_sd and NTDLL_free_struct_sd so that other modules are able to use them

by Alexandre Julliard

Joris van der Wel <joris(a)jorisvanderwel.com> writes: > ntdll: refactor NTDLL_create_struct_sd and NTDLL_free_struct_sd so > that other modules are able to use them (extern). New names are > wine_server_create_struct_sd and wine_server_free_struct_sd. That's not used enough to warrant new private exports from ntdll. -- Alexandre Julliard julliard(a)winehq.org

July 7, 2014

Re: kernel32: Partially implement GetGeoInfo()

by Dmitry Timoshkov

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > [0001-kernel32-Partially-implement-GetGeoInfo.patch text/x-patch (32.2KB)] Some of this info already exists in the locale data under dlls/kernel32/nls and returned by GetLocaleInfo(), probably it would be a good idea to add missing geo data there as well (auto-generate from the public source) and use it from inside of GetGeoInfo(). -- Dmitry.

July 6, 2014

Re: [4/9] wined3d: replace vendor specific callbacks with generic code that uses vendor specific renderer string tables

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-07-05 14:19, schrieb Andrei Slăvoiu: > Is it ok to replace it with this one? > http://developer.amd.com/resources/hardware-drivers/ati-catalyst-pc-vendor-… > Looks ok to me. Alternatively this could be put on a wiki page. Your call. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTuZ5WAAoJEN0/YqbEcdMw52cP/39Q3kTmxCzn2708t1ZH1war EF70+UT6ElT9A7aI0BY/5ODlgEHIo/9n1jINVRYRuKKW5v1AIi0tuvbKxZnOgQSw bpxm/t91tYxS7Vek19TAo3SjUCDWaJila6Q3+XZv7c41YJQSsPydKwqjWnUql895 kyc0VFDy9iyDKPfga72eVVvSX/MAOeW1fUOe9ATVj5LJ/bqQXB1GmPLGwtg8DDwm YvbhJS+c8Gyl8JgbB5IxTtHf/LlPcM/52v8Xpdbj9m0BpUuKAaSQwVBc5RXNCak3 Q4IIbdOmnc5c/5ZFy8mYaKbjAzdcT8K2kwLQurCcohl7KEf7BzxnbAknQ2WGu6OH uJyGEY6GqtirWlwrjKJGOnEHZnf+IiN0WxcryxSBpN9PYNfxnija5YOdtVKnnmVG IL3S1gbopm5FS297h09k5lze/UsdWwsNOpkOeoolxuJO9qcKPQCOjiuBasACi/uX cd1l/KYATVnJ3WWur3nW/bNJ78i/PDFvIKoLooQF20SPvqf8Nr1GESINkX+OGX+v 7t/Jsxyy4eYm7aIZn6Qs2E4nb3v4CkQNsUEbxUQodSSmKgt8ezHwPrIbRRO4IoLN crTatz8nyT32JYLVGWYUrBbZYt2xJLk3CYuhrB4ftt0lPSAOEMaaAs3EgVLVuKuw Tkqfa8kRH8ptBQc9RwFR =e/ad -----END PGP SIGNATURE-----

July 6, 2014

Re: wininet: Call WSAStartup/WSACleanup to mime the Windows behavior

by Erich E. Hoover

On Sun, Jul 6, 2014 at 12:32 PM, Joris van der Wel <joris(a)jorisvanderwel.com> wrote: > First section on http://wiki.winehq.org/SubmittingPatches ;) Ah, so it is - clearly everyone's not seeing it though ;) Best, Erich

July 6, 2014

Re: wininet: Call WSAStartup/WSACleanup to mime the Windows behavior

by Joris van der Wel

First section on http://wiki.winehq.org/SubmittingPatches ;) <http://wiki.winehq.org/SubmittingPatches> > Maybe we should update http://wiki.winehq.org/CleanRoomGuidelines and > make it more prominent on http://www.winehq.org/devel/ ? I don't even > know how to get to it from that page, and it seems like a pretty > important document... > > Best, > Erich > > >

July 6, 2014