August 2014 - Wine-Devel - list.winehq.org

Re: wpcap: Load libpcap dynamically

by Sebastian Lackner

Linking it dynamically has a great advantage for distributions and package maintainers providing precompiled wine builds. I would also like to provide my wine builds with wpcap support (some users might want to use it) - but when I do that a fixed dependency is required. This is especially confusing when wine is only used as a dependency, like in case of pipelight, where users are already wondering why we now depend on libpcap (those are wine builds where it was already enabled): https://answers.launchpad.net/pipelight/+question/253591 I guess other package maintainers might probably think the same, but most haven't updated to 1.7.25 yet, and are not aware of this problem. Just converting the static dependency to a dynamic dependency would be the easiest approach to solve this - the alternative would be to split wine into (more) packages, and avoid the libpcap dependency on the main one... or just leave this feature exclusively for source-based distros where users have fine-grained control about which features they want. :/ Regards, Sebastian Am 26.08.2014 um 11:55 schrieb Alexandre Julliard: > André Hentschel <nerv(a)dawncrow.de> writes: > >> This is intended for packagers, without this patch libpcap easily becomes a fixed dependency of wine. >> Something we don't want i guess. > > It's only used for wpcap, which can't work without it anyway, so I don't > see any need to make it dynamic. >

Aug. 26, 2014

Re: wpcap: Load libpcap dynamically

by Alexandre Julliard

André Hentschel <nerv(a)dawncrow.de> writes: > This is intended for packagers, without this patch libpcap easily becomes a fixed dependency of wine. > Something we don't want i guess. It's only used for wpcap, which can't work without it anyway, so I don't see any need to make it dynamic. -- Alexandre Julliard julliard(a)winehq.org

Aug. 26, 2014

Re: [PATCH 2/5] comdlg32: Implement calling IFileDialogEvents::OnTypeChange().

by Alexandre Julliard

David Hedberg <david.hedberg(a)gmail.com> writes: > @@ -1652,6 +1666,11 @@ static LRESULT on_command_filetype(FileDialogImpl *This, WPARAM wparam, LPARAM l > } > CoTaskMemFree(filename); > } > + > + /* The documentation claims that OnTypeChange is called only > + * when the dialog is opened, but this is obviously not the > + * case. */ > + events_OnTypeChange(This); It would be more obvious with a test case... -- Alexandre Julliard julliard(a)winehq.org

Aug. 25, 2014

Re: [PATCH 2/2] vbscript: Implemented Time(try 3)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8660 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

Aug. 25, 2014

Re: [PATCH 1/2] vbscript: Implemented Date(try 3)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8659 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

Aug. 25, 2014

Re: [PATCH 1/2] vbscript: Implemented Date(try 2)

by Shuai Meng

Thank you for commenting~ 2014-08-23 23:45 GMT+08:00 Nikolay Sivov <nsivov(a)codeweavers.com>: > On 8/23/2014 19:38, Shuai Meng wrote: > >> + GetLocalTime(&lt); >> + ud.st = lt; >> + VarDateFromUdateEx(&ud, 0, VAR_DATEVALUEONLY, &date); >> + return return_date(res, date); >> > It's better to init 'wDayOfYear' part too, even if it's not used > internally +variant will show its garbage value. I will check this. > Also I'm not sure about ignoring return value of VarDateFromUdateEx(). > > > I am not sure as well , but maybe it's better to add it.

Aug. 24, 2014

Re: configure: Add -linotify when present, for non-Linux platforms.

by Gerald Pfeifer

On Tue, 26 Jun 2012, Alexandre Julliard wrote: >> A FreeBSD user ran into this when sys/inotify.h was present via an >> extra package and Wine went ahead using that, only to fail at link- >> time. > We'd want to use kqueue instead on FreeBSD. Yes, but _if_ inotify is present, we can (should?) use that until someone implements that alternate approach, can't we? Right now the build simply fails in that case, since we pick up the headers, but not the library. Can I talk you into accepting the patch below? :-) Gerald --- configure.ac | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/configure.ac b/configure.ac index 1753e14..7d0fa44 100644 --- a/configure.ac +++ b/configure.ac @@ -383,6 +383,8 @@ dnl Check for -li386 for NetBSD and OpenBSD AC_CHECK_LIB(i386,i386_set_ldt) dnl Check for -lossaudio for NetBSD AC_CHECK_LIB(ossaudio,_oss_ioctl) +dnl Check for -linotify for non-Linux platforms +AC_CHECK_LIB(inotify,inotify_init) AC_SUBST(XLIB,"") AC_SUBST(OPENGL_LIBS,"") -- 1.7.7.3

Aug. 23, 2014

Re: [PATCH 2/2] vbscript: Implemented Time(try 2)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8634 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

Aug. 23, 2014

Re: [PATCH 1/2] vbscript: Implemented Date(try 2)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8633 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

Aug. 23, 2014

Re: [PATCH 1/2] vbscript: Implemented Date(try 2)

by Nikolay Sivov

On 8/23/2014 19:38, Shuai Meng wrote: > + GetLocalTime(&lt); > + ud.st = lt; > + VarDateFromUdateEx(&ud, 0, VAR_DATEVALUEONLY, &date); > + return return_date(res, date); It's better to init 'wDayOfYear' part too, even if it's not used internally +variant will show its garbage value. Also I'm not sure about ignoring return value of VarDateFromUdateEx().

Aug. 23, 2014