August 2014 - Wine-Devel - list.winehq.org

Re: [1/5] ntdll/tests: Add tests for FILE_PIPE_INFORMATION. (try 2)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8610 Your paranoid android. === w8 (32 bit pipe) === pipe.c:546: Test failed: can't open pipe, GetLastError: e7 pipe.c:622: Test failed: can't open pipe, GetLastError: e7

Aug. 21, 2014

Re: [4/4] ntdll/tests: Add tests for FILE_PIPE_INFORMATION.

by Alexandre Julliard

Sebastian Lackner <sebastian(a)fds-team.de> writes: > +#define check_pipe_handle_state(handle, r, c) \ > + do \ > + { \ > + memset(&fpi, 0x55, sizeof(fpi)); \ > + if (handle == INVALID_HANDLE_VALUE) break; \ > + res = pNtQueryInformationFile(handle, &iosb, &fpi, sizeof(fpi), (FILE_INFORMATION_CLASS)23); \ > + ok(!res, "NtQueryInformationFile returned %x\n", res); \ > + ok(fpi.ReadMode == r, "ReadMode == %x\n", fpi.ReadMode); \ > + ok(fpi.CompletionMode == c, "CompletionMode == %x\n", fpi.CompletionMode); \ > + } \ > + while (0) Please use a function instead of a macro for that sort of thing. -- Alexandre Julliard julliard(a)winehq.org

Aug. 20, 2014

Re: [PATCH 1/2] vbscript: Implemented Date(try 2)

by Piotr Caban

On 08/19/14 17:56, Shuai Meng wrote: > Change log: > checked the type of returned variant instead of printing it. > --- > dlls/vbscript/global.c | 10 ++++++++-- > dlls/vbscript/tests/api.vbs | 2 ++ > 2 files changed, 10 insertions(+), 2 deletions(-) > The patch will not apply cleanly in current git. I've sent a patch that adds support for VAR_TIMEVALUEONLY and VAR_DATEVALUEONLY flags to VarDateFromUdateEx function. I think it will be nicer to use this function here. Thanks, Piotr

Aug. 20, 2014

Re: Wine test analysis August 6

by Francois Gouget

On Tue, 19 Aug 2014, André Hentschel wrote: [...] > But it truly has a strange locale config, i don't know for what it might be useful: > > "A default install of Windows 7 Ultimate 64bit in VMware plus SP1 and > IE9, running the 32bit tests with elevated privileges and a mixed > locale: Formats=Inuktitut (Syllabics, Canada); Location=Israel; > Language=German (Germany); SystemLocale=Japanese (Japan)." It's useful for testing. As mentionned in the VM description, in the Windows Control Panel the user can choose different settings for Formats, the UI display language and the system locale. But how can our tests determine which of these is used by APIs such as SHFormatDateTime() if all our VMs use the same value for all three? The answer is they can't. That's why this VM is configured to have a different value for each setting. I have further tried to pick values that maximize the differences between each setting. After all picking US, British and Canadian English would be pretty unlikely to expose bugs. Now maybe Inuktitut was a bit overboard but AFAIR the resulting formats were the ones most unlikely to match any of the others. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ If you think the whole world revolves around you, quit staring at the GPS display while driving.

Aug. 19, 2014

Re: Wine test analysis August 6

by André Hentschel

Am 06.08.2014 um 23:05 schrieb Jeremy White: > There are five failures not annotated in any way, and my link for them was blue, so they might be new and easy: > http://test.winehq.org/data/tests/shlwapi:ordinal.html This one is mostly fixed by badfdaf56c446cb37305e9df101cb1d9411afe0a besides: https://test.winehq.org/data/1986e496c79915a14beac3050bef371a97ab0296/win7_… But it truly has a strange locale config, i don't know for what it might be useful: "A default install of Windows 7 Ultimate 64bit in VMware plus SP1 and IE9, running the 32bit tests with elevated privileges and a mixed locale: Formats=Inuktitut (Syllabics, Canada); Location=Israel; Language=German (Germany); SystemLocale=Japanese (Japan)."

Aug. 19, 2014

Re: [PATCH 2/2] vbscript: Implemented Time(try 2)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8592 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

Aug. 19, 2014

Re: [PATCH 1/2] vbscript: Implemented Date(try 2)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8591 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

Aug. 19, 2014

Re: d3d10_1.idl: Added some missing constants.

by Jacek Caban

On 08/18/14 13:59, Henri Verbeet wrote: > In my copy of the PSDK these are guarded by _D3D10_1_CONSTANTS, > although it's not entirely clear to me if that actually does anything, > since it's only used there, inside d3d10_1.idl. Yeah, this doesn't make much sense. Anyway, I sent a patch adding the guard for sake of compatibility. Jacek

Aug. 19, 2014

Re: [1/2] wbemprox: Implement __SystemSecurity::GetSD.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8576 Your paranoid android. === wvistau64 (64 bit query) === query: unhandled exception c0000005 at 0000000077336B27 === w2008s64 (64 bit query) === query: unhandled exception c0000005 at 0000000077C76B27

Aug. 18, 2014

Re: [PATCH 7/7] vbscript: Implemented Log(try 4)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8570 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

Aug. 18, 2014