September 2014 - Wine-Devel

Re: wined3d: Correctly display fog for right-handed projection matrix

by Bruno Jesus

On Thu, Sep 18, 2014 at 3:30 PM, Joachim Priesner <joachim.priesner(a)web.de> wrote: > + // A right-handed perspective projection matrix designed so that vertices > + // (x in [-1..1], y in [-1..1], z = 0.1) will be mapped to the view plane. > + // Obtained from D3DXMatrixPerspectiveFovRH with the parameters > + // fov=84.29deg, aspect=640/480 near=0.01, far=100 Hi, Joachim. Please don't use C++ style comments, see: http://wiki.winehq.org/DeveloperFaq#head-24502845ecdabaeb82c82889a665c445d8… https://www.winehq.org/site/docs/winedev-guide/style-notes

Sept. 18, 2014

Re: [PATCH] vbscript: Implemented RGB

by Nikolay Sivov

On 09/18/2014 08:46 PM, Shuai Meng wrote: > + LONG total, color[3];//color[0] for red, color[1] for green, color[2] for blue. This could be just 'int', as you use to_int(). > static HRESULT return_int(VARIANT *res, int val) > { > - if((short)val == val) > - return return_short(res, val); > - That's a questionable thing to do as it affects all other places where this helper is used. > + if(color[i] > 255) > + color[i] = 255; This needs a test too. > + total = color[0] + 256 * color[1] + 256 * 256 * color[2]; RGB() macro does the same thing.

Sept. 18, 2014

Re: [PATCH] vbscript: Implemented RGB

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8974 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

Sept. 18, 2014

Re: [PATCH] vbscript: Implemented RGB

by Qian Hong

Hi Shuai, Please don't use C++ style comment, see: http://wiki.winehq.org/DeveloperFaq#head-24502845ecdabaeb82c82889a665c445d8… https://www.winehq.org/site/docs/winedev-guide/style-notes

Sept. 18, 2014

Re: [PATCH 4/5] riched20: Stub for ITextFont interface and implement ITextRange::GetFont.

by Jactry Zeng

Hi Huw, 2014-09-17 18:23 GMT+08:00 Huw Davies <huw(a)codeweavers.com>: > > Since the ITextFont objects do hold a ref on their parent range / > selection objects I don't think we need the list stuff again. > > I wouldn't store the reOle pointer here, but use txtRge / txtSel > to access it (and check for disconnections). You probably > want a helper function to do that. I will have another try. Thanks for your review! -- Regards, Jactry Zeng

Sept. 17, 2014

Re: [PATCH 4/5] riched20: Stub for ITextFont interface and implement ITextRange::GetFont.

by Huw Davies

On Wed, Sep 17, 2014 at 05:39:23PM +0800, Jactry Zeng wrote: > > +typedef struct ITextFontImpl { > + ITextFont ITextFont_iface; > + LONG ref; > + struct list entry; > + > + IRichEditOleImpl *reOle; > + ITextRangeImpl *txtRge; > + ITextSelectionImpl *txtSel; > +} ITextFontImpl; Since the ITextFont objects do hold a ref on their parent range / selection objects I don't think we need the list stuff again. I wouldn't store the reOle pointer here, but use txtRge / txtSel to access it (and check for disconnections). You probably want a helper function to do that. Huw.

Sept. 17, 2014

Re: [PATCH 4/5] riched20: Implement ITextRange::Collapse. (try 2)

by Jactry Zeng

Thank you! A newer version was sent. 2014-09-17 16:39 GMT+08:00 Huw Davies <huw(a)codeweavers.com>: > On Wed, Sep 17, 2014 at 11:35:50AM +0300, Indrek Altpere wrote: > > This seems to be a typo, I think the original variable name was mean to > be > > isedge or is_edge. > > No, I fairly sure it's short for degenerate - that term is used in the > docs. > > > Perhaps this check would be simpler to understand and would not create > local > > variable if it were like this? > > > > if (*end == *start) > > return S_FALSE; > > Yup, just suggested that too (I need more coffee!). > > Thanks, > Huw. > > > -- Regards, Jactry Zeng

Sept. 17, 2014

Re: winedbg: Respect TMPDIR environment variable

by Michael Stefaniuc

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 09/16/2014 09:25 PM, André Hentschel wrote: > First attack on https://bugs.winehq.org/show_bug.cgi?id=14838 > > diff --git a/programs/winedbg/gdbproxy.c > b/programs/winedbg/gdbproxy.c index 0865f44..d7596a0 100644 --- > a/programs/winedbg/gdbproxy.c +++ b/programs/winedbg/gdbproxy.c @@ > -2342,11 +2342,13 @@ static BOOL gdb_exec(const char* wine_path, > unsigned port, unsigned flags) { char buf[MAX_PATH]; int > fd; - const char* gdb_path; + const char *gdb_path, > *tmp_path; FILE* f; > > if (!(gdb_path = getenv("WINE_GDB"))) gdb_path = "gdb"; - > strcpy(buf,"/tmp/winegdb.XXXXXX"); + if (!(tmp_path = > getenv("TMPDIR"))) tmp_path = "/tmp"; + strcpy(buf, tmp_path); + > strcat(buf, "/winegdb.XXXXXX"); Just wondering, as we already have the .wine-$UID directory in TMPDIR shouldn't this file be placed in that directory too? > fd = mkstemps(buf, 0); if (fd == -1) return FALSE; if ((f = > fdopen(fd, "w+")) == NULL) return FALSE; > bye michael -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (GNU/Linux) iD8DBQFUGVSO0ei8kcpE1VERAgC/AJ9Ow9H7xnu/qQ3VYlh49BXOgG75pACePrh7 aLhMgo8NZ7EhpQCB2cs8NnY= =OHEq -----END PGP SIGNATURE-----

Sept. 17, 2014

Re: [PATCH 4/5] riched20: Implement ITextRange::Collapse. (try 2)

by Huw Davies

On Wed, Sep 17, 2014 at 11:35:50AM +0300, Indrek Altpere wrote: > This seems to be a typo, I think the original variable name was mean to be > isedge or is_edge. No, I fairly sure it's short for degenerate - that term is used in the docs. > Perhaps this check would be simpler to understand and would not create local > variable if it were like this? > > if (*end == *start) > return S_FALSE; Yup, just suggested that too (I need more coffee!). Thanks, Huw.

Sept. 17, 2014

Re: [PATCH 4/5] riched20: Implement ITextRange::Collapse. (try 2)

by Huw Davies

On Wed, Sep 17, 2014 at 09:27:18AM +0100, Huw Davies wrote: > On Tue, Sep 16, 2014 at 06:39:32PM +0800, Jactry Zeng wrote: > > +static HRESULT range_Collapse(LONG bStart, LONG *start, LONG *end) > > +{ > > + BOOL isdege = !(*end - *start); > > This is a strange way to test for an equality! > > Also, isdegen or is_degen would be much better > choices for the variable name. Or even better, get rid of the variable completely if (*start == *end) return S_FALSE; Huw.

Sept. 17, 2014