September 2014 - Wine-Devel

Re: [PATCH 1/3] mshtml: Use proper type for text node in exec_hyperlink.

by Michael Stefaniuc

On 09/30/2014 10:12 AM, Jacek Caban wrote: > --- dlls/mshtml/editor.c | 7 ++++--- 1 file changed, 4 > insertions(+), 3 deletions(-) > > > > 0001-mshtml-Use-proper-type-for-text-node-in-exec_hyperlin.diff > > > diff --git a/dlls/mshtml/editor.c b/dlls/mshtml/editor.c index > 14aab53..779dcc7 100644 --- a/dlls/mshtml/editor.c +++ > b/dlls/mshtml/editor.c @@ -1170,13 +1170,14 @@ static HRESULT > exec_hyperlink(HTMLDocument *This, DWORD cmdexecopt, VARIANT *in, > > /* create an element with text of URL */ if (insert_link_at_caret) > { - nsIDOMNode *text_node, *unused_node; + nsIDOMNode > *unused_node; + nsIDOMText *text_node; > > nsIDOMHTMLDocument_CreateTextNode(This->doc_node->nsdoc, &ns_url, > (nsIDOMText **)&text_node); Jacek, you don't need the above cast anymore. > /* wrap the <a> tags around the text element */ - > nsIDOMHTMLElement_AppendChild(anchor_elem, text_node, > &unused_node); - nsIDOMNode_Release(text_node); + > nsIDOMHTMLElement_AppendChild(anchor_elem, (nsIDOMNode*)text_node, > &unused_node); + nsIDOMText_Release(text_node); > nsIDOMNode_Release(unused_node); } bye michael

Sept. 30, 2014

Re: dpnet: Implement IDirectPlay8Address GetComponentByName

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9131 Your paranoid android. === w8 (32 bit address) === The test timed out

Sept. 30, 2014

Re: dpnet: Implement IDirectPlay8Address GetComponentByName

by Nikolay Sivov

On 9/30/2014 08:08, Alistair Leslie-Hughes wrote: > + *pdwBufferSize = entry->size; > + > + if(*pdwBufferSize < entry->size) > + return DPNERR_BUFFERTOOSMALL; Looks broken.

Sept. 30, 2014

Re: [PATCH 1/3] user32: Add initial WindowFromPoint tests

by Dmitry Timoshkov

Hi Piotr, Piotr Caban <piotr(a)codeweavers.com> wrote: > --- > dlls/user32/tests/win.c | 39 +++++++++++++++++++++++++++++++++++++++ > 1 file changed, 39 insertions(+) There already exist the tests for RealChildWindowFromPoint with a FIXME about adding new tests for WindowFromPoint, ChildWindowFromPoint and ChildWindowFromPointEx, is it possible to use existing tests as a base and extend them as needed? -- Dmitry.

Sept. 30, 2014

Re: wpp: Fix a few memory leaks

by Fabian Ebner

Am 29.09.2014 um 11:37 schrieb Alexandre Julliard: > Fabian Ebner <f.ebner94(a)gmail.com> writes: > >> Fixes bug 37130 where it was discovered. > > You can't do that, the buffer is on the buffer stack. > Sorry for overlooking that. This means the bug is invalid and relying on Clang Static Analyzer without double-checking is bad.

Sept. 29, 2014

Re: wpp: Fix a few memory leaks

by Alexandre Julliard

Fabian Ebner <f.ebner94(a)gmail.com> writes: > Fixes bug 37130 where it was discovered. You can't do that, the buffer is on the buffer stack. -- Alexandre Julliard julliard(a)winehq.org

Sept. 29, 2014

Re: [2/2] shell32: Implement IApplicationAssociationRegistration, QueryCurrentDefault

by Nikolay Sivov

> + hr = CoCreateInstance(&CLSID_ApplicationAssociationRegistration, NULL, CLSCTX_INPROC_SERVER, > + &IID_IApplicationAssociationRegistration, (LPVOID*)&appreg); > + if (FAILED(hr)) { > + skip("IApplicationAssociationRegistration not created: 0x%x\n", hr); > + return; > + } Just check it with ok(), missing implementation is already checked in START_TEST(). > + trace("%s\n", wine_dbgstr_w(assocprog)); Do you really need this? > - test_IApplicationAssociationRegistration_QueryInterface(); > + /* this works since Vista */ > + hr = CoCreateInstance(&CLSID_ApplicationAssociationRegistration, NULL, CLSCTX_INPROC_SERVER, > + &IID_IApplicationAssociationRegistration, (LPVOID*)&appreg); > + if (hr == S_OK) > + { > + test_IApplicationAssociationRegistration_QueryInterface(); > + test_IApplicationAssociationRegistration_QueryCurrentDefault(); > + > + IApplicationAssociationRegistration_Release(appreg); > + } > + else > + skip("IApplicationAssociationRegistration not supported: 0x%x\n", hr); This should be win_skip().

Sept. 29, 2014

Re: Assorted spelling fixes.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9111 Your paranoid android. === w8 (32 bit device) === device.c:2398: Test failed: Expected foreground window 000301E4, got 0002004C. device.c:3040: Test failed: Expected wndproc 0x412cf0, got 0x412cf0.

Sept. 29, 2014

Re: Assorted spelling fixes.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9103 Your paranoid android. === wvistau64 (32 bit shlfileop) === shlfileop.c:815: Test failed: Expected ERROR_CANCELLED or DE_DIFFDIR === wvistau64 (64 bit shlfileop) === shlfileop.c:815: Test failed: Expected ERROR_CANCELLED or DE_DIFFDIR

Sept. 28, 2014

Re: [PATCH] vbscript: Implemented RGB (try 3)

by Shuai Meng

2014-09-25 20:54 GMT+08:00 Qian Hong <fracting(a)gmail.com>: > Hi Shuai, > > > Call ok(RGB(0, &h00001f&, &h0000f1&) = &hf11f00&, " > > I think Call ok(RGB(0, &h1f&, &hf1&) = &hf11f00&, "... is better and > clearer. > OK, thanks for commenting.

Sept. 26, 2014