January 2015 - Wine-Devel - list.winehq.org

Re: League of Legends shop in game fix

by Austin English

On Thu, Jan 29, 2015 at 9:19 AM, Monster <manuiglesias96(a)yahoo.es> wrote: > @@ -220,7 +220,10 @@ BOOL wined3d_resource_allocate_sysmem(struct > wined3d_resource *resource) > SIZE_T align = RESOURCE_ALIGNMENT - 1 + sizeof(*p); > void *mem; > - if (!(mem = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, > resource->size + align))) > + UINT size = resource->size; > + if (resource->width <= 128 && resource->height <= 128) > + size *= 2; > + if (!(mem = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, size + > align))) > return FALSE; > p = (void **)(((ULONG_PTR)mem + align) & ~(RESOURCE_ALIGNMENT - 1)) - 1; > > > > Please use your real name when sending patches. -- -Austin

Jan. 29, 2015

Re: msvcrt: Bump MSVCRT_MB_LEN_MAX to 6 and use it in MSVCRT__wctomb_l for default buffer length

by Piotr Caban

On 01/28/15 00:25, Orion Poplawski wrote: > Looks like things are a bit version dependent - It appears that is is 2 for > Visual Studio .NET 2003, and 5 for later versions: > > https://msdn.microsoft.com/en-us/library/296az74e%28v=vs.71%29.aspx I'm not sure what should be done in this case. I would go with changing it to 5 in all headers so applications can use it to allocate buffers. 5 is big enough to handle all codepages in wine. > Not sure if I should be producing an updated patch, or if the wine devs can > take it from here. It's your patch. It's best if you send it yourself. Thanks, Piotr

Jan. 29, 2015

Re: [PATCH 1/2] kernel32/tests: Make loader tests independent from each other

by Dmitry Timoshkov

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > >> So why should I leave it as it is? > > There is no actual reason to touch it, and these purely cosmetic changes > > create conflicts with the tests I have in local tree. > > > Well, local merge problems can't be a reason to block cleanups like that. Since that's my code I'd prefer to keep it that way. -- Dmitry.

Jan. 28, 2015

Re: [PATCH 1/2] kernel32/tests: Make loader tests independent from each other

by Nikolay Sivov

On 28.01.2015 18:39, Dmitry Timoshkov wrote: > Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > >>> There are various reasons of the current tests structure, if you are not >>> planning to add new tests please leave the code as it is please. >>> >> Are you going to name those reasons? > I don't think it's really important unless you are going to add new tests. That's how I saw they depend on each other, when I tried to add some more. > >> Currently some tests depend on >> values set by previous tests. >> That's clearly a broken behavior. test_import_resolution() does it right >> already by the way. >> >> So why should I leave it as it is? > There is no actual reason to touch it, and these purely cosmetic changes > create conflicts with the tests I have in local tree. > Well, local merge problems can't be a reason to block cleanups like that.

Jan. 28, 2015

Re: [PATCH 1/2] kernel32/tests: Make loader tests independent from each other

by Dmitry Timoshkov

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > > There are various reasons of the current tests structure, if you are not > > planning to add new tests please leave the code as it is please. > > > Are you going to name those reasons? I don't think it's really important unless you are going to add new tests. > Currently some tests depend on > values set by previous tests. > That's clearly a broken behavior. test_import_resolution() does it right > already by the way. > > So why should I leave it as it is? There is no actual reason to touch it, and these purely cosmetic changes create conflicts with the tests I have in local tree. -- Dmitry.

Jan. 28, 2015

Re: [PATCH 1/2] kernel32/tests: Make loader tests independent from each other

by Nikolay Sivov

On 28.01.2015 18:20, Dmitry Timoshkov wrote: >> +const static IMAGE_NT_HEADERS nt_header_template = > 'static const' is a commonly accepted order. > > There are various reasons of the current tests structure, if you are not > planning to add new tests please leave the code as it is please. > Are you going to name those reasons? Currently some tests depend on values set by previous tests. That's clearly a broken behavior. test_import_resolution() does it right already by the way. So why should I leave it as it is?

Jan. 28, 2015

Re: [PATCH 1/2] kernel32/tests: Make loader tests independent from each other

by Dmitry Timoshkov

> +const static IMAGE_NT_HEADERS nt_header_template = 'static const' is a commonly accepted order. There are various reasons of the current tests structure, if you are not planning to add new tests please leave the code as it is please. -- Dmitry.

Jan. 28, 2015

Re: mshtml: Added support for _self target in IHTMLWindow2::open.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11354 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

Jan. 28, 2015

Re: msvcrt: Fix inconsistent rounding behaviour for sprintf and add tests.

by YongHao Hu

Thank you for your review and advice. I will try to improve it. :) By the way, I will send another independent patch to msvcp tests. On 2015年01月27日 19:02, Piotr Caban wrote: > This is not correct, val may loose to much precision. Also temp can > become INF (in your patch temp is int but I guess it's a mistake). I'm > afraid that in order to fix this bug you'll need to stop using glibcs > sprintf in wine's printf implementation. > > Your patch to msvcp tests depends on this patch. Please send patches > that depend on each other in series.

Jan. 28, 2015

Re: msvcrt: Bump MSVCRT_MB_LEN_MAX to 6 and use it in MSVCRT__wctomb_l for default buffer length

by Orion Poplawski

On 01/26/2015 06:10 AM, Piotr Caban wrote: > On 01/23/15 18:38, Orion Poplawski wrote: >> diff --git a/dlls/msvcrt/msvcrt.h b/dlls/msvcrt/msvcrt.h >> index 41f31b9..401628a 100644 >> --- a/dlls/msvcrt/msvcrt.h >> +++ b/dlls/msvcrt/msvcrt.h >> @@ -47,7 +47,7 @@ >> #define MSVCRT_I64_MAX (((__int64)0x7fffffff << 32) | 0xffffffff) >> #define MSVCRT_I64_MIN (-MSVCRT_I64_MAX-1) >> #define MSVCRT_UI64_MAX (((unsigned __int64)0xffffffff << 32) | 0xffffffff) >> -#define MSVCRT_MB_LEN_MAX 2 >> +#define MSVCRT_MB_LEN_MAX 6 > MB_LEN_MAX equals 5 on windows. It should probably be set to 5 here as well. > Probably include/msvcrt/limits.h should also be changed. > > Thanks, > Piotr Looks like things are a bit version dependent - It appears that is is 2 for Visual Studio .NET 2003, and 5 for later versions: https://msdn.microsoft.com/en-us/library/296az74e%28v=vs.71%29.aspx I have no idea how this intersects with wine's implementation though. Not sure if I should be producing an updated patch, or if the wine devs can take it from here. Thanks, Orion -- Orion Poplawski Technical Manager 303-415-9701 x222 NWRA, Boulder/CoRA Office FAX: 303-415-9702 3380 Mitchell Lane orion(a)nwra.com Boulder, CO 80301 http://www.nwra.com

Jan. 27, 2015