January 2015 - Wine-Devel - list.winehq.org

Re: dpnet: Implement IDirectPlay8Address GetComponentByIndex (try 5)

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, > +static void add_component(IDirectPlay8AddressImpl *This, struct component *item) > +{ > + if(!This->comp_count) > + This->components = HeapAlloc(GetProcessHeap(), 0, sizeof(struct component *) * This->comp_count+1 ); You can use your heap_alloc() helper here. The same applies to the HeapFree calls added in the patch. Other than that I think error handling would be a good idea. You can check for NULL (as well as in the place where you allocate storage for the component in AddComponent) and return from AddComponent with E_OUTOFMEMORY. The patch has a few formatting issues. Since it looks like dplay & friends will be mostly your reign I'll leave it up to you on how to handle formatting. Do you want me to continue pointing them out? In that case please send me a mail what your intended formatting is. (Obviously it'd be even better if you described your intended formatting to git in the form of a git pre-commit hook containing some regexes ;-) ). Other than this the patch looks good. The following is unrelated to this patch, I just noticed it (again?) while reading through it: Am 2015-01-23 um 08:10 schrieb Alistair Leslie-Hughes: > + case DPNA_DATATYPE_STRING: > + memcpy(pvBuffer, &entry->data.string, entry->size); > + break; Please add a test for a case where AddComponent is called with DPNA_DATATYPE_STRING where (strlen(string) + 1) * sizeof(WCHAR) != dwDataSize. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJUxS4iAAoJEN0/YqbEcdMwvFkP/RF6kH1o1C4fQgfa/J+4j6zV kwp3M7rqU5VTasKYV+G0pdAQ+wvBzHpMPSqLRD/HfBWGf3dAPCk94C9d659enkJN Qhy7hhO6aazsXKq7iWVAgQrGJy59oBoL14Vg+44hUJIeu7qWv3uuqihVgKUqiG2K Bl235p9cM/WYLGXFEF4d1UFHBKZb0bhRudwuzRbuN8r3RLwpEhrKbbKg8yXOPjLq Vejc4d219iib3ZpbT13pq0j/+a+ox+R62+O9S5wGbu/G8IGxVPTgsY20mpFyPsHX DoedE56wfSSe5Psb78NVmC32bWY8nmUzJA9YBb26a0KPO9QZNVnJkkYkOKIFr6P/ ouVLfWbO4QV2dOPRbYnh+40XCIbPeatGMq9vE7TDZPtxLBkRTEl1GudZ5usFwCK7 XgTPjb+BIu37UCbt0hpWA4IH8UeyYue08DnGCWkMkGS6ClH9KCG2xVqL8F1gr8Bw W5iKcVVHFZzHS6D947nN17Fl6Rg4+oLui0zkgtveU/AY/ew8xptHt4rW6It3QU5t HkNce4St+2w1LErIuYRITrvQV6lrndDDgvvlPcK1P1zt2D1a9gpqnsPgKM/tZLu+ fO8P8Yjl81KZHlAVWMUutiDzlelUOJvaXnVNX5VVkyOajHDI569MKy4qOETSdiim gwulxslghTkPCsAa+LpB =iY0u -----END PGP SIGNATURE-----

Jan. 25, 2015

Re: [3/3] cmd: implemented && and || functionality (try 2)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11295 Your paranoid android. === build (build) === Patch failed to apply

Jan. 24, 2015

Wine 1.7.35 source code scanning (Cppcheck)

by Игорь Чебаненко

Jan. 24, 2015

Re: [PATCH 3/5] atl: Added stub AtlIPersistPropertyBag_Save.

by Qian Hong

On Fri, Jan 23, 2015 at 6:03 PM, Jacek Caban <jacek(a)codeweavers.com> wrote: > after two patches in series removing > unnecessary empty lines, you add a new one here ;) Intentionally, this is incremental development mode <grin> -- Regards, Qian Hong - http://www.codeweavers.com

Jan. 23, 2015

Re: [PATCH 4/5] atl100: Implemented semi stub AtlAxCreateControlLic and AtlAxCreateControlLicEx.

by Qian Hong

Hi Jacek, On Fri, Jan 23, 2015 at 6:11 PM, Jacek Caban <jacek(a)codeweavers.com> wrote: > Please forward AtlAxCreateControlEx to AtlAxCreateControlLicEx and add > FIXME about unsupported argument instead of the other way around. > Otherwise we'd have to do that later to support the argument anyway. > > Also AtlAxCreateControlLic would probably be better forwarded to > AtlAxCreateControlLicEx. Good point, thanks for advice. Also thanks for the new line catch :) -- Regards, Qian Hong - http://www.codeweavers.com

Jan. 23, 2015

Re: Wine 64 bit

by Michael Stefaniuc

Ken, On 01/23/2015 07:32 AM, Ken Thomases wrote: > I don't know if Alexandre will allow that. He wasn't willing to drop > support for 10.5 back when the Mac driver was added. He was even kind > of grumpy that the Mac driver itself required 10.6. At the time, he > had an old Mac Mini that couldn't be upgraded past 10.5 that he > continued to build and test on. > > Perhaps if dropping 10.5 gained us something, he could be persuaded. persuading Alexandre with that is difficult, nay impossible. But you do not have to do that, the solution is much simpler: Just prove that nobody is using Wine on MacOSX 10.5. And if the only user turns out to be Alexandre himself then pester Jeremey to buy Alexandre a new Mac Mini. bye michael

Jan. 23, 2015

Re: [PATCH 4/5] atl100: Implemented semi stub AtlAxCreateControlLic and AtlAxCreateControlLicEx.

by Jacek Caban

Hi Qian, On 01/23/15 10:19, Qian Hong wrote: > diff --git a/dlls/atl/atl_ax.c b/dlls/atl/atl_ax.c > index 15b0550..656165b 100644 > --- a/dlls/atl/atl_ax.c > +++ b/dlls/atl/atl_ax.c > @@ -1435,8 +1435,9 @@ INT_PTR WINAPI AtlAxDialogBoxA(HINSTANCE hInstance, LPCSTR lpTemplateName, HWND > */ > HRESULT WINAPI AtlAxCreateControlLic(const WCHAR *lpTricsData, HWND hwnd, IStream *stream, IUnknown **container, BSTR lic) > { > - FIXME("(%s %p %p %p %s)\n", debugstr_w(lpTricsData), hwnd, stream, container, debugstr_w(lic)); > - return E_NOTIMPL; > + if (lic) > + FIXME("semi stub (%s %p %p %p %s)\n", debugstr_w(lpTricsData), hwnd, stream, container, debugstr_w(lic)); > + return AtlAxCreateControl(lpTricsData, hwnd, stream, container); > } > > /*********************************************************************** > @@ -1446,9 +1447,10 @@ HRESULT WINAPI AtlAxCreateControlLic(const WCHAR *lpTricsData, HWND hwnd, IStrea > HRESULT WINAPI AtlAxCreateControlLicEx(const WCHAR *lpTricsData, HWND hwnd, IStream *stream, > IUnknown **container, IUnknown **control, REFIID iidSink, IUnknown *punkSink, BSTR lic) > { > - FIXME("(%s %p %p %p %p %s %p %s)\n", debugstr_w(lpTricsData), hwnd, stream, container, control, > + if (lic) > + FIXME("semi stub (%s %p %p %p %p %s %p %s)\n", debugstr_w(lpTricsData), hwnd, stream, container, control, > debugstr_guid(iidSink), punkSink, debugstr_w(lic)); > - return E_NOTIMPL; > + return AtlAxCreateControlEx(lpTricsData, hwnd, stream, container, control, iidSink, punkSink); > } > > #endif Please forward AtlAxCreateControlEx to AtlAxCreateControlLicEx and add FIXME about unsupported argument instead of the other way around. Otherwise we'd have to do that later to support the argument anyway. Also AtlAxCreateControlLic would probably be better forwarded to AtlAxCreateControlLicEx. Cheers, Jacek

Jan. 23, 2015

Re: [PATCH 3/5] atl: Added stub AtlIPersistPropertyBag_Save.

by Jacek Caban

On 01/23/15 10:18, Qian Hong wrote: > +HRESULT WINAPI AtlIPersistPropertyBag_Save(LPPROPERTYBAG pPropBag, BOOL fClearDirty, BOOL fSaveAllProperties, > + ATL_PROPMAP_ENTRY *pMap, void *pThis, IUnknown *pUnk) > +{ > + > + FIXME("(%p, %x, %x, %p, %p, %p)\n", pPropBag, fClearDirty, fSaveAllProperties, pMap, pThis, pUnk); > + return S_OK; > +} It's a minor detail, but after two patches in series removing unnecessary empty lines, you add a new one here ;) Cheers, Jacek

Jan. 23, 2015

Re: [PATCH 5/5] wined3d: Use the core version of the shader object functions.

by Henri Verbeet

On 22 January 2015 at 21:10, Chris Robinson <chris.kcat(a)gmail.com> wrote: > C doesn't technically allow casting function pointers to/from void*, > <https://stackoverflow.com/questions/5579835/c-function-pointer-casting-to-v…>. Strictly speaking that's true, but I think that's in the same category as e.g. NULL not being guaranteed to be defined as "(void *)0". I.e., it should be safe on any platform we'll realistically support.

Jan. 23, 2015

Re: shell32: Implement IApplicationAssociationRegistration, QueryCurrentDefault (try 6)

by Nikolay Sivov

On 23.01.2015 10:24, Alistair Leslie-Hughes wrote: > + ret = RegGetValueW(hkey, NULL, NULL, RRF_RT_REG_SZ, &keytype, NULL, &size); > + if(ret == ERROR_SUCCESS) > + { > + *association = CoTaskMemAlloc(size * sizeof(WCHAR)); Does it really return length in characters? I thought it's always in bytes. > + if(*association) > + { > + ret = RegGetValueW(hkey, NULL, NULL, RRF_RT_REG_SZ, &keytype, *association, &size); > + if(ret == ERROR_SUCCESS) > + hr = S_OK; > + } > + } In case of !*association please return earlier with E_OUTOFMEMORY.

Jan. 23, 2015