January 2015 - Wine-Devel - list.winehq.org

Re: ws2_32: Better trace setsockopt/getsockopt

by Bruno Jesus

On Tue, Jan 6, 2015 at 12:49 AM, Bruno Jesus <00cpxxx(a)gmail.com> wrote: > The intention of this patch is to make it easier to read winsock logs, > for setsockopt it even displays the value if its size is less than 5 > bytes. Hi, any complains about this patch? It's pending for 2 weeks now and I think this is a good waiting time to ask. Best Regards, Bruno

Jan. 22, 2015

Re: [PATCH 3/5] wined3d: Initialize the last two components of R16G16_SINT attributes.

by Henri Verbeet

On 21 January 2015 at 18:32, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > - GL_EXTCALL(glVertexAttrib4svARB(index, ptr)); > + { > + GLshort s[4] = {((const GLshort *)ptr)[0], ((const GLshort *)ptr)[1], 0, 1}; > + GL_EXTCALL(glVertexAttrib4svARB(index, s)); > break; > + } Perhaps I'm missing something, but wouldn't it be much easier to just use glVertexAttrib2svARB() instead?

Jan. 22, 2015

Re: [PATCH 5/5] wined3d: Use the core version of the shader object functions.

by Henri Verbeet

On 21 January 2015 at 18:32, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > + typedef void (WINE_GLAPI *gl_shader_source_type)(GLuint, GLsizei, const GLchar * const *, const GLint*); > + ... > + #define MAP_GL_FUNCTION_CAST(core_func, cast, ext_func) \ > + do \ > + { \ > + if (!gl_info->gl_ops.ext.p_##core_func) \ > + gl_info->gl_ops.ext.p_##core_func = (cast)gl_info->gl_ops.ext.p_##ext_func; \ > + } while (0) ... > + MAP_GL_FUNCTION_CAST(glShaderSource, gl_shader_source_type, glShaderSourceARB); I'm not sure that's really much better than just adding a (void *) cast.

Jan. 22, 2015

Re: [PATCH 6/6] kernel32: Invalid console handles for new processes are 0, not INVALID_HANDLE_VALUE.

by Erich E. Hoover

On Wed, Jan 21, 2015 at 1:37 AM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > On 21/01/15 08:51, Erich E. Hoover wrote: >> >> Several applications rely on the TEB value for fresh invalid console >> handles to be zero instead of INVALID_HANDLE_VALUE (fixes Bug #36216 >> and Bug #37914). >> >> >> +····if·(!params->hStdOutput·||·params->hStdOutput·==·INVALID_HANDLE_VALUE) >> +········params->hStdOutput·=·0; > > > The !params->hStdOutput check is redundant since it's already 0. Applies to > the other places as well. You need to provide some sort of no-op, otherwise it will try to map the handle in the next part of that if block: else if (VerifyConsoleIoHandle(console_handle_map(params->hStdOutput))) params->hStdOutput = console_handle_map(params->hStdOutput); Best, Erich

Jan. 21, 2015

Wine Gecko 2.36-beta1

by Jacek Caban

Hi all, I just uploaded new Wine Gecko beta packages. This time it's based on Firefox 36 beta branch, so it should be pretty stable. To test it please use the attached patch. That's all you need, Wine will download Gecko automatically. Packages are also available on Wine SourceForge if you prefer to download it manually. All testing is appreciated. Regressions and build problems are most important, but all feedback is welcomed. I'm also sending this announcement mingw-w64 mailing list. I know that some distro package maintainers that maintain Wine Gecko packages read it. Beta releases are a good chance to make sure that it builds with toolchains available in distros. Note that the package requires very recent mingw-w64 Git version. A new release on mingw-w64 is planned, so hopefully it will be out before final Wine Gecko release (which is expected in 5-6 weeks). Thanks, Jacek

Jan. 21, 2015

Re: msi: Add a partial implementation of MsiProvideComponent.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11245 Your paranoid android. === wxppro (32 bit msi) === The test timed out === w7u (32 bit msi) === The test timed out

Jan. 21, 2015

Re: msxml3/tests: Actually test the return values (PVS-Studio)

by Michael Stefaniuc

Please ignore, wrong resend. On 01/21/2015 10:48 AM, Michael Stefaniuc wrote: > --- > dlls/msxml3/tests/domdoc.c | 1 + > dlls/msxml3/tests/schema.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c > index a23fb66..e669de4 100644 > --- a/dlls/msxml3/tests/domdoc.c > +++ b/dlls/msxml3/tests/domdoc.c > @@ -11085,6 +11085,7 @@ static void test_xmlns_attribute(void) > V_VT(&v) = VT_BSTR; > V_BSTR(&v) = _bstr_("urn:schemas-microsoft-com:datatypes"); > hr = IXMLDOMAttribute_put_nodeValue(pAttribute, v); > + ok(hr == S_OK, "ret %08x\n", hr ); > > hr = IXMLDOMElement_setAttributeNode(root, pAttribute, NULL); > ok(hr == S_OK, "ret %08x\n", hr ); > diff --git a/dlls/msxml3/tests/schema.c b/dlls/msxml3/tests/schema.c > index f5d6fcd..be18fcf 100644 > --- a/dlls/msxml3/tests/schema.c > +++ b/dlls/msxml3/tests/schema.c > @@ -1292,6 +1292,7 @@ static void test_XDR_datatypes(void) > > VariantClear(&type); > hr = IXMLDOMNode_get_nodeTypedValue(node, &type); > + EXPECT_HR(hr, S_OK); > ok(V_VT(&type) == VT_BSTR, "got variant type %i\n", V_VT(&v)); > VariantClear(&type); > IXMLDOMNode_Release(node); >

Jan. 21, 2015

Re: msxml3/tests: Remove an unused assignment (PVS-Studio)

by Michael Stefaniuc

*SIGH* please ignore this one as this is already commited. Pushed out the wrong mailbox. On 01/21/2015 10:43 AM, Michael Stefaniuc wrote: > --- dlls/msxml3/tests/domdoc.c | 1 - 1 file changed, 1 deletion(-) > > diff --git a/dlls/msxml3/tests/domdoc.c > b/dlls/msxml3/tests/domdoc.c index 1a73771..a23fb66 100644 --- > a/dlls/msxml3/tests/domdoc.c +++ b/dlls/msxml3/tests/domdoc.c @@ > -4903,7 +4903,6 @@ static void test_xmlTypes(void) > > doc = create_document(&IID_IXMLDOMDocument); > > - pNextChild = (void*)0xdeadbeef; hr = > IXMLDOMDocument_get_nextSibling(doc, NULL); ok(hr == E_INVALIDARG, > "ret %08x\n", hr );

Jan. 21, 2015

Re: msxml3/tests: Actually test the return values (PVS-Studio)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11239 Your paranoid android. === build (build) === Patch failed to apply

Jan. 21, 2015

Re: msxml3/tests: Remove an unused assignment (PVS-Studio)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11238 Your paranoid android. === build (build) === Patch failed to apply

Jan. 21, 2015