October 2015 - Wine-Devel - list.winehq.org

Re: [4/4] dlls/ole32: Add more traces to the storage methods.

by Vincent Povirk

On Thu, Oct 29, 2015 at 2:41 AM, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > > static HRESULT TransactedSnapshotImpl_GetTransactionSig(StorageBaseImpl *base, > ULONG* result, BOOL refresh) > { > + FIXME("stub\n"); > return E_NOTIMPL; > } This is intentional. We don't need transaction signatures because nothing else can have our snapshot open to commit to it. Anything calling these methods should expect and handle E_NOTIMPL.

Oct. 31, 2015

Re: [2/4] dlls/ole32: Zero out returned stats when IEnumSTATSTG::Next reaches end of enumeration.

by Vincent Povirk

Are you sure we shouldn't be zeroing the entire remaining buffer? And maybe we should put it after the loop, given there are multiple exits.

Oct. 31, 2015

Re: [PATCH 4/4] winex11: Make color cubes as big as possible.

by Vincent Povirk

Sorry, I don't think I'm qualified to review this. There's too much context here that I don't understand.

Oct. 31, 2015

Re: [PATCH 2/4] winex11: Avoid inefficiency and overflow in remove_startup_notification.

by Vincent Povirk

It seems like you're doing two unrelated things here? I'd expect the process of building the string to send and sending it to be independent. > if ((src = strstr( id, "_TIME" ))) update_user_time( atol( src + 5 )); > > - pos = snprintf(message, sizeof(message), "remove: ID="); > - message[pos++] = '"'; > - for (i = 0; id[i] && pos < sizeof(message) - 2; i++) > + pos = sprintf(message, "remove: ID=\""); > + for (i = 0; id[i]; i++) > { > if (id[i] == '"' || id[i] == '\\') > + { > + if (pos == sizeof(message) - 3) break; > message[pos++] = '\\'; > + } > + if (pos == sizeof(message) - 2) break; > message[pos++] = id[i]; > } > message[pos++] = '"'; > message[pos++] = '\0'; Your use of == instead of > or >= in these checks makes me uncomfortable. Given that a single iteration can increment pos twice, why can't we have a situation where (pos > sizeof(message) - 3), inside the if statement? As for the memset, I didn't examine that as thoroughly, but it's a good policy to not send uninitialized data over the wire. Still, we could move the memset outside the loop and know that won't happen.

Oct. 31, 2015

Re: [PATCH 01/4] msvcp110: Add tr2_sys__Open_dir implementation.(try 4)

by YongHao Hu

Hi. On 15/10/30 下午11:08, Piotr Caban wrote: > On 10/29/15 16:28, YongHao Hu wrote: >> + char temppath[MAX_PATH+1]; >> + TRACE("(%p %s %p %p)\n", target, debugstr_a(dest), err_code, type); >> + if(strlen(dest) >= MAX_PATH) { >> + *err_code = ERROR_BAD_PATHNAME; >> + return NULL; >> + } >> + strcpy(temppath, dest); >> + strcat(temppath, "\\*"); > There may still write outside of temppath array in this code. I had sent a new patch to upstream. I think it will fix possible buffer overflow this time. Thank you very much.

Oct. 31, 2015

Re: [7/7] oleaut32/tests: Add a bunch of new tests for typelib generation.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17862 Your paranoid android. === wxppro (32 bit typelib) === typelib.c:4570: Test failed: bstrIfName expected "_n" got "child_iface" typelib.c:4574: Test failed: typeattr->typekind expected 1 got 3 typelib.c:4591: Test failed: help_ctx expected 3 got 0 typelib.c:4592: Test failed: ((LONG)(((WORD)((DWORD_PTR)(typeattr->wMinorVerNum) & 0xFFFF)) | ((DWORD)((WORD)((DWORD_PTR)(typeattr->wMajorVerNum) & 0xFFFF))) << 16)) expected 65538 got 0 typelib.c:4593: Test failed: typeattr->cbSizeVft expected 0 got 20 typelib.c:4594: Test failed: typeattr->cFuncs expected 0 got 1 typelib.c:4606: Test failed: got wrong guid {b14b6bb5-904e-4ff9-b247-bd361f7aa002} typelib.c:4625: Test failed: desc->memid expected 0 got 1610743808 typelib.c:4626: Test failed: desc->funckind expected 0 got 1 typelib.c:4627: Test failed: desc->invkind expected 0 got 1 typelib.c:4628: Test failed: desc->callconv expected 0 got 4 typelib.c:4631: Test failed: desc->oVft got 16 typelib: unhandled exception c0000005 at 00420ACA === w2003std (32 bit typelib) === typelib.c:4570: Test failed: bstrIfName expected "_n" got "child_iface" typelib.c:4574: Test failed: typeattr->typekind expected 1 got 3 typelib.c:4591: Test failed: help_ctx expected 3 got 0 typelib.c:4592: Test failed: ((LONG)(((WORD)((DWORD_PTR)(typeattr->wMinorVerNum) & 0xFFFF)) | ((DWORD)((WORD)((DWORD_PTR)(typeattr->wMajorVerNum) & 0xFFFF))) << 16)) expected 65538 got 0 typelib.c:4593: Test failed: typeattr->cbSizeVft expected 0 got 20 typelib.c:4594: Test failed: typeattr->cFuncs expected 0 got 1 typelib.c:4606: Test failed: got wrong guid {b14b6bb5-904e-4ff9-b247-bd361f7aa002} typelib.c:4625: Test failed: desc->memid expected 0 got 1610743808 typelib.c:4626: Test failed: desc->funckind expected 0 got 1 typelib.c:4627: Test failed: desc->invkind expected 0 got 1 typelib.c:4628: Test failed: desc->callconv expected 0 got 4 typelib.c:4631: Test failed: desc->oVft got 16 typelib: unhandled exception c0000005 at 00420ACA === wvistau64 (32 bit typelib) === typelib.c:4570: Test failed: bstrIfName expected "_n" got "child_iface" typelib.c:4574: Test failed: typeattr->typekind expected 1 got 3 typelib.c:4591: Test failed: help_ctx expected 3 got 0 typelib.c:4592: Test failed: ((LONG)(((WORD)((DWORD_PTR)(typeattr->wMinorVerNum) & 0xFFFF)) | ((DWORD)((WORD)((DWORD_PTR)(typeattr->wMajorVerNum) & 0xFFFF))) << 16)) expected 65538 got 0 typelib.c:4593: Test failed: typeattr->cbSizeVft expected 0 got 20 typelib.c:4594: Test failed: typeattr->cFuncs expected 0 got 1 typelib.c:4606: Test failed: got wrong guid {b14b6bb5-904e-4ff9-b247-bd361f7aa002} typelib.c:4625: Test failed: desc->memid expected 0 got 1610743808 typelib.c:4626: Test failed: desc->funckind expected 0 got 1 typelib.c:4627: Test failed: desc->invkind expected 0 got 1 typelib.c:4628: Test failed: desc->callconv expected 0 got 4 typelib.c:4631: Test failed: desc->oVft got 16 typelib: unhandled exception c0000005 at 00420ACA === w2008s64 (32 bit typelib) === typelib.c:4570: Test failed: bstrIfName expected "_n" got "child_iface" typelib.c:4574: Test failed: typeattr->typekind expected 1 got 3 typelib.c:4591: Test failed: help_ctx expected 3 got 0 typelib.c:4592: Test failed: ((LONG)(((WORD)((DWORD_PTR)(typeattr->wMinorVerNum) & 0xFFFF)) | ((DWORD)((WORD)((DWORD_PTR)(typeattr->wMajorVerNum) & 0xFFFF))) << 16)) expected 65538 got 0 typelib.c:4593: Test failed: typeattr->cbSizeVft expected 0 got 20 typelib.c:4594: Test failed: typeattr->cFuncs expected 0 got 1 typelib.c:4606: Test failed: got wrong guid {b14b6bb5-904e-4ff9-b247-bd361f7aa002} typelib.c:4625: Test failed: desc->memid expected 0 got 1610743808 typelib.c:4626: Test failed: desc->funckind expected 0 got 1 typelib.c:4627: Test failed: desc->invkind expected 0 got 1 typelib.c:4628: Test failed: desc->callconv expected 0 got 4 typelib.c:4631: Test failed: desc->oVft got 16 typelib: unhandled exception c0000005 at 00420ACA === w7u (32 bit typelib) === typelib.c:4570: Test failed: bstrIfName expected "_n" got "child_iface" typelib.c:4574: Test failed: typeattr->typekind expected 1 got 3 typelib.c:4591: Test failed: help_ctx expected 3 got 0 typelib.c:4592: Test failed: ((LONG)(((WORD)((DWORD_PTR)(typeattr->wMinorVerNum) & 0xFFFF)) | ((DWORD)((WORD)((DWORD_PTR)(typeattr->wMajorVerNum) & 0xFFFF))) << 16)) expected 65538 got 0 typelib.c:4593: Test failed: typeattr->cbSizeVft expected 0 got 20 typelib.c:4594: Test failed: typeattr->cFuncs expected 0 got 1 typelib.c:4606: Test failed: got wrong guid {b14b6bb5-904e-4ff9-b247-bd361f7aa002} typelib.c:4625: Test failed: desc->memid expected 0 got 1610743808 typelib.c:4626: Test failed: desc->funckind expected 0 got 1 typelib.c:4627: Test failed: desc->invkind expected 0 got 1 typelib.c:4628: Test failed: desc->callconv expected 0 got 4 typelib.c:4631: Test failed: desc->oVft got 16 typelib: unhandled exception c0000005 at 00420ACA === w7pro64 (32 bit typelib) === typelib.c:4570: Test failed: bstrIfName expected "_n" got "child_iface" typelib.c:4574: Test failed: typeattr->typekind expected 1 got 3 typelib.c:4591: Test failed: help_ctx expected 3 got 0 typelib.c:4592: Test failed: ((LONG)(((WORD)((DWORD_PTR)(typeattr->wMinorVerNum) & 0xFFFF)) | ((DWORD)((WORD)((DWORD_PTR)(typeattr->wMajorVerNum) & 0xFFFF))) << 16)) expected 65538 got 0 typelib.c:4593: Test failed: typeattr->cbSizeVft expected 0 got 20 typelib.c:4594: Test failed: typeattr->cFuncs expected 0 got 1 typelib.c:4606: Test failed: got wrong guid {b14b6bb5-904e-4ff9-b247-bd361f7aa002} typelib.c:4625: Test failed: desc->memid expected 0 got 1610743808 typelib.c:4626: Test failed: desc->funckind expected 0 got 1 typelib.c:4627: Test failed: desc->invkind expected 0 got 1 typelib.c:4628: Test failed: desc->callconv expected 0 got 4 typelib.c:4631: Test failed: desc->oVft got 16 typelib: unhandled exception c0000005 at 00420ACA === w8 (32 bit typelib) === typelib.c:4570: Test failed: bstrIfName expected "_n" got "child_iface" typelib.c:4574: Test failed: typeattr->typekind expected 1 got 3 typelib.c:4591: Test failed: help_ctx expected 3 got 0 typelib.c:4592: Test failed: ((LONG)(((WORD)((DWORD_PTR)(typeattr->wMinorVerNum) & 0xFFFF)) | ((DWORD)((WORD)((DWORD_PTR)(typeattr->wMajorVerNum) & 0xFFFF))) << 16)) expected 65538 got 0 typelib.c:4593: Test failed: typeattr->cbSizeVft expected 0 got 20 typelib.c:4594: Test failed: typeattr->cFuncs expected 0 got 1 typelib.c:4606: Test failed: got wrong guid {b14b6bb5-904e-4ff9-b247-bd361f7aa002} typelib.c:4625: Test failed: desc->memid expected 0 got 1610743808 typelib.c:4626: Test failed: desc->funckind expected 0 got 1 typelib.c:4627: Test failed: desc->invkind expected 0 got 1 typelib.c:4628: Test failed: desc->callconv expected 0 got 4 typelib.c:4631: Test failed: desc->oVft got 16 typelib: unhandled exception c0000005 at 00420ACA === w864 (32 bit typelib) === typelib.c:4570: Test failed: bstrIfName expected "_n" got "child_iface" typelib.c:4574: Test failed: typeattr->typekind expected 1 got 3 typelib.c:4591: Test failed: help_ctx expected 3 got 0 typelib.c:4592: Test failed: ((LONG)(((WORD)((DWORD_PTR)(typeattr->wMinorVerNum) & 0xFFFF)) | ((DWORD)((WORD)((DWORD_PTR)(typeattr->wMajorVerNum) & 0xFFFF))) << 16)) expected 65538 got 0 typelib.c:4593: Test failed: typeattr->cbSizeVft expected 0 got 20 typelib.c:4594: Test failed: typeattr->cFuncs expected 0 got 1 typelib.c:4606: Test failed: got wrong guid {b14b6bb5-904e-4ff9-b247-bd361f7aa002} typelib.c:4625: Test failed: desc->memid expected 0 got 1610743808 typelib.c:4626: Test failed: desc->funckind expected 0 got 1 typelib.c:4627: Test failed: desc->invkind expected 0 got 1 typelib.c:4628: Test failed: desc->callconv expected 0 got 4 typelib.c:4631: Test failed: desc->oVft got 16 typelib: unhandled exception c0000005 at 00420ACA === w1064 (32 bit typelib) === typelib.c:4570: Test failed: bstrIfName expected "_n" got "child_iface" typelib.c:4574: Test failed: typeattr->typekind expected 1 got 3 typelib.c:4591: Test failed: help_ctx expected 3 got 0 typelib.c:4592: Test failed: ((LONG)(((WORD)((DWORD_PTR)(typeattr->wMinorVerNum) & 0xFFFF)) | ((DWORD)((WORD)((DWORD_PTR)(typeattr->wMajorVerNum) & 0xFFFF))) << 16)) expected 65538 got 0 typelib.c:4593: Test failed: typeattr->cbSizeVft expected 0 got 20 typelib.c:4594: Test failed: typeattr->cFuncs expected 0 got 1 typelib.c:4606: Test failed: got wrong guid {b14b6bb5-904e-4ff9-b247-bd361f7aa002} typelib.c:4625: Test failed: desc->memid expected 0 got 1610743808 typelib.c:4626: Test failed: desc->funckind expected 0 got 1 typelib.c:4627: Test failed: desc->invkind expected 0 got 1 typelib.c:4628: Test failed: desc->callconv expected 0 got 4 typelib.c:4631: Test failed: desc->oVft got 16 typelib: unhandled exception c0000005 at 00420ACA === wvistau64 (64 bit typelib) === typelib.c:4570: Test failed: bstrIfName expected "_n" got "child_iface" typelib.c:4574: Test failed: typeattr->typekind expected 1 got 3 typelib.c:4589: Test failed: typeattr->cbSizeInstance expected 4 got 8 typelib.c:4591: Test failed: help_ctx expected 3 got 0 typelib.c:4592: Test failed: ((LONG)(((WORD)((DWORD_PTR)(typeattr->wMinorVerNum) & 0xFFFF)) | ((DWORD)((WORD)((DWORD_PTR)(typeattr->wMajorVerNum) & 0xFFFF))) << 16)) expected 65538 got 0 typelib.c:4593: Test failed: typeattr->cbSizeVft expected 0 got 40 typelib.c:4594: Test failed: typeattr->cFuncs expected 0 got 1 typelib.c:4606: Test failed: got wrong guid {b14b6bb5-904e-4ff9-b247-bd361f7aa002} typelib.c:4625: Test failed: desc->memid expected 0 got 1610743808 typelib.c:4626: Test failed: desc->funckind expected 0 got 1 typelib.c:4627: Test failed: desc->invkind expected 0 got 1 typelib.c:4628: Test failed: desc->callconv expected 0 got 4 typelib.c:4631: Test failed: desc->oVft got 32 typelib: unhandled exception c0000005 at 000000000041E933 === w2008s64 (64 bit typelib) === typelib.c:4570: Test failed: bstrIfName expected "_n" got "child_iface" typelib.c:4574: Test failed: typeattr->typekind expected 1 got 3 typelib.c:4589: Test failed: typeattr->cbSizeInstance expected 4 got 8 typelib.c:4591: Test failed: help_ctx expected 3 got 0 typelib.c:4592: Test failed: ((LONG)(((WORD)((DWORD_PTR)(typeattr->wMinorVerNum) & 0xFFFF)) | ((DWORD)((WORD)((DWORD_PTR)(typeattr->wMajorVerNum) & 0xFFFF))) << 16)) expected 65538 got 0 typelib.c:4593: Test failed: typeattr->cbSizeVft expected 0 got 40 typelib.c:4594: Test failed: typeattr->cFuncs expected 0 got 1 typelib.c:4606: Test failed: got wrong guid {b14b6bb5-904e-4ff9-b247-bd361f7aa002} typelib.c:4625: Test failed: desc->memid expected 0 got 1610743808 typelib.c:4626: Test failed: desc->funckind expected 0 got 1 typelib.c:4627: Test failed: desc->invkind expected 0 got 1 typelib.c:4628: Test failed: desc->callconv expected 0 got 4 typelib.c:4631: Test failed: desc->oVft got 32 typelib: unhandled exception c0000005 at 000000000041E933 === w7pro64 (64 bit typelib) === typelib.c:4570: Test failed: bstrIfName expected "_n" got "child_iface" typelib.c:4574: Test failed: typeattr->typekind expected 1 got 3 typelib.c:4589: Test failed: typeattr->cbSizeInstance expected 4 got 8 typelib.c:4591: Test failed: help_ctx expected 3 got 0 typelib.c:4592: Test failed: ((LONG)(((WORD)((DWORD_PTR)(typeattr->wMinorVerNum) & 0xFFFF)) | ((DWORD)((WORD)((DWORD_PTR)(typeattr->wMajorVerNum) & 0xFFFF))) << 16)) expected 65538 got 0 typelib.c:4593: Test failed: typeattr->cbSizeVft expected 0 got 40 typelib.c:4594: Test failed: typeattr->cFuncs expected 0 got 1 typelib.c:4606: Test failed: got wrong guid {b14b6bb5-904e-4ff9-b247-bd361f7aa002} typelib.c:4625: Test failed: desc->memid expected 0 got 1610743808 typelib.c:4626: Test failed: desc->funckind expected 0 got 1 typelib.c:4627: Test failed: desc->invkind expected 0 got 1 typelib.c:4628: Test failed: desc->callconv expected 0 got 4 typelib.c:4631: Test failed: desc->oVft got 32 typelib: unhandled exception c0000005 at 000000000041E933 === w864 (64 bit typelib) === typelib.c:4570: Test failed: bstrIfName expected "_n" got "child_iface" typelib.c:4574: Test failed: typeattr->typekind expected 1 got 3 typelib.c:4589: Test failed: typeattr->cbSizeInstance expected 4 got 8 typelib.c:4591: Test failed: help_ctx expected 3 got 0 typelib.c:4592: Test failed: ((LONG)(((WORD)((DWORD_PTR)(typeattr->wMinorVerNum) & 0xFFFF)) | ((DWORD)((WORD)((DWORD_PTR)(typeattr->wMajorVerNum) & 0xFFFF))) << 16)) expected 65538 got 0 typelib.c:4593: Test failed: typeattr->cbSizeVft expected 0 got 40 typelib.c:4594: Test failed: typeattr->cFuncs expected 0 got 1 typelib.c:4606: Test failed: got wrong guid {b14b6bb5-904e-4ff9-b247-bd361f7aa002} typelib.c:4625: Test failed: desc->memid expected 0 got 1610743808 typelib.c:4626: Test failed: desc->funckind expected 0 got 1 typelib.c:4627: Test failed: desc->invkind expected 0 got 1 typelib.c:4628: Test failed: desc->callconv expected 0 got 4 typelib.c:4631: Test failed: desc->oVft got 32 typelib: unhandled exception c0000005 at 000000000041E933 === w1064 (64 bit typelib) === typelib.c:4570: Test failed: bstrIfName expected "_n" got "child_iface" typelib.c:4574: Test failed: typeattr->typekind expected 1 got 3 typelib.c:4589: Test failed: typeattr->cbSizeInstance expected 4 got 8 typelib.c:4591: Test failed: help_ctx expected 3 got 0 typelib.c:4592: Test failed: ((LONG)(((WORD)((DWORD_PTR)(typeattr->wMinorVerNum) & 0xFFFF)) | ((DWORD)((WORD)((DWORD_PTR)(typeattr->wMajorVerNum) & 0xFFFF))) << 16)) expected 65538 got 0 typelib.c:4593: Test failed: typeattr->cbSizeVft expected 0 got 40 typelib.c:4594: Test failed: typeattr->cFuncs expected 0 got 1 typelib.c:4606: Test failed: got wrong guid {b14b6bb5-904e-4ff9-b247-bd361f7aa002} typelib.c:4625: Test failed: desc->memid expected 0 got 1610743808 typelib.c:4626: Test failed: desc->funckind expected 0 got 1 typelib.c:4627: Test failed: desc->invkind expected 0 got 1 typelib.c:4628: Test failed: desc->callconv expected 0 got 4 typelib.c:4631: Test failed: desc->oVft got 32 typelib: unhandled exception c0000005 at 000000000041E933

Oct. 31, 2015

Release plans

by Alexandre Julliard

Folks, We've decided at WineConf that there would be a code freeze and release every year in the fall. That means about right now... However, there are a few things I'd like to get in first (*cough* Pulse driver), so my thinking is to do one more development release cycle, and start code freeze after 1.7.55. This should enable us to release 1.8 before the end of the year. So if there are new features you'd like to get into 1.8, you have another two weeks... -- Alexandre Julliard julliard(a)winehq.org

Oct. 31, 2015

Re: [PATCH] user32: Silently ignore temporary foreground loss (v2).

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17854 Your paranoid android. === w1064 (32 bit win) === win.c:6708: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6730: Test failed: 0x80/0x1010000: window rect 0,0-1024,768 win.c:6708: Test failed: 0x80/0x81c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6708: Test failed: 0/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6708: Test failed: 0x40000/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6708: Test failed: 0x80/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6708: Test failed: 0x80/0x1c50000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6730: Test failed: 0x80/0x1050000: window rect 0,0-1024,768 win.c:6708: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6730: Test failed: 0x80/0x1410000: window rect 0,0-1024,768 === w1064 (64 bit win) === win.c:6708: Test failed: 0x80/0x1c50000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6730: Test failed: 0x80/0x1050000: window rect 0,0-1024,768

Oct. 30, 2015

Re: steam web browsing on OS X

by Sebastian Lackner

On 30.10.2015 17:42, Theodore Dubois wrote: > Wine Staging includes some patches to fix Steam web browsing, but they are deactivated on Mac because they apparently require special build flags. Does anyone know what this refers to? > > ~Theodore > The staged patchset adds thunk wrappers for ntdll functions, but to be compatible with Windows, they have to contain absolute addresses. This requires text relocations, which are not allowed by default on OSX. Since this issue was discovered shortly before the last release, disabling the patchset on OSX was easier than the necessary configure.ac changes, but I'm working on a solution. Unless we hit some impossible to solve problems Wine Staging 1.7.54 will make the Steam fix also available on OSX. ;) Best regards, Sebastian

Oct. 30, 2015

steam web browsing on OS X

by Theodore Dubois

Wine Staging includes some patches to fix Steam web browsing, but they are deactivated on Mac because they apparently require special build flags. Does anyone know what this refers to? ~Theodore

Oct. 30, 2015