November 2015 - Wine-Devel - list.winehq.org

Re: mshtml: Add IHTMLXMLHttpRequest::responseXML() method implementation. (try 2)

by Christopher Harrington

On Mon, Nov 30, 2015 at 5:32 AM Jacek Caban <jacek(a)codeweavers.com> wrote: > Hi Zhenbo, > > > On 11/27/15 15:49, Zhenbo Li wrote: > > 2015-11-14 17:33 GMT+08:00 Zhenbo Li <litimetal(a)gmail.com> <litimetal(a)gmail.com>: > > + hres = IXMLDOMDocument_loadXML(xmldoc, str, &vbool); > + SysFreeString(str); > + if(hres != S_OK || vbool != VARIANT_TRUE) { > + ERR("loadXML failed: %08x, returning an cmpty xmldoc\n", hres); > + } > > > ERR is not appropriate here. Please use WARN instead. > Also "cmpty" possibly a typo for "empty"? > Thanks, > Jacek > >

Nov. 30, 2015

Re: Learning to Develop for the Wine Project

by Joel Holdsworth

On 30/11/15 19:01, David Reinert wrote: > Hello Friends, > > I am a current undergraduate senior Computer Science major looking to > become familiar with and contribute to Wine. I just want to make sure I > am doing all the best things I can do to familiarize myself with the > project. I have over 3 years of experience coding in C/C++ and I have > taken a course in Operating systems, but my familiarity with any > MS-DOS/Windows based OS(DLLs, etc.) is next to none and I understand > that the learning curve for Wine development is very steep. I've started > by reading through the Wine Developer's Guide Wine Architecture section > to try and gain an understanding of how the whole process operates. is > this useful? Is there anything else that anyone would recommend I do to > gain to good understanding of the project or should I just start writing > patches and dive in head first? Any and all suggestions are welcome and > Iwould appreciate any advice. > > Thanks, > David Reinert > > > Always best to scratch an itch you have. Find an application you want to get working - ideally something that is close to working, maybe something with an open bug report. Then track down the problem either through application source code if you have it, or by catching API calls with WINEDEBUG etc. (good use of bash log filtering is helpful here). Then try and find the behavioral difference between Wine and Windows, and write a mini-test app that demonstrates the problem. The innards of the test app can be used to write a test case for the test suite, and you use both of these to correct the Wine behavior. Now you have patches that you can submit, submit them to wine-patches, respond to feedback, and with some persistence you should get your issue fixed. Good Luck Joel

Nov. 30, 2015

Re: Wine devel packages ready for testing

by Michael Müller

Am 30.11.2015 um 20:29 schrieb Austin English: > Typically the .pkg installer is signed. You are right. Signing the xar archive is sufficient to make OS X happy (I installed my self signed certificate): $ pkgutil --check-signature wine-staging-1.7.55-osx.pkg Package "wine-staging-1.7.55-osx.pkg": Status: signed by a certificate trusted on this system Certificate Chain: 1. Test SHA1 fingerprint: A9 95 25 95 [...] >From a technical point of view I don't see a problem in signing the packages. We already have all required tools on the build system. Am 30.11.2015 um 21:22 schrieb Hin-Tak Leung: > Can you tell me more about the open tool used for signing Mac OS X executables? > > I have been working on font signing in the recently open-sourced > microsoft font validator (there is an official windows-only tool for > signing fonts, but apparently an open-toolchain based tool also exist > in somebody's hard disk) The tool I used for sining the executables is ldid (http://gitweb.saurik.com/ldid.git) The program calculates the checksums for all code sections, signs the checksums and then embeds the signature into the Mach-O executable. It is unlikely that this will help you with font files.

Nov. 30, 2015

Re: [PATCH] ddraw/tests: Test color keys on cube map surfaces.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18665 Your paranoid android. === w1064 (32 bit ddraw7) === ddraw7.c:2252: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w864 (64 bit ddraw7) === ddraw7: unhandled exception c0000005 at 0000000000000000 === w1064 (64 bit ddraw7) === ddraw7: unhandled exception c0000005 at 0000000000000000

Nov. 30, 2015

(OT) code siging on Mac OSX Re: Wine devel packages ready for testing

by Hin-Tak Leung

(going off topic) -------------------------------------------- On Mon, 30/11/15, Michael Müller <michael(a)fds-team.de> wrote: ... It is indeed difficult to sign executables without using any proprietary tools by Apple, but it seems like I found one which works. "codesign -vd wine" seems to like my signature, except that the tool slightly messed up the timestamp of the signature which now lies before the creation date of my self signed certificate. ... Can you tell me more about the open tool used for signing Mac OS X executables? I have been working on font signing in the recently open-sourced microsoft font validator (there is an official windows-only tool for signing fonts, but apparently an open-toolchain based tool also exist in somebody's hard disk) That although is part of an ISO standard for fonts, borrows heavily from microsoft's authenticode excutable signing infrastructure. For those who want to know. Hin-Tak

Nov. 30, 2015

Re: rsaenh: Remove dead assignments (Clang)

by Vincent Povirk

>> The usual idea in cryptography is to zeroize temporary components. >> >> The compiler will optimize away however if its just stack space :( >> > > That's exactly the reason, compilers would maybe only care about it with -O0 FWIW, SecureZeroMemory exists to prevent that optimization.

Nov. 30, 2015

Re: secur32: Remove a dead assignment (Clang)

by André Hentschel

Am 30.11.2015 um 15:10 schrieb Lauri Kenttä: > On 2015-11-29 23:31, André Hentschel wrote: >> - pfQOP = &fQOP; > > Surely nobody would write that kind of dead assignment if there wasn't some intended function for it. > > I wonder if this was supposed to be: > > if (pfQOP) > *pfQOP = fQOP; > > After all, the parameter is designated as _Out_ in MSDN. > I recently met the author, if only I've seen it before :) CCing him, though I doubt he can remember his code from 2006 And you're right, maybe it's rather something like: if (pfQOP) *pfQOP = 0;

Nov. 30, 2015

Re: wininet: Fix allocation error handling (Clang)

by André Hentschel

Am 30.11.2015 um 11:47 schrieb Jacek Caban: > Hi André, > > On 11/29/15 19:53, André Hentschel wrote: >> diff --git a/dlls/wininet/cookie.c b/dlls/wininet/cookie.c >> index 4784b33..0b7f5e1 100644 >> --- a/dlls/wininet/cookie.c >> +++ b/dlls/wininet/cookie.c >> @@ -713,7 +713,8 @@ DWORD get_cookie_header(const WCHAR *host, const WCHAR *path, WCHAR **ret) >> >> *ret = header; >> }else { >> - res = ERROR_NOT_ENOUGH_MEMORY; >> + LeaveCriticalSection(&cookie_cs); >> + return ERROR_NOT_ENOUGH_MEMORY; > > How about returning res in the bottom of the function? Good point, thx

Nov. 30, 2015

Re: rsaenh: Remove dead assignments (Clang)

by André Hentschel

Am 30.11.2015 um 09:51 schrieb Marcus Meissner: > On Mon, Nov 30, 2015 at 01:39:09AM +0300, Nikolay Sivov wrote: >> On 30.11.2015 0:31, André Hentschel wrote: >>> Signed-off-by: André Hentschel <nerv(a)dawncrow.de> >>> --- >>> dlls/rsaenh/sha2.c | 21 --------------------- >>> 1 file changed, 21 deletions(-) >> >> This and advapi32 looks like was done on purpose. Why are you removing that? > > The usual idea in cryptography is to zeroize temporary components. > > The compiler will optimize away however if its just stack space :( > That's exactly the reason, compilers would maybe only care about it with -O0

Nov. 30, 2015

Re: Wine devel packages ready for testing

by Austin English

On Mon, Nov 30, 2015 at 1:27 PM, Michael Müller <michael(a)fds-team.de> wrote: > Am 30.11.2015 um 03:21 schrieb Austin English: >> I'm not sure where you plan on installing wine on OS X, but be aware >> that 10.11/El Capitan forbids installing into /usr (except >> /usr/local): >> https://support.apple.com/en-us/HT204899 >> >> I ran into that recently in my day job. > > Currently we install wine staging into /opt/wine-staging which seems to > work. I would prefer to install the new packages into the home > directory, so that also users without admin rights can install the > package. The only problem are the dependencies since they usually do not > use relative rpaths and they might contain the prefix embedded in the > executables. Not sure if this is a problem, I need to test this. > >> You may also want to consider getting an Apple Developer Key so that >> packages can be signed and users can avoid scary warnings, but I don't >> know if that would work in your cross-compile setup. > > It is indeed difficult to sign executables without using any proprietary > tools by Apple, but it seems like I found one which works. "codesign -vd > wine" seems to like my signature, except that the tool slightly messed > up the timestamp of the signature which now lies before the creation > date of my self signed certificate. I am sure this can be fixed though > ;-). Signing the whole package is most probably a bit more difficult > than just signing one executable, but I am sure this is doable. Typically the .pkg installer is signed. > I guess it is necessary to pay 99$/year for the developer program to get > your key signed, right? Unfortunately yes. -- -Austin

Nov. 30, 2015