November 2015 - Wine-Devel - list.winehq.org

Re: [PATCH 3/5] winepulse: Add audioclient

by Sebastian Lackner

I know this patch is already committed, but still... On 29.10.2015 18:04, Andrew Eikum wrote: > } > if (pulse_ml) > pa_mainloop_quit(pulse_ml, 0); > + if (pulse_thread) { > + WaitForSingleObject(pulse_thread, INFINITE); This can't work. You can't wait for a thread while holding the loader lock. > > +static DWORD CALLBACK pulse_mainloop_thread(void *tmp) { > + int ret; > + pulse_ml = pa_mainloop_new(); I might be wrong, but I see a risk here that the pulse_ml conflicts with the use in pulse_test_connect(). Is it guaranteed that pulse_test_connect() is only called once after loading the DLL? Regards, Sebastian

Nov. 3, 2015

Re: Downloads Site Mirrors

by Jeremy Newman

That is up to Alexandre, but I'm fine with that. -N On 11/02/2015 04:04 PM, Austin English wrote: > On Mon, Nov 2, 2015 at 4:01 PM, Jeremy Newman <jnewman(a)codeweavers.com > <mailto:jnewman(a)codeweavers.com>> wrote: > > We are now mirroring https://ftp.winehq.org, as https://dl.winehq.org/ > > For faster downloads, if you are using our old ftp site for files, > change it to the new dl site. > > Thanks go out to the fine folks at Fastly for providing this service > to Wine. > > -N > > > Does this mean we can migrate away from SourceForge? > > -- > -Austin

Nov. 2, 2015

Re: Downloads Site Mirrors

by Austin English

On Mon, Nov 2, 2015 at 4:01 PM, Jeremy Newman <jnewman(a)codeweavers.com> wrote: > We are now mirroring https://ftp.winehq.org, as https://dl.winehq.org/ > > For faster downloads, if you are using our old ftp site for files, change > it to the new dl site. > > Thanks go out to the fine folks at Fastly for providing this service to > Wine. > > -N > Does this mean we can migrate away from SourceForge? -- -Austin

Nov. 2, 2015

Downloads Site Mirrors

by Jeremy Newman

We are now mirroring https://ftp.winehq.org, as https://dl.winehq.org/ For faster downloads, if you are using our old ftp site for files, change it to the new dl site. Thanks go out to the fine folks at Fastly for providing this service to Wine. -N

Nov. 2, 2015

Re: [PATCH 8/8] ddraw: Mark tests which no longer pass due to reverts as todo_wine.

by Ken Thomases

On Nov 2, 2015, at 3:36 PM, Marvin <testbot(a)winehq.org> wrote: > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > https://testbot.winehq.org/JobDetails.pl?Key=17911 Since my patch just added "todo_wine"s, it can't have had any effect on the behavior of the tests on Windows. -Ken

Nov. 2, 2015

Re: [PATCH 1/8] Revert "wined3d: Track if a context's private hdc has had its pixel format set, so we don't need to check it."

by Ken Thomases

On Nov 2, 2015, at 3:12 PM, Henri Verbeet <hverbeet(a)gmail.com> wrote: > > On 2 November 2015 at 21:37, Ken Thomases <ken(a)codeweavers.com> wrote: >> This reverts commit f3aa4812382caa459b9b612f66998c6ea8257594. >> --- > I may have mentioned this the last time this series came up, but if > you want me to consider signing off on this it wouldn't hurt to > include some text on what the actual issue is, what configurations are > affected, why a year and a half isn't enough time to fix it, etc. I didn't get any feedback on these reverts last time until I asked and then was simply told that you and Alexandre had discussed it and felt that the original change being reverted was "correct" even if it had undesirable side effects. I'm resubmitting now because Alexandre asked me to for the 1.8 release. Patch 5 cites the bugs that are actually fixed by that specific revert. Patches 1-4 are just removing things which didn't break anything but only make sense on top of the restore-pixel-format commit. I'm not sure what you mean by "what configurations are affected". It's not so much configurations (although it primarily affects the X11 driver), it's certain apps and their D3D/WGL usage patterns. As the pixel format is changed back and forth, the window has to be torn down and recreated constantly because the visual has to match between the window and the GL context. This causes flickering and probably loss of X events. As to why a year and a half isn't enough time to fix it: when velocity is 0, distance traveled is going to be 0 regardless of time. I'm no longer working on the proper fix. Let's chalk it up to emotional immaturity on my part. If that makes you reluctant to have my work in wined3d, then you have a sticky dilemma to resolve. ;) -Ken

Nov. 2, 2015

Re: [PATCH 8/8] ddraw: Mark tests which no longer pass due to reverts as todo_wine.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17911 Your paranoid android. === w1064 (32 bit ddraw2) === ddraw2.c:2337: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. ddraw2.c:3193: Test failed: Failed to set display mode, hr 0x80004001. ddraw2.c:3195: Test failed: Got unexpected screen width 1024. ddraw2.c:3197: Test failed: Got unexpected screen height 768. ddraw2.c:3210: Test failed: Failed to set display mode, hr 0x80004001. ddraw2.c:3212: Test failed: Got unexpected screen width 1024. ddraw2.c:3214: Test failed: Got unexpected screen height 768. ddraw2.c:3218: Test failed: Failed to set display mode, hr 0x80004001. ddraw2.c:3220: Test failed: Got unexpected screen width 1024. ddraw2.c:3222: Test failed: Got unexpected screen height 768. ddraw2.c:3241: Test failed: Failed to set display mode, hr 0x80004001. ddraw2.c:3243: Test failed: Got unexpected screen width 1024. ddraw2.c:3245: Test failed: Got unexpected screen height 768. ddraw2.c:3249: Test failed: Failed to set display mode, hr 0x80004001. ddraw2.c:3251: Test failed: Got unexpected screen width 1024. ddraw2.c:3253: Test failed: Got unexpected screen height 768. ddraw2.c:3273: Test failed: Failed to set display mode, hr 0x80004001. ddraw2.c:3275: Test failed: Got unexpected screen width 1024. ddraw2.c:3277: Test failed: Got unexpected screen height 768. ddraw2.c:3282: Test failed: Got unexpected screen width 1024. ddraw2.c:3284: Test failed: Got unexpected screen height 768. ddraw2.c:3297: Test failed: Failed to set display mode, hr 0x80004001. ddraw2.c:3299: Test failed: Got unexpected screen width 1024. ddraw2.c:3301: Test failed: Got unexpected screen height 768. ddraw2.c:3305: Test failed: Failed to set display mode, hr 0x80004001. ddraw2.c:3307: Test failed: Got unexpected screen width 1024. ddraw2.c:3309: Test failed: Got unexpected screen height 768. ddraw2.c:3317: Test failed: Got unexpected screen width 1024. ddraw2.c:3319: Test failed: Got unexpected screen height 768. ddraw2.c:3331: Test failed: Failed to set display mode, hr 0x80004001. ddraw2.c:3333: Test failed: Got unexpected screen width 1024. ddraw2.c:3335: Test failed: Got unexpected screen height 768. ddraw2.c:3506: Test failed: Failed to set display mode, hr 0x80004001. ddraw2.c:3506: Test failed: Failed to set display mode, hr 0x80004001. ddraw2.c:3506: Test failed: Failed to set display mode, hr 0x80004001. ddraw2.c:3552: Test failed: Display mode restored after good ddraw1::SetCooperativeLevel call ddraw2.c:3506: Test failed: Failed to set display mode, hr 0x80004001. ddraw2.c:3565: Test failed: Display mode restored after ddraw1::SetCooperativeLevel(SETFOCUSWINDOW) call ddraw2.c:3506: Test failed: Failed to set display mode, hr 0x80004001. ddraw2.c:3581: Test failed: Display mode restored after good-bad ddraw1::SetCooperativeLevel() call sequence ddraw2.c:3506: Test failed: Failed to set display mode, hr 0x80004001. ddraw2.c:3600: Test failed: Display mode restored after ddraw1-ddraw2 SetCooperativeLevel() call sequence ddraw2.c:3506: Test failed: Failed to set display mode, hr 0x80004001. ddraw2.c:4757: Test failed: Failed to set display mode, hr 0x80004001. === w1064 (32 bit ddraw1) === ddraw1.c:2186: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. ddraw1.c:2931: Test failed: Failed to set display mode, hr 0x80004001. ddraw1.c:2933: Test failed: Got unexpected screen width 1024. ddraw1.c:2935: Test failed: Got unexpected screen height 768. ddraw1.c:2948: Test failed: Failed to set display mode, hr 0x80004001. ddraw1.c:2950: Test failed: Got unexpected screen width 1024. ddraw1.c:2952: Test failed: Got unexpected screen height 768. ddraw1.c:2956: Test failed: Failed to set display mode, hr 0x80004001. ddraw1.c:2958: Test failed: Got unexpected screen width 1024. ddraw1.c:2960: Test failed: Got unexpected screen height 768. ddraw1.c:2979: Test failed: Failed to set display mode, hr 0x80004001. ddraw1.c:2981: Test failed: Got unexpected screen width 1024. ddraw1.c:2983: Test failed: Got unexpected screen height 768. ddraw1.c:2987: Test failed: Failed to set display mode, hr 0x80004001. ddraw1.c:2989: Test failed: Got unexpected screen width 1024. ddraw1.c:2991: Test failed: Got unexpected screen height 768. ddraw1.c:3011: Test failed: Failed to set display mode, hr 0x80004001. ddraw1.c:3013: Test failed: Got unexpected screen width 1024. ddraw1.c:3015: Test failed: Got unexpected screen height 768. ddraw1.c:3020: Test failed: Got unexpected screen width 1024. ddraw1.c:3022: Test failed: Got unexpected screen height 768. ddraw1.c:3035: Test failed: Failed to set display mode, hr 0x80004001. ddraw1.c:3037: Test failed: Got unexpected screen width 1024. ddraw1.c:3039: Test failed: Got unexpected screen height 768. ddraw1.c:3043: Test failed: Failed to set display mode, hr 0x80004001. ddraw1.c:3045: Test failed: Got unexpected screen width 1024. ddraw1.c:3047: Test failed: Got unexpected screen height 768. ddraw1.c:3055: Test failed: Got unexpected screen width 1024. ddraw1.c:3057: Test failed: Got unexpected screen height 768. ddraw1.c:3069: Test failed: Failed to set display mode, hr 0x80004001. ddraw1.c:3071: Test failed: Got unexpected screen width 1024. ddraw1.c:3073: Test failed: Got unexpected screen height 768. ddraw1.c:4122: Test failed: Failed to set display mode, hr 0x80004001. === w1064 (32 bit ddraw7) === ddraw7.c:2183: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. ddraw7.c:3024: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3026: Test failed: Got unexpected screen width 1024. ddraw7.c:3028: Test failed: Got unexpected screen height 768. ddraw7.c:3041: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3043: Test failed: Got unexpected screen width 1024. ddraw7.c:3045: Test failed: Got unexpected screen height 768. ddraw7.c:3049: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3051: Test failed: Got unexpected screen width 1024. ddraw7.c:3053: Test failed: Got unexpected screen height 768. ddraw7.c:3072: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3074: Test failed: Got unexpected screen width 1024. ddraw7.c:3076: Test failed: Got unexpected screen height 768. ddraw7.c:3080: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3082: Test failed: Got unexpected screen width 1024. ddraw7.c:3084: Test failed: Got unexpected screen height 768. ddraw7.c:3104: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3106: Test failed: Got unexpected screen width 1024. ddraw7.c:3108: Test failed: Got unexpected screen height 768. ddraw7.c:3113: Test failed: Got unexpected screen width 1024. ddraw7.c:3115: Test failed: Got unexpected screen height 768. ddraw7.c:3128: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3130: Test failed: Got unexpected screen width 1024. ddraw7.c:3132: Test failed: Got unexpected screen height 768. ddraw7.c:3136: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3138: Test failed: Got unexpected screen width 1024. ddraw7.c:3140: Test failed: Got unexpected screen height 768. ddraw7.c:3148: Test failed: Got unexpected screen width 1024. ddraw7.c:3150: Test failed: Got unexpected screen height 768. ddraw7.c:3162: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3164: Test failed: Got unexpected screen width 1024. ddraw7.c:3166: Test failed: Got unexpected screen height 768. ddraw7.c:3975: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3975: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3975: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:4021: Test failed: Display mode restored after good ddraw1::SetCooperativeLevel call ddraw7.c:3975: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:4034: Test failed: Display mode restored after ddraw1::SetCooperativeLevel(SETFOCUSWINDOW) call ddraw7.c:3975: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:4050: Test failed: Display mode restored after good-bad ddraw1::SetCooperativeLevel() call sequence ddraw7.c:3975: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:4069: Test failed: Display mode restored after ddraw1-ddraw7 SetCooperativeLevel() call sequence ddraw7.c:3975: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:5877: Test failed: Failed to set display mode, hr 0x80004001. === w864 (64 bit ddraw7) === ddraw7: unhandled exception c0000005 at 0000000000000000 === w1064 (64 bit ddraw7) === The test timed out === w1064 (32 bit ddraw4) === ddraw4.c:2522: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. ddraw4.c:3363: Test failed: Failed to set display mode, hr 0x80004001. ddraw4.c:3365: Test failed: Got unexpected screen width 1024. ddraw4.c:3367: Test failed: Got unexpected screen height 768. ddraw4.c:3380: Test failed: Failed to set display mode, hr 0x80004001. ddraw4.c:3382: Test failed: Got unexpected screen width 1024. ddraw4.c:3384: Test failed: Got unexpected screen height 768. ddraw4.c:3388: Test failed: Failed to set display mode, hr 0x80004001. ddraw4.c:3390: Test failed: Got unexpected screen width 1024. ddraw4.c:3392: Test failed: Got unexpected screen height 768. ddraw4.c:3411: Test failed: Failed to set display mode, hr 0x80004001. ddraw4.c:3413: Test failed: Got unexpected screen width 1024. ddraw4.c:3415: Test failed: Got unexpected screen height 768. ddraw4.c:3419: Test failed: Failed to set display mode, hr 0x80004001. ddraw4.c:3421: Test failed: Got unexpected screen width 1024. ddraw4.c:3423: Test failed: Got unexpected screen height 768. ddraw4.c:3443: Test failed: Failed to set display mode, hr 0x80004001. ddraw4.c:3445: Test failed: Got unexpected screen width 1024. ddraw4.c:3447: Test failed: Got unexpected screen height 768. ddraw4.c:3452: Test failed: Got unexpected screen width 1024. ddraw4.c:3454: Test failed: Got unexpected screen height 768. ddraw4.c:3467: Test failed: Failed to set display mode, hr 0x80004001. ddraw4.c:3469: Test failed: Got unexpected screen width 1024. ddraw4.c:3471: Test failed: Got unexpected screen height 768. ddraw4.c:3475: Test failed: Failed to set display mode, hr 0x80004001. ddraw4.c:3477: Test failed: Got unexpected screen width 1024. ddraw4.c:3479: Test failed: Got unexpected screen height 768. ddraw4.c:3487: Test failed: Got unexpected screen width 1024. ddraw4.c:3489: Test failed: Got unexpected screen height 768. ddraw4.c:3501: Test failed: Failed to set display mode, hr 0x80004001. ddraw4.c:3503: Test failed: Got unexpected screen width 1024. ddraw4.c:3505: Test failed: Got unexpected screen height 768. ddraw4.c:4346: Test failed: Failed to set display mode, hr 0x80004001. ddraw4.c:4346: Test failed: Failed to set display mode, hr 0x80004001. ddraw4.c:4346: Test failed: Failed to set display mode, hr 0x80004001. ddraw4.c:4392: Test failed: Display mode restored after good ddraw1::SetCooperativeLevel call ddraw4.c:4346: Test failed: Failed to set display mode, hr 0x80004001. ddraw4.c:4405: Test failed: Display mode restored after ddraw1::SetCooperativeLevel(SETFOCUSWINDOW) call ddraw4.c:4346: Test failed: Failed to set display mode, hr 0x80004001. ddraw4.c:4421: Test failed: Display mode restored after good-bad ddraw1::SetCooperativeLevel() call sequence ddraw4.c:4346: Test failed: Failed to set display mode, hr 0x80004001. ddraw4.c:4440: Test failed: Display mode restored after ddraw1-ddraw4 SetCooperativeLevel() call sequence ddraw4.c:4346: Test failed: Failed to set display mode, hr 0x80004001. ddraw4.c:6081: Test failed: Failed to set display mode, hr 0x80004001.

Nov. 2, 2015

Re: [PATCH 1/8] Revert "wined3d: Track if a context's private hdc has had its pixel format set, so we don't need to check it."

by Henri Verbeet

On 2 November 2015 at 21:37, Ken Thomases <ken(a)codeweavers.com> wrote: > This reverts commit f3aa4812382caa459b9b612f66998c6ea8257594. > --- I may have mentioned this the last time this series came up, but if you want me to consider signing off on this it wouldn't hurt to include some text on what the actual issue is, what configurations are affected, why a year and a half isn't enough time to fix it, etc.

Nov. 2, 2015

Re: [PATCH 2/4] winex11: Avoid inefficiency and overflow in remove_startup_notification.

by Alex Henrie

2015-11-02 9:54 GMT-07:00 Vincent Povirk <vincent(a)codeweavers.com>: >>> It seems like you're doing two unrelated things here? I'd expect the >>> process of building the string to send and sending it to be >>> independent. >> >> I don't think the other code we have that interacts with X11 is >> similar enough to this to justify creating a helper code and moving >> some of this code there. Also, I'm not trying to redesign the entire >> startup notification feature, I'm just trying to fix a potential >> buffer overflow while making this function a bit more efficient and >> understandable. > > I don't think you need to restructure the code, just saying maybe it'd > make sense to split this. > >>>> if ((src = strstr( id, "_TIME" ))) update_user_time( atol( src + 5 )); >>>> >>>> - pos = snprintf(message, sizeof(message), "remove: ID="); >>>> - message[pos++] = '"'; >>>> - for (i = 0; id[i] && pos < sizeof(message) - 2; i++) >>>> + pos = sprintf(message, "remove: ID=\""); >>>> + for (i = 0; id[i]; i++) >>>> { >>>> if (id[i] == '"' || id[i] == '\\') >>>> + { >>>> + if (pos == sizeof(message) - 3) break; >>>> message[pos++] = '\\'; >>>> + } >>>> + if (pos == sizeof(message) - 2) break; >>>> message[pos++] = id[i]; >>>> } >>>> message[pos++] = '"'; >>>> message[pos++] = '\0'; >>> >>> Your use of == instead of > or >= in these checks makes me >>> uncomfortable. Given that a single iteration can increment pos twice, >>> why can't we have a situation where (pos > sizeof(message) - 3), >>> inside the if statement? >> >> Because I'm checking pos every time that it increments by one. > > You're checking it, but not for the same value. Why can't we have this happen: > * id[i] is 'a', and pos == sizeof(message) - 3 > * We check whether pos == sizeof(message) - 2, it isn't so we keep going. > * We write 'a' into message and increment pos, now it's sizeof(message) - 2 > * We increment i and continue with the loop, now id[i] is '"'. > * We check whether pos == sizeof(message) - 3, it isn't, we write a \ > and increment pos to sizeof(message) - 1 > * There's nothing to stop the loop from continuing when we run out of buffer. Okay, I see what you mean now, thanks. > A simpler approach might be to change the buffer sizes so that we > can't overrun the second buffer. After looking at it again, I agree that this is the right way to go. If we make message 4 KiB, there is no chance of overflow. Coincidentally, the spec <http://standards.freedesktop.org/startup-notification-spec/startup-notifica…> suggests that "4k of data" is the maximum that the X server will accept anyway. I will upload a revised patch to <https://github.com/alexhenrie/wine/commits/master> shortly and if there are no objections, I'll send it tonight. -Alex

Nov. 2, 2015

Re: [PATCH 6/6] mmdevapi/tests: Remove todo_wine on some tests for winepulse

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17908 Your paranoid android. === w7u (32 bit capture) === capture.c:329: Test failed: GCP 11200 vs. BufferSize 21996 === w8 (32 bit capture) === capture.c:325: Test failed: Position 3127 gap 1152 capture.c:349: Test failed: Position 4215 expected 3575 capture.c:374: Test failed: Position 5303 expected 4023 === w864 (32 bit capture) === capture.c:181: Test failed: Position 1015 expected 0 capture.c:231: Test failed: Position 2167 expected 1463 capture.c:263: Test failed: Position 2167 expected 1463 capture.c:325: Test failed: Position 3255 gap 1344 capture.c:349: Test failed: Position 4343 expected 3703 capture.c:374: Test failed: Position 4791 expected 4151 === w1064 (32 bit capture) === capture.c:181: Test failed: Position 1079 expected 0 capture.c:231: Test failed: Position 2167 expected 1527 capture.c:263: Test failed: Position 2167 expected 1527 capture.c:325: Test failed: Position 4151 gap 2176 capture.c:329: Test failed: GCP 12992 vs. BufferSize 21996 capture.c:349: Test failed: Position 5239 expected 4599 capture.c:350: Test failed: flags 1 capture.c:374: Test failed: Position 5687 expected 5047 === w864 (64 bit capture) === capture.c:329: Test failed: GCP 13888 vs. BufferSize 21996 === w1064 (64 bit capture) === capture.c:329: Test failed: GCP 13888 vs. BufferSize 21996 capture.c:349: Test failed: Position 5239 expected 4663 capture.c:374: Test failed: Position 5687 expected 5111

Nov. 2, 2015