December 2015 - Wine-Devel - list.winehq.org

Re: programs/xcopy: Fix casing of usage message

by Alexandre Julliard

Austin English <austinenglish(a)gmail.com> writes: > On Wed, Dec 2, 2015 at 10:33 PM, Alexandre Julliard <julliard(a)winehq.org> wrote: >> Austin English <austinenglish(a)gmail.com> writes: >> >>> I'm not sure about that. I don't know any other languages than >>> English, and some are in different scripts that I can't recognize >>> which letter I'm supposed to change. >>> >>> If that's why AJ wants I can do it, but I think that updating PO files >>> should be the job of the translators, not developers. >>> >>> Alexandre, care to comment? >> >> I'm not convinced that we want to change this. It's localized, so no >> reasonable app is going to depend on it. > > Sure, but we all know not all apps are reasonable. Of course. If there's a real app that depends on it, then it should be fixed. But if it's just someone's personal script, I don't think it qualifies. -- Alexandre Julliard julliard(a)winehq.org

Dec. 3, 2015

Re: programs/xcopy: Fix casing of usage message

by Austin English

On Wed, Dec 2, 2015 at 10:33 PM, Alexandre Julliard <julliard(a)winehq.org> wrote: > Austin English <austinenglish(a)gmail.com> writes: > >> I'm not sure about that. I don't know any other languages than >> English, and some are in different scripts that I can't recognize >> which letter I'm supposed to change. >> >> If that's why AJ wants I can do it, but I think that updating PO files >> should be the job of the translators, not developers. >> >> Alexandre, care to comment? > > I'm not convinced that we want to change this. It's localized, so no > reasonable app is going to depend on it. Sure, but we all know not all apps are reasonable. > Of course anybody can write a script checking for the exact message on > their version of Windows, but we can't be compatible with that unless we > copy all Windows messages verbatim, which we don't want to do. Sure, I'm not proposing that we copy every string verbatim, only the minimal necessary to fix the reported bug. As it stands, there's a bug in bugzilla and the only way to fix it is to change that string. If that's not permissible, then please close the bug WONTFIX. -- -Austin

Dec. 3, 2015

Re: programs/xcopy: Fix casing of usage message

by Alexandre Julliard

Austin English <austinenglish(a)gmail.com> writes: > I'm not sure about that. I don't know any other languages than > English, and some are in different scripts that I can't recognize > which letter I'm supposed to change. > > If that's why AJ wants I can do it, but I think that updating PO files > should be the job of the translators, not developers. > > Alexandre, care to comment? I'm not convinced that we want to change this. It's localized, so no reasonable app is going to depend on it. Of course anybody can write a script checking for the exact message on their version of Windows, but we can't be compatible with that unless we copy all Windows messages verbatim, which we don't want to do. -- Alexandre Julliard julliard(a)winehq.org

Dec. 3, 2015

Re: Random err:winediag:nulldrv_CreateWindow errors related to windows and explorer

by Alexandre Julliard

Bruno Jesus <00cpxxx(a)gmail.com> writes: > On Wed, Dec 2, 2015 at 9:54 PM, Sebastian Lackner <sebastian(a)fds-team.de> wrote: >> Hi Bruno, > > Lali-ho! > >> I think this issue already exists since a long time - for example after >> running the user32/winstation tests. >> I personally have not noticed that the probability has increased, but like >> with all random issues, even a >> small delay / speedup can make it more or less likely to trigger such a >> random issue. If you can >> reproduce it reliable enough, it would be nice if you could try to do a >> bisect (by running the corresponding >> app/tests several times). The "bad" commit could be completely unrelated >> though. > > Thanks for the reply. I don't remember ever seeing those messages, I'm > trying to make it easier to reproduce here. I have never seen those messages either, and I run the tests a lot, so I'm worried that it may be something new. If you could manage to reproduce it, that would be great. -- Alexandre Julliard julliard(a)winehq.org

Dec. 3, 2015

Re: Random err:winediag:nulldrv_CreateWindow errors related to windows and explorer

by Austin English

On Wed, Dec 2, 2015 at 8:32 PM, Bruno Jesus <00cpxxx(a)gmail.com> wrote: > On Wed, Dec 2, 2015 at 9:54 PM, Sebastian Lackner <sebastian(a)fds-team.de> wrote: >> Hi Bruno, > > Lali-ho! > >> I think this issue already exists since a long time - for example after >> running the user32/winstation tests. >> I personally have not noticed that the probability has increased, but like >> with all random issues, even a >> small delay / speedup can make it more or less likely to trigger such a >> random issue. If you can >> reproduce it reliable enough, it would be nice if you could try to do a >> bisect (by running the corresponding >> app/tests several times). The "bad" commit could be completely unrelated >> though. > > Thanks for the reply. I don't remember ever seeing those messages, I'm > trying to make it easier to reproduce here. What I have always > randomly experienced is other error (which also have a bug I can't > remember) and it is something like wine_kernel_boot: timeout, or > wine_kernel_init or something like that. https://bugs.winehq.org/show_bug.cgi?id=15492 I was only able to reproduce in a VM on an (older) machine without virtualization extensions IIRC (definitely slow in any case ;)). -- -Austin

Dec. 3, 2015

Re: Random err:winediag:nulldrv_CreateWindow errors related to windows and explorer

by Bruno Jesus

On Wed, Dec 2, 2015 at 9:54 PM, Sebastian Lackner <sebastian(a)fds-team.de> wrote: > Hi Bruno, Lali-ho! > I think this issue already exists since a long time - for example after > running the user32/winstation tests. > I personally have not noticed that the probability has increased, but like > with all random issues, even a > small delay / speedup can make it more or less likely to trigger such a > random issue. If you can > reproduce it reliable enough, it would be nice if you could try to do a > bisect (by running the corresponding > app/tests several times). The "bad" commit could be completely unrelated > though. Thanks for the reply. I don't remember ever seeing those messages, I'm trying to make it easier to reproduce here. What I have always randomly experienced is other error (which also have a bug I can't remember) and it is something like wine_kernel_boot: timeout, or wine_kernel_init or something like that. > BTW: After Qian pointed out the problem with explorer.exe process leaks some > weeks ago, I've started > preparing patches for winstation and desktop cleanup. They also fix some > race-conditions, but in their > current form I would consider them too experimental to be merged. Also, > there are still a few unfixed > problems left. I'll wait for your patches them, after restarting the computer the error seems to be happening less so I believe it is related to the amount of memory used. Bruno

Dec. 3, 2015

Re: Simplified local IP reordering patch for default routes

by Bruno Jesus

On Wednesday, December 2, 2015, Austin English <austinenglish(a)gmail.com> wrote: > > Hi Bruno, Hello, Austin. > > Should this help with ws2_32/sock.c failing? On my Gentoo machine, > this test fails: > sock.c:4402: Test failed: address does not match: 0.0.0.0 != 127.12.34.56 > > It also fails with your patch. The patch does fix one todo test, however: > sock.c:4549: Test succeeded inside todo block: failed to find the > first IP from gethostbyname! This is the first patch in a series, I believe that the final version will fix that problem.

Dec. 3, 2015

RE: programs/xcopy: Fix casing of usage message

by Hugh McMaster

On Wednesday, 2 Dec 2015 17:14:25 -0600, Austin English wrote: > On Thu, Nov 19, 2015 at 3:01 AM, Hugh McMaster wrote: >> On Wednesday, 18 Nov 2015 19:08:29 -0600, Austin English wrote: >> >>>- STRING_SIMCOPY, "%1!d! file(s) would be copied\n" >>>- STRING_COPY, "%1!d! file(s) copied\n" >>>+ STRING_SIMCOPY, "%1!d! File(s) would be copied\n" >>>+ STRING_COPY, "%1!d! File(s) copied\n" >> >> You should probably patch all of the po files as well. It's a simple change, >> and it means Alexandre doesn't have to regenerate everything. > > I'm not sure about that. I don't know any other languages than > English, and some are in different scripts that I can't recognize > which letter I'm supposed to change. > > If that's why AJ wants I can do it, but I think that updating PO files > should be the job of the translators, not developers. I meant that you should update the relevant msgid in each of the po files, e.g. msgid "%1!d! file(s) copied\n". Alexandre may have a different view, though.

Dec. 2, 2015

Re: winedbg: Print windows version in system info.

by Austin English

On Wed, Dec 2, 2015 at 5:20 PM, Sebastian Lackner <sebastian(a)fds-team.de> wrote: > From: Michael Müller <michael(a)fds-team.de> > > Signed-off-by: Michael Müller <michael(a)fds-team.de> > Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de> > --- > > ... for those who don't have a crystal ball while triaging bug reports. :) > > programs/winedbg/tgt_active.c | 58 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 58 insertions(+) > > diff --git a/programs/winedbg/tgt_active.c b/programs/winedbg/tgt_active.c > index 989e433..07edccc 100644 > --- a/programs/winedbg/tgt_active.c > +++ b/programs/winedbg/tgt_active.c > @@ -678,6 +678,63 @@ static HANDLE create_temp_file(void) > NULL, CREATE_ALWAYS, FILE_ATTRIBUTE_NORMAL | FILE_FLAG_DELETE_ON_CLOSE, 0 ); > } > > +static const struct > +{ > + int type; > + int platform; > + int major; > + int minor; > + const char *str; > +} > +version_table[] = > +{ > + { 0, VER_PLATFORM_WIN32s, 2, 0, "2.0" }, > + { 0, VER_PLATFORM_WIN32s, 3, 0, "3.0" }, > + { 0, VER_PLATFORM_WIN32s, 3, 10, "3.1" }, > + { 0, VER_PLATFORM_WIN32_WINDOWS, 4, 0, "95" }, > + { 0, VER_PLATFORM_WIN32_WINDOWS, 4, 10, "98" }, > + { 0, VER_PLATFORM_WIN32_WINDOWS, 4, 90, "ME" }, > + { VER_NT_WORKSTATION, VER_PLATFORM_WIN32_NT, 3, 51, "NT 3.51" }, > + { VER_NT_WORKSTATION, VER_PLATFORM_WIN32_NT, 4, 0, "NT 4.0" }, > + { VER_NT_WORKSTATION, VER_PLATFORM_WIN32_NT, 5, 0, "2000" }, > + { VER_NT_WORKSTATION, VER_PLATFORM_WIN32_NT, 5, 1, "XP" }, > + { VER_NT_WORKSTATION, VER_PLATFORM_WIN32_NT, 5, 2, "XP" }, > + { VER_NT_SERVER, VER_PLATFORM_WIN32_NT, 5, 2, "Server 2003" }, > + { VER_NT_WORKSTATION, VER_PLATFORM_WIN32_NT, 6, 0, "Vista" }, > + { VER_NT_SERVER, VER_PLATFORM_WIN32_NT, 6, 0, "Server 2008" }, > + { VER_NT_WORKSTATION, VER_PLATFORM_WIN32_NT, 6, 1, "7" }, > + { VER_NT_SERVER, VER_PLATFORM_WIN32_NT, 6, 1, "Server 2008 R2" }, > + { VER_NT_WORKSTATION, VER_PLATFORM_WIN32_NT, 6, 2, "8" }, > + { VER_NT_SERVER, VER_PLATFORM_WIN32_NT, 6, 2, "Server 2012" }, > + { VER_NT_WORKSTATION, VER_PLATFORM_WIN32_NT, 6, 3, "8.1" }, > + { VER_NT_SERVER, VER_PLATFORM_WIN32_NT, 6, 3, "Server 2012 R2" }, > + { VER_NT_WORKSTATION, VER_PLATFORM_WIN32_NT, 10, 0, "10" }, > +}; > + > +static const char *get_windows_version(void) > +{ > + OSVERSIONINFOEXW info = { sizeof(OSVERSIONINFOEXW) }; > + static char str[64]; > + int i; > + > + GetVersionExW( (OSVERSIONINFOW *)&info ); > + > + for (i = 0; i < sizeof(version_table) / sizeof(version_table[0]); i++) > + { > + if (version_table[i].type == info.wProductType && > + version_table[i].platform == info.dwPlatformId && > + version_table[i].major == info.dwMajorVersion && > + version_table[i].minor == info.dwMinorVersion) > + { > + return version_table[i].str; > + } > + } > + > + snprintf( str, sizeof(str), "%d.%d (%d)", info.dwMajorVersion, > + info.dwMinorVersion, info.wProductType ); > + return str; > +} > + > static void output_system_info(void) > { > #ifdef __i386__ > @@ -705,6 +762,7 @@ static void output_system_info(void) > dbg_printf( "System information:\n" ); > if (wine_get_build_id) dbg_printf( " Wine build: %s\n", wine_get_build_id() ); > dbg_printf( " Platform: %s%s\n", platform, is_wow64 ? " (WOW64)" : "" ); > + dbg_printf( " Version: Windows %s\n", get_windows_version() ); > if (wine_get_host_version) > { > const char *sysname, *release; > -- > 2.6.2 > > With my bugzilla hat on: Thank you!! -- -Austin

Dec. 2, 2015

Re: programs/xcopy: Fix casing of usage message

by Austin English

On Thu, Nov 19, 2015 at 3:01 AM, Hugh McMaster <hugh.mcmaster(a)outlook.com> wrote: > On Wednesday, 18 Nov 2015 19:08:29 -0600, Austin English wrote: > >>- STRING_SIMCOPY, "%1!d! file(s) would be copied\n" >>- STRING_COPY, "%1!d! file(s) copied\n" >>+ STRING_SIMCOPY, "%1!d! File(s) would be copied\n" >>+ STRING_COPY, "%1!d! File(s) copied\n" > > Hi Austin, > > You should probably patch all of the po files as well. It's a simple change, > and it means Alexandre doesn't have to regenerate everything. > > -- > Hugh McMaster > I'm not sure about that. I don't know any other languages than English, and some are in different scripts that I can't recognize which letter I'm supposed to change. If that's why AJ wants I can do it, but I think that updating PO files should be the job of the translators, not developers. Alexandre, care to comment? -- -Austin

Dec. 2, 2015