December 2015 - Wine-Devel - list.winehq.org

Re: Simplified local IP reordering patch for default routes

by Austin English

On Tue, Dec 1, 2015 at 8:24 PM, Bruno Jesus <00cpxxx(a)gmail.com> wrote: > On Wed, Dec 2, 2015 at 5:56 AM, Jamie Taylor <Jamie.Taylor(a)pobox.com> wrote: >> On Thu, Nov 26, 2015 at 11:00:01PM -0500, Jamie Taylor wrote: >>> On Thu, Nov 26, 2015 at 08:11:20PM +0800, Bruno Jesus wrote: >>> > Hi, Jamie and Joachim and list. This is a short version of a long >>> > patch I'm working on, it orders the IP list with the default routes on >>> > top and it supports more than one default route. It fixes the problem >>> > on Linux and FreeBSD, could anyone also test it on OSX, please? >>> >>> I am away from my test setup until next week due to the Thanksgiving >>> holiday in the USA, but I will do a test on OSX when I get back to it, >> >> Works for me on OSX. > > Thanks for the test, patch will be submitted after code freeze. Hi Bruno, Should this help with ws2_32/sock.c failing? On my Gentoo machine, this test fails: sock.c:4402: Test failed: address does not match: 0.0.0.0 != 127.12.34.56 It also fails with your patch. The patch does fix one todo test, however: sock.c:4549: Test succeeded inside todo block: failed to find the first IP from gethostbyname! -- -Austin

Dec. 2, 2015

Re: loader/wine.inf.in: add 'HKLM\Software\Classes\Applications\iexplore.exe\shell\open\command' key

by Austin English

On Wed, Dec 2, 2015 at 4:55 AM, Jacek Caban <jacek(a)codeweavers.com> wrote: > Hi Austin, > > On 12/02/15 07:31, Austin English wrote: > > > From a8309f37269bc374359e6ee473e66465551b867f Mon Sep 17 00:00:00 2001 > From: Austin English <austinenglish(a)gmail.com> > Date: Wed, 2 Dec 2015 01:27:15 -0500 > Subject: [PATCH] loader/wine.inf.in: add > 'HKLM\Software\Classes\Applications\iexplore.exe\shell\open\command' key > > Signed-off-by: Austin English <austinenglish(a)gmail.com> > --- > loader/wine.inf.in | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/loader/wine.inf.in b/loader/wine.inf.in > > > I believe this should go to programs/iexplore/iexplore.inf. OK, thanks. > index 58a8d1d..02b92f4 100644 > --- a/loader/wine.inf.in > +++ b/loader/wine.inf.in > @@ -245,6 +245,7 @@ HKCR,https\shell\open\ddeexec,"NoActivateHandler",2,"" > HKCR,https\shell\open\ddeexec\Application,,2,"IExplore" > HKCR,https\shell\open\ddeexec\Topic,,2,"WWW_OpenURL" > HKCR,mailto\shell\open\command,,2,"%11%\winebrowser %1" > +HKLM,Software\Classes\Applications\iexplore.exe\shell\open\command,,2,"""%16422%\Internet > Explorer\iexplore.exe"" %1" > > > Why don't you use HKCR here? I considered it to match the other entries, but the user requested/tested HKLM, and I cannot find the application to test myself. -- -Austin

Dec. 2, 2015

Re: [PATCH 3/3] ntdll/tests: Restore old value in a more context independent way.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18722 Your paranoid android. === wvistau64 (32 bit exception) === exception.c:485: Test failed: 42: Wrong exception address 002D0000/002D0001 exception: unhandled exception 80000004 at 002D0000 exception.c:485: Test failed: 42: Wrong exception address 77BAED97/002D0001 === w7u (32 bit exception) === exception.c:485: Test failed: 42: Wrong exception address 002F0000/002F0001 exception: unhandled exception 80000004 at 002F0000 exception.c:485: Test failed: 42: Wrong exception address 77CDE34F/002F0001 === w1064 (32 bit exception) === Failure running script in VM: network read timed out (Connect:AgentVersion.h:0/9)

Dec. 2, 2015

Re: [PATCH 1/3] ntdll/tests: Add SIMD exception test for floating point invalid operation fault (try 4).

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18721 Your paranoid android. === wvistau64 (32 bit exception) === exception.c:485: Test failed: 42: Wrong exception address 003D0000/003D0001 exception: unhandled exception 80000004 at 003D0000 exception.c:485: Test failed: 42: Wrong exception address 77BAED97/003D0001 === w7u (32 bit exception) === exception.c:485: Test failed: 42: Wrong exception address 002F0000/002F0001 exception: unhandled exception 80000004 at 002F0000 exception.c:485: Test failed: 42: Wrong exception address 77CDE34F/002F0001 === w1064 (32 bit exception) === Failure running script in VM: network read timed out (Connect:AgentVersion.h:0/9)

Dec. 2, 2015

Re: [PATCH 4/4 v2] dsound: Fail to create a version 8 3d buffer with DSBCAPS_CTRLPAN

by Andrew Eikum

This looks fine, but since it doesn't fix a bug, I think this one should be deferred. As Michael knows, dsound applications can be fragile... Andrew On Tue, Dec 01, 2015 at 02:49:45PM +0100, Michael Stefaniuc wrote: > Signed-off-by: Michael Stefaniuc <mstefani(a)redhat.de> > --- > dlls/dsound/dsound.c | 5 +++++ > dlls/dsound/tests/ds3d8.c | 1 - > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/dlls/dsound/dsound.c b/dlls/dsound/dsound.c > index 7b93455..e50ef58 100644 > --- a/dlls/dsound/dsound.c > +++ b/dlls/dsound/dsound.c > @@ -542,6 +542,11 @@ static HRESULT DirectSoundDevice_CreateSoundBuffer( > return DSERR_INVALIDPARAM; > } > > + if (from8 && (dsbd->dwFlags & DSBCAPS_CTRL3D) && (dsbd->dwFlags & DSBCAPS_CTRLPAN)) { > + WARN("invalid parameter: DSBCAPS_CTRL3D and DSBCAPS_CTRLPAN cannot be used together\n"); > + return DSERR_INVALIDPARAM; > + } > + > hres = IDirectSoundBufferImpl_Create(device, &dsb, dsbd); > if (dsb) { > *ppdsb = (IDirectSoundBuffer*)&dsb->IDirectSoundBuffer8_iface; > diff --git a/dlls/dsound/tests/ds3d8.c b/dlls/dsound/tests/ds3d8.c > index 330f590..25eb010 100644 > --- a/dlls/dsound/tests/ds3d8.c > +++ b/dlls/dsound/tests/ds3d8.c > @@ -654,7 +654,6 @@ static HRESULT test_secondary8(LPGUID lpGuid, BOOL play, > /* Invalid flag combination */ > bufdesc.dwFlags|=DSBCAPS_CTRLPAN; > rc=IDirectSound8_CreateSoundBuffer(dso,&bufdesc,&secondary,NULL); > - todo_wine > ok(rc==DSERR_INVALIDPARAM, > "IDirectSound8_CreateSoundBuffer(secondary) should have " > "returned DSERR_INVALIDPARAM, returned %08x\n", rc); > -- > 2.1.0 > >

Dec. 2, 2015

Re: [PATCH 1/2] ntdll/tests: Add SIMD exception test for floating point invalid operation fault (try 3).

by Qian Hong

On Wed, Dec 2, 2015 at 10:30 PM, Alexandre Julliard <julliard(a)winehq.org> wrote: > If you could, fixing the existing code too would be great. Thanks for comment, will send as a separate patch. -- Regards, Qian Hong - http://www.codeweavers.com

Dec. 2, 2015

Re: [PATCH 1/2] ntdll/tests: Add SIMD exception test for floating point invalid operation fault (try 3).

by Alexandre Julliard

Qian Hong <qhong(a)codeweavers.com> writes: > On Wed, Dec 2, 2015 at 9:21 PM, Alexandre Julliard <julliard(a)winehq.org> wrote: >> It would be even better to restore the original value, without making >> assumptions about the previous contents. > > Thanks for comment, I'll send a v4. Would you want me also change the > existent code in simd_exception_test or just leave it in the old way? If you could, fixing the existing code too would be great. -- Alexandre Julliard julliard(a)winehq.org

Dec. 2, 2015

Re: Random err:winediag:nulldrv_CreateWindow errors related to windows and explorer

by Sebastian Lackner

Hi Bruno, I think this issue already exists since a long time - for example after running the user32/winstation tests. I personally have not noticed that the probability has increased, but like with all random issues, even a small delay / speedup can make it more or less likely to trigger such a random issue. If you can reproduce it reliable enough, it would be nice if you could try to do a bisect (by running the corresponding app/tests several times). The "bad" commit could be completely unrelated though. BTW: After Qian pointed out the problem with explorer.exe process leaks some weeks ago, I've started preparing patches for winstation and desktop cleanup. They also fix some race-conditions, but in their current form I would consider them too experimental to be merged. Also, there are still a few unfixed problems left. Regards, Sebastian 2015-12-01 20:20 GMT+01:00 Bruno Jesus <00cpxxx(a)gmail.com>: > I believe that since code freeze started (or maybe 1.7.55) a random > behavior was introduced related to these 2 messages: > > err:winediag:nulldrv_CreateWindow Application tried to create a > window, but no driver could be loaded. > err:winediag:nulldrv_CreateWindow The explorer process failed to start. > > Sometimes together there is also: > err:ole:apartment_createwindowifneeded CreateWindow failed with error 0 > > I'm not seeing this alone. at November 23 there was a mention to it in > bug https://bugs.winehq.org/show_bug.cgi?id=39384 and also in December > 1 there was a mention at bug > https://bugs.winehq.org/show_bug.cgi?id=39057 > > The issue seems to manifest more when the computer is heavily loaded > (cpu/ram). > > I believe a regression test to be very hard since the issue is random, > sorry. > > Is anyone else affected by this? I'm still affected with today's git. > > Best wishes, > Bruno > > >

Dec. 2, 2015

Re: [PATCH 1/2] ntdll/tests: Add SIMD exception test for floating point invalid operation fault (try 3).

by Qian Hong

On Wed, Dec 2, 2015 at 9:21 PM, Alexandre Julliard <julliard(a)winehq.org> wrote: > It would be even better to restore the original value, without making > assumptions about the previous contents. Thanks for comment, I'll send a v4. Would you want me also change the existent code in simd_exception_test or just leave it in the old way? -- Regards, Qian Hong - http://www.codeweavers.com

Dec. 2, 2015

Re: [PATCH 1/2] ntdll/tests: Add SIMD exception test for floating point invalid operation fault (try 3).

by Alexandre Julliard

Qian Hong <qhong(a)codeweavers.com> writes: > Try 3: > - Correctly revert side effect of previous ldmxcsr, change 0x200 to > 0x80, 0x80 & 0xff7f = 0, 0x200 & 0xfdff = 0. It would be even better to restore the original value, without making assumptions about the previous contents. -- Alexandre Julliard julliard(a)winehq.org

Dec. 2, 2015