March 2015 - Wine-Devel - list.winehq.org

Re: dwrite/tests: Test the correct return code.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12500 Your paranoid android. === wvistau64 (32 bit font) === font.c:1818: Test failed: got 0x8faecafe === w2008s64 (32 bit font) === font.c:1818: Test failed: got 0x8faecafe === w7u (32 bit font) === font.c:1818: Test failed: got 0x8faecafe === w8 (32 bit font) === font.c:1818: Test failed: got 0x8faecafe === wvistau64 (64 bit font) === font.c:1818: Test failed: got 0x8faecafe === w2008s64 (64 bit font) === font.c:1818: Test failed: got 0x8faecafe

March 30, 2015

Re: [7/7] ws2_32: Better trace setsockopt/getsockopt (try 2)

by Alexandre Julliard

Bruno Jesus <00cpxxx(a)gmail.com> writes: > Use wine_dbg_sprintf instead of plain sprintf, that simplified the patch =) What you really want is to implement a debugstr_sockopt and something like a debugstr_optval and use these in normal TRACE statements, instead of hiding the trace inside a helper function. Also you can't append to a wine_dbg_sprintf string, that's why it's const... -- Alexandre Julliard julliard(a)winehq.org

March 30, 2015

Re: kernel32: add a stub for QueryThreadCycleTime

by Dmitry Timoshkov

Austin English <austinenglish(a)gmail.com> wrote: > +@ stdcall QueryThreadCycleTime(ptr ptr) ... > +BOOL WINAPI QueryThreadCycleTime(HANDLE thread, PULONG64 cycle) 'ptr' is not suitable for HANDLE in the .spec file. -- Dmitry.

March 30, 2015

Re: d3drm/tests: Add QueryInterface tests for IDirect3DRMFrame

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2015-03-29 um 17:46 schrieb Aaryaman Vasishta: > Actually this patch fails windows tests. That means the return > value is not right at D3DRM and D3DRMDevice, and I'm also getting > wrong refcounts for all IDirect3DRMFrame{1-3} (after putting the > correct return values). Yeah, I obviously should have checked the testbot results... -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVGIwLAAoJEN0/YqbEcdMwlXsQAIcrSPUwhJurxYzvOo3vAwLb l3P9Iyy9Vqiwg/HszYdA5ssH4k140HaOLDd42saZ7Cf1NMUErLFrvXwPu8d3DMNB AtBc/EHpo21Xf+tsu44WsQPaWbCYgre+ZqrY0dWauWin0Pc7tAQQgaNf11cx16d2 Yy1i6dhBi0td7HpPvKAaz1asKqCvSUiIqke4K7P4wqJj6nEmIhWgn0xYzAKmmd4h vGMLg64N16W1U24sPxShMIyl6tmYv7S/HUiULgF4PYlIvMc/bqIKBsh+fuxJYSQA 6ZoePj5bdCu5Ns9K7g3KvGtAgxfp77XJossp2rfeyIVoApo31IGtqV9mQhbHxsV7 WGwcN7GVwWi2Qu+qJpKeBCmg1Zqev8NMzbcL50VApDhS7xvvORCBcG6jkaZNgAJ8 WuNKCqqWAoyZzOs5OkzFAwg1suROL2dXGCE6Yo1XCUJ4OqUxgmE2nU5ZaeG63VV4 wtSmJZFgNI0x+/kNT8XJZ0v4KAJks8miM9Do6D4JM6YWziiuJ5k7aJ1e5o3U4neH 4qTcmC3kjRuozafr2kZ2Cq5EdkOXFV47dNfYHcW+O3MtzXepCkP+IaTn8Cl7TBme zr+vDsfZHkY+u4kVFP4J6NYaU5GW27SY7AcYmi+aaVwXhifqVsBCO72GxDf6TvX6 4S4kCpl/63w5JiFEaQ/u =KatV -----END PGP SIGNATURE-----

March 29, 2015

Re: [PATCH 4/5] comctl32/listview: Always forward LVM_GETCOLUMNORDERARRAY to header

by Nikolay Sivov

On 03/29/2015 09:16 PM, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > https://testbot.winehq.org/JobDetails.pl?Key=12491 > > Your paranoid android. > > > === w7u (32 bit listview) === > listview.c:5141: Test failed: NM_HOVER allow test: the msg sequence is not complete: expected 0087 - actual 0000 > listview.c:5146: Test failed: NM_HOVER block test: the msg sequence is not complete: expected 0087 - actual 0000 > > === wvistau64 (64 bit listview) === > listview.c:5141: Test failed: NM_HOVER allow test: the msg sequence is not complete: expected 0087 - actual 0000 > listview.c:5146: Test failed: NM_HOVER block test: the msg sequence is not complete: expected 0087 - actual 0000 > > === w2008s64 (64 bit listview) === > listview.c:5141: Test failed: NM_HOVER allow test: the msg sequence is not complete: expected 0087 - actual 0000 > listview.c:5146: Test failed: NM_HOVER block test: the msg sequence is not complete: expected 0087 - actual 0000 > No, it's not related.

March 29, 2015

Re: [PATCH 4/5] comctl32/listview: Always forward LVM_GETCOLUMNORDERARRAY to header

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12491 Your paranoid android. === w7u (32 bit listview) === listview.c:5141: Test failed: NM_HOVER allow test: the msg sequence is not complete: expected 0087 - actual 0000 listview.c:5146: Test failed: NM_HOVER block test: the msg sequence is not complete: expected 0087 - actual 0000 === wvistau64 (64 bit listview) === listview.c:5141: Test failed: NM_HOVER allow test: the msg sequence is not complete: expected 0087 - actual 0000 listview.c:5146: Test failed: NM_HOVER block test: the msg sequence is not complete: expected 0087 - actual 0000 === w2008s64 (64 bit listview) === listview.c:5141: Test failed: NM_HOVER allow test: the msg sequence is not complete: expected 0087 - actual 0000 listview.c:5146: Test failed: NM_HOVER block test: the msg sequence is not complete: expected 0087 - actual 0000

March 29, 2015

Re: dsound: Fix angle to sound source calculation.

by Mark Harmstone

On 26/03/15 15:26, Andrew Eikum wrote: > On Tue, Mar 24, 2015 at 09:13:43PM +0300, Стас Цымбалов wrote: >>> Any thoughts on the coning breakage, Stas? >> >> To me it seems that coning should work the same as before commit >> 02f9edfd77302eabc0a8a6e45a9423ebe2b1acef (which introduced panning >> between multiple speakers). In that commit AngleBetweenVectorsRad was >> changed in the way that it is now and there was no comment about how >> it would affect coning code. So there are 2 possibilities: >> 1. Coning was broken before >> 02f9edfd77302eabc0a8a6e45a9423ebe2b1acef, got silently fixed by that >> commit, and will be broken again after my patch. >> 2. Coning was fine before 02f9edfd77302eabc0a8a6e45a9423ebe2b1acef, >> and will be the same after my patch. >> Which of these is true I don't know, I would appreciate if anybody >> could point out to me how could I test it. >> > > Mark, any thoughts? We could remove the logic from > AngleBetweenVectorsRad and add it back just to the coning handling in > DSOUND_Calc3DBuffer if you think it's correct. > > I've tried working through the logic, but I can't figure out why we > want to subtract 180 degrees when the cosine is negative. It seems to > me that Stas's change to AngleBetweenVectorsRad is correct. Am I > missing something? > > Andrew > That's entirely possible - I can't remember if I touched the coning code when I put in the surround sound support. Do you know if there's any testcase we could use for coning support? Mark

March 29, 2015

Re: d3drm/tests: Add QueryInterface tests for IDirect3DRMFrame

by Aaryaman Vasishta

Actually this patch fails windows tests. That means the return value is not right at D3DRM and D3DRMDevice, and I'm also getting wrong refcounts for all IDirect3DRMFrame{1-3} (after putting the correct return values). I'll also keep the splitting up of files in mind as I write more tests in the future. :) On Sun, Mar 29, 2015 at 8:39 PM, Stefan Dösinger <stefandoesinger(a)gmail.com> wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Am 2015-03-29 um 15:37 schrieb Aaryaman Vasishta: > > + { &IID_IDirect3DRM, NULL, > E_NOINTERFACE, FALSE }, > It's funny that this interface returns the right error value on QI. > > > + hr = IDirect3DRM_CreateFrame(d3drm3, NULL, &frame3); > Minor nitpick: IDirect3DRM3_CreateFrame . You can resend the patch with a > fix if you want, but I'm OK with this patch as it is. > > Something to think about for future tests: It may make sense to split up > d3drm.c into d3drm1.c, d3drm2.c and d3drm3.c for each interface version, > similar to the ddraw tests. > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v2 > > iQIcBAEBAgAGBQJVGBWOAAoJEN0/YqbEcdMwLkUP/3S8gOP5XSYOgOkELFOSznNp > ir09O5ef1HUpECpZjCks7ez4IbUhswcb/idJ3UeEx3lSBy4vIk3vY0usXcXKkfMl > TlioDlOuzKhpXxb/5lZ/SUoG/nguBvzisKeifAA1gi8ne+3REhWeJvY6iBNDNDEX > dNUYiTP+qxsq8c+bzgydxDuu0OT7LVEXrVrDO1g3qOebJjFSdkXOnf1bCntejX4S > WdnxPlioWBMvffP42r0oinXzjoqobi5BDw8r4YppflEUou1bH3oT7fczJEpK4rBm > 2ZDz9EOhvMOa6M5PSiqwPpINfI1PpH+p9S0r3iMZz8ux2VbXDyfJ0i/5CdzQ3HX8 > rnNq/NcObXVgweBYIN7uFvjlo0Si963ACYDperAVyBNgP/oJXsz3dA5ysvrf6Lf8 > Xy1kdP2B79AxWR3DRumQS9sbruaofENF16/7d9MZE933uWY9xBS6JIKTP0AVdDsP > tqF8ppHwVdPfpiazYnrG1ivpE0jNIPJJ67I6FWRC1S8k7QQVmbAdVnDgczDs6lLx > hiZbjksd4Uf16oGO29bXeZ2YM3Zi75K9pCa7ruYoftcF2ihd0tU01+jbM6hY32qm > K1RKe7/HCMANoal7pQEukARHVRvHDpVFRGJzeMbysc8yumnpbgl7/UI9z0wZvoYI > aCAXfxi21aSdCzxC7mIU > =9SMA > -----END PGP SIGNATURE----- >

March 29, 2015

Re: d3drm/tests: Add QueryInterface tests for IDirect3DRMFrame

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2015-03-29 um 15:37 schrieb Aaryaman Vasishta: > + { &IID_IDirect3DRM, NULL, E_NOINTERFACE, FALSE }, It's funny that this interface returns the right error value on QI. > + hr = IDirect3DRM_CreateFrame(d3drm3, NULL, &frame3); Minor nitpick: IDirect3DRM3_CreateFrame . You can resend the patch with a fix if you want, but I'm OK with this patch as it is. Something to think about for future tests: It may make sense to split up d3drm.c into d3drm1.c, d3drm2.c and d3drm3.c for each interface version, similar to the ddraw tests. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVGBWOAAoJEN0/YqbEcdMwLkUP/3S8gOP5XSYOgOkELFOSznNp ir09O5ef1HUpECpZjCks7ez4IbUhswcb/idJ3UeEx3lSBy4vIk3vY0usXcXKkfMl TlioDlOuzKhpXxb/5lZ/SUoG/nguBvzisKeifAA1gi8ne+3REhWeJvY6iBNDNDEX dNUYiTP+qxsq8c+bzgydxDuu0OT7LVEXrVrDO1g3qOebJjFSdkXOnf1bCntejX4S WdnxPlioWBMvffP42r0oinXzjoqobi5BDw8r4YppflEUou1bH3oT7fczJEpK4rBm 2ZDz9EOhvMOa6M5PSiqwPpINfI1PpH+p9S0r3iMZz8ux2VbXDyfJ0i/5CdzQ3HX8 rnNq/NcObXVgweBYIN7uFvjlo0Si963ACYDperAVyBNgP/oJXsz3dA5ysvrf6Lf8 Xy1kdP2B79AxWR3DRumQS9sbruaofENF16/7d9MZE933uWY9xBS6JIKTP0AVdDsP tqF8ppHwVdPfpiazYnrG1ivpE0jNIPJJ67I6FWRC1S8k7QQVmbAdVnDgczDs6lLx hiZbjksd4Uf16oGO29bXeZ2YM3Zi75K9pCa7ruYoftcF2ihd0tU01+jbM6hY32qm K1RKe7/HCMANoal7pQEukARHVRvHDpVFRGJzeMbysc8yumnpbgl7/UI9z0wZvoYI aCAXfxi21aSdCzxC7mIU =9SMA -----END PGP SIGNATURE-----

March 29, 2015

Re: d3drm/tests: Add QueryInterface tests for IDirect3DRMFrame

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12490 Your paranoid android. === w2000pro (32 bit d3drm) === d3drm.c:1738: Test failed: Got refcount 2 for test "frame_qi" 0, 1, expected 0. d3drm.c:1738: Test failed: Got refcount 2 for test "frame_qi" 0, 2, expected 0. d3drm.c:1728: Test failed: Got hr 0x80040111 for test "frame_qi" 0, 3. d3drm.c:1728: Test failed: Got hr 0x80040111 for test "frame_qi" 0, 4. d3drm.c:1728: Test failed: Got hr 0 for test "frame_qi" 0, 5. d3drm: unhandled exception c0000005 at 780273CD === wxppro (32 bit d3drm) === d3drm.c:1738: Test failed: Got refcount 2 for test "frame_qi" 0, 1, expected 0. d3drm.c:1738: Test failed: Got refcount 2 for test "frame_qi" 0, 2, expected 0. d3drm.c:1728: Test failed: Got hr 0x80040111 for test "frame_qi" 0, 3. d3drm.c:1728: Test failed: Got hr 0x80040111 for test "frame_qi" 0, 4. d3drm.c:1728: Test failed: Got hr 0 for test "frame_qi" 0, 5. d3drm: unhandled exception c0000005 at 77C46F07 === w2003std (32 bit d3drm) === d3drm.c:1738: Test failed: Got refcount 2 for test "frame_qi" 0, 1, expected 0. d3drm.c:1738: Test failed: Got refcount 2 for test "frame_qi" 0, 2, expected 0. d3drm.c:1728: Test failed: Got hr 0x80040111 for test "frame_qi" 0, 3. d3drm.c:1728: Test failed: Got hr 0x80040111 for test "frame_qi" 0, 4. d3drm.c:1728: Test failed: Got hr 0 for test "frame_qi" 0, 5. d3drm: unhandled exception c0000005 at 77BD7D8D

March 29, 2015