March 2015 - Wine-Devel - list.winehq.org

Re: [PATCH] vbscript: Implemented Asc(try 2)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11857 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === w2003std (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

March 3, 2015

Re: [PATCH] vbscript: Implemented Asc(try 2)

by Nikolay Sivov

You're still leaking memory.

March 3, 2015

Re: [PATCH] uxtheme: Support images in GetThemeBackgroundRegion. (try 2)

by Alexandre Julliard

Mark Harmstone <hellas(a)burntcomma.com> writes: > + /* loop through the image looking for transparent pixels, > + * grouping together horizontal runs into one rect */ > + ptr = bits; > + for (y = 0; y < r.bottom; y++) { > + BOOL trans = FALSE; > + int transstart; > + > + for (x = 0; x < r.right; x++) { > + COLORREF colour = ptr[2] << 16 | ptr[1] << 8 | ptr[0]; > + ptr += 4; > + > + if (colour == transcolour) { > + if (!trans) { > + transstart = x; > + trans = TRUE; > + } > + } else if (trans) { > + rgntemp = CreateRectRgn(transstart, y, x, y+1); > + CombineRgn(hrgn, hrgn, rgntemp, RGN_DIFF); > + DeleteObject(rgntemp); > + trans = FALSE; > + } > + } > + > + if (trans) { > + rgntemp = CreateRectRgn(transstart, y, r.right, y+1); > + CombineRgn(hrgn, hrgn, rgntemp, RGN_DIFF); > + DeleteObject(rgntemp); > + } > + } That's going to be pretty slow. There's a better implementation in winex11.drv:update_surface_region(), you could just copy that. -- Alexandre Julliard julliard(a)winehq.org

March 3, 2015

Re: [1/3] dpnet: Add check for mismatched string lengths (try 2)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11855 Your paranoid android. === w8 (32 bit address) === Failure running script in VM: timed out waiting for the child process

March 3, 2015

Re: [1/3] dpnet: Add check for mismatched string lengths (try 2)

by Nikolay Sivov

On 03.03.2015 11:57, Alistair Leslie-Hughes wrote: > + hr = IDirectPlay8Address_AddComponent(localaddr, DPNA_KEY_HOSTNAME, &localhost, sizeof(localhost)+2, DPNA_DATATYPE_STRING); > + ok(hr == DPNERR_INVALIDPARAM, "got 0x%08x\n", hr); What happens with size == sizeof(localhost)/2 (or any size that cuts off a string)? Does it make a partial copy? > + hr = IDirectPlay8Address_AddComponent(localaddr, DPNA_KEY_HOSTNAME, "testing", 8+2, DPNA_DATATYPE_STRING_ANSI); > + ok(hr == DPNERR_INVALIDPARAM, "got 0x%08x\n", hr); Please use sizeof() here too.

March 3, 2015

Re: [2/3] dpnet: Free previous allocated data

by Nikolay Sivov

On 03.03.2015 11:59, Alistair Leslie-Hughes wrote: > + if(entry->type == DPNA_DATATYPE_STRING_ANSI) > + heap_free(entry->data.ansi); > + else if(entry->type == DPNA_DATATYPE_STRING) > + heap_free(entry->data.string); > + else if(entry->type == DPNA_DATATYPE_BINARY) > + heap_free(entry->data.string); > + You can as well just call heap_free(entry->data.binary) for all those types (or add another neutral 'ptr' field).

March 3, 2015

Google Summer of 2015 has begun

by Austin English

Howdy all, Wine has been accepted to Google's Summer Of Code for 2015: https://www.google-melange.com/gsoc/org2/google/gsoc2015/wine Developers, if you'd like to be a mentor, please go here to make a connection with the wine project, and then Andre or I will approve you: https://www.google-melange.com/gsoc/homepage/google/gsoc2015 Students, you can apply starting March 16 at 19:00 UTC. Now is a good time to start introducing yourself, explore the source, send patches, and discuss your proposals. Good luck. -- -Austin

March 2, 2015

Re: GSOC 2015 Applicant

by Austin English

On Mon, Mar 2, 2015 at 2:35 PM, Saurabh Goyal <srgnuclear(a)gmail.com> wrote: > Hi, I am Saurabh Goyal a third year undergraduate from Indian institute of > Technology BHU. > > I have taken basic Machine Learning course on coursera, created few > android applications and know algorithms and data structures in c++ and i > use linux(ubuntu) for my programming work. > > I want to participate and work on your organisation as part of GSOC this > summer and i am willing to put as many hours as required per day to match > the skill set required provided i get directions from my mentor and > complete the job perfectly in given time. > > I know c++,c,R,octave,java. > > Please let me know how to start and look forward to hear from you. > > Your faithful, > Saurabh Goyal > Hi Saurabh, See http://wiki.winehq.org/SummerOfCode for information about Wine and Summer of Code. You'll need to propose a project (and make sure you've submitted a patch to wine) before applying. -- -Austin

March 2, 2015

GSOC 2015 Applicant

by Saurabh Goyal

Hi, I am Saurabh Goyal a third year undergraduate from Indian institute of Technology BHU. I have taken basic Machine Learning course on coursera, created few android applications and know algorithms and data structures in c++ and i use linux(ubuntu) for my programming work. I want to participate and work on your organisation as part of GSOC this summer and i am willing to put as many hours as required per day to match the skill set required provided i get directions from my mentor and complete the job perfectly in given time. I know c++,c,R,octave,java. Please let me know how to start and look forward to hear from you. Your faithful, Saurabh Goyal

March 2, 2015

Re: [PATCH 2/3] include/ole32/user32/winemac.drv/winex11.drv: do not allow dropping drags through obscuring native windows

by Ken Thomases

Hi, On Mar 1, 2015, at 10:32 PM, Damjan Jovanovic <damjan.jov(a)gmail.com> wrote: > Currently Wine does not support dragging from a Wine window to a > native Window, but does from a Wine window to another Wine window. > What is a big surprise though, is that if a Wine window is obscured by > a native window that's on top of it in the z-order, it looks like you > are dropping onto the native window, but you are actually dropping > THROUGH the native window into the Wine window - in other words, the > wrong application gets the drop! > > This patch fixes that problem by giving ole32 awareness of native > windows (represented by a ULONG_PTR) via new Wine-specific functions > in user32 that are implemented by the display drivers winex11.drv and > winemac.drv (of which only the former is implemented by this patch). > The ole32 drag loop can thus tell whether the window under the mouse > is a Wine window or a native window, and obtain IDropTarget from > either window type, something that is used by the next patch to > implement dragging from Wine to native windows. I appreciate your work on this, but I think this isn't the right approach. I think if you solve the other problem (dragging from Wine to other apps) by having the driver take over drags and translating them into a native drag operation, then this problem gets solved automatically. The native drag operation will target the proper window under the cursor, eliminating the problem of dropping through non-Wine windows. If the drag goes over a Wine window, then the native drag will get translated back into Win32 by the existing code in the drivers for receiving drops. I understand your point from the next patch email that this may result in code duplication between the drivers, but I think that's largely inevitable because of the requirements of driving a native drag operation. Also, I don't believe your design where the driver implements IDropTarget and ole32 calls its methods can be made to work on the Mac. As is often the case, Cocoa has a much more closed API for drag and drop than X11. We can't really arbitrarily do pieces of the drag operation in isolation and effectively start and stop the drag (as the cursor moves from Wine window to native window and back to a Wine window). We can only start the drag and then Cocoa takes it from there. It calls relevant methods on the drag source object along the way, of course, but we don't have a lot of control over the drag operation other than that. -Ken

March 2, 2015