March 2015 - Wine-Devel - list.winehq.org

Re: [PATCH] vbscript: Implemented Oct

by Shuai Meng

Hi, VT_BSTR and VT_R4 and other types can also be supported by Oct, I'll send a patch again. 2015-03-27 11:40 GMT+08:00 Marvin <testbot(a)winehq.org>: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > https://testbot.winehq.org/JobDetails.pl?Key=12441 > > Your paranoid android. > > > === w2000pro (32 bit) === > No test summary line found > > === wxppro (32 bit) === > No test summary line found > > === w2003std (32 bit) === > No test summary line found > > === wvistau64 (32 bit) === > No test summary line found > > === w2008s64 (32 bit) === > No test summary line found > > === w7u (32 bit) === > No test summary line found > > === w8 (32 bit) === > No test summary line found > > === wvistau64 (64 bit) === > No test summary line found > > === w2008s64 (64 bit) === > No test summary line found >

March 27, 2015

Re: [PATCH] vbscript: Implemented Oct

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12441 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === w2003std (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

March 27, 2015

Re: [2/3] windowscodecs: Implement PngDecoder_Block_GetCount.

by Alexandre Julliard

Vincent Povirk <madewokherd(a)gmail.com> writes: > From 398cd35190fddb05de97f6b125897be6c0e9e92d Mon Sep 17 00:00:00 2001 > From: Vincent Povirk <vincent(a)codeweavers.com> > Date: Wed, 25 Mar 2015 14:26:28 -0500 > Subject: [PATCH 2/3] windowscodecs: Implement PngDecoder_Block_GetCount. > > --- > dlls/windowscodecs/pngformat.c | 80 +++++++++++++++++++++++++++++++++++++++--- > 1 file changed, 76 insertions(+), 4 deletions(-) ../../../tools/runtest -q -P wine -T ../../.. -M windowscodecs.dll -p windowscodecs_test.exe.so metadata && touch metadata.ok metadata.c:949: Test succeeded inside todo block: GetCount failed, hr=80070057 metadata.c:952: Test succeeded inside todo block: GetCount failed, hr=0 metadata.c:953: Test succeeded inside todo block: unexpected count 1 Makefile:375: recipe for target 'metadata.ok' failed -- Alexandre Julliard julliard(a)winehq.org

March 27, 2015

winegcc & stdin

by Leon Bogaert

I'm getting an error when using winegcc with stdin: > $ cat test.c | winegcc -xc -c - > gcc: warning: ‘-x c’ after last input file has no effect > gcc: error: -E or -x required when input is from standard input > winegcc: gcc failed Does anyone know what I could be doing wrong? I'm trying to use stdin because that's what the go (cgo) build tool is trying to use. Leon

March 26, 2015

Re: [PATCH 3/4] advapi32: Add DACL inheritance support in SetSecurityInfo

by Erich E. Hoover

On Thu, Mar 26, 2015 at 2:59 PM, Erich E. Hoover <erich.e.hoover(a)wine-staging.com> wrote: > On Thu, Mar 26, 2015 at 12:10 PM, Piotr Caban <piotr.caban(a)gmail.com> wrote: >> ... >> The inheritance doesn't occur when function from ntdll are used for setting >> DACL. This makes your code inside server incorrect. Also your code is not >> checking handle permissions correctly. If you try to test it keep in mind >> that if correct inheritance flags are set in security descriptor control >> field the permissions will be filled when you right-click on file and >> display security properties on windows. > > I don’t have the time to write a test at the moment, but I find it > highly unlikely that MS would implement security descriptors in a > high-level DLL. If that were the case then an application could > easily hijack the API in order to permit access to files that would > otherwise be inaccessible. I would guess that > UNPROTECTED_DACL_SECURITY_INFORMATION and SE_DACL_AUTO_INHERITED > probably enter into this somehow. > > Besides that I think we should start implementing stored ACLs first, > before even thinking about implementing suitable inheritance > mechanisms. I submitted a bunch of patches for this some time ago, > but Alexandre wasn’t happy with using extended user attributes to > store this information. I’m just not sure that it’s useful to > implement inheritance without storing the ACLs, it’ll certainly fix > some apps but it will likely break a bunch of others. Whoops, forgot reply-all - sorry for the duplicate Piotr. Best, Erich

March 26, 2015

Re: [PATCH 3/4] advapi32: Add DACL inheritance support in SetSecurityInfo

by Austin English

On Thu, Mar 26, 2015 at 3:45 PM, Piotr Caban <piotr.caban(a)gmail.com> wrote: > Hi, > > On 26/03/15 19:21, Sebastian Lackner wrote: > >> On 26.03.2015 19:10, Piotr Caban wrote: >> >>> The inheritance doesn't occur when function from ntdll are used for >>> setting DACL. This makes your code inside server incorrect. Also your >>> code is not checking handle permissions correctly. >>> >> does that mean you reviewed our code? Would you please give some more >> details to us about the error you found? >> Feel free to open a bug report on bugs.wine-staging.com with your >> results. >> > I've not really reviewed it, I've only skimmed the diff. According to my > testing NtSetSecurityObject is only setting supplied DACL, it's not adding > inherited entries. > > I also haven't seen the implementation from wine-staging tree earlier (I > think these patches were not mentioned anywhere on wine bugzilla/were never > sent to wine but maybe I've missed something). > > Thanks, > Piotr > https://bugs.winehq.org/show_bug.cgi?id=33576#c10 -- -Austin

March 26, 2015

Re: [PATCH 3/4] advapi32: Add DACL inheritance support in SetSecurityInfo

by Piotr Caban

Hi, On 26/03/15 19:21, Sebastian Lackner wrote: > On 26.03.2015 19:10, Piotr Caban wrote: >> The inheritance doesn't occur when function from ntdll are used for >> setting DACL. This makes your code inside server incorrect. Also your >> code is not checking handle permissions correctly. > does that mean you reviewed our code? Would you please give some more details to us about the error you found? > Feel free to open a bug report on bugs.wine-staging.com with your results. I've not really reviewed it, I've only skimmed the diff. According to my testing NtSetSecurityObject is only setting supplied DACL, it's not adding inherited entries. I also haven't seen the implementation from wine-staging tree earlier (I think these patches were not mentioned anywhere on wine bugzilla/were never sent to wine but maybe I've missed something). Thanks, Piotr

March 26, 2015

Re: [PATCH 3/4] advapi32: Add DACL inheritance support in SetSecurityInfo

by Sebastian Lackner

On 26.03.2015 19:10, Piotr Caban wrote: > The inheritance doesn't occur when function from ntdll are used for > setting DACL. This makes your code inside server incorrect. Also your > code is not checking handle permissions correctly. Hello Piotr, does that mean you reviewed our code? Would you please give some more details to us about the error you found? Feel free to open a bug report on bugs.wine-staging.com with your results. BTW: The installers are also fixed with our patchsets, but I am sure you will agree, that this should not influence the decision if the patches should be applied or not ;) Thanks in advance, Sebastian

March 26, 2015

Re: [PATCH 3/4] advapi32: Add DACL inheritance support in SetSecurityInfo

by Piotr Caban

On 03/26/15 17:59, Erich E. Hoover wrote: > I do not believe this is the correct place to make this change. > Inheritance still needs to occur even when SetSecurityInfo is not > used, which pretty much means it has to be within the wineserver > itself so that the same code can be used for CreateFile. The code I > put together for this (as written it is somewhat dependent on my other > ACL code) can be found here: > https://github.com/wine-compholio/wine-staging/tree/master/patches/server-I… > > The first patch is for CreateFile and the second one is for > SetSecurityInfo. I'm happy to try and change this to help you solve > your problem without my other ACL code, it's been on my TODO list > anyway - I've just been too busy with work lately :/ On windows the inheritance code is inside ntmarta.dll (according to some Microsoft docs). Probably Microsoft uses ntmarta.dll inside advapi. But I don't think we want to be compatible with native dlls in this case. The inheritance doesn't occur when function from ntdll are used for setting DACL. This makes your code inside server incorrect. Also your code is not checking handle permissions correctly. If you try to test it keep in mind that if correct inheritance flags are set in security descriptor control field the permissions will be filled when you right-click on file and display security properties on windows. I see 3 ways of implementing the DACLs inheritance: 1) add a server call that does the inheritance in this case there's no code duplication between CreateFile and SetFileInformation, also it's possible to skip the inheritance when NtSetSecurityObject is used directly 2) duplicate inheritance code inside advapi and ntdll/server I think this is the best solution. The code that merges 2 DACLs has only ~36 lines in my implementation. The code for getting parent directory DACL is also not long (~30 lines). This code may get longer in future (when we have complete support for security descriptors). 3) implement something like ntmarta.dll This will need much more testing. I'm also not sure if it can be used from ntdll at all. What do you think about it? Thanks, Piotr P.S. this patches fixes some real installers (TEMSInvestigation 16.1.1 (fails), Uru - Ages Beyond Myst (fails to remove some temporary files))

March 26, 2015

Re: [PATCH 3/4] advapi32: Add DACL inheritance support in SetSecurityInfo

by Erich E. Hoover

I do not believe this is the correct place to make this change. Inheritance still needs to occur even when SetSecurityInfo is not used, which pretty much means it has to be within the wineserver itself so that the same code can be used for CreateFile. The code I put together for this (as written it is somewhat dependent on my other ACL code) can be found here: https://github.com/wine-compholio/wine-staging/tree/master/patches/server-I… The first patch is for CreateFile and the second one is for SetSecurityInfo. I'm happy to try and change this to help you solve your problem without my other ACL code, it's been on my TODO list anyway - I've just been too busy with work lately :/ Best, Erich

March 26, 2015