March 2015 - Wine-Devel - list.winehq.org

Re: dsound: Fix angle to sound source calculation.

by Andrew Eikum

On Tue, Mar 24, 2015 at 09:13:43PM +0300, Стас Цымбалов wrote: > > Any thoughts on the coning breakage, Stas? > > To me it seems that coning should work the same as before commit > 02f9edfd77302eabc0a8a6e45a9423ebe2b1acef (which introduced panning > between multiple speakers). In that commit AngleBetweenVectorsRad was > changed in the way that it is now and there was no comment about how > it would affect coning code. So there are 2 possibilities: > 1. Coning was broken before > 02f9edfd77302eabc0a8a6e45a9423ebe2b1acef, got silently fixed by that > commit, and will be broken again after my patch. > 2. Coning was fine before 02f9edfd77302eabc0a8a6e45a9423ebe2b1acef, > and will be the same after my patch. > Which of these is true I don't know, I would appreciate if anybody > could point out to me how could I test it. > Mark, any thoughts? We could remove the logic from AngleBetweenVectorsRad and add it back just to the coning handling in DSOUND_Calc3DBuffer if you think it's correct. I've tried working through the logic, but I can't figure out why we want to subtract 180 degrees when the cosine is negative. It seems to me that Stas's change to AngleBetweenVectorsRad is correct. Am I missing something? Andrew

March 26, 2015

Re: urlmon: Remove unneeded NONAMELESSXXX directives.

by Jacek Caban

Hi Francois, On 03/26/15 15:29, Francois Gouget wrote: > Also put them in the files that need them. It may be a bit late for such question after so many patches already went in, but what's the point of this patch? Those defines are defined in central place, so that we don't have to deal with them in each .c file. Even if they are not needed for some .c files, they are harmless. BTW, I think we could even consider putting this macro in a central place like windef.h inside __WINESRC__ guard. Jacek

March 26, 2015

Re: named memory-mapped file

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2015-03-25 um 13:18 schrieb Leon Bogaert: > The syscalls I need translated to linux are: > - OpenFileMappingW > - MapViewOfFile > > Today I found out about winelib. I guess I could give that a go. Wine implements those two calls and maps them to the equivalent POSIX functions. Yes, building a Winelib program is the right way to go. It can use the Win32 functions and normal Linux functions at the same time. It does depend on the Wine runtime environment though. Note that your game and your winelib application have to run in the same wine prefix. In theory you could probably use plain mmap in some way, but then you have to know how Wine maps the Windows object to it's POSIX equivalent. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVFBd4AAoJEN0/YqbEcdMwoXYP/2KyY+gGfNeFZbeuwRdnkpUi XX+a/xtNtpCTN2PFLYd3aqvKu11NCeojxXB1wETcLI0LQ/kjwXL5W/ZuE5X3Eqac stvxp8j+G/5fu+2ZFxt/Fuqi/HPV/P5aGUgdMTgcGQOIUIoHB8qtlNrfDyJ9eC+k xgy0fOkxt5EUlU5QvyaGpDcC0LEpCDS9mtnhkaucV6v+VblAXYWARoonIVm/nsRn 1oKFUgfRAJ4taIIrREeN+e2Z9pqFiX2J/tCQxKMdPvHYQcEjRFyUJfjvC44YdImU bKaMJBPhqDVRWjScRNkY+BCdfbeuFjUfwty8GDGIBQ9/TvLOYoi050/GFU+DIF/h /R4pZDR+MhWtvupEpsSnfewlKHnntRya00rHiRUoDwGV/R4qf1lGDGI8EXWW9Fky lyZb4tUrJGYmDxqIQee5gX3u77y5c8l4UdzLBzx1F6omFHMsWVCMist2ikOUQ0hs K510PIrjIQdqPEwW7rbh4+FymYxKfpN1MCrzSq7R1jo5PX8Txp6PYKp7c/S14nDG 8SON9i6LcbYaYn5U4PuRLRUp2nmbDe0AAaGTDi3s5/gBZFSfmM89p4/1AIHla1Om eVQEGeWLO8lL4IDmll+xEkZrflSa6pFRC1a4VNIom878nXNVTSE3FirbstZM1Jh/ r49GAKVDxmli0Mu2Fbx+ =snGQ -----END PGP SIGNATURE-----

March 26, 2015

Re: named memory-mapped file

by Andrew Eikum

Hey Leon, sorry I missed your earlier emails. I'm the primary developer of the official iRacing Linux port by CodeWeavers, and I actually play it myself. I don't have the time to dig into this right now, but I'm definitely interested in what you find out and could maybe help with some questions. Depending on what you end up with, we could maybe integrate your work back into the official port. I think what you want to do, at a high level, is find out how Wine implements those methods on Linux. Then figure out how a Linux-native application could hook into that implementation. Wine is, after all, just a program running on Linux like any other. Alternatively, you could write a win32 application and use those Wine APIs to access the memory and do what you want, like you said. Andrew On Wed, Mar 25, 2015 at 01:18:40PM +0100, Leon Bogaert wrote: > The syscalls I need translated to linux are: > - OpenFileMappingW > - MapViewOfFile > > Today I found out about winelib. I guess I could give that a go. > > On Sat, Mar 21, 2015 at 6:49 PM, Leon Bogaert <leonbogaert(a)gmail.com> wrote: > > > Just to clarify: the game runs under wine (crossover) on my Linux box. > > > > > > On Saturday, March 21, 2015, Leon Bogaert <leonbogaert(a)gmail.com> wrote: > > > >> Hi all, > >> > >> I don't know if this is the correct list. If it's not I'm sorry. > >> > >> I have kind of a weird question. I'm playing this game iRacing which > >> exposed it's api via named memory map ( > >> https://github.com/meltingice/node-iracing/blob/master/lib/irsdk_utils.cpp > >> ). > >> > >> Is there a way I can access that named memory-mapped file via Linux? I > >> did some Googling and I don't think it's possible but I thought I made sure > >> to ask around here. If that isn't possible I think I'll write a simple > >> program that would run under wine and expose that data in a Linux-friendly > >> manner. > >> > >> Leon

March 26, 2015

Re: how to upload and view reports

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2015-03-25 um 14:02 schrieb Shubham kumar: > Sir, i have applied for winetest graphical user interface project. > Problem is to see the test results in application itself we first > need to know that how it shows report on test.winehq.org so that, > we could get idea on how it shows report after uploading. But, on > the website i could not find any link to upload the report. > Where/How am i supposed to upload the report and view the test > results on website? Did you run winetest.exe yet? -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVFBZlAAoJEN0/YqbEcdMwOK8P/0k1XdA1QfEoM+VTyQx8+7GK vA8dr/S0EU1zF2mn+yGSH6CwojOIeV9bcqehr5Bm4QrBQCIF4uGTeu2DbsWrU1Or oYqmJOP+tyejq1KtMQTFSTEj6VApKXGv0bEL1QcO3tu3hZN7mpYOW+NxfQfSYIWi 8U4mhCnoiJrP2SVENuutQImYCXWogiKj7do28W5XLEkDbVJLTaXyr+J2P6NG9BSu PzFYltUe148vYnCL4zWhVcH4kfZSpYzmaL9v/6KCGlUa/f4VpY/xRdSv0F8IeisN 4tvDXP49kgqw+KdIdcYU7g90bI/Ep65N4WkVb9/kPWKif5qd8mPmZDWTujUQjUP8 pPVuknYAssDXL+YuQewPYxVg9nyabutgl0U6w5Flp3Pq+G/atR3SGjVy1WGqmaj8 +c1FHsOgv6Krz+vXX90xMH8G/UxGYORiZay45andAeAtfQcmm2HPkpg4VYHvaccx yJvNvEu03b3cEUq1sF8WpyWRHoPrnJwzBUkX8nmz4ImFw3Y/ezbD1KtIpiv6JsZD QwKBLt42WlbXeRmA3jsGmuqDX5pUOZBsxWHl1Msq9C2fqBkQ4X/2oTI8YdchJR0F NUScPGFpgqc+P39UFDfRph9lqUn0hGuHlwZm5L5RXEyMfn0KpBAyAaKVMKLYVDvA mHVIveB2hW0N/WRoIoxv =GvJm -----END PGP SIGNATURE-----

March 26, 2015

Re: [PATCH] wineconsole: Set input stream buffer length per OS limit

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2015-03-26 um 13:58 schrieb Hugh McMaster: > The Windows command line (cmd or command.com) limits the maximum > length of an input string. [1] Do we care about this? Do you have an application that depends on this kind of limit? -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVFBYpAAoJEN0/YqbEcdMwyUIP/12M+6VvYYWqm7/BrEyKaQGz gsLPCA1cSEZ8FOEeD69lzLzSp16pglAoxaN2/MMFaOivml7mEeEtBm2mx3n3ww93 pl/0k7vURzTKzoANfVdzAWHkCgfRP6/emhfv5mZakaVYI8X99MkDC8/kO5j7xOAG SvBb5Q2JJkL7dnuODHNxJwDI6h+JWllqAkv7yB7DiSlcQDVygxCLkpPQJe/rnuaK Elj545AwsAOz8IfI9qOYwVMI1lYRNt/c27H3ixNzI4vMkRpk/u4gSn8+qfMypSmF kiQIfBnk9k9l2CKsNGRlcpbU0eoBlkukmwFdWejnhqhcYl8W0FaxdvfL8m3N9hdP roYyE7Lbb5sj5mvQsvNRoMayZz9DAosVCWcBm2ohRUCLy0x14A2myeIJiDkS2ByF XVgOmZtR6CcIWFUMi4c94Ms0bvPG2gRc9TwinKYrHZFRaxO0xaa5hMHTwpvzp4e9 gM/KvBjlsbqPAKYoLd8Mtc/xBaNtJQvr3bQX5fuyrhlnTk8eSh2HTUEJsfToZyZf qFrvnS/8yK1vhowF69NhVrprNQRlTL6JQ/rgGJFHUnml66y7BNslRrXw7jle1JrN O2X3U3vJgihUxSFxrQcyGsV9vqXbSJYcRedGM9O1SAeKpZ/gFWrRV1RS8mIOG1og oXPOvUTuIOKF+KptcgPj =Yz6G -----END PGP SIGNATURE-----

March 26, 2015

Re: [PATCH] cmd: Add basic handling of Ctrl-C

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2015-03-26 um 13:46 schrieb Hugh McMaster: > The PHANDLER_ROUTINE is a pointer to the function handler. MSDN's > own example [1] on installing a Ctrl handler uses a cast. > > Otherwise, what would you suggest? If the function signature (including calling convention) matches the one SetConsoleCtrlHandler expects the compiler should accept it without a cast and without a warning. In your patch you should probably use WINAPI for console_ctrl_handler. That the MSDN example uses a cast is just terrible. If you get e.g. the calling convention wrong you're begging for random crashes or incorrectly passed parameters that are difficult to debug. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVFBSFAAoJEN0/YqbEcdMwJ94P/jJRST2oGaIkTasgTe8Vf9NV slfdp/vvk+y+hxzAmZrFK6wd76Bq+tUctnU6FY+KLZEYXocMJxTviSKuDsNGUvUi 4U2oHgFBWLys6tXiBfDHSHnjKezTL3yRm0ZCYvZKYgeQBQusCpNIpRETqntjbZg8 egeSF+l2vlSLNC/O2XnzQfXzjsc/uOMdcT9G1Tom3Y/dCzHRW+NfET4l1uGX4G+6 JcZKeYqKvcHo6T0EhP+6pagMZh17l2sc43sVWtZwuXRYQwRQJdNDVl/mvlJziqnJ vbyfQxjyqO7KMppIqwSP+tpC5Z5wbBWdx14+NXKa82APi39dNtzgdR3eyN4hUMCP D/8OuLuAJvg60FYj7Jb17eLs9l7n9ufXT+BcVe2tb/F8G+fhVswA5cMqX1LjAN9G VIU5uiEWEOgfHa+joDuk/yQhy78+vnbC1H3ihabvA0CNnyms4DE/if7hL6JslgKY qUcRLYZSrj0Ikql/ThGSn+/SNPEcFqb0kEI2jmND+kpcdKKl7fJ+ueecuO1Oa9fT /gSRBzETzlaonGpi+JiMbYYNKbUsUzn6dBs6djB+unvki5LG8TsRxc8l5Mwh6eHB ABHfO5EOCEDYgJDY1l9f5qozCHt/beiKrzSO3An2+FJ7cjP6Txvng9a04d4NzXyr YGYKcHZW/MTAGl3iDD1d =H+J+ -----END PGP SIGNATURE-----

March 26, 2015

RE: [PATCH] wineconsole: Set input stream buffer length per OS limit

by Hugh McMaster

---------------------------------------- On Thu, 26 Mar 2015 14:39:50 +0300, Nikolay Sivov wrote: > On 26.03.2015 14:32, Hugh McMaster wrote: >> --- >> programs/wineconsole/wineconsole.c | 32 ++++++++++++++++++++++++++++++-- >> 1 file changed, 30 insertions(+), 2 deletions(-) >> >> diff --git a/programs/wineconsole/wineconsole.c b/programs/wineconsole/wineconsole.c >> index 3c2faf5..81300ed 100644 >> --- a/programs/wineconsole/wineconsole.c >> +++ b/programs/wineconsole/wineconsole.c >> @@ -797,6 +797,11 @@ static UINT WINECON_ParseOptions(const char* lpCmdLine, struct wc_init* wci) >> return 0; >> } >> >> +#define MAXSTRING_NON_NT 128 >> +#define MAXSTRING_NT351 260 >> +#define MAXSTRING_NT4_W2K 2048 >> +#define MAXSTRING_XP 8192 >> + > > Why do you need this mess? To avoid magic numbers, unless you think that's unnecessary here. The Windows command line (cmd or command.com) limits the maximum length of an input string. [1] The limits are defined as that 'mess' above. :) Windows 3.x, 95, 98, ME --> 128 characters NT 3.51 --> 260 characters NT 4, W2K --> 2048 characters XP, Vista, 7, etc. --> 8192 characters I was actually wondering if using a standard buffer[8192] would be better in this case, as it allocates enough memory for all of the above. Somehow this functionality needs to be extended to cmd itself. Windows blocks input in cmd at the defines -1, e.g. 8191 characters in XP and above. [1] http://support.microsoft.com/en-us/kb/830473

March 26, 2015

RE: [PATCH] cmd: Add basic handling of Ctrl-C

by Hugh McMaster

On Thu, 26 Mar 2015 14:39:12 +0300, Nikolay Sivov wrote: > On 26.03.2015 14:32, Hugh McMaster wrote: >> + /* Enable handling of Ctrl-C signals */ >> + if (SetConsoleCtrlHandler((PHANDLER_ROUTINE)console_ctrl_handler, TRUE)) >> + WINE_TRACE("cmd: Ctrl handler was installed.\n"); >> + else >> + WINE_ERR("cmd: Unable to install Ctrl handler.\n"); >> + > > Judging by the fact that you needed a cast, that's not right. The PHANDLER_ROUTINE is a pointer to the function handler. MSDN's own example [1] on installing a Ctrl handler uses a cast. Otherwise, what would you suggest? [1] https://msdn.microsoft.com/en-us/library/windows/desktop/ms685049%28v=vs.85…

March 26, 2015

Re: [PATCH] wineconsole: Set input stream buffer length per OS limit

by Nikolay Sivov

On 26.03.2015 14:32, Hugh McMaster wrote: > --- > programs/wineconsole/wineconsole.c | 32 ++++++++++++++++++++++++++++++-- > 1 file changed, 30 insertions(+), 2 deletions(-) > > diff --git a/programs/wineconsole/wineconsole.c b/programs/wineconsole/wineconsole.c > index 3c2faf5..81300ed 100644 > --- a/programs/wineconsole/wineconsole.c > +++ b/programs/wineconsole/wineconsole.c > @@ -797,6 +797,11 @@ static UINT WINECON_ParseOptions(const char* lpCmdLine, struct wc_init* wci) > return 0; > } > > +#define MAXSTRING_NON_NT 128 > +#define MAXSTRING_NT351 260 > +#define MAXSTRING_NT4_W2K 2048 > +#define MAXSTRING_XP 8192 > + Why do you need this mess?

March 26, 2015