June 2015 - Wine-Devel - list.winehq.org

Re: [PATCH 1/6]: msvcp110: Add tr2_sys__Copy_file implementation and test.

by YongHaoHu

On 15/6/29 下午10:51, Piotr Caban wrote: > On 06/29/15 16:40, YongHaoHu wrote: >> On 15/6/29 下午5:29, Piotr Caban wrote: >>> On 06/27/15 19:49, YongHaoHu wrote: >>>> + ret = p_tr2_sys__Copy_file(tests[i].source, tests[i].dest, >>>> tests[i].fail_if_exists); >>>> + ok(ret == GetLastError(), "test_tr2_sys__Copy_file(): test >>>> %d expect: %d, got %d\n", i+1, GetLastError(), ret); >>>> + ok(errno == 0xdeadbeef, "test_tr2_sys__Copy_file(): test %d >>>> errno expect 0xdeadbeef, got %d\n", i+1, errno); >>> Please check the return value of the function explicitly. Currently >>> your implementation returns error while it should succeed and it's not >>> visible in the tests. >> Because the last error handling is not correct in CopyFile[1], I check >> GetLastError() instead of values. Do you have any good idea? > If testing exact return value of function is hard please at least test > if function succeeds/fails when it should. Sorry, could you explain a bit more details? > Currently your implementation sometimes returns error even so it > succeeds. > Which one do you mean ? As you know, last_error hadling is not correct in wine's CopyFile, was this happened in Wine platform? Thank you very much. : P

June 29, 2015

Re: [PATCH 4/6]: msvcp110: Add tr2_sys__Stat implementation and test.

by YongHaoHu

On 15/6/29 下午10:54, Piotr Caban wrote: > On 06/29/15 16:42, YongHaoHu wrote: >>> Why are you handling ERROR_BAD_DEV_TYPE error here? >>> >> I don't have special reason, just base on the test result on testbot. > It looks wrong. Could you please send the test here and point on what > testbot machine it happens? > Yes, it's wrong. According to your advice, I tested GetFileAttributesA and found that its last error handling was also not correct. (It means that many ntdll functions have problems with last_error handling.) The code I used is : GetFileAttributesA("\\\\.\\PiPe\\tests_pipe.c"); printf("getlast err is %d\n", GetLastError()); The output in wine is "getlast err is 66" while "|getlast err is 0" in testbot. Here is the test result: https://testbot.winehq.org/JobDetails.pl?Key=14832&log_101=1#k101 Plesase ignore the failed msg. |

June 29, 2015

Re: d3drm/tests: Add test for IDirect3DRM*::CreateDeviceFromD3D (try 9 resend).

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=14829 Your paranoid android. === build (build) === Patch failed to apply

June 29, 2015

Re: d3drm/tests: Add test for IDirect3DRM*::CreateDeviceFromSurface (try 7 resend).

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=14828 Your paranoid android. === build (build) === Patch failed to apply

June 29, 2015

Re: [PATCH 4/6]: msvcp110: Add tr2_sys__Stat implementation and test.

by Piotr Caban

On 06/29/15 16:42, YongHaoHu wrote: >> Why are you handling ERROR_BAD_DEV_TYPE error here? >> > I don't have special reason, just base on the test result on testbot. It looks wrong. Could you please send the test here and point on what testbot machine it happens? Thanks, Piotr

June 29, 2015

Re: [PATCH 1/6]: msvcp110: Add tr2_sys__Copy_file implementation and test.

by Piotr Caban

On 06/29/15 16:40, YongHaoHu wrote: > On 15/6/29 下午5:29, Piotr Caban wrote: >> On 06/27/15 19:49, YongHaoHu wrote: >>> + ret = p_tr2_sys__Copy_file(tests[i].source, tests[i].dest, >>> tests[i].fail_if_exists); >>> + ok(ret == GetLastError(), "test_tr2_sys__Copy_file(): test >>> %d expect: %d, got %d\n", i+1, GetLastError(), ret); >>> + ok(errno == 0xdeadbeef, "test_tr2_sys__Copy_file(): test %d >>> errno expect 0xdeadbeef, got %d\n", i+1, errno); >> Please check the return value of the function explicitly. Currently >> your implementation returns error while it should succeed and it's not >> visible in the tests. > Because the last error handling is not correct in CopyFile[1], I check > GetLastError() instead of values. Do you have any good idea? If testing exact return value of function is hard please at least test if function succeeds/fails when it should. Currently your implementation sometimes returns error even so it succeeds. Thanks, Piotr

June 29, 2015

Re: [PATCH 4/6]: msvcp110: Add tr2_sys__Stat implementation and test.

by YongHaoHu

On 15/6/29 下午5:55, Piotr Caban wrote: > On 06/27/15 19:50, YongHaoHu wrote: >> +static file_type stat_set_error(int *err_code) >> +{ >> + file_type ret; >> + *err_code = ERROR_SUCCESS; >> + >> + switch(GetLastError()) { >> + case ERROR_FILE_NOT_FOUND: >> + case ERROR_BAD_NETPATH: >> + case ERROR_INVALID_NAME: >> + case ERROR_BAD_PATHNAME: >> + case ERROR_PATH_NOT_FOUND: >> + ret = file_not_found; >> + break; >> + case ERROR_BAD_DEV_TYPE: >> + ret = regular_file; >> + break; >> + default: >> + ret = status_unknown; > Shouldn't err_code be set to GetLastError in default case? You end up > setting it to ERROR_SUCCESS in every case except if path is NULL. > Yeah, you are right. > Why are you handling ERROR_BAD_DEV_TYPE error here? > I don't have special reason, just base on the test result on testbot. >> + TRACE("(%s %p)\n", debugstr_a(path), err_code); >> + DWORD attr; > This will produce a compilation warning. > Got it. Thank you for your comment. :)

June 29, 2015

Re: [PATCH 1/6]: msvcp110: Add tr2_sys__Copy_file implementation and test.

by YongHaoHu

Hi, Piotr. On 15/6/29 下午5:29, Piotr Caban wrote: > On 06/27/15 19:49, YongHaoHu wrote: >> + ret = p_tr2_sys__Copy_file(tests[i].source, tests[i].dest, >> tests[i].fail_if_exists); >> + ok(ret == GetLastError(), "test_tr2_sys__Copy_file(): test >> %d expect: %d, got %d\n", i+1, GetLastError(), ret); >> + ok(errno == 0xdeadbeef, "test_tr2_sys__Copy_file(): test %d >> errno expect 0xdeadbeef, got %d\n", i+1, errno); > Please check the return value of the function explicitly. Currently > your implementation returns error while it should succeed and it's not > visible in the tests. Because the last error handling is not correct in CopyFile[1], I check GetLastError() instead of values. Do you have any good idea? [1]: https://bugs.winehq.org/show_bug.cgi?id=38772

June 29, 2015

Re: d3drm/tests: Add test for IDirect3DRM*::CreateDeviceFromD3D (try 9).

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=14826 Your paranoid android. === build (build) === Patch failed to apply

June 29, 2015

Re: Wiki is down

by Jeremy Newman

I've updated the DNS. Might take a bit for your respective caches to update Also, you can email me directly for these sorts of changes. Or, you know, just wait for me to discover the site is down on my own. Your choice. :-p -N On 06/28/2015 09:10 AM, Dimi Paun wrote: > Yes, the DNS entry needs to change. > > wiki.winehq.org <http://wiki.winehq.org> points to www.lattica. com > > we need to change it to point to: > > winewiki.lattica.com <http://winewiki.lattica.com>. > > Thanks, > > > On Sat, Jun 27, 2015 at 9:01 AM Austin English <austinenglish(a)gmail.com > <mailto:austinenglish(a)gmail.com>> wrote: > > On Jun 27, 2015 3:33 PM, "Rosanne DiMesio" <dimesio(a)earthlink.net > <mailto:dimesio(a)earthlink.net>> wrote: > > > > Http://wiki.winehq.org leads to a bluehost.com > <http://bluehost.com> page that says "There is no website configured > at this address" and links to specific wiki pages produce 404: File > not found. > > > > -- > > Rosanne DiMesio <dimesio(a)earthlink.net > <mailto:dimesio(a)earthlink.net>> > > +Dimi > > > >

June 29, 2015