June 2015 - Wine-Devel - list.winehq.org

RE: programs/regsvr32 patches

by Hugh McMaster

On Fri, 29 May 2015 22:42:59 +1000, Hugh McMaster wrote: > > I've looked through patches 111564-111568 and have only found one minor issue. In patch 111565 I forgot to include ctype.h for tolower(). > > Was there a problem with the input comparison handling, or something else? The changes to the input handling make conversion to unicode much easier and cleaner. I realise that patch 111565 looks complex, but it's just the indenting. Hmmm. No comments at all? I'll take another look and resend.

June 4, 2015

Re: [PATCH] riched20: Fix link notification conditions and add tests.

by Nikolay Sivov

On 04.06.2015 9:34, Alex Henrie wrote: > Fixes https://bugs.winehq.org/show_bug.cgi?id=35949 > --- > dlls/riched20/editor.c | 13 +++- > dlls/riched20/tests/editor.c | 178 +++++++++++++++++++++++++++++++++++++++---- > 2 files changed, 172 insertions(+), 19 deletions(-) > Looks good to me.

June 4, 2015

Re: ntdll/tests: Properly mark test failures with todo_wine.

by Alexandre Julliard

Sebastian Lackner <sebastian(a)fds-team.de> writes: > @@ -353,14 +353,18 @@ static void test_NtQueryDirectoryFile_case(void) > mask.Length = mask.MaximumLength = lstrlenW(testmask) * sizeof(WCHAR); > pNtQueryDirectoryFile(dirh, NULL, NULL, NULL, &io, data, data_size, > FileBothDirectoryInformation, TRUE, &mask, FALSE); > + todo_wine > ok(U(io).Status == STATUS_SUCCESS, "failed to query directory; status %x\n", U(io).Status); > data_len = io.Information; > + todo_wine > ok(data_len >= sizeof(FILE_BOTH_DIRECTORY_INFORMATION), "not enough data in directory\n"); > > name = dir_info->FileName; > name_len = dir_info->FileNameLength / sizeof(WCHAR); > > + todo_wine > ok(name_len == testfile_len, "unexpected filename length %u\n", name_len); > + todo_wine I don't see any failure here. -- Alexandre Julliard julliard(a)winehq.org

June 4, 2015

Re: TestBot job 13726 results: [PATCH 2/2] d3d9/test: implemented tests for UpdateTexture method

by Sergey Isakov

It may mean that Win8 contains a bug. Use Windows Update. On 01 июня 2015 г., at 3:05, Marvin <testbot(a)winehq.org> wrote: > VM Status Number of test failures > build completed > w2000pro completed 0 > wxppro completed 0 > w2003std completed 0 > wvistau64 completed 0 > w2008s64 completed 0 > w7u completed 0 > w8 completed 3 > wvistau64 completed 0 > w2008s64 completed 0 > > === build (build) === > No build failures found > > === w2000pro (32 bit visual) === > No test failures found > > === wxppro (32 bit visual) === > No test failures found > > === w2003std (32 bit visual) === > No test failures found > > === wvistau64 (32 bit visual) === > No test failures found > > === w2008s64 (32 bit visual) === > No test failures found > > === w7u (32 bit visual) === > No test failures found > > === w8 (32 bit visual) === > > d3d9: > visual.c:18560: Test failed: Unexpected result on update texture, hr 0, should fail, case 0, 8. > visual.c:18560: Test failed: Unexpected result on update texture, hr 0, should fail, case 1, 8. > visual.c:18560: Test failed: Unexpected result on update texture, hr 0, should fail, case 2, 8. > > === wvistau64 (64 bit visual) === > No test failures found > > === w2008s64 (64 bit visual) === > No test failures found<build.log><w2000pro.log><wxppro.log><w2003std.log><wvistau64.log><w2008s64.log><w7u.log><w8.log><wvistau64.log><w2008s64.log>

June 4, 2015

Re: wbemprox: Treat \r as whitespace.

by Sebastian Lackner

On 04.06.2015 03:06, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > https://testbot.winehq.org/JobDetails.pl?Key=13841 > > Your paranoid android. > > > === wvistau64 (64 bit query) === > The test timed out > Looks like a random failure, worked fine on the second attempt: https://newtestbot.winehq.org/JobDetails.pl?Key=13850

June 4, 2015

Re: wbemprox: Treat \r as whitespace.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13841 Your paranoid android. === wvistau64 (64 bit query) === The test timed out

June 4, 2015

Re: CSMT status?

by Sebastian Lackner

On 04.06.2015 01:40, Forest wrote: > Can anyone offer a status update on D3D command stream multithreading? > > I've been packaging Stefan Dösinger's CSMT work, with over 500 people using > my last release, and several asking when I'll build a new one. I don't know > what to tell them, because his github repo hasn't been updated in half a > year, and he hasn't responded to the email I sent him last week. It's > starting to look like this excellent work has been abandoned. I am wondering about that myself. Nevertheless, in order to provide up-to-date Wine builds you can use the CSMT patches contained in Wine-Staging. We're not actively improving them at the moment, but they are rebased daily to apply on top of the upstream changes. So far the rebasing was basically trivial, so no idea what is currently blocking inclusion of the patchset. https://github.com/wine-compholio/wine-staging/tree/master/patches/wined3d-… https://github.com/wine-compholio/wine-staging/tree/master/patches/wined3d-… > > Pherhaps I missed an announcement? Has it already been integrated into > mainline wine? Is there some other plan for it? > > Regards, Sebastian

June 3, 2015

CSMT status?

by Forest

Can anyone offer a status update on D3D command stream multithreading? I've been packaging Stefan Dösinger's CSMT work, with over 500 people using my last release, and several asking when I'll build a new one. I don't know what to tell them, because his github repo hasn't been updated in half a year, and he hasn't responded to the email I sent him last week. It's starting to look like this excellent work has been abandoned. Pherhaps I missed an announcement? Has it already been integrated into mainline wine? Is there some other plan for it?

June 3, 2015

Re: shlwapi: Fix error handling in IUnknown_GetClassID (Coverity)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13825 Your paranoid android. === w2000pro (32 bit ordinal) === ordinal.c:3225: Test failed: got wrong clsid {cccccccc-cccc-cccc-cccc-cccccccccccc} === wxppro (32 bit ordinal) === ordinal.c:3225: Test failed: got wrong clsid {cccccccc-cccc-cccc-cccc-cccccccccccc} === w2003std (32 bit ordinal) === ordinal.c:3225: Test failed: got wrong clsid {cccccccc-cccc-cccc-cccc-cccccccccccc}

June 3, 2015

Re: [PATCH 2/5] wined3d: Clamp per-vertex point size in vertex shaders.

by Henri Verbeet

On 3 June 2015 at 16:27, Matteo Bruni <matteo.mystral(a)gmail.com> wrote: > Right. The problem is that vs_compile_args isn't necessarily around > (we might be reusing the previously selected vertex shader) and > recomputing it just for this seemed a bit overkill. Any idea? > No particular good one. We could perhaps store it in struct glsl_vs_program, but it would probably be only marginally better.

June 3, 2015