June 2015 - Wine-Devel - list.winehq.org

Re: [PATCH 3/5] wined3d: Handle point sprites with PS 3.0.

by Matteo Bruni

2015-06-03 12:46 GMT+02:00 Henri Verbeet <hverbeet(a)gmail.com>: > On 2 June 2015 at 16:39, Matteo Bruni <mbruni(a)codeweavers.com> wrote: >> + else if (args->pointsprite && shader_match_semantic(semantic_name, WINED3D_DECL_USAGE_TEXCOORD)) >> + shader_addline(buffer, "ps_in[%u].xy = vec2(gl_PointCoord.x, gl_PointCoord.y);\n", input->register_idx); > Why not "ps_in[%u].xy = gl_PointCoord.xy;\n"? Also, do the z and w > components have a defined value? Eh, I planned to test the .zw components but I forgot...

June 3, 2015

Re: [PATCH 2/5] wined3d: Clamp per-vertex point size in vertex shaders.

by Matteo Bruni

2015-06-03 12:46 GMT+02:00 Henri Verbeet <hverbeet(a)gmail.com>: > On 2 June 2015 at 16:39, Matteo Bruni <mbruni(a)codeweavers.com> wrote: >> @@ -6711,7 +6721,8 @@ static void set_glsl_shader_program(const struct wined3d_context *context, const >> WORD map = vshader->reg_maps.input_registers; >> struct wined3d_string_buffer *tmp_name = string_buffer_get(&priv->string_buffers); >> >> - reorder_shader_id = generate_param_reorder_function(priv, vshader, pshader, gl_info); >> + reorder_shader_id = generate_param_reorder_function(priv, vshader, pshader, >> + state->gl_primitive_type == GL_POINTS && vshader->reg_maps.point_size, gl_info); > This works because "state->gl_primitive_type == GL_POINTS" is mirrored > in struct vs_compile_args, but it isn't necessarily very obvious or > pretty. Right. The problem is that vs_compile_args isn't necessarily around (we might be reusing the previously selected vertex shader) and recomputing it just for this seemed a bit overkill. Any idea?

June 3, 2015

Re: [1/2] msvcirt: Add initial implementation of streambuf (try 3)

by Piotr Caban

On 06/03/15 13:50, Iván Matellanes wrote: > +DEFINE_RTTI_DATA0(streambuf, 0, ".?AVstreambuf@@") You need to call init_streambuf_rtti function to initialize RTTI in 64-bit case. Cheers, Piotr

June 3, 2015

Re: [PATCH 3/5] wined3d: Handle point sprites with PS 3.0.

by Henri Verbeet

On 2 June 2015 at 16:39, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > + else if (args->pointsprite && shader_match_semantic(semantic_name, WINED3D_DECL_USAGE_TEXCOORD)) > + shader_addline(buffer, "ps_in[%u].xy = vec2(gl_PointCoord.x, gl_PointCoord.y);\n", input->register_idx); Why not "ps_in[%u].xy = gl_PointCoord.xy;\n"? Also, do the z and w components have a defined value?

June 3, 2015

Re: [PATCH 2/5] wined3d: Clamp per-vertex point size in vertex shaders.

by Henri Verbeet

On 2 June 2015 at 16:39, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > @@ -6711,7 +6721,8 @@ static void set_glsl_shader_program(const struct wined3d_context *context, const > WORD map = vshader->reg_maps.input_registers; > struct wined3d_string_buffer *tmp_name = string_buffer_get(&priv->string_buffers); > > - reorder_shader_id = generate_param_reorder_function(priv, vshader, pshader, gl_info); > + reorder_shader_id = generate_param_reorder_function(priv, vshader, pshader, > + state->gl_primitive_type == GL_POINTS && vshader->reg_maps.point_size, gl_info); This works because "state->gl_primitive_type == GL_POINTS" is mirrored in struct vs_compile_args, but it isn't necessarily very obvious or pretty.

June 3, 2015

Re: [1/2] msvcirt: Add initial implementation of streambuf (try 2)

by Piotr Caban

On 06/02/15 18:20, Iván Matellanes wrote: > +/* ?seekoff(a)streambuf@@UAEJJW4seek_dir(a)ios@@H(a)Z */ > +/* ?seekoff(a)streambuf@@UEAAJJW4seek_dir(a)ios@@H(a)Z */ > +DEFINE_THISCALL_WRAPPER(streambuf_seekoff, 16) > +long __thiscall streambuf_seekoff(streambuf *this, long offset, int dir, int mode) > +{ > + FIXME("(%p %ld %d %d): stub\n", this, offset, dir, mode); > + return EOF; > +} You can't use long type here, please use LONG instead (it's used also in some other functions). Thanks, Piotr

June 3, 2015

Re: include: add initial winsta.h

by Austin English

On Wed, Jun 3, 2015 at 12:01 AM, Alexandre Julliard <julliard(a)winehq.org> wrote: > Austin English <austinenglish(a)gmail.com> writes: > >> On Tue, Jun 2, 2015 at 11:51 PM, Alexandre Julliard <julliard(a)winehq.org> wrote: >>> Austin English <austinenglish(a)gmail.com> writes: >>>> Patch has been pending for several days, is there something I can do >>>> to improve it? >>>> >>>> Nikolay asked in #winehackers where this came from, it's on MSDN: >>>> https://msdn.microsoft.com/en-us/library/cc248871.aspx >>>> >>>> and also in Process Hacker's source: >>>> http://processhacker.sourceforge.net/doc/winsta_8h_source.html >>> >>> It doesn't look like it's part of the SDK. What do you need this for? >> >> https://bugs.winehq.org/show_bug.cgi?id=38102 >> >> Should I instead put winsta.h in dlls/winsta/ ? > > Probably. You also have to fix handling of anonymous unions, and your > TS_ALL_PROCESSES_INFO definition doesn't look right. > > -- > Alexandre Julliard > julliard(a)winehq.org Okay, thanks for reviewing. -- -Austin

June 3, 2015

Re: include: add initial winsta.h

by Alexandre Julliard

Austin English <austinenglish(a)gmail.com> writes: > On Tue, Jun 2, 2015 at 11:51 PM, Alexandre Julliard <julliard(a)winehq.org> wrote: >> Austin English <austinenglish(a)gmail.com> writes: >>> Patch has been pending for several days, is there something I can do >>> to improve it? >>> >>> Nikolay asked in #winehackers where this came from, it's on MSDN: >>> https://msdn.microsoft.com/en-us/library/cc248871.aspx >>> >>> and also in Process Hacker's source: >>> http://processhacker.sourceforge.net/doc/winsta_8h_source.html >> >> It doesn't look like it's part of the SDK. What do you need this for? > > https://bugs.winehq.org/show_bug.cgi?id=38102 > > Should I instead put winsta.h in dlls/winsta/ ? Probably. You also have to fix handling of anonymous unions, and your TS_ALL_PROCESSES_INFO definition doesn't look right. -- Alexandre Julliard julliard(a)winehq.org

June 3, 2015

Re: include: add initial winsta.h

by Austin English

On Tue, Jun 2, 2015 at 11:51 PM, Alexandre Julliard <julliard(a)winehq.org> wrote: > Austin English <austinenglish(a)gmail.com> writes: > >> On Tue, May 26, 2015 at 10:21 PM, Austin English >> <austinenglish(a)gmail.com> wrote: >>> -- >>> -Austin >> >> Patch has been pending for several days, is there something I can do >> to improve it? >> >> Nikolay asked in #winehackers where this came from, it's on MSDN: >> https://msdn.microsoft.com/en-us/library/cc248871.aspx >> >> and also in Process Hacker's source: >> http://processhacker.sourceforge.net/doc/winsta_8h_source.html > > It doesn't look like it's part of the SDK. What do you need this for? > > -- > Alexandre Julliard > julliard(a)winehq.org https://bugs.winehq.org/show_bug.cgi?id=38102 Should I instead put winsta.h in dlls/winsta/ ? -- -Austin

June 3, 2015

Re: include: add initial winsta.h

by Alexandre Julliard

Austin English <austinenglish(a)gmail.com> writes: > On Tue, May 26, 2015 at 10:21 PM, Austin English > <austinenglish(a)gmail.com> wrote: >> -- >> -Austin > > Patch has been pending for several days, is there something I can do > to improve it? > > Nikolay asked in #winehackers where this came from, it's on MSDN: > https://msdn.microsoft.com/en-us/library/cc248871.aspx > > and also in Process Hacker's source: > http://processhacker.sourceforge.net/doc/winsta_8h_source.html It doesn't look like it's part of the SDK. What do you need this for? -- Alexandre Julliard julliard(a)winehq.org

June 3, 2015