June 2015 - Wine-Devel - list.winehq.org

Re: msvcirt/tests: Add initial tests for streambuf

by Iván Matellanes

I have already implemented those methods. Is it OK if I skip the stubs and send the implementation directly? Thanks, Iván El 02/06/15 a las 13:12, Piotr Caban escribió: > On 06/02/15 12:47, Iván Matellanes wrote: >> +todo_wine{ >> + /* constructors */ >> + call_func1(p_streambuf_ctor, &sb); > You'll need to add streambuf_ctor stub in wine before you can test it. Currently the tests will fail with exception. Please also set &sb memory to something so you can detect uninitialized values. > > Please also call streambuf_dtor. > > Cheers, > Piotr

June 2, 2015

Re: msvcirt/tests: Add initial tests for streambuf

by Piotr Caban

On 06/02/15 12:47, Iván Matellanes wrote: > +todo_wine{ > + /* constructors */ > + call_func1(p_streambuf_ctor, &sb); You'll need to add streambuf_ctor stub in wine before you can test it. Currently the tests will fail with exception. Please also set &sb memory to something so you can detect uninitialized values. Please also call streambuf_dtor. Cheers, Piotr

June 2, 2015

Re: [PATCH 2/3] riched20: Reduce code duplication in WM_SETTEXT/WM_CREATE handler

by Henri Verbeet

On 2 June 2015 at 11:22, Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > On 06/02/2015 11:41 AM, Dmitry Timoshkov wrote: >> >> Nikolay Sivov <nsivov(a)codeweavers.com> wrote: >> >>> + if (lParam) >>> + text = unicode ? (void*)createW->lpszName : >>> (void*)createA->lpszName; >> >> >> These casts should not be needed. >> > > I get warnings without them, so I prefer to keep this as it was before my > patch. > I suppose it's mostly down to preference, but you actually don't really need the conditional at all, since the only difference between CREATESTRUCTW and CREATESTRUCTA is the type of the pointers. I.e., you could essentially just do "ME_SetText(editor, ((CREATESTRUCTW *)lParam)->lpszName, unicode);". After doing a couple of const-correctness fixes first anyway.

June 2, 2015

Re: [PATCH 2/3] riched20: Reduce code duplication in WM_SETTEXT/WM_CREATE handler

by Nikolay Sivov

On 06/02/2015 11:41 AM, Dmitry Timoshkov wrote: > Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > >> + if (lParam) >> + text = unicode ? (void*)createW->lpszName : (void*)createA->lpszName; > > These casts should not be needed. > I get warnings without them, so I prefer to keep this as it was before my patch.

June 2, 2015

Re: [PATCH 2/3] riched20: Reduce code duplication in WM_SETTEXT/WM_CREATE handler

by Dmitry Timoshkov

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > + if (lParam) > + text = unicode ? (void*)createW->lpszName : (void*)createA->lpszName; These casts should not be needed. -- Dmitry.

June 2, 2015

Re: gdi32: Return default palette entries from GetSystemPaletteEntries for non-palette-based devices. (try 2)

by Anton Baskanov

Oops :-) Thanks for spotting! I'll resend the patch with your changes and tests included. On Mon, Jun 1, 2015 at 10:29 PM, Sebastian Lackner <sebastian(a)fds-team.de> wrote: > On 01.06.2015 17:51, Anton Baskanov wrote: >> + if (entries && start < 256) >> + { >> + UINT i; >> + const RGBQUAD *default_entries; >> + >> + if (start + count > 256) count = 256 - start; >> + >> + default_entries = get_default_color_table( 8 ); >> + for (i = 0; i < count; ++i) >> + { >> + if (i < 10 || i >= 246) >> + { > > That condition is obviously wrong. Feel free to merge the changes and additional tests from my improved patchset which is included in Wine-Staging: > https://github.com/wine-compholio/wine-staging/blob/master/patches/gdi32-De… > >> + entries[i].peRed = default_entries[start + i].rgbRed; >> + entries[i].peGreen = default_entries[start + i].rgbGreen; >> + entries[i].peBlue = default_entries[start + i].rgbBlue; >> + } >> + else >> + { >> + entries[i].peRed = 0; >> + entries[i].peGreen = 0; >> + entries[i].peBlue = 0; >> + } >> + entries[i].peFlags = 0; >> + } >

June 2, 2015

wine CPU usage and CreateWaitableTimer

by andrea

Hi, I'm trying to understand why AppleWin uses 100% CPU when running in wine vs ~1% in Windows. my case is wine 1.7.43 vs Windows 7 https://appdb.winehq.org/objectManager.php?sClass=version&iId=29403 https://bugs.winehq.org/show_bug.cgi?id=34945 basically 97% time is spent in a WaitForSingleObject on a semaphore signalled by a DirectSound IReferenceClock via AdvisePeriodic. The timer period is set to 1 millisecond. I have tried an other Windows call to create the timer: CreateWaitableTimer The latter uses about 50% CPU, so it is much better, but still not very good. This is true even on a simple app that does nothing other than waiting for this timer all the time. Does anybody know 1) is this normal? should these waits be almost free like they are in Windows? 2) what is the best implemented timer in wine that can be used for a periodic event (~1ms)? Thanks

June 1, 2015

Re: [PATCH 2/2] d3d9/test: implemented tests for UpdateTexture method

by Matteo Bruni

2015-05-27 21:55 GMT+02:00 Sergey Isakov <isakov-sl(a)bk.ru>: > The test was initially written by Matteo Bruni > https://www.winehq.org/pipermail/wine-patches/2015-April/138974.html > but rejected as failed > https://www.winehq.org/pipermail/wine-devel/2015-April/107491.html For the records, my tests failed for Alexandre on Linux because of a bug in the Nouveau drivers which is fixed by Mesa commit f617029db3f8786d94c64f1a73c42b89b6d261fa. I'll resend the unmodified tests at some point.

June 1, 2015

Re: [PATCH 1/2] wined3d: fix wrong level calculation implemented in 1.7.42

by Matteo Bruni

2015-05-27 21:45 GMT+02:00 Sergey Isakov <isakov-sl(a)bk.ru>: > Bug 38048. > It is closed by wrong fix 5af656ea85e22a00304f1904e91ccfee52a6ccc5 > According to MSDN > https://msdn.microsoft.com/en-us/library/windows/desktop/bb205858(v=vs.85).… > “If the source texture has fewer levels than the destination, the method > will fail.” > The method must fail > 1. To prevent fail on undefined levels. > 2. To inform caller that the call is wrong. > The correct patch attached. > Test will follow next commit As I already mentioned, MSDN is wrong in this case, like in many other cases. UpdateTexture never returns failure when using hardware devices on Windows.

June 1, 2015

Re: [1/3] shell32/tests: Make tests run on win2k again.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13744 Your paranoid android. === w2003std (32 bit shlfolder) === shlfolder.c:4997: Test failed: MKDIR: Expected wndproc to be called shlfolder.c:4910: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 8) shlfolder.c:4997: Test failed: CREATE: Expected wndproc to be called shlfolder.c:4910: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 2) shlfolder.c:4997: Test failed: RMDIR: Expected wndproc to be called shlfolder.c:4910: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 10) shlfolder.c:4997: Test failed: MKDIR: Expected wndproc to be called shlfolder.c:4910: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 468) shlfolder.c:4997: Test failed: CREATE: Expected wndproc to be called shlfolder.c:4910: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 468) shlfolder.c:4997: Test failed: RMDIR: Expected wndproc to be called shlfolder.c:4910: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 468)

June 1, 2015