July 2015 - Wine-Devel - list.winehq.org

Re: [website] Update Debian downloads info

by Jeremy Newman

You can still switch to 'Sid' or 'Unstable' from that page. Most users are going to be running Debian Stable right now anyway. Also, installing a Sid package on Stable is not recommended anyway due to dependency issues. This is the root of the issue. How do Debian Stable users get the latest version of Wine that is built specifically for them? -N On 07/23/2015 10:02 AM, Rosanne DiMesio wrote: > On Thu, 23 Jul 2015 09:10:42 -0500 > Jeremy Newman <jnewman(a)codeweavers.com> wrote: > >> I misunderstood the package. I thought it was just a meta package to >> install required development libs, like build-essential. >> >> -N >> > > I understand why you thought that. It's the very reason I could never find the packages by googling "Debian wine," and probably the main reason Debian users can't find them either. > > Now, the problem with what you changed it to is that it now points to the page for Debian Jessie (stable), which has outdated packages, and doesn't show the packages for Stretch (testing) or Sid (unstable). My patch linked to https://packages.debian.org/search?keywords=wine-development because the search results produce links to all three, which I think is easiest for users. > >

July 23, 2015

Re: [website] Update Debian downloads info

by Rosanne DiMesio

On Thu, 23 Jul 2015 09:10:42 -0500 Jeremy Newman <jnewman(a)codeweavers.com> wrote: > I misunderstood the package. I thought it was just a meta package to > install required development libs, like build-essential. > > -N > I understand why you thought that. It's the very reason I could never find the packages by googling "Debian wine," and probably the main reason Debian users can't find them either. Now, the problem with what you changed it to is that it now points to the page for Debian Jessie (stable), which has outdated packages, and doesn't show the packages for Stretch (testing) or Sid (unstable). My patch linked to https://packages.debian.org/search?keywords=wine-development because the search results produce links to all three, which I think is easiest for users. -- Rosanne DiMesio <dimesio(a)earthlink.net>

July 23, 2015

Re: [website] Update Debian downloads info

by Jeremy Newman

I misunderstood the package. I thought it was just a meta package to install required development libs, like build-essential. -N On 07/22/2015 05:08 PM, Rosanne DiMesio wrote: > On Wed, 22 Jul 2015 14:27:59 -0500 > Jeremy Newman <jnewman(a)codeweavers.com> wrote: > >> Patch looks good. We will also need to update all the other languages >> and put in a redirect for the /downloads/debian page to the regular >> downloads page. >> >> -N > > I'm wondering why you changed the link to point to the packages for the stable release rather than the development release packages. All the other links on our Downloads page point to packages for the development releases, and that's what users are looking for when they come here. > >

July 23, 2015

Re: msxml3: Handle NULL parameter in IXMLDOMElement::get_ownerDocument().

by Zhenbo Li

Hi Nikolay, 2015-07-18 23:34 GMT+08:00 Nikolay Sivov <bunglehead(a)gmail.com>: >> >> Do you mean an iteration like that? Have I tested all the included nodes? > > > In principle yes, but you're not testing anything in that patch, > ownerDocument() is IXMLDOMNode property, you have to call it on 'node'. > Also this document doesn't cover anything but elements I think, because > childNodes() only iterates through immediate children, and grand-children > are not included (I think, it's been a while since I looked into that). So I > suggest adding a new document, with all kinds of nodes, and run a loop on > it. Attribute nodes still need special handling. Okay, so I write a recursive test for it. Could you have a check with it? > >> Also, we already have a helper function: test_get_ownerDocument() >> Should I use this? >> > > Right, I missed that, please move new loop there. I'm wondering how to combine the tests now. Can I just call test_null_owner in test_get_ownerDocument()? It seems easier. Thanks -- Have a nice day! Zhenbo Li

July 23, 2015

Re: [website] Update Debian downloads info

by Rosanne DiMesio

On Wed, 22 Jul 2015 14:27:59 -0500 Jeremy Newman <jnewman(a)codeweavers.com> wrote: > Patch looks good. We will also need to update all the other languages > and put in a redirect for the /downloads/debian page to the regular > downloads page. > > -N I'm wondering why you changed the link to point to the packages for the stable release rather than the development release packages. All the other links on our Downloads page point to packages for the development releases, and that's what users are looking for when they come here. -- Rosanne DiMesio <dimesio(a)earthlink.net>

July 22, 2015

Re: [website] Update Debian downloads info

by André Hentschel

Am 22.07.2015 um 21:27 schrieb Jeremy Newman: > Patch looks good. We will also need to update all the other languages and put in a redirect for the /downloads/debian page to the regular downloads page. > > -N > > On 07/22/2015 01:43 PM, Rosanne DiMesio wrote: >> Updates the Debian links on the Downloads page to point to packages.debian.org and deletes the obsolete WineHQ Debian downloads page. >> Jeremy, I think the intention was to link to the wine-development package, you changed the link to stable/wine which is quite old meanwhile...

July 22, 2015

Re: Scan-build report uploaded

by André Hentschel

Am 22.07.2015 um 22:13 schrieb Aaryaman Vasishta: > Looks great! It's the first time I've seen a scan-build. > I was looking through the d3drm related reports. What does this mean? > "Null pointer passed as an argument to a 'nonnull' parameter" > Does it mean that there's a potential for get_IID_string to be passed a NULL GUID? Click on "View Report", the numbers in the upper left corner are the steps to "reproduce" an issue, click on the blue arrows to step through/back. the analyzer doesn't trust the array "iids" coming from extern and the function doesn't check for a NULL GUID, but we never check for a NULL GUID at least in that file... I think this falls under "if a application needs it", but you could also provoke it with a test, if we crash and windows does, then we did it right ;)

July 22, 2015

Re: Scan-build report uploaded

by Aaryaman Vasishta

Looks great! It's the first time I've seen a scan-build. I was looking through the d3drm related reports. What does this mean? "Null pointer passed as an argument to a 'nonnull' parameter" Does it mean that there's a potential for get_IID_string to be passed a NULL GUID? On Wed, Jul 22, 2015 at 11:31 PM, André Hentschel <nerv(a)dawncrow.de> wrote: > Hi, > > in case someone is interested, i've uploaded a scan-build here: > http://dawncrow.de/scan-build-2015-07-20-200148-28114-1/ > Wine source is from last Friday > > >

July 22, 2015

Re: [website] Update Debian downloads info

by Nathan Schulte

Ah, nice; I see you already caught the wine-development vs wine package differences. -- Nate

July 22, 2015

Re: [PATCH 4/4] mshtml: Add IHTMLXMLHttpRequest::statusText property implementation.

by Jacek Caban

Hi Zhenbo, On 22/07/15 17:34, Zhenbo Li wrote: > + len = MultiByteToWideChar(CP_ACP, 0, str, -1, NULL, 0); > + *p = SysAllocStringLen(NULL, len); > + if(!*p) { > + nsACString_Finish(nscstr); > + return E_OUTOFMEMORY; > + } > + MultiByteToWideChar(CP_ACP, 0, str, -1, *p, len); I didn't catch it earlier, but this should use CP_UTF8. Cheers, Jacek

July 22, 2015