August 2015 - Wine-Devel - list.winehq.org

Re: WS2_32: WSACleanup implementation, server-side, plus remove todos around passing tests. This also fixes bug 32910

by Matt Durgavich

How do I read this test failure? I don’t see any real clues. -Matt > On Aug 29, 2015, at 4:32 PM, Marvin <testbot(a)winehq.org> wrote: > > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > https://testbot.winehq.org/JobDetails.pl?Key=16405 > > Your paranoid android. > > > === w2008s64 (64 bit sock) === > No test summary line found

Aug. 29, 2015

Re: WS2_32: WSACleanup implementation, server-side, plus remove todos around passing tests. This also fixes bug 32910

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16405 Your paranoid android. === w2008s64 (64 bit sock) === No test summary line found

Aug. 29, 2015

Re: [PATCH 1/4] xaudio2: Implement device activation

by Chris Robinson

On 08/29/2015 11:36 AM, Matt Durgavich wrote: > Unless I misapplied your patch, it looks like xaudio2 gets disabled > on OS X due to lack of full OpenAL support. OS X does support some > OpenAL APIs through CoreAudio in a 1:1 fashion, and the rest would > likely need to be implemented. > > I can take a pass at this, unless there’s some objection. Knowing how MS's APIs tend to be designed, is it possible the XAudio2 device relies on knowing which mmdeviceapi device is used for output? At least I'd assume that's why the loopback extension is needed, to ensure output is properly synchronized with an IAudioClient.

Aug. 29, 2015

Re: [PATCH 1/4] xaudio2: Implement device activation

by Andrew Eikum

As explained on bug 39165, my xaudio2 work uses the ALC_SOFT_loopback extension, which OSX doesn't support. You'll need to install openal-soft on OSX and build against that to use this xaudio2 implementation. Native xaudio2 installed through winetricks will also continue to work, of course. Andrew On Sat, Aug 29, 2015 at 02:36:38PM -0400, Matt Durgavich wrote: > Unless I misapplied your patch, it looks like xaudio2 gets disabled on OS X due to lack of full OpenAL support. OS X does support some OpenAL APIs through CoreAudio in a 1:1 fashion, and the rest would likely need to be implemented. > > I can take a pass at this, unless there’s some objection. > > -Matt > > > On Aug 28, 2015, at 10:09 PM, Sebastian Lackner <sebastian(a)fds-team.de> wrote: > > > > On 29.08.2015 03:51, Matt Durgavich wrote: > >> Looks like it is too late :( > >> > >> This appears to break the build on OSX. Any idea for when a patch will arrive? > > > > The following patch (submitted today) might help: > > http://source.winehq.org/patches/data/114068 > > > > (needs "autoreconf -f" to update the ./configure script) > > > >> > >> -Matt > >> > > >

Aug. 29, 2015

Re: [PATCH 1/4] xaudio2: Implement device activation

by Matt Durgavich

Unless I misapplied your patch, it looks like xaudio2 gets disabled on OS X due to lack of full OpenAL support. OS X does support some OpenAL APIs through CoreAudio in a 1:1 fashion, and the rest would likely need to be implemented. I can take a pass at this, unless there’s some objection. -Matt > On Aug 28, 2015, at 10:09 PM, Sebastian Lackner <sebastian(a)fds-team.de> wrote: > > On 29.08.2015 03:51, Matt Durgavich wrote: >> Looks like it is too late :( >> >> This appears to break the build on OSX. Any idea for when a patch will arrive? > > The following patch (submitted today) might help: > http://source.winehq.org/patches/data/114068 > > (needs "autoreconf -f" to update the ./configure script) > >> >> -Matt >> >

Aug. 29, 2015

Re: ws2_32: WSACleanup cleans up open sockets (OSX only)

by Matt Durgavich

Cool. Thanks for all the feedback. I’m happy to be contributing, and I got a crash course in server and dll development. :) > On Aug 29, 2015, at 2:19 PM, Bruno Jesus <00cpxxx(a)gmail.com> wrote: > > On Sun, Aug 30, 2015 at 2:13 AM, Matt Durgavich <mattdurgavich(a)gmail.com> wrote: >> All suggestions rolled in. Removing todos in tests will be a separate patch > > You can't do that, because the changes you are making will break the > tests (tests will fail since problems were fixed and todo_wine need to > be removed). Just merge the todo removal and IMO the patch is fine. > Remember to run make test inside the ws2_32/tests folder to check if > it runs fine. > > It amazes me that such a simple solution could be found for this bug, > thanks for working on it and thanks Henri for the tip.

Aug. 29, 2015

Re: [PATCH 2/2] gdi32: Added GetFontRealizationInfo() export

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16404 Your paranoid android. === wvistau64 (64 bit font) === The test timed out

Aug. 29, 2015

Re: ws2_32: WSACleanup cleans up open sockets (OSX only)

by Bruno Jesus

On Sun, Aug 30, 2015 at 2:13 AM, Matt Durgavich <mattdurgavich(a)gmail.com> wrote: > All suggestions rolled in. Removing todos in tests will be a separate patch You can't do that, because the changes you are making will break the tests (tests will fail since problems were fixed and todo_wine need to be removed). Just merge the todo removal and IMO the patch is fine. Remember to run make test inside the ws2_32/tests folder to check if it runs fine. It amazes me that such a simple solution could be found for this bug, thanks for working on it and thanks Henri for the tip.

Aug. 29, 2015

Re: ws2_32: WSACleanup cleans up open sockets (OSX only)

by Matt Durgavich

All suggestions rolled in. Removing todos in tests will be a separate patch >From d62ed3e109f6d6a862f62afb1242ca15e199fd98 Mon Sep 17 00:00:00 2001 From: Matt <matt(a)wymzee.com> Date: Thu, 27 Aug 2015 23:43:59 -0400 Subject: [PATCH] WS2_32: WSACleanup implementation, server-side. --- dlls/ws2_32/socket.c | 9 +++++++++ server/protocol.def | 3 +++ server/sock.c | 10 ++++++++++ 3 files changed, 22 insertions(+) diff --git a/dlls/ws2_32/socket.c b/dlls/ws2_32/socket.c index ca82ec9..b5d5ff5 100644 --- a/dlls/ws2_32/socket.c +++ b/dlls/ws2_32/socket.c @@ -1471,6 +1471,15 @@ INT WINAPI WSACleanup(void) { if (num_startup) { num_startup--; + if (num_startup == 0) + { + SERVER_START_REQ(socket_cleanup) + { + wine_server_call( req ); + } + SERVER_END_REQ; + } + TRACE("pending cleanups: %d\n", num_startup); return 0; } diff --git a/server/protocol.def b/server/protocol.def index c313006..2dccb9a 100644 --- a/server/protocol.def +++ b/server/protocol.def @@ -942,6 +942,9 @@ struct rawinput_device obj_handle_t handle; /* handle to close */ @END +/* Close all sockets for the current process */ +(a)REQ(socket_cleanup) +(a)END /* Set a handle information */ @REQ(set_handle_info) diff --git a/server/sock.c b/server/sock.c index 67d6416..c5c5083 100644 --- a/server/sock.c +++ b/server/sock.c @@ -1383,3 +1383,13 @@ DECL_HANDLER(get_socket_info) release_object( &sock->obj ); } + +DECL_HANDLER(socket_cleanup) +{ + obj_handle_t sock; + unsigned int index = 0; + while ( (sock = enumerate_handles(current->process, &sock_ops, &index)) ) + { + close_handle(current->process, sock); + } +} -- 2.3.2 (Apple Git-55) > On Aug 29, 2015, at 10:43 AM, Bruno Jesus <00cpxxx(a)gmail.com> wrote: > > On Sat, Aug 29, 2015 at 6:28 AM, Matt Durgavich <mattdurgavich(a)gmail.com> wrote: >> And the renaming patch > > Please attach a single patch that is based against the original file, > it's unnecessary harder to review an incremental patch.

Aug. 29, 2015

Re: Congratulations / thanks to our 2015 GSoC Students

by YongHao Hu

Thank you for giving me this opportunity. :) Thanks for Slackner, Piotr, QianHong and everyone else involved in giving input on my patches and teaching me knowledge about programming. It's a great summer and I did enjoy the coding in wine. Let's have Snacks that go well with Wine and be a Slacker for a while to celebrate! ;P On 15/8/29 上午4:42, Austin English wrote: > I wanted to send a note congratulating our Google Summer of Code > students for all passing their reviews, and thanking them for their > work on Wine this summer. > > I hope you've enjoyed working on Wine and will continue to work with > us in the future. >

Aug. 29, 2015