September 2015 - Wine-Devel

WineConf 2015 decisions

by Alexandre Julliard

Over the last few months there have been a lot of discussions about how to improve our development process. I've been gathering feedback, and last week at WineConf I summarized the suggestions in my keynote presentation; the slides can be viewed at http://wiki.winehq.org/WineConf2015?action=AttachFile&do=get&target=winecon… We've then had a lot of constructive discussions about the various points. The major decisions we've agreed on are: - Wine-staging is now considered an integral part of the Wine development process, and will be used as a mechanism to enable more patches to meet the requirements for inclusion in the main tree. We will all be working together as a team. - Bugs reported against wine-staging will be accepted in the WineHQ bug tracker; there will be a way to distinguish bugs specific to Staging, and bugs that are fixed in Staging but not yet in main Wine. The Staging bug tracker will be retired. Austin English is in charge of implementing the necessary changes in Bugzilla. - We will switch to a time-based stable release, on a yearly schedule. The code freeze will start every year in the fall. Michael Stefaniuc will be maintaining the stable branch starting with 1.8. - We will start enforcing a Signed-Off-By header on patches, to make it possible to better distribute reviewing responsibility, and to allow multiple authors to cooperate on a patch. - We will keep a list of maintainer contact information for the various submodules; developers will be encouraged to go through the respective maintainer before submitting to wine-patches. - There will be a group of people who volunteer to be assigned patches to review, to make sure that no patch goes unreviewed. Going through Staging first will also be encouraged for unfinished or risky patches. - The patch tracker will send automated emails when a patch status changes; this will also serve to encourage discussion rather than despair when a patch is not approved. - We will start building and distributing binary packages for all distros that don't have readily available packages. The packaging scripts and control files will be maintained in git, so that people can review them and submit improvements. These changes will be implemented over the next few weeks. I'm hoping that this will make the development process more pleasant for everybody, and enable us to better respond to users' needs. Once these changes are in place, I'll also encourage everybody who had given up in disgust to give us another chance; and if things are still not satisfactory, please send us feedback. This is a work in progress, and we will continue to listen and work on making things better. -- Alexandre Julliard julliard(a)winehq.org

Sept. 25, 2015

Re: user32/tests: Allow tracing in menu test

by Francois Gouget

On Thu, 24 Sep 2015, André Hentschel wrote: [...] > The sense behind this patch is that I have a task from wineconf to send AJ > a trace log of what happens before: > Test failed: id 205: wID should be equal to hSubMenu > on w2k8 systems. > Strange enough is that I can't reproduce it by manually testbot runs anymore. Sometimes a test does not fail when run on its own but does when run as part of WineTest because previous tests changed something. Typically they left a window open or something like it. But if you managed to reproduce the issue by running the test on its own before it may be something else. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ All generalizations are false, including this one. -- Mark Twain

Sept. 25, 2015

Re: [PATCH] [comctl32] Fix sizing of edit window for listview icon view

by Nikolay Sivov

On 25.09.2015 4:33, Barrett Karish wrote: > --- > dlls/comctl32/listview.c | 42 +++++++++++++++++++++++++----------------- > 1 file changed, 25 insertions(+), 17 deletions(-) > > diff --git a/dlls/comctl32/listview.c b/dlls/comctl32/listview.c > index e3fad51..ba227a7 100644 > --- a/dlls/comctl32/listview.c > +++ b/dlls/comctl32/listview.c > @@ -6048,12 +6048,15 @@ static LRESULT CALLBACK EditLblWndProcA(HWND hwnd, UINT uMsg, WPARAM wParam, LPA > */ > static HWND CreateEditLabelT(LISTVIEW_INFO *infoPtr, LPCWSTR text, BOOL isW) > { > - static const DWORD style = WS_CHILDWINDOW|WS_CLIPSIBLINGS|ES_LEFT|ES_AUTOHSCROLL|WS_BORDER|WS_VISIBLE; > - HINSTANCE hinst = (HINSTANCE)GetWindowLongPtrW(infoPtr->hwndSelf, GWLP_HINSTANCE); > + DWORD style = WS_CHILDWINDOW | WS_CLIPSIBLINGS | ES_LEFT | ES_AUTOHSCROLL | WS_BORDER | WS_VISIBLE | ES_MULTILINE; > + HINSTANCE hinst = (HINSTANCE)GetWindowLongPtrW(infoPtr->hwndSelf, GWLP_HINSTANCE); Hi, Barrett. Please use existing 4 space formatting and avoid unnecessary changes. > HWND hedit; > > TRACE("(%p, text=%s, isW=%d)\n", infoPtr, debugtext_t(text, isW), isW); > > + if (infoPtr->uView == LV_VIEW_ICON) > + style |= ES_CENTER; We need a test that proves that Edit gets centered style on icon view. > + > /* window will be resized and positioned after LVN_BEGINLABELEDIT */ > if (isW) > hedit = CreateWindowW(WC_EDITW, text, style, 0, 0, 0, 0, infoPtr->hwndSelf, 0, hinst, 0); > @@ -6093,7 +6096,6 @@ static HWND LISTVIEW_EditLabelT(LISTVIEW_INFO *infoPtr, INT nItem, BOOL isW) > HFONT hOldFont = NULL; > TEXTMETRICW tm; > RECT rect; > - SIZE sz; > HDC hdc; > > TRACE("(nItem=%d, isW=%d)\n", nItem, isW); > @@ -6152,24 +6154,30 @@ static HWND LISTVIEW_EditLabelT(LISTVIEW_INFO *infoPtr, INT nItem, BOOL isW) > GetWindowTextW(infoPtr->hwndEdit, disptextW, DISP_TEXT_SIZE); > TRACE("edit box text=%s\n", debugstr_w(disptextW)); > > - /* get string length in pixels */ > - GetTextExtentPoint32W(hdc, disptextW, lstrlenW(disptextW), &sz); > + DrawTextW(hdc, disptextW, -1, &rect, infoPtr->uView == LV_VIEW_ICON ? LV_FL_DT_FLAGS : LV_SL_DT_FLAGS | DT_CALCRECT); > > - /* add extra spacing for the next character */ > - GetTextMetricsW(hdc, &tm); > - sz.cx += tm.tmMaxCharWidth * 2; > + if (infoPtr->uView != LV_VIEW_ICON) > + { > + /* add extra spacing for the next character */ > + GetTextMetricsW(hdc, &tm); > + rect.right += tm.tmMaxCharWidth; > + rect.left -= 2; > + rect.top -= 1; > + rect.bottom += 2; > + } > + else > + { > + rect.bottom += 3; > + } > This should ideally use some font metrics instead of hardcoded magic, but I know we do it this way already. > - if (infoPtr->hFont) > - SelectObject(hdc, hOldFont); > + if (infoPtr->hFont) > + SelectObject(hdc, hOldFont); > > - ReleaseDC(infoPtr->hwndSelf, hdc); > + ReleaseDC(infoPtr->hwndSelf, hdc); > > - sz.cy = rect.bottom - rect.top + 2; > - rect.left -= 2; > - rect.top -= 1; > - TRACE("moving edit=(%d,%d)-(%d,%d)\n", rect.left, rect.top, sz.cx, sz.cy); > - MoveWindow(infoPtr->hwndEdit, rect.left, rect.top, sz.cx, sz.cy, FALSE); > - ShowWindow(infoPtr->hwndEdit, SW_NORMAL); > + TRACE("moving edit=(%d,%d)-(%d,%d)\n", rect.left, rect.top, rect.right - rect.left, rect.bottom - rect.top); > + MoveWindow(infoPtr->hwndEdit, rect.left, rect.top, rect.right - rect.left, rect.bottom - rect.top, FALSE); > + ShowWindow(infoPtr->hwndEdit, SW_NORMAL); > SetFocus(infoPtr->hwndEdit); > SendMessageW(infoPtr->hwndEdit, EM_SETSEL, 0, -1); > return infoPtr->hwndEdit; >

Sept. 25, 2015

Wine and Buildroot

by André Hentschel

Hi, For those interested, I just add an introduction of Buildroot to our Wine-Wiki: http://wiki.winehq.org/Buildroot See also my slides from WineConf2015: http://wiki.winehq.org/WineConf2015?action=AttachFile&do=get&target=otherar… And a short WWN article from March 2015: https://www.winehq.org/wwn/387#Wine%20in%20Buildroot

Sept. 24, 2015

Re: Videos or Slides from WineConf

by Joel Holdsworth

Thanks Stefan, I'm really looking forward to watching. Joel On 24/09/15 20:09, Stefan Dösinger wrote: > I am still working on the videos (done with the keynote and Jeremy White's talk, halfway done with Michael Stefanuic's), I expect that they're ready at the beginning of the next week. > > Cheers, > Stefan > >> Am 24.09.2015 um 18:19 schrieb André Hentschel <nerv(a)dawncrow.de>: >> >> I attached my slides on "The other Architectures" >> >> > > > >

Sept. 24, 2015

Re: Videos or Slides from WineConf

by Stefan Dösinger

I am still working on the videos (done with the keynote and Jeremy White's talk, halfway done with Michael Stefanuic's), I expect that they're ready at the beginning of the next week. Cheers, Stefan > Am 24.09.2015 um 18:19 schrieb André Hentschel <nerv(a)dawncrow.de>: > > I attached my slides on "The other Architectures" > >

Sept. 24, 2015

Re: user32/tests: Allow tracing in menu test

by Aaryaman Vasishta

On Thu, Sep 24, 2015 at 11:36 PM, André Hentschel <nerv(a)dawncrow.de> wrote: > Strange enough is that I can't reproduce it by manually testbot runs > anymore. > That's kinda odd. Could it be some kinda regression in the testbot itself? Cheers, Aaryaman

Sept. 24, 2015

Re: user32/tests: Allow tracing in menu test

by André Hentschel

Am 23.09.2015 um 05:54 schrieb Dmitry Timoshkov: > André Hentschel <nerv(a)dawncrow.de> wrote: > >> + if (winetest_debug > 1) >> + trace("item #%u: fType %04x, fState %04x, wID %u, hSubMenu %p\n", >> + i, mii.fType, mii.fState, mii.wID, mii.hSubMenu); > > Please use 4 spaces for indentation after 'if ()', not 8. Oops, done. > Also, what's the reason of this patch? There are several other similar > disabled debug traces in that file, anything special about this one? True, I fixed that. > And I'd suggest to simply replace if (0) by if (1) in the personal build > if you really need to see the traces. We have the feature of enabling it based on winetest_debug, so we should use that. The sense behind this patch is that I have a task from wineconf to send AJ a trace log of what happens before: Test failed: id 205: wID should be equal to hSubMenu on w2k8 systems. Strange enough is that I can't reproduce it by manually testbot runs anymore.

Sept. 24, 2015

Re: Videos or Slides from WineConf

by André Hentschel

I attached my slides on "The other Architectures"

Sept. 24, 2015

Re: Videos or Slides from WineConf

by Aric Stewart

I have attached the slides from my HID presentation for anyone who is interested. -aric

Sept. 24, 2015