January 2016 - Wine-Devel - list.winehq.org

Re: [6/6] shell32/tests: Add server-side DDE checks.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=20064 Your paranoid android. === w1064 (32 bit shlexec) === shlexec.c:2435: Test failed: failed: rc=29 err=2 shlexec.c:2433: Test failed: ShlexecVar expected 'Present', but key not found or empty shlexec.c:2435: Test failed: failed: rc=29 err=32 shlexec.c:2435: Test failed: failed: rc=29 err=2 shlexec.c:2433: Test failed: ShlexecVar expected 'Present', but key not found or empty shlexec.c:2435: Test failed: failed: rc=29 err=32 === w1064 (64 bit shlexec) === shlexec.c:2435: Test failed: failed: rc=29 err=2 shlexec.c:2435: Test failed: failed: rc=29 err=2 shlexec.c:2433: Test failed: ShlexecVar expected 'Present', but key not found or empty shlexec.c:2435: Test failed: failed: rc=29 err=32 shlexec.c:2447: Test failed: ddeExec expected '[ifexec("C:\Users\winetest\AppData\Local\Temp\wt209B.tmp\test file.sde")]', got '[open("C:\Users\winetest\AppData\Local\Temp\wt209B.tmp\test file.sde")]' shlexec.c:2435: Test failed: failed: rc=29 err=2 shlexec.c:2435: Test failed: failed: rc=29 err=2

Jan. 29, 2016

Re: [5/6] shell32/tests: Test environment variable inheritance with ShellExecute().

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=20063 Your paranoid android. === wvistau64 (32 bit shlexec) === shlexec.c:1666: Test failed: WaitForSingleObject returned 258 shlexec.c:1695: Test failed: argvA3 expected 'QuotedLowerL', got 'Open' shlexec.c:1703: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wtD4FA.tmp\test file.shlexec', got 'C:\Users\winetest\AppData\Local\Temp\wtD4FA.tmp\test file.noassoc.shlexec' shlexec.c:1695: Test failed: argvA3 expected 'QuotedUpperL', got 'QuotedLowerL' shlexec.c:1666: Test failed: ShlexecVar expected 'Present', but key not found or empty shlexec.c:1695: Test failed: argvA3 expected 'Open', but key not found or empty shlexec.c:1703: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wtD4FA.tmp\masked file.shlexec', but key not found or empty === w1064 (32 bit shlexec) === shlexec.c:2426: Test failed: failed: rc=29 err=2 shlexec.c:2424: Test failed: ShlexecVar expected 'Present', but key not found or empty shlexec.c:2426: Test failed: failed: rc=29 err=32 shlexec.c:2426: Test failed: failed: rc=29 err=2 shlexec.c:2424: Test failed: ShlexecVar expected 'Present', but key not found or empty shlexec.c:2426: Test failed: failed: rc=29 err=32 === w1064 (64 bit shlexec) === shlexec.c:2426: Test failed: failed: rc=29 err=2 shlexec.c:2426: Test failed: failed: rc=29 err=2 shlexec.c:2424: Test failed: ShlexecVar expected 'Present', but key not found or empty shlexec.c:2426: Test failed: failed: rc=29 err=32 shlexec.c:2438: Test failed: ddeExec expected '[ifexec("C:\Users\winetest\AppData\Local\Temp\wt9FCE.tmp\test file.sde")]', got '[open("C:\Users\winetest\AppData\Local\Temp\wt9FCE.tmp\test file.sde")]' shlexec.c:2426: Test failed: failed: rc=29 err=2 shlexec.c:2426: Test failed: failed: rc=29 err=2

Jan. 29, 2016

Re: [4/6] shell32/tests: Check for failures in the child process.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=20062 Your paranoid android. === w1064 (32 bit shlexec) === shlexec.c:2408: Test failed: failed: rc=29 err=2 shlexec.c:2408: Test failed: failed: rc=29 err=32 shlexec.c:2408: Test failed: failed: rc=29 err=2 shlexec.c:2408: Test failed: failed: rc=29 err=32 === w1064 (64 bit shlexec) === shlexec.c:2408: Test failed: failed: rc=29 err=2 shlexec.c:2408: Test failed: failed: rc=29 err=32 shlexec.c:2408: Test failed: failed: rc=29 err=2 shlexec.c:2408: Test failed: failed: rc=29 err=32

Jan. 29, 2016

Re: [3/6] shell32/tests: Check the child process exit code and close the process handle.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=20061 Your paranoid android. === w1064 (32 bit shlexec) === shlexec.c:2394: Test failed: failed: rc=29 err=2 shlexec.c:2394: Test failed: failed: rc=29 err=2 shlexec.c:2394: Test failed: failed: rc=29 err=2 shlexec.c:2394: Test failed: failed: rc=29 err=2 === w1064 (64 bit shlexec) === shlexec.c:2394: Test failed: failed: rc=29 err=2 shlexec.c:2394: Test failed: failed: rc=29 err=2 shlexec.c:2394: Test failed: failed: rc=29 err=2 shlexec.c:2394: Test failed: failed: rc=29 err=2

Jan. 28, 2016

Re: shell32/tests: Add traces to the WaitForInputIdle() hooking process.

by Francois Gouget

On Thu, 28 Jan 2016, Marvin wrote: [...] > === w1064 (32 bit shlexec) === > shlexec.c:2379: Test failed: failed: rc=29 err=2 > shlexec.c:2379: Test failed: failed: rc=29 err=2 > shlexec.c:2379: Test failed: failed: rc=29 err=2 > shlexec.c:2391: Test failed: ddeExec expected '[ifexec("C:\Users\winetest\AppData\Local\Temp\wt4CE4.tmp\test file.sde")]', got '[open("C:\Users\winetest\AppData\Local\Temp\wt4CE4.tmp\test file.sde")]' > shlexec.c:2379: Test failed: failed: rc=29 err=2 > shlexec.c:2379: Test failed: failed: rc=29 err=2 > > === w1064 (64 bit shlexec) === > shlexec.c:2379: Test failed: failed: rc=29 err=2 > shlexec.c:2379: Test failed: failed: rc=29 err=2 > shlexec.c:2379: Test failed: failed: rc=29 err=2 > shlexec.c:2379: Test failed: failed: rc=29 err=2 These are the usual Windows 10 DDE ShellExecute() failures. What's interesting is that I think the extra traces point to the reason for these failures. Unfortunately I don't know how to fix it. The extra traces (and a bit more) can be seen here: https://testbot.winehq.org/JobDetails.pl?Key=20056&log_207=1#k207 * There is a set of traces showing WaitForInputIdle() being replaced with our own implementation: shlexec.c:2318: Hooked USER32.dll.WaitForInputIdle * And then traces showing our implementation being called: shlexec.c:2258: WaitForInputIdle() waiting for dde event Except that on Windows 10 we never get the second set of traces which means we failed to override WaitForInputIdle(). Why override WaitForInputIdle()? Here it is from the source: * WaitForInputIdle() will normally return immediately for console apps. * That's a problem for us because ShellExecute will assume that an app * is ready to receive DDE messages after it has called * WaitForInputIdle() on that app. To work around that we install our * own version of WaitForInputIdle() that will wait for the child to * explicitly tell us that it is ready. We do that by changing the * entry for WaitForInputIdle() in the shell32 import address table. Does anyone know why hooking WaitForInputIdle() had no effect on Windows 10? -- Francois Gouget <fgouget(a)codeweavers.com>

Jan. 28, 2016

Re: [2/6] shell32/tests: Declare childPrintf() as a printf-style function.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=20060 Your paranoid android. === w1064 (32 bit shlexec) === shlexec.c:2389: Test failed: failed: rc=29 err=2 shlexec.c:2389: Test failed: failed: rc=29 err=2 shlexec.c:2389: Test failed: failed: rc=29 err=2 shlexec.c:2389: Test failed: failed: rc=29 err=2 === w1064 (64 bit shlexec) === shlexec.c:2389: Test failed: failed: rc=29 err=2 shlexec.c:2389: Test failed: failed: rc=29 err=2 shlexec.c:2389: Test failed: failed: rc=29 err=2 shlexec.c:2401: Test failed: ddeExec expected '[ifexec("C:\Users\winetest\AppData\Local\Temp\wt8341.tmp\test file.sde")]', got '[open("C:\Users\winetest\AppData\Local\Temp\wt8341.tmp\test file.sde")]' shlexec.c:2389: Test failed: failed: rc=29 err=2 shlexec.c:2389: Test failed: failed: rc=29 err=2

Jan. 28, 2016

Re: [1/6] shell32/tests: Reorder the functions to avoid forward declarations.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=20059 Your paranoid android. === w1064 (32 bit shlexec) === shlexec.c:2389: Test failed: failed: rc=29 err=2 shlexec.c:2389: Test failed: failed: rc=29 err=2 shlexec.c:2389: Test failed: failed: rc=29 err=2 shlexec.c:2389: Test failed: failed: rc=29 err=2 === w1064 (64 bit shlexec) === shlexec.c:2389: Test failed: failed: rc=29 err=2 shlexec.c:2389: Test failed: failed: rc=29 err=2 shlexec.c:2389: Test failed: failed: rc=29 err=2 shlexec.c:2389: Test failed: failed: rc=29 err=2

Jan. 28, 2016

Re: shell32/tests: Add traces to the WaitForInputIdle() hooking process.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=20058 Your paranoid android. === w1064 (32 bit shlexec) === shlexec.c:2379: Test failed: failed: rc=29 err=2 shlexec.c:2379: Test failed: failed: rc=29 err=2 shlexec.c:2379: Test failed: failed: rc=29 err=2 shlexec.c:2391: Test failed: ddeExec expected '[ifexec("C:\Users\winetest\AppData\Local\Temp\wt4CE4.tmp\test file.sde")]', got '[open("C:\Users\winetest\AppData\Local\Temp\wt4CE4.tmp\test file.sde")]' shlexec.c:2379: Test failed: failed: rc=29 err=2 shlexec.c:2379: Test failed: failed: rc=29 err=2 === w1064 (64 bit shlexec) === shlexec.c:2379: Test failed: failed: rc=29 err=2 shlexec.c:2379: Test failed: failed: rc=29 err=2 shlexec.c:2379: Test failed: failed: rc=29 err=2 shlexec.c:2379: Test failed: failed: rc=29 err=2

Jan. 28, 2016

Re: [1/3] scrrun: Implement filesys_DriveExists. (resend)

by Joachim Priesner

Am Donnerstag, 28. Januar 2016 schrieb Alexandre Julliard: > Joachim Priesner <joachim.priesner(a)web.de> writes: > > > - return E_NOTIMPL; > > + if (!pfExists) return E_POINTER; > > + *pfExists = VARIANT_FALSE; > > + len = SysStringLen(DriveSpec); > > + if (len >= 1 && DriveSpec[0] >= 'A' && DriveSpec[0] <= 'Z' > > + && (len < 2 || DriveSpec[1] == ':') > > + && (len < 3 || DriveSpec[2] == '\\')) { > > Surely lower-case drives should work too. Of course. Resent, along with some minor fixes to the other patches in the series.

Jan. 28, 2016

Re: [PATCH 2/2] shell32: Set the stream and storage attributes where needed.

by Huw Davies

On 28 Jan 2016, at 15:41, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > https://testbot.winehq.org/JobDetails.pl?Key=20039 > > Your paranoid android. > > > === w1064 (32 bit shlfolder) === > shlfolder.c:1591: Test failed: IShellFolder_GetDisplayNameOf(NULL) failed! hr = 80070057 This is an existing failure. Huw.

Jan. 28, 2016