November 2016 - Wine-Devel - list.winehq.org

Re: Donat Enikeev : crypt32/tests: Fix chain tests failure with cs.standford.edu certificates.

by Francois Gouget

On Tue, 22 Nov 2016, Huw Davies wrote: [...] > This has caused failures on some of Francois’ XP VMs. For example: > http://test.winehq.org/data/8a4508cecc4a6e46da200c85aa7d62515041f6e2/xp_fg-… Another more important place where tests fail is on Debian: https://test.winehq.org/data/0e8bb752b8c9423540086df114ee00114b24d493/linux… I believe Hans is planning to look into it but since this is fresh in your mind maybe you have ideas about it. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ The last time religion ruled, it was called the dark ages.

Nov. 23, 2016

Re: WineTest reference Linux machines

by Stefan Dösinger

> Am 22.11.2016 um 14:31 schrieb Francois Gouget <fgouget(a)codeweavers.com>: > > On Tue, 22 Nov 2016, Matteo Bruni wrote: > [...] >> FWIW, for the AMD box all those test failures but one in d3d9:visual >> are window messages-related and probably affected by the WM. >> >> Do you want to give a try to fvwm2 and see what happens? :D > > Sure. I installed fvwm 1:2.6.5.ds-3 and that should now be used by > default. Note that if you access the winetest account through the KVM > things are now really bare. But you can access the fvwm menu through a > left click and from there start an xterm. Fwiw, I didn’t forget that I said I’d look into those :-) . But first I need bring my Non-Nvidia box back to life, which will take a while. On The Nvidia laptop I have mysterious mode setting problems with xfce, and I think they’re related to our fallback to randr 1.1. The tests pass for me on KDE. Back when I wrote them they were reliable on fvwm2 when the focus behavior was set to click to focus. The default focus follows mouse works or fails depending on which windows you have in the top left corner of the screen. An early device.c test in d3d8/9 sets the mouse to 50/50, so the mouse position is somewhat deterministic unless you touch it while the test is running.

Nov. 22, 2016

Re: [PATCH 6/6] d3d9/tests: Add test for occlusion query with result bigger than UINT32_MAX.

by Alexandre Julliard

Józef Kucia <jkucia(a)codeweavers.com> writes: > Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> > --- > dlls/d3d9/tests/device.c | 87 +++++++++++++++++++++++++++++++++++++++++++----- > 1 file changed, 78 insertions(+), 9 deletions(-) This one fails here: ../../../tools/runtest -q -P wine -T ../../.. -M d3d9.dll -p d3d9_test.exe.so device && touch device.ok device.c:2291: Tests skipped: could not create device, IDirect3D9_CreateDevice returned 0x8876086c device.c:5666: Test failed: Failed to create render target, hr 0x8876017c. device.c:5670: Test failed: Failed to set render target, hr 0x8876086c. device.c:5705: Test failed: Got unexpected query result 0x0000000003f7a000. wine: Unhandled page fault on read access to 0x00000000 at address 0x7ecb5a48 (thread 00bd), starting debugger... Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x7ecb5a48). fixme:dbghelp_dwarf:dwarf2_parse_const_type Unsupported children Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:7ecb5a48 ESP:0032f484 EBP:0032f658 EFLAGS:00210212( R- -- I -A- - ) EAX:00000000 EBX:7ed3f000 ECX:0032f480 EDX:00000000 ESI:00000001 EDI:7ed15e7c Stack dump: 0x0032f484: 7ed198a4 00000000 03f7a000 04000000 0x0032f494: 7ed198a4 7ed12a3f 7ed13f78 00000001 0x0032f4a4: 001434b8 01390060 00000042 7ed15e7c 0x0032f4b4: 00000001 7ed1e200 7ed12a26 0032f4e0 0x0032f4c4: 00000000 03f7a000 00161970 00000000 0x0032f4d4: 00000000 0013ea60 0013aa30 03f7a000 Backtrace: =>0 0x7ecb5a48 test_occlusion_query+0xe58() [/home/julliard/wine/wine/dlls/d3d9/tests/device.c:5713] in d3d9_test (0x0032f658) 1 0x7ecbe103 func_device+0x4772() [/home/julliard/wine/wine/dlls/d3d9/tests/device.c:11382] in d3d9_test (0x0032fd68) 2 0x7ec85d9a main+0x379(argc=<is not available>, argv=<is not available>) [/home/julliard/wine/wine/dlls/d3d9/tests/../../../include/wine/test.h:589] in d3d9_test (0x0032fe18) 3 0x7ed124db __wine_spec_exe_entry+0x4a(peb=<couldn't compute location>) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in d3d9_test (0x0032fe58) 4 0x7b45e3cc call_process_entry+0xb() in kernel32 (0x0032fe78) 5 0x7b45f34a start_process+0x59(peb=<couldn't compute location>) [/home/julliard/wine/wine/dlls/kernel32/process.c:1108] in kernel32 (0x0032fea8) 6 0x7bc7fb8c call_thread_func_wrapper+0xb() in ntdll (0x0032fec8) 7 0x7bc8295f call_thread_func+0xde(entry=0x7b45f2f0, arg=0x7ffdf000, frame=0x32ffc8) [/home/julliard/wine/wine/dlls/ntdll/signal_i386.c:2759] in ntdll (0x0032ffa8) 8 0x7bc7fb6a call_thread_entry_point+0x11() in ntdll (0x0032ffc8) 9 0x7bc53587 start_process+0x16(kernel_start=0x7b45f2f0) [/home/julliard/wine/wine/dlls/ntdll/loader.c:3047] in ntdll (0x0032ffe8) 10 0xf755e8cd wine_call_on_stack+0x1c() in libwine.so.1 (0x00000000) 11 0xf755ea30 wine_switch_to_stack+0x1f(func=0x7bc53570, arg=0x7b45f2f0, stack=0x330000) [/home/julliard/wine/wine/libs/wine/port.c:77] in libwine.so.1 (0xffda6508) 12 0x7bc59279 LdrInitializeThunk+0x228(kernel_start=<couldn't compute location>, unknown2=<couldn't compute location>, unknown3=<couldn't compute location>, unknown4=<couldn't compute location>) [/home/julliard/wine/wine/dlls/ntdll/loader.c:3103] in ntdll (0xffda6548) 13 0x7b465179 __wine_kernel_init+0xa58() [/home/julliard/wine/wine/dlls/kernel32/process.c:1302] in kernel32 (0xffda7438) 14 0x7bc5a0c3 __wine_process_init+0x152() [/home/julliard/wine/wine/dlls/ntdll/loader.c:3312] in ntdll (0xffda74a8) 15 0xf755cac3 wine_init+0x2a2(argc=0x3, argv=0xffda79e4, error="", error_size=0x400) [/home/julliard/wine/wine/libs/wine/loader.c:956] in libwine.so.1 (0xffda74f8) 16 0x7c000a3a main+0x79(argc=<is not available>, argv=<is not available>) [/home/julliard/wine/wine/loader/main.c:254] in <wine-loader> (0xffda7938) 17 0xf736a276 __libc_start_main+0xf5() in libc.so.6 (0x00000000) 0x7ecb5a48 test_occlusion_query+0xe58 [/home/julliard/wine/wine/dlls/d3d9/tests/device.c:5713] in d3d9_test: movl 0x0(%eax),%edx 5713 IDirect3DSurface9_Release(rt); -- Alexandre Julliard julliard(a)winehq.org

Nov. 22, 2016

Re: Donat Enikeev : crypt32/tests: Fix chain tests failure with cs.standford.edu certificates.

by Alexandre Julliard

Donat Enikeev <donat(a)enikeev.net> writes: > Hi Huw, > > I will, though it would be not easy to find XP with Service Pack 1 > > In this context, and considering Wine is going to report itself as > Windows 7, could you or someone else clarify please whether testing on > XP SP1 (not the latest service pack 3) is being done for purpose? I don't think we care about older service packs anymore. If it's easy to fix we should do it, but otherwise, succeeding with the latest service pack is good enough. -- Alexandre Julliard julliard(a)winehq.org

Nov. 22, 2016

Re: Donat Enikeev : crypt32/tests: Fix chain tests failure with cs.standford.edu certificates.

by Donat Enikeev

Hi Francois, The question around purposes of using XP SP1 as testing platform is probably to you. I've just confirmed that tests are working on SP3 (below), so does it make sense to upgrade the testing environment to SP3? Meanwhile I am checking whether the most recent Debian 8.x fails the tests in oppose to the nightly failures reported Also you might probably want to consider Windows XP *Embedded* as the target testing platform. It seems much more important and sensible, as it has extended support and a lot of corporate software is still there, and *any* case when one decides to move it to Wine&Linux automatically brings level-up for all involved. What do you think? And yes, I could put another hack for the tests if XP SP1 support is crucial X:\winetmp>ver Microsoft Windows XP [Version 5.1.2600] X:\winetmp>crypt32_crosstest.exe chain chain.c:4430: Tests skipped: ignoredBadDateNestingBasePolicyCheck[0](#0001): error 00000000 doesn't match expected 800b0101, not checking indexes chain.c:4430: Tests skipped: ignoredInvalidDateBasePolicyCheck[0](#0001): error 00000000 doesn't match expected 800b0101, not checking indexes chain.c:4430: Tests skipped: ignoredInvalidUsageBasePolicyCheck[0](#0001): error 00000000 doesn't match expected 800b0101, not checking indexes chain.c:4430: Tests skipped: ignoredInvalidUsageBasePolicyCheck[0](#0001): error 00000000 doesn't match expected 800b0101, not checking indexes chain.c:4430: Tests skipped: invalidExtensionPolicyCheck[0](#0001): error 00000000 doesn't match expected 800b0105, not checking indexes chain.c:4677: Tests skipped: Couldn't create chain engine chain.c:4430: Tests skipped: ignoredInvalidDateBasePolicyCheck[0](#0002): error 00000000 doesn't match expected 800b0101, not checking indexes chain.c:4027: info[0] = 102 chain.c:4027: info[1] = 102 chain.c:4027: info[2] = 10a chain: 2678 tests executed (0 marked as todo, 0 failures), 7 skipped. Best, Donnie 22.11.2016, 12:32, "Donat Enikeev" <donat(a)enikeev.net>: > Hi Huw, > > I will, though it would be not easy to find XP with Service Pack 1 > > In this context, and considering Wine is going to report itself as Windows 7, could you or someone else clarify please whether testing on XP SP1 (not the latest service pack 3) is being done for purpose? > > Best, > Donnie > > 22.11.2016, 11:59, "Huw Davies" <huw(a)codeweavers.com>: >>> On 21 Nov 2016, at 21:28, Alexandre Julliard <julliard(a)winehq.org> wrote: >>> >>> Module: wine >>> Branch: master >>> Commit: 8a4508cecc4a6e46da200c85aa7d62515041f6e2 >>> URL: http://source.winehq.org/git/wine.git/?a=commit;h=8a4508cecc4a6e46da200c85a… >>> >>> Author: Donat Enikeev <donat(a)enikeev.net> >>> Date: Sat Nov 19 21:12:30 2016 +0300 >>> >>> crypt32/tests: Fix chain tests failure with cs.standford.edu certificates. >>> >>> Signed-off-by: Donat Enikeev <donat(a)enikeev.net> >>> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> >>> >>> --- >>> >>> dlls/crypt32/tests/chain.c | 658 ++++++++++++++++++++++++--------------------- >>> 1 file changed, 352 insertions(+), 306 deletions(-) >>> >>> Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=8a4508cecc4a6e46da200… >> >> Hi Donat, >> >> This has caused failures on some of Francois’ XP VMs. For example: >> http://test.winehq.org/data/8a4508cecc4a6e46da200c85aa7d62515041f6e2/xp_fg-… >> >> Could you take a look? >> >> Thanks, >> Huw.

Nov. 22, 2016

Re: [PATCH 1/2] gdi32: Initialize rgbReserved to zero in SetDIBColorTable

by Nikolay Sivov

On 11/22/2016 06:36 PM, Daniel Lehman wrote: > removes a TODO > > Signed-off-by: Daniel Lehman <dlehman25(a)gmail.com> > --- > dlls/gdi32/dib.c | 9 ++++++++- > dlls/gdi32/tests/bitmap.c | 3 ++- > 2 files changed, 10 insertions(+), 2 deletions(-) > > diff --git a/dlls/gdi32/dib.c b/dlls/gdi32/dib.c > index 36a7b0f..6636f23 100644 > --- a/dlls/gdi32/dib.c > +++ b/dlls/gdi32/dib.c > @@ -922,7 +922,7 @@ INT WINAPI SetDIBitsToDevice(HDC hdc, INT xDest, INT yDest, DWORD cx, > UINT WINAPI SetDIBColorTable( HDC hdc, UINT startpos, UINT entries, const RGBQUAD *colors ) > { > DC * dc; > - UINT result = 0; > + UINT i, result = 0; > BITMAPOBJ * bitmap; > > if (!(dc = get_dc_ptr( hdc ))) return 0; > @@ -933,6 +933,13 @@ UINT WINAPI SetDIBColorTable( HDC hdc, UINT startpos, UINT entries, const RGBQUA > { > result = min( entries, bitmap->dib.dsBmih.biClrUsed - startpos ); > memcpy(bitmap->color_table + startpos, colors, result * sizeof(RGBQUAD)); > + for (i = 0; i < result; i++) > + { > + bitmap->color_table[startpos + i].rgbBlue = colors[i].rgbBlue; > + bitmap->color_table[startpos + i].rgbGreen = colors[i].rgbGreen; > + bitmap->color_table[startpos + i].rgbRed = colors[i].rgbRed; > + bitmap->color_table[startpos + i].rgbReserved = 0; > + } > } Doesn't this make memcpy() redundant? A couple of options that could be used: - leave memcpy() and only reset rgbReserved() in the loop; - remove memcpy(); - remove memcpy(), add another memcpy() for a size of three fields instead of a quad, keep separate rgbReserved assignment; Not sure which one will be the fastest, could depend on 'result' value too. > GDI_ReleaseObj( dc->hBitmap ); > > diff --git a/dlls/gdi32/tests/bitmap.c b/dlls/gdi32/tests/bitmap.c > index 5539283..88250ca 100644 > --- a/dlls/gdi32/tests/bitmap.c > +++ b/dlls/gdi32/tests/bitmap.c > @@ -880,12 +880,13 @@ static void test_dibsections(void) > ok( ret == 1, "SetDIBColorTable returned unexpected result %u\n", ret ); > ok( rgb[0].rgbReserved == 123, "Expected rgbReserved = 123, got %u\n", rgb[0].rgbReserved ); > > + rgb[0].rgbRed = rgb[0].rgbGreen = rgb[0].rgbBlue = rgb[0].rgbReserved = -1; > ret = GetDIBColorTable( hdcmem, 0, 1, rgb ); > ok( ret == 1, "GetDIBColorTable returned unexpected result %u\n", ret ); > ok( rgb[0].rgbRed == 1, "Expected rgbRed = 1, got %u\n", rgb[0].rgbRed ); > ok( rgb[0].rgbGreen == 2, "Expected rgbGreen = 2, got %u\n", rgb[0].rgbGreen ); > ok( rgb[0].rgbBlue == 3, "Expected rgbBlue = 3, got %u\n", rgb[0].rgbBlue ); > - todo_wine ok( rgb[0].rgbReserved == 0, "Expected rgbReserved = 0, got %u\n", rgb[0].rgbReserved ); > + ok( rgb[0].rgbReserved == 0, "Expected rgbReserved = 0, got %u\n", rgb[0].rgbReserved ); > > SelectObject(hdcmem, oldbm); > DeleteObject(hdib);

Nov. 22, 2016

Re: Jeremy Newman : beginnings of HTML5 code and updating design

by Jeremy Newman

Ha! You are correct. Not sure what I was thinking. Fixed! -N November 22, 2016 9:10 AM, "Bruno Jesus" <00cpxxx(a)gmail.com> wrote: > On Tue, Nov 22, 2016 at 12:52 PM, Jeremy Newman <jnewman(a)codeweavers.com> wrote: > >> It is not required, so why add it? The only jquery-ui control we are using currently is dialog() >> for screenshots. If we start adding more jquery-ui controls, I'll add a theme. It will most likely >> be a custom theme-roller made one. > > I was not clear enough, sorry. You have added minified versions of the > other files, but added the standard file for jquery-ui. Why not also > use the minified version of jquery-ui? > > Standard: https://code.jquery.com/ui/1.11.4/themes/smoothness/jquery-ui.css > Minified: https://code.jquery.com/ui/1.11.4/themes/smoothness/jquery-ui.min.css

Nov. 22, 2016

Re: [PATCH 2/3] kernel32/tests: On failure don't test the returned count - it contains random data on Windows 8 and 10.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=26790 Your paranoid android. === w864 (32 bit console) === console.c:1322: Test failed: expected VerifyConsoleIoHandle to succeed === w1064 (32 bit console) === console.c:1322: Test failed: expected VerifyConsoleIoHandle to succeed === w1064 (64 bit console) === console.c:1322: Test failed: expected VerifyConsoleIoHandle to succeed

Nov. 22, 2016

Re: [PATCH 1/3] kernel32/tests: Add some GetLastError() values for Windows 8 and 10.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=26789 Your paranoid android. === w864 (32 bit console) === console.c:1322: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1497: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1497: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1497: Test failed: [13] Expected output count to be 0, got 2685552 console.c:1497: Test failed: [15] Expected output count to be 0, got 2685616 console.c:1497: Test failed: [18] Expected output count to be 3735928559, got 2685680 console.c:1741: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1741: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1741: Test failed: [13] Expected output count to be 0, got 2685552 console.c:1741: Test failed: [15] Expected output count to be 0, got 2685616 console.c:1741: Test failed: [18] Expected output count to be 3735928559, got 2685680 console.c:2200: Test failed: [7] Expected count to be 0, got 1 console.c:2266: Test failed: [7] Expected count to be 0, got 1 console.c:2332: Test failed: [7] Expected count to be 0, got 1 === w1064 (32 bit console) === console.c:1322: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1497: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1497: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1497: Test failed: [13] Expected output count to be 0, got 51 console.c:1497: Test failed: [15] Expected output count to be 0, got 43 console.c:1497: Test failed: [18] Expected output count to be 3735928559, got 43 console.c:1741: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1741: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1741: Test failed: [13] Expected output count to be 0, got 51 console.c:1741: Test failed: [15] Expected output count to be 0, got 43 console.c:1741: Test failed: [18] Expected output count to be 3735928559, got 43 console.c:2200: Test failed: [7] Expected count to be 0, got 1 console.c:2266: Test failed: [7] Expected count to be 0, got 1 console.c:2332: Test failed: [7] Expected count to be 0, got 1 === w1064 (64 bit console) === console.c:1322: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1497: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1497: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1497: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:1741: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1741: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1741: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:2200: Test failed: [7] Expected count to be 0, got 1 console.c:2266: Test failed: [7] Expected count to be 0, got 1 console.c:2332: Test failed: [7] Expected count to be 0, got 1

Nov. 22, 2016

Re: [PATCH 2/6] wined3d: Increase data size for occlusion queries to 8 bytes.

by Henri Verbeet

On 21 November 2016 at 15:15, Józef Kucia <jkucia(a)codeweavers.com> wrote: > @@ -115,7 +115,9 @@ static DWORD WINAPI d3d9_query_GetDataSize(IDirect3DQuery9 *iface) > > wined3d_mutex_lock(); > type = wined3d_query_get_type(query->wined3d_query); > - if (type == WINED3D_QUERY_TYPE_TIMESTAMP_DISJOINT) > + if (type == WINED3D_QUERY_TYPE_OCCLUSION) > + ret = sizeof(DWORD); We probably don't care that much, but note that this only works with little-endian byte order.

Nov. 22, 2016