November 2016 - Wine-Devel - list.winehq.org

Re: [PATCH v2] msvcrt: Add _lfind_s

by Piotr Caban

Hi Daniel, it fails to compile: ../../tools/winegcc/winegcc -o api-ms-win-crt-utility-l1-1-0.dll.so -B../../tools/winebuild -m32 -fasynchronous-unwind-tables -shared ../../../wine_src/dlls/api-ms-win-crt-utility-l1-1-0/api-ms-win-crt-utility-l1-1-0.spec \ ../../libs/port/libwine_port.a ../../../wine_src/dlls/api-ms-win-crt-utility-l1-1-0/api-ms-win-crt-utility-l1-1-0.spec:6: function '_lfind_s' not defined winegcc: ../../tools/winebuild/winebuild failed Makefile:166: recipe for target 'api-ms-win-crt-utility-l1-1-0.dll.so' failed make[1]: *** [api-ms-win-crt-utility-l1-1-0.dll.so] Error 2 Thank you, Piotr

Nov. 24, 2016

Re: [PATCH] d2d1: Implement retrieving dash pattern data for stroke styles

by Nikolay Sivov

On 24.11.2016 14:08, Henri Verbeet wrote: > On 23 November 2016 at 18:09, Nikolay Sivov <nsivov(a)codeweavers.com> wrote: >> -static void STDMETHODCALLTYPE d2d_stroke_style_GetDashes(ID2D1StrokeStyle *iface, float *dashes, UINT32 count) >> +static void STDMETHODCALLTYPE d2d_stroke_style_GetDashes(ID2D1StrokeStyle *iface, float *dashes, UINT32 dash_count) >> { >> - FIXME("iface %p, dashes %p, count %u stub!\n", iface, dashes, count); >> + struct d2d_stroke_style *style = impl_from_ID2D1StrokeStyle(iface); >> + >> + TRACE("iface %p, dashes %p, count %u.\n", iface, dashes, dash_count); >> + >> + memcpy(dashes, style->dashes, min(style->dash_count, dash_count) * sizeof(*dashes)); >> + if (dash_count > style->dash_count) >> + memset(dashes, 0, (dash_count - style->dash_count) * sizeof(*dashes)); > That doesn't look right. > Oh, right. That means GetGradientStops() is broken too. Are you okay with keeping memset() or it's better to explicitly set them to 0.0f?

Nov. 24, 2016

Re: [PATCH] d2d1: Implement retrieving dash pattern data for stroke styles

by Henri Verbeet

On 23 November 2016 at 18:09, Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > -static void STDMETHODCALLTYPE d2d_stroke_style_GetDashes(ID2D1StrokeStyle *iface, float *dashes, UINT32 count) > +static void STDMETHODCALLTYPE d2d_stroke_style_GetDashes(ID2D1StrokeStyle *iface, float *dashes, UINT32 dash_count) > { > - FIXME("iface %p, dashes %p, count %u stub!\n", iface, dashes, count); > + struct d2d_stroke_style *style = impl_from_ID2D1StrokeStyle(iface); > + > + TRACE("iface %p, dashes %p, count %u.\n", iface, dashes, dash_count); > + > + memcpy(dashes, style->dashes, min(style->dash_count, dash_count) * sizeof(*dashes)); > + if (dash_count > style->dash_count) > + memset(dashes, 0, (dash_count - style->dash_count) * sizeof(*dashes)); That doesn't look right.

Nov. 24, 2016

Re: Wineconf wrap up

by Francois Gouget

On Sat, 19 Nov 2016, Marcus Meissner wrote: [...] > My pictures are at: > > https://www.flickr.com/photos/marcusmeissner/sets/72157676817552305 I have uploaded mine to: http://fgouget.free.fr/tmp/201611-WineConf/index.html You can also download the original pictures here: http://fgouget.free.fr/tmp/201611-WineConf.zip -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ 145 = 1! + 4! + 5!

Nov. 24, 2016

Re: Donat Enikeev : crypt32/tests: Fix chain tests failure with cs.standford.edu certificates.

by Alasdair Sinclair

Donat Those tests are mine, run on my laptop. It's running Fedora 25, its just running on the intel 4000 graphics, I also run the winetest exe from winehq, which can sometimes give different results than make test. Regards Alasdair On Wed, 23 Nov 2016 at 19:56 Donat Enikeev <donat(a)enikeev.net> wrote: > Thank you, looking forward > > Meanwhile, could you please clarify what distributions are on VMs with > as-f25-* prefix (like as-f25-win64)? I see chain tests are failing there as > well, but for google > > Best, > Donnie > > >

Nov. 24, 2016

Re: Donat Enikeev : crypt32/tests: Fix chain tests failure with cs.standford.edu certificates.

by Alasdair Sinclair

On Wed, 23 Nov 2016, 19:56 Donat Enikeev, <donat(a)enikeev.net> wrote: > Thank you, looking forward > > Meanwhile, could you please clarify what distributions are on VMs with > as-f25-* prefix (like as-f25-win64)? I see chain tests are failing there as > well, but for google > > Best, > Donnie > >

Nov. 24, 2016

Re: [PATCH] wincodecs: Trigger conversion to target format in WriteSource()

by Dmitry Timoshkov

Vincent Povirk <madewokherd(a)gmail.com> wrote: > > Despite the removing a questionable FIXME this part of the code won't do > > what you think it does. > > I think it will request a specific pixel format, and the encoder may > actually set a different format if it does not support that one. Am I > missing something? That's correct. > > Besides, since there is no a single todo_wine > > removed with this patch adding a bunch of tests for different encoders > > is needed to show that the automatic conversion is really supposed to > > happen, and that it doesn't depend on the implementation detail in some > > of the encoders. According to my testing not every encoder does this > > kind of thing, especially when a conversion needs a palette. > > As long as some of them do, it makes sense to have it in common code, > and if we need to refine the behavior for individual encoders we can > do that later. First thing to do (as usually) is to write some tests to see that auto- conversion actually is supposed to happen. Most likely In reality a target encoder simply needs to be fixed in order to support the missing format natively. -- Dmitry.

Nov. 23, 2016

Re: Donat Enikeev : crypt32/tests: Fix chain tests failure with cs.standford.edu certificates.

by Francois Gouget

On Wed, 23 Nov 2016, Donat Enikeev wrote: > Thank you, looking forward > > Meanwhile, could you please clarify what distributions are on VMs with > as-f25-* prefix (like as-f25-win64)? I see chain tests are failing > there as well, but for google Those are not mine so I have no idea. f25 would suggest Fedora 25. You can find the person managing the machine (likely not a VM) on the test result's information page: https://test.winehq.org/data/0e8bb752b8c9423540086df114ee00114b24d493/linux… -- Francois Gouget <fgouget(a)codeweavers.com>

Nov. 23, 2016

Re: Donat Enikeev : crypt32/tests: Fix chain tests failure with cs.standford.edu certificates.

by Donat Enikeev

Thank you, looking forward Meanwhile, could you please clarify what distributions are on VMs with as-f25-* prefix (like as-f25-win64)? I see chain tests are failing there as well, but for google Best, Donnie 23.11.2016, 21:46, "Francois Gouget" <fgouget(a)codeweavers.com>: > On Wed, 23 Nov 2016, Donat Enikeev wrote: > >> Hi Francois, >> >> > Another more important place where tests fail is on Debian >> >> Yes, I saw that nightly failures, and has started downloading latest >> Debian ISO to confirm that the packages are outdated >> >> > but since this is fresh in your mind maybe you have ideas about it. >> >> I believe the distribution should be updated - there are Debians >> without the failures like fg-acer64-t32 > > I have upgraded cw1's ca-certificates package to the latest from Debian > Stable, that is 20141019+deb8u1. It still seems old particularly > compared to my laptop (fg-acer64-t32, Debian Testing) which has > 20160104. But Debian usually backports updates to Stable rather than > upgrading to the latest upstream. > > A make chain.ok succeeded so that seems encouraging. If that > works out I will update cw2 also. > > -- > Francois Gouget <fgouget(a)codeweavers.com>

Nov. 23, 2016

Re: Donat Enikeev : crypt32/tests: Fix chain tests failure with cs.standford.edu certificates.

by Francois Gouget

On Wed, 23 Nov 2016, Donat Enikeev wrote: > > Hi Francois, > > > Another more important place where tests fail is on Debian > > Yes, I saw that nightly failures, and has started downloading latest > Debian ISO to confirm that the packages are outdated > > > but since this is fresh in your mind maybe you have ideas about it. > > I believe the distribution should be updated - there are Debians > without the failures like fg-acer64-t32 I have upgraded cw1's ca-certificates package to the latest from Debian Stable, that is 20141019+deb8u1. It still seems old particularly compared to my laptop (fg-acer64-t32, Debian Testing) which has 20160104. But Debian usually backports updates to Stable rather than upgrading to the latest upstream. A make chain.ok succeeded so that seems encouraging. If that works out I will update cw2 also. -- Francois Gouget <fgouget(a)codeweavers.com>

Nov. 23, 2016