December 2016 - Wine-Devel - list.winehq.org

Can't build crosstests

by Fabian Maurer

Hello, I'm trying to build the tests for windows, but I can't get it working anymore. I have mingw installed and it does work for cross-compiling with code-blocks, but wine says it's broken. The configure script fails with >checking for i686-w64-mingw32-gcc... i686-w64-mingw32-gcc >checking whether i686-w64-mingw32-gcc works... no An idea how to find out what's going wrong?

Dec. 20, 2016

Re: [PATCH] gdiplus/tests: Test for initial properties of adjustable arrow caps

by Nikolay Sivov

On 19.12.2016 20:46, Vincent Povirk wrote: > On Fri, Dec 16, 2016 at 6:21 AM, Nikolay Sivov <nsivov(a)codeweavers.com> wrote: >> + stat = GdipGetCustomLineCapBaseInset((GpCustomLineCap*)cap, &inset); >> + ok(stat == Ok, "Unexpected return code, %d\n", stat); >> + > It isn't enough to reject the patch, but I'm curious why you don't > test this value. > > I only tested this briefly, inset depends on width/height ratio. It felt like one test is not enough, so I decided to leave it to come back later. That of course means I can remove this call altogether.

Dec. 19, 2016

Re: [PATCH] gdiplus/tests: Test for initial properties of adjustable arrow caps

by Vincent Povirk

On Fri, Dec 16, 2016 at 6:21 AM, Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > + stat = GdipGetCustomLineCapBaseInset((GpCustomLineCap*)cap, &inset); > + ok(stat == Ok, "Unexpected return code, %d\n", stat); > + It isn't enough to reject the patch, but I'm curious why you don't test this value.

Dec. 19, 2016

Re: shell32/tests: Skip SHFileOperationW tests if the user doesn't have admin rights.

by Hans Leidekker

On Mon, 2016-12-19 at 14:38 +0300, Nikolay Sivov wrote: > > diff --git a/dlls/shell32/tests/shlfileop.c b/dlls/shell32/tests/shlfileop.c > > index 0e502fc..776da98 100644 > > --- a/dlls/shell32/tests/shlfileop.c > > +++ b/dlls/shell32/tests/shlfileop.c > > @@ -819,7 +819,7 @@ static void test_rename(void) > > retval == DE_DIFFDIR || /* Vista */ > > broken(retval == DE_OPCANCELLED) || /* Win9x */ > > broken(retval == 65652), /* NT4 */ > > - "Expected ERROR_CANCELLED or DE_DIFFDIR\n"); > > + "Expected ERROR_CANCELLED or DE_DIFFDIR, got %u\n", retval); > > ok(file_exists("test1.txt"), "Expected test1.txt to exist\n"); > > > > /* pFrom is empty */ > > @@ -2516,6 +2516,11 @@ static void test_unicode(void) > > skip("Unicode tests skipped on non-unicode system\n"); > > return; > > } > > + if (GetLastError()==ERROR_ACCESS_DENIED) > > + { > > + skip("test needs admin rights\n"); > > + return; > > + } > > CloseHandle(file); > > > > /* Try to delete a file with unicode filename */ > > @@ -2574,6 +2579,7 @@ static void test_unicode(void) > > ok(GetLastError() == ERROR_SUCCESS || > > broken(GetLastError() == ERROR_INVALID_HANDLE), /* WinXp, win2k3 */ > > "Expected ERROR_SUCCESS, got %d\n", GetLastError()); > > + DeleteFileW(UNICODE_PATH_TO); > > > > /* Check last error after a failed file operation. */ > > DeleteFileW(UNICODE_PATH); > Will it work if user temp directory was used instead of current > directory or C: root? Yes, running it from a temporary directory instead of c: makes the failure go away.

Dec. 19, 2016

Re: shell32/tests: Skip SHFileOperationW tests if the user doesn't have admin rights.

by Nikolay Sivov

On 19.12.2016 13:38, Hans Leidekker wrote: > Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> > --- > dlls/shell32/tests/shlfileop.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/dlls/shell32/tests/shlfileop.c b/dlls/shell32/tests/shlfileop.c > index 0e502fc..776da98 100644 > --- a/dlls/shell32/tests/shlfileop.c > +++ b/dlls/shell32/tests/shlfileop.c > @@ -819,7 +819,7 @@ static void test_rename(void) > retval == DE_DIFFDIR || /* Vista */ > broken(retval == DE_OPCANCELLED) || /* Win9x */ > broken(retval == 65652), /* NT4 */ > - "Expected ERROR_CANCELLED or DE_DIFFDIR\n"); > + "Expected ERROR_CANCELLED or DE_DIFFDIR, got %u\n", retval); > ok(file_exists("test1.txt"), "Expected test1.txt to exist\n"); > > /* pFrom is empty */ > @@ -2516,6 +2516,11 @@ static void test_unicode(void) > skip("Unicode tests skipped on non-unicode system\n"); > return; > } > + if (GetLastError()==ERROR_ACCESS_DENIED) > + { > + skip("test needs admin rights\n"); > + return; > + } > CloseHandle(file); > > /* Try to delete a file with unicode filename */ > @@ -2574,6 +2579,7 @@ static void test_unicode(void) > ok(GetLastError() == ERROR_SUCCESS || > broken(GetLastError() == ERROR_INVALID_HANDLE), /* WinXp, win2k3 */ > "Expected ERROR_SUCCESS, got %d\n", GetLastError()); > + DeleteFileW(UNICODE_PATH_TO); > > /* Check last error after a failed file operation. */ > DeleteFileW(UNICODE_PATH); Will it work if user temp directory was used instead of current directory or C: root?

Dec. 19, 2016

Re: shell32/tests: Skip SHFileOperationW tests if the user doesn't have admin rights.

by Hans Leidekker

On Mon, 2016-12-19 at 04:54 -0600, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > https://testbot.winehq.org/JobDetails.pl?Key=27406 > > Your paranoid android. > > > === wvistau64 (32 bit shlfileop) === > shlfileop.c:818: Test failed: Expected ERROR_CANCELLED or DE_DIFFDIR, got 128 > > === wvistau64 (64 bit shlfileop) === > shlfileop.c:818: Test failed: Expected ERROR_CANCELLED or DE_DIFFDIR, got 128 This test also fails with a whitespace patch: https://testbot.winehq.org/JobDetails.pl?Key=27409

Dec. 19, 2016

Re: shell32/tests: Skip SHFileOperationW tests if the user doesn't have admin rights.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27406 Your paranoid android. === wvistau64 (32 bit shlfileop) === shlfileop.c:818: Test failed: Expected ERROR_CANCELLED or DE_DIFFDIR, got 128 === wvistau64 (64 bit shlfileop) === shlfileop.c:818: Test failed: Expected ERROR_CANCELLED or DE_DIFFDIR, got 128

Dec. 19, 2016

Re: [PATCH] webservices: free the potentially allocated pointer (Coverity)

by Marcus Meissner

On Mon, Dec 19, 2016 at 09:14:16AM +0100, Hans Leidekker wrote: > On Sat, 2016-12-17 at 12:48 +0100, Marcus Meissner wrote: > > 1374356 Resource leak > > > > Signed-off-by: Marcus Meissner <marcus(a)jet.franken.de> > > --- > > dlls/webservices/reader.c | 26 ++++++++++++++++++++++---- > > 1 file changed, 22 insertions(+), 4 deletions(-) > > > > diff --git a/dlls/webservices/reader.c b/dlls/webservices/reader.c > > index d67c47a701..219683b2af 100644 > > --- a/dlls/webservices/reader.c > > +++ b/dlls/webservices/reader.c > > @@ -4701,15 +4701,33 @@ static ULONG get_field_size( const WS_FIELD_DESCRIPTION *desc ) > > > > static HRESULT read_param( struct reader *reader, const WS_FIELD_DESCRIPTION *desc, WS_HEAP *heap, void *ret ) > > { > > - if (!ret && !(ret = ws_alloc_zero( heap, get_field_size(desc) ))) return WS_E_QUOTA_EXCEEDED; > > - return read_type_struct_field( reader, desc, heap, ret, 0 ); > > + HRESULT hr; > > + VOID *xret = NULL; > > + > > + if (!ret) > > + { > > + if (!(xret = ws_alloc_zero( heap, get_field_size(desc) ))) return WS_E_QUOTA_EXCEEDED; > > + ret = xret; > > + } > > + hr = read_type_struct_field( reader, desc, heap, ret, 0 ); > > + ws_free( heap, xret); > > + return hr; > > } > > It's not a leak. The memory is allocated on the heap passed to this function and it will > be released when the heap is destroyed. I guess Coverity doesn't see that. Yes, it does not think in Heaps. Will mark the issue as invalid. Ciao, Marcus

Dec. 19, 2016

Re: [PATCH 2/4] ddraw: Subtract framebuffer size from reported available video memory.

by Henri Verbeet

On 18 December 2016 at 00:22, Józef Kucia <jkucia(a)codeweavers.com> wrote: > + INT64 total_vidmem, free_vidmem; ... > + free_vidmem = wined3d_device_get_available_texture_mem(ddraw->wined3d_device); > + *free = max(0, free_vidmem - framebuffer_size); This works, but it seems a little silly to use INT64 to avoid writing something along the lines of "*free = framebuffer_size > free_vidmem ? 0 : free_vidmem - framebuffer_size;".

Dec. 19, 2016

Re: [PATCH] webservices: free the potentially allocated pointer (Coverity)

by Hans Leidekker

On Sat, 2016-12-17 at 12:48 +0100, Marcus Meissner wrote: > 1374356 Resource leak > > Signed-off-by: Marcus Meissner <marcus(a)jet.franken.de> > --- > dlls/webservices/reader.c | 26 ++++++++++++++++++++++---- > 1 file changed, 22 insertions(+), 4 deletions(-) > > diff --git a/dlls/webservices/reader.c b/dlls/webservices/reader.c > index d67c47a701..219683b2af 100644 > --- a/dlls/webservices/reader.c > +++ b/dlls/webservices/reader.c > @@ -4701,15 +4701,33 @@ static ULONG get_field_size( const WS_FIELD_DESCRIPTION *desc ) > > static HRESULT read_param( struct reader *reader, const WS_FIELD_DESCRIPTION *desc, WS_HEAP *heap, void *ret ) > { > - if (!ret && !(ret = ws_alloc_zero( heap, get_field_size(desc) ))) return WS_E_QUOTA_EXCEEDED; > - return read_type_struct_field( reader, desc, heap, ret, 0 ); > + HRESULT hr; > + VOID *xret = NULL; > + > + if (!ret) > + { > + if (!(xret = ws_alloc_zero( heap, get_field_size(desc) ))) return WS_E_QUOTA_EXCEEDED; > + ret = xret; > + } > + hr = read_type_struct_field( reader, desc, heap, ret, 0 ); > + ws_free( heap, xret); > + return hr; > } It's not a leak. The memory is allocated on the heap passed to this function and it will be released when the heap is destroyed. I guess Coverity doesn't see that.

Dec. 19, 2016