February 2016 - Wine-Devel - list.winehq.org

Re: kernel32: Add test MultiByteToWideChar for code page is 936. (try 2)

by Alexandre Julliard

Changhui LIU <chliu027028(a)gmail.com> writes: > + BOOL vistaOrLater = FALSE; > + OSVERSIONINFOA osvi; > + > + memset(&osvi, 0, sizeof(osvi)); > + osvi.dwOSVersionInfoSize = sizeof(osvi); > + GetVersionExA(&osvi); > + vistaOrLater = (osvi.dwMajorVersion > 5); Please don't do version checks in tests. You can mark the old behavior as broken if necessary. -- Alexandre Julliard julliard(a)winehq.org

Feb. 5, 2016

Re: [PATCH 2/3] msvcp110: Add tr2_sys__Symlink implementation and test.

by YongHao Hu

Hi, Piotr. Sorry for the late reply. On 16/1/12 下午9:28, Piotr Caban wrote: > On 01/11/16 14:56, YongHao Hu wrote: >> + delete_flag = 1; >> + for(i=0; i<sizeof(tests)/sizeof(tests[0]); i++) { >> + errno = 0xdeadbeef; >> + SetLastError(0xdeadbeef); >> + ret = p_tr2_sys__Symlink(tests[i].existing_path, >> tests[i].new_path); >> + if(ret==ERROR_PRIVILEGE_NOT_HELD || >> ret==ERROR_INVALID_FUNCTION) { >> + delete_flag = 0; >> + tests[i].last_error = ret; >> + win_skip("Privilege not held or symbolic link not >> supported, skipping symbolic link tests.\n"); > I think it would be nicer if the tests are really skipped in this > case. Please detect such case and return from the function instead of > adding workarounds in the code for it. > Could you explain a bit more details？ Thanks.

Feb. 5, 2016

Re: [v5 PATCH 1/2] gdiplus: Implement GdipSetPenTransform

by Alistair Leslie-Hughes

On 05/02/16 18:22, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > https://testbot.winehq.org/JobDetails.pl?Key=20197 > > Your paranoid android. > > > === build (build) === > Patch failed to apply > It would appear that the testbot source is out of date. These patches apply cleanly git tree. Best Regards Alistair Leslie-Hughes

Feb. 5, 2016

Re: [v5 PATCH 2/2] gdiplus: Implement GdipResetPenTransform

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=20198 Your paranoid android. === build (build) === Patch failed to apply

Feb. 5, 2016

Re: [v5 PATCH 1/2] gdiplus: Implement GdipSetPenTransform

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=20197 Your paranoid android. === build (build) === Patch failed to apply

Feb. 5, 2016

Re: [v5 PATCH 2/2] gdiplus: Implement GdipResetPenTransform

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=20195 Your paranoid android. === build (build) === Patch failed to apply

Feb. 5, 2016

Re: [v5 PATCH 1/2] gdiplus: Implement GdipSetPenTransform

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=20194 Your paranoid android. === build (build) === Patch failed to apply

Feb. 5, 2016

Re: [PATCH] dwrite/tests: Remove failing test line, we have skips for this now

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=20191 Your paranoid android. === build (build) === Patch failed to apply

Feb. 5, 2016

Re: [v4 PATCH 2/3] gdiplus: Implement GdipSetPenTransform

by Vincent Povirk

Why did you remove the TRACE from this function?

Feb. 4, 2016

Re: [PATCH 3/6] wined3d: Add support for separate sRGB formats.

by Józef Kucia

On Thu, Feb 4, 2016 at 3:57 PM, Henri Verbeet <hverbeet(a)gmail.com> wrote: > On 4 February 2016 at 01:17, Józef Kucia <jkucia(a)codeweavers.com> wrote: >> - factory->wined3d = wined3d_create(0); >> + factory->wined3d = wined3d_create(WINED3D_SEPARATE_SRGB_FORMATS); > In some ways I like this, although I wonder if it wouldn't make more > sense to handle this in terms of a flag to enable support for > SRGB_READ/SRGB_WRITE. I.e., when WINED3D_SAMP_SRGB_TEXTURE and > WINED3D_RS_SRGBWRITEENABLE are supported, WINED3DFMT_R8G8B8A8_UNORM > and WINED3DFMT_R8G8B8A8_UNORM_SRGB would effectively be the same, > while when they aren't you'd get the d3d10+ behaviour. I'll explore this option. >> diff --git a/dlls/wined3d/utils.c b/dlls/wined3d/utils.c >> index 1904dd1..718aa18 100644 >> --- a/dlls/wined3d/utils.c >> +++ b/dlls/wined3d/utils.c >> @@ -58,8 +58,11 @@ static const struct wined3d_format_channels formats[] = >> {WINED3DFMT_DXT4, 0, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0}, >> {WINED3DFMT_DXT5, 0, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0}, >> {WINED3DFMT_BC1_UNORM, 0, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0}, >> + {WINED3DFMT_BC1_UNORM_SRGB, 0, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0}, >> {WINED3DFMT_BC2_UNORM, 0, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0}, >> + {WINED3DFMT_BC2_UNORM_SRGB, 0, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0}, >> {WINED3DFMT_BC3_UNORM, 0, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0}, >> + {WINED3DFMT_BC3_UNORM_SRGB, 0, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0}, >> {WINED3DFMT_MULTI2_ARGB8, 0, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0}, >> {WINED3DFMT_G8R8_G8B8, 0, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0}, >> {WINED3DFMT_R8G8_B8G8, 0, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0}, > One thought I have about this is that we could just store the channel > sizes and shifts for the typeless formats, and then have the typed > formats copy the information from there, perhaps instead of the > format_base_flags[] table we have now. So you'd have something like > this: > {WINED3DFMT_R8G8B8A8_UNORM, WINED3DFMT_R8G8B8A8_TYPELESS, > UNORM, UNORM, UNORM, UNORM} > {WINED3DFMT_R8G8B8A8_UNORM_SRGB, WINED3DFMT_R8G8B8A8_TYPELESS, > UNORM, UNORM, UNORM, UNORM} > {WINED3DFMT_R8G8B8A8_SNORM, WINED3DFMT_R8G8B8A8_TYPELESS, > SNORM, SNORM, SNORM, SNORM} > {WINED3DFMT_R8G8B8A8_UINT, WINED3DFMT_R8G8B8A8_TYPELESS, > UINT, UINT, UINT, UINT} > {WINED3DFMT_R8G8B8A8_SINT, WINED3DFMT_R8G8B8A8_TYPELESS, > SINT, SINT, SINT, SINT} I'll keep this in mind when extending support for typeless formats.

Feb. 4, 2016