February 2016 - Wine-Devel - list.winehq.org

Re: [PATCH] comdlg32: Use SetDlgItemInt() instead of writing number manually.

by Sebastian Lackner

On 26.02.2016 10:41, carlo.bramix(a)libero.it wrote: > Hello friends, > I have sent this patch: > > https://source.winehq.org/patches/data/119492 > > but it has been put in "Formatting" state and I cannot understand why. Could you help me and tell me what's wrong, so I will use more attention next time? > Thank you very much. > > Sincerely, > > Carlo Bramini. > You forgot to add a "Signed-off-by:"-line. Since WineConf 2015, this line is used to indicate that you take responsibility for your patch and is a necessary requirement to get patches accepted. Could you please resend the patch? As Nikolay already suggested to you a while ago, you might want to change your git settings to add a Signed-off-by: line automatically. Regards, Sebastian

Feb. 26, 2016

Re: [PATCH 2/2] Programs: Load device drivers of the same group into the same winedevice process

by Aric Stewart

Thank you for looking over my patches. On 2/25/16 11:30 PM, Sebastian Lackner wrote: > On 24.02.2016 15:16, Aric Stewart wrote: >> Signed-off-by: Aric Stewart <aric(a)codeweavers.com> >> --- >> programs/services/services.c | 124 ++++++++++++++++++++++++++++ >> programs/winedevice/device.c | 191 ++++++++++++++++++++++++++++++++++++------- >> 2 files changed, 286 insertions(+), 29 deletions(-) >> > > Although the general idea seems fine, the patches are still very hacky, and I fear > we need a better method to communicate between services and winedevices - a separate > mailslot communication doesn't seem like a good idea. The main issues I still see: > > * Instead of two separate communication channels, we should implement marshalling of > data structures, and return them for example in the ServiceCtrlHandler callback. > Depending on the exact mechanism, special care has to be taken to ensure the > process is up and running before sending control commands. > > * Currently wine supports loading of both 32-bit and 64-bit drivers. This needs > special care in both patch 1 and patch 2. A winedevice process with the wrong > architecture will not be able to load the driver. > > * programs/services should be able to track the services correctly. Unfortunately > it seems like the advapi32 functions do not offer any nice method to add additional > services after startup. Maybe we could add a wine-specific extension here? I have a few follow-up patches that I have not sent yet that basically do this. I modified winedevice to use IoCreateDriver instead of creating the DRIVER_OBJECT itself. Then ntoskrnl.exe can track all drivers created by IoCreateDriver and programs can use ObReferenceObjectByName using the '\Driver\<something>' path to find loaded drivers. > > * Proper locking is required before accessing the database or services structures. > Those are technical issues though, and can be fixed of course. > > I'm currently trying a couple of own ideas, and will share them as soon as they do > something useful. ;) > > Regards, > Sebastian > My basic requirements are that I need to be able to load a number of .sys drivers into the same process space, and Plug and Play drivers are installed with a start type of 3 (On Demand) So the plug and play manager needs to be able to do a StartService or something similar on the no currently loaded driver and have it go into the right process. Alexandre was the one who suggested doing it by LoadOrderGroup, which I like. -aric

Feb. 26, 2016

Re: [PATCH] configure: Check for __builtin_ms_va_list on all x86_64 platforms.

by Alexandre Julliard

Charles Davis <cdavis5x(a)gmail.com> writes: > If we're running configure, we're probably not going to be using Visual > C++, even on Windows. Everywhere else, we need this for variadic > argument lists to work. You could probably unify the Mac OS case with the x86_64 one, instead of adding another check for the build host. -- Alexandre Julliard julliard(a)winehq.org

Feb. 26, 2016

Re: [PATCH v3] winex11.drv: Make the GL context current even if no drawables were given.

by Charles Davis

On Thu, Feb 25, 2016 at 7:29 AM, Matteo Bruni <matteo.mystral(a)gmail.com> wrote: > > 2016-02-24 5:12 GMT+01:00 Charles Davis <cdavis5x(a)gmail.com>: > > Signed-off-by: Charles Davis <cdavis5x(a)gmail.com> > > --- > > Try 3: Fix an assignment I missed. (Thanks, Ken.) > > > > dlls/opengl32/tests/opengl.c | 2 +- > > dlls/winex11.drv/opengl.c | 69 +++++++++++++++++++++++++------------------- > > 2 files changed, 41 insertions(+), 30 deletions(-) > > > > diff --git a/dlls/opengl32/tests/opengl.c b/dlls/opengl32/tests/opengl.c > > index e5e1507..c058c19 100644 > > --- a/dlls/opengl32/tests/opengl.c > > +++ b/dlls/opengl32/tests/opengl.c > > @@ -975,7 +975,7 @@ static void test_opengl3(HDC hdc) > > * expect drivers to ever offer it. > > */ > > res = wglMakeCurrent(0, gl3Ctx); > > - ok(res == FALSE, "Wow, OpenGL 3.0 windowless rendering passed while it was expected not to!\n"); > > + ok(res || broken(!res), "OpenGL 3.0 windowless rendering failed!\n"); > > That seems suspicious... > AFAICS the comment right above this hunk is still valid (it is for > current Nvidia drivers on Win7 at least), which probably means that > this patch is not a good idea. Yeah, I was afraid of that. Truth be told, I don't need this for an application. Besides the fact that OpenGL 3.0+ is supposed to allow this, I added it because I thought it might be useful for wined3d (e.g. being able to create devices without an implicit swapchain, though now that I've looked into that possibility, making that change would be much harder than I thought). In any case, I 'd imagine from your comment that you disagree. If you do, I 'll retract this patch and revert the patch adding this to winemac.drv , since no known apps depend on this . Chip

Feb. 26, 2016

[PATCH] comdlg32: Use SetDlgItemInt() instead of writing number manually.

by carlo.bramix＠libero.it

Hello friends, I have sent this patch: https://source.winehq.org/patches/data/119492 but it has been put in "Formatting" state and I cannot understand why. Could you help me and tell me what's wrong, so I will use more attention next time? Thank you very much. Sincerely, Carlo Bramini.

Feb. 26, 2016

Re: [PATCH] winex11: Don't create a temporary context each time X11DRV_wglBindTexImageARB is called.

by Ken Thomases

On Feb 25, 2016, at 9:22 AM, Miklós Máté <mtmkls(a)gmail.com> wrote: > > Theoretically wglBindTexImageARB is supposed to be a fast > render-to-texture method, and creating a new context is anything but fast. > > This fixes horrible performance in Star Wars > Knights of the Old Republic when post-process effects are enabled. > > Signed-off-by: Miklós Máté <mtmkls(a)gmail.com> > --- > dlls/winex11.drv/opengl.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) You need to destroy the temporary context when the pbuffer object is destroyed in X11DRV_wglDestroyPbufferARB(). -Ken

Feb. 26, 2016

Re: [PATCH 2/2] authz: Stub functions AuthzAccessCheck, AuthzFreeContext, AuthzInitializeContextFromSid, AuthzInitializeContextFromToken

by Alistair Leslie-Hughes

On 26/02/16 02:57, Sebastian Lackner wrote: > On 25.02.2016 08:50, Alistair Leslie-Hughes wrote: >> From: Zhenbo Li <litimetal(a)gmail.com> >> >> Moved defines to authz.h > > I will assume you typed the definitions in patch 1 yourself, and did not move them from > Zhenbo Lis patch - otherwise a remark about authorship would be necessary in 1/2. > Yes, patch 1 is mine. Zhenbo Lis patch only has typedefs to allow it to compile. The original patch is in wine-staging if you want to compare. Best Regards Alistair Leslie-Hughes

Feb. 26, 2016

Re: user32: Preserve beginning of extra data for MDI windows.

by Sebastian Lackner

On 26.02.2016 07:35, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > https://testbot.winehq.org/JobDetails.pl?Key=20905 > > Your paranoid android. > > > === w7u (32 bit msg) === > msg.c:8803: Test failed: did not get expected count for minimum timeout (54 != ~100). > > === w1064 (32 bit msg) === > msg.c:6294: Test failed: Update region shouldn't be empty > msg.c:6528: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 > msg.c:6530: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 > msg.c:6300: Test failed: Regions are different > msg.c:6300: Test failed: Regions are different > msg.c:6300: Test failed: Regions are different > The Win 7 test failure is random, the Win 10 test failures already existed before.

Feb. 26, 2016

Re: user32: Preserve beginning of extra data for MDI windows.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=20905 Your paranoid android. === w7u (32 bit msg) === msg.c:8803: Test failed: did not get expected count for minimum timeout (54 != ~100). === w1064 (32 bit msg) === msg.c:6294: Test failed: Update region shouldn't be empty msg.c:6528: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6530: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6300: Test failed: Regions are different msg.c:6300: Test failed: Regions are different msg.c:6300: Test failed: Regions are different

Feb. 26, 2016

Re: [PATCH 2/2] Programs: Load device drivers of the same group into the same winedevice process

by Sebastian Lackner

On 24.02.2016 15:16, Aric Stewart wrote: > Signed-off-by: Aric Stewart <aric(a)codeweavers.com> > --- > programs/services/services.c | 124 ++++++++++++++++++++++++++++ > programs/winedevice/device.c | 191 ++++++++++++++++++++++++++++++++++++------- > 2 files changed, 286 insertions(+), 29 deletions(-) > Although the general idea seems fine, the patches are still very hacky, and I fear we need a better method to communicate between services and winedevices - a separate mailslot communication doesn't seem like a good idea. The main issues I still see: * Instead of two separate communication channels, we should implement marshalling of data structures, and return them for example in the ServiceCtrlHandler callback. Depending on the exact mechanism, special care has to be taken to ensure the process is up and running before sending control commands. * Currently wine supports loading of both 32-bit and 64-bit drivers. This needs special care in both patch 1 and patch 2. A winedevice process with the wrong architecture will not be able to load the driver. * programs/services should be able to track the services correctly. Unfortunately it seems like the advapi32 functions do not offer any nice method to add additional services after startup. Maybe we could add a wine-specific extension here? * Proper locking is required before accessing the database or services structures. Those are technical issues though, and can be fixed of course. I'm currently trying a couple of own ideas, and will share them as soon as they do something useful. ;) Regards, Sebastian

Feb. 26, 2016