March 2016 - Wine-Devel - list.winehq.org

Re: [PATCH 2/3] user32: Added more dialog owner tests.

by Alexandre Julliard

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > Jacek Caban <jacek(a)codeweavers.com> wrote: >> I'm not sure I agree. > > Please don't get me wrong, but when sending tests after the fixes the result > can't be easily verified, and therefore this reduces the trust and value of > patches. There are many cases where adding todos and then removing them creates more work, so it's perfectly acceptable to send a test to apply after the fix to demonstrate that it is correct. We do that all the time. If you don't trust that the test is testing the right thing, it's easy enough to verify by reverting the fix and confirming that the test fails. I do that frequently myself. -- Alexandre Julliard julliard(a)winehq.org

March 1, 2016

Re: The Wine Project has been accepted as a GSoC 2016 mentor organization!

by Alexandre Julliard

André Hentschel <nerv(a)dawncrow.de> writes: > Hi, > > I'm a little late, but yes, we're accepted again! Great, thank you for taking care of this! -- Alexandre Julliard julliard(a)winehq.org

March 1, 2016

Re: [PATCH 2/3] user32: Added more dialog owner tests.

by Jacek Caban

On 3/1/16 12:25 AM, Dmitry Timoshkov wrote: > Jacek Caban <jacek(a)codeweavers.com> wrote: > >>>>> Please don't create fake embedded blocks. >>>> I need this declaration here, otherwise I wouldn't be able to use >>>> handles for testing lparam value. >>> wparam/lparam could be tested directly in the window procedure. >> It would require some global variables and new window procedure. It's >> cleaner to do it using existing tools IMO. > Writing the tests for user32 requires a bit of efforts, yes. I'd prefer to respond to comments that intend to improve the patch instead of comments that intend to increase efforts. > But since > you are new to this area I think it's justified to ask for more tests > to show that you well understand the code and can proof that the patch > is 100% correct. Given quality of your comments so far (and I mean technical ones, not just this one) I think it's justified to ask you to go back and try to understand my patch before questioning my abilities. Jacek

March 1, 2016