April 2016 - Wine-Devel - list.winehq.org

Re: [PATCH 2/2] inetcomm: Implement IMimeBody GetProp

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22590 Your paranoid android. === wvistau64 (64 bit mimeole) === mimeole.c:387: Test failed: Invalid mask 0x 779e9075 mimeole.c:390: Test failed: Invalid encoding 3 === w2008s64 (64 bit mimeole) === mimeole.c:387: Test failed: Invalid mask 0x 77009075 mimeole.c:390: Test failed: Invalid encoding 3 === w7pro64 (64 bit mimeole) === mimeole.c:387: Test failed: Invalid mask 0x 2c0000 mimeole.c:388: Test failed: Invalid flags 0x2c0000 mimeole.c:390: Test failed: Invalid encoding 3 === w864 (64 bit mimeole) === mimeole.c:387: Test failed: Invalid mask 0x 9 mimeole.c:388: Test failed: Invalid flags 0x9 mimeole.c:389: Test failed: Invalid row number 32757 mimeole.c:390: Test failed: Invalid encoding 3 === w1064 (64 bit mimeole) === mimeole.c:387: Test failed: Invalid mask 0x 5f8400 mimeole.c:388: Test failed: Invalid flags 0x5f8400 mimeole.c:390: Test failed: Invalid encoding 3

April 26, 2016

Re: [PATCH 1/2] inetcomm: Implement IMimeBody SetProp

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22589 Your paranoid android. === wvistau64 (64 bit mimeole) === mimeole.c:378: Test failed: Invalid mask 0x 779e9075 mimeole.c:381: Test failed: Invalid encoding 3 === w2008s64 (64 bit mimeole) === mimeole.c:378: Test failed: Invalid mask 0x 77009075 mimeole.c:381: Test failed: Invalid encoding 3 === w7pro64 (64 bit mimeole) === mimeole.c:378: Test failed: Invalid mask 0x 510000 mimeole.c:379: Test failed: Invalid flags 0x510000 mimeole.c:381: Test failed: Invalid encoding 3 === w864 (64 bit mimeole) === mimeole.c:378: Test failed: Invalid mask 0x 9 mimeole.c:379: Test failed: Invalid flags 0x9 mimeole.c:380: Test failed: Invalid row number 32757 mimeole.c:381: Test failed: Invalid encoding 3 === w1064 (64 bit mimeole) === mimeole.c:378: Test failed: Invalid mask 0x 5d7410 mimeole.c:379: Test failed: Invalid flags 0x5d7410 mimeole.c:381: Test failed: Invalid encoding 3

April 26, 2016

Re: RFC: gdi32: add a [fonts] section to win.ini

by Austin English

On Tue, Apr 26, 2016 at 1:57 AM, Nikolay Sivov <bunglehead(a)gmail.com> wrote: > On 26.04.2016 9:18, Austin English wrote: >> This patch is for https://bugs.winehq.org/show_bug.cgi?id=33492, >> already tested as working. >> >> I wanted to send for review first, as I'm not sure if this is the best >> approach or if someone has a better idea for how to handle it. >> >> Thanks, >> > > Isn't it enough to have empty [fonts] section created on prefix > creation? On Win7 installation I don't see SystemFont entries there, > only empty section. So the question is do we ever have to update it, and > if yes, what is it updated with? If it's static strings, having gdi32 do > that looks wrong. Empty would be enough, but I wasn't able to get WriteProfileSectionW() to write an empty section. I haven't been able to find an example of what should be in there online, and I don't have any old 9x machines. XP is blank as well. I originally had it in kernel32, but moved to gdi32 since I thought it may end up enumerating fonts. I suppose I should move back to kernel32 and try to get an empty section to work. Thanks for looking. -- -Austin

April 26, 2016

Re: RFC: gdi32: add a [fonts] section to win.ini

by Nikolay Sivov

On 26.04.2016 9:18, Austin English wrote: > This patch is for https://bugs.winehq.org/show_bug.cgi?id=33492, > already tested as working. > > I wanted to send for review first, as I'm not sure if this is the best > approach or if someone has a better idea for how to handle it. > > Thanks, > Isn't it enough to have empty [fonts] section created on prefix creation? On Win7 installation I don't see SystemFont entries there, only empty section. So the question is do we ever have to update it, and if yes, what is it updated with? If it's static strings, having gdi32 do that looks wrong.

April 26, 2016

RFC: gdi32: add a [fonts] section to win.ini

by Austin English

This patch is for https://bugs.winehq.org/show_bug.cgi?id=33492, already tested as working. I wanted to send for review first, as I'm not sure if this is the best approach or if someone has a better idea for how to handle it. Thanks, -- -Austin

April 26, 2016

Re: [PATCH 5/5] qedit: Implement IAMTimelineObj_GetTimelineNoRef and add tests.

by Alex Henrie

2016-04-25 23:10 GMT-06:00 Nikolay Sivov <bunglehead(a)gmail.com>: > On 26.04.2016 7:57, Alex Henrie wrote: >> 2016-04-25 22:21 GMT-06:00 Nikolay Sivov <bunglehead(a)gmail.com>: >>> On 26.04.2016 6:10, Alex Henrie wrote: >>>> static HRESULT WINAPI TimelineObj_GetTimelineNoRef(IAMTimelineObj *iface, IAMTimeline **timeline) >>>> { >>>> + /* MSDN says that this function is "not supported" */ >>>> TimelineObjImpl *This = impl_from_IAMTimelineObj(iface); >>>> - FIXME("(%p)->(%p): not implemented!\n", This, timeline); >>>> - return E_NOTIMPL; >>>> + TRACE("(%p)->(%p)\n", This, timeline); >>>> + if (!timeline) return E_POINTER; >>>> + return E_NOINTERFACE; >>>> } >>> >>> This looks like a call to QI, according to your tests. >> >> It looks that way, but which interface would it be querying? The tests >> show that an IAMTimelineObj cannot double as an IAMTimeline, nor is >> the function supposed to return the IAMTimeline that was used to >> create the IAMTimelineObj. My best guess is that Microsoft never >> bothered implementing this function properly and so whatever >> implementation they have always winds up returning E_NOINTERFACE. > > Yes, return type is IAMTimeline, so I was suggesting a shortcut doing > same thing in one line IAMTimelineObj_QueryInterface(iface, > &IID_IAMTimeline, ...). This should cover for setting out pointer to > NULL, returning E_NOINTERFACE, and probably handling NULL case too, > though it's not a standard QI behavior. None of that is actually > important, what you did is fine, take it as a suggestion, or don't. OK, I see what you mean now, and I'll make that change in version 2 of this patchset. As always, you can see my most up-to-date work at <https://github.com/alexhenrie/wine/commits/master>. Andrew: Don't bother signing off any of these patches. Just tell me if you want timelineobj.c merged into timeline.c, and any other comments you have. After that I will resubmit all 5 patches with the new tests etc. that Nikolay suggested. -Alex

April 26, 2016

Re: [PATCH] shell32: Add SHLimitInputEdit stub.

by Nikolay Sivov

On 26.04.2016 7:28, Alex Henrie wrote: > 2016-04-25 22:25 GMT-06:00 Nikolay Sivov <bunglehead(a)gmail.com>: >> On 26.04.2016 6:13, Alex Henrie wrote: >>> Needed for Windows Movie Maker 2.6. >>> >>> Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> >>> --- >>> dlls/shell32/shell32.spec | 1 + >>> dlls/shell32/shlfolder.c | 9 +++++++++ >>> 2 files changed, 10 insertions(+) >>> >>> diff --git a/dlls/shell32/shell32.spec b/dlls/shell32/shell32.spec >>> index 93fd449..7ebd032 100644 >>> --- a/dlls/shell32/shell32.spec >>> +++ b/dlls/shell32/shell32.spec >>> @@ -264,6 +264,7 @@ >>> 727 stdcall SHGetImageList(long ptr ptr) >>> 730 stdcall -noname RestartDialogEx(long wstr long long) >>> 743 stdcall SHCreateFileExtractIconW(wstr long ptr ptr) >>> + 747 stdcall SHLimitInputEdit(ptr ptr) >>> >> >> Does it actually need explicit ordinal? > > Yes. I tried it without the ordinal and the program still crashed. The > exact error message is "Unhandled exception: unimplemented function > SHELL32.dll.747 called in 32-bit code (0x7bc53e71)." Ok, thanks. > > -Alex >

April 26, 2016

Re: [PATCH 5/5] qedit: Implement IAMTimelineObj_GetTimelineNoRef and add tests.

by Nikolay Sivov

On 26.04.2016 7:57, Alex Henrie wrote: > 2016-04-25 22:21 GMT-06:00 Nikolay Sivov <bunglehead(a)gmail.com>: >> On 26.04.2016 6:10, Alex Henrie wrote: >>> static HRESULT WINAPI TimelineObj_GetTimelineNoRef(IAMTimelineObj *iface, IAMTimeline **timeline) >>> { >>> + /* MSDN says that this function is "not supported" */ >>> TimelineObjImpl *This = impl_from_IAMTimelineObj(iface); >>> - FIXME("(%p)->(%p): not implemented!\n", This, timeline); >>> - return E_NOTIMPL; >>> + TRACE("(%p)->(%p)\n", This, timeline); >>> + if (!timeline) return E_POINTER; >>> + return E_NOINTERFACE; >>> } >> >> This looks like a call to QI, according to your tests. > > It looks that way, but which interface would it be querying? The tests > show that an IAMTimelineObj cannot double as an IAMTimeline, nor is > the function supposed to return the IAMTimeline that was used to > create the IAMTimelineObj. My best guess is that Microsoft never > bothered implementing this function properly and so whatever > implementation they have always winds up returning E_NOINTERFACE. Yes, return type is IAMTimeline, so I was suggesting a shortcut doing same thing in one line IAMTimelineObj_QueryInterface(iface, &IID_IAMTimeline, ...). This should cover for setting out pointer to NULL, returning E_NOINTERFACE, and probably handling NULL case too, though it's not a standard QI behavior. None of that is actually important, what you did is fine, take it as a suggestion, or don't. > > -Alex >

April 26, 2016

Re: [PATCH 5/5] qedit: Implement IAMTimelineObj_GetTimelineNoRef and add tests.

by Alex Henrie

2016-04-25 22:21 GMT-06:00 Nikolay Sivov <bunglehead(a)gmail.com>: > On 26.04.2016 6:10, Alex Henrie wrote: >> static HRESULT WINAPI TimelineObj_GetTimelineNoRef(IAMTimelineObj *iface, IAMTimeline **timeline) >> { >> + /* MSDN says that this function is "not supported" */ >> TimelineObjImpl *This = impl_from_IAMTimelineObj(iface); >> - FIXME("(%p)->(%p): not implemented!\n", This, timeline); >> - return E_NOTIMPL; >> + TRACE("(%p)->(%p)\n", This, timeline); >> + if (!timeline) return E_POINTER; >> + return E_NOINTERFACE; >> } > > This looks like a call to QI, according to your tests. It looks that way, but which interface would it be querying? The tests show that an IAMTimelineObj cannot double as an IAMTimeline, nor is the function supposed to return the IAMTimeline that was used to create the IAMTimelineObj. My best guess is that Microsoft never bothered implementing this function properly and so whatever implementation they have always winds up returning E_NOINTERFACE. -Alex

April 26, 2016

Re: [PATCH 3/5] qedit: Implement IAMTimelineObj_GetTimelineType and add tests.

by Alex Henrie

2016-04-25 22:18 GMT-06:00 Nikolay Sivov <bunglehead(a)gmail.com>: > On 26.04.2016 6:09, Alex Henrie wrote: >> static HRESULT WINAPI TimelineObj_GetTimelineType(IAMTimelineObj *iface, TIMELINE_MAJOR_TYPE *type) >> { >> TimelineObjImpl *This = impl_from_IAMTimelineObj(iface); >> - FIXME("(%p)->(%p): not implemented!\n", This, type); >> - return E_NOTIMPL; >> + TRACE("(%p)->(%p)\n", This, type); >> + *type = This->timeline_type; >> + return S_OK; >> } > > Is it supposed to handle NULL input? No, it's not. Good catch. -Alex

April 26, 2016