April 2016 - Wine-Devel - list.winehq.org

Re: [PATCH 1/5] dwrite/tests: Added GetFontSignature() test

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22328 Your paranoid android. === build (build) === Patch failed to apply

April 19, 2016

Re: ntdll: Ignore invalid exit_frame when exiting thread.

by Alexandre Julliard

Sebastian Lackner <sebastian(a)fds-team.de> writes: > This was one of my initial approaches, but first of all its very hacky, and moreover > that alone is not sufficient. The 64-bit version of MSYS2 will try to reuse the > existing stack at one point, and memset()s a specific amount of memory at the top for > its internal use as thread local storage. Depending on the exact memory layout, this > might corrupt pthread or wine internal structures like debug_info... ;) Couldn't we ask them to stop doing such things? -- Alexandre Julliard julliard(a)winehq.org

April 19, 2016

Re: [3/3] services: Track services and processes separately.

by Sebastian Lackner

On 19.04.2016 14:25, Alexandre Julliard wrote: > Sebastian Lackner <sebastian(a)fds-team.de> writes: > >> Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de> >> --- >> programs/services/rpc.c | 37 ++++--- >> programs/services/services.c | 199 ++++++++++++++++++++++++++----------------- >> programs/services/services.h | 4 >> 3 files changed, 147 insertions(+), 93 deletions(-) > > It breaks the tests: > > ../../../tools/runtest -q -P wine -T ../../.. -M taskschd.dll -p taskschd_test.exe.so scheduler && touch scheduler.ok > scheduler.c:78: Test failed: Connect error 0x80041315 > scheduler.c:101: Test failed: Connect error 0x80041315 > scheduler.c:151: Test failed: Connect error 0x80041315 > scheduler.c:162: Test failed: GetFolder error 0x800704e3 > wine: Unhandled page fault on read access to 0x00000000 at address 0x7eff3a5e (thread 0009), starting debugger... > Hm, it didn't fail here, but I'll take a look. Thanks.

April 19, 2016

Re: ntdll: Ignore invalid exit_frame when exiting thread.

by Sebastian Lackner

On 19.04.2016 07:11, Alexandre Julliard wrote: > Sebastian Lackner <sebastian(a)fds-team.de> writes: > >> Some versions of pthread indeed put internal structures at the top of the stack. >> To solve that, the current Staging patchset allocates threads with a dummy pthread, >> and then switches to the real stack, see: >> https://github.com/wine-compholio/wine-staging/blob/master/patches/ntdll-Th… >> Unless there is something weird going on, thanks to the CFI annotations in >> wine_switch_to_stack() pthread should be able to unwind the stack correctly despite >> the stack switch inbetween. At least I have not found any problems so far ;) > > For this specific stack switch, sure, but it can't unwind across Win32 > code, which was the reason for the exit frame in the first place. > >> You are right that ignoring exit_frame might (under specific circumstances) >> run language handlers, but I'm not yet aware of a better way to deal with this. >> The only alternative would be to calculate it based on StackBase, but its also >> far from perfect. > > I'd suggest to instead try to keep the initial stack around. > This was one of my initial approaches, but first of all its very hacky, and moreover that alone is not sufficient. The 64-bit version of MSYS2 will try to reuse the existing stack at one point, and memset()s a specific amount of memory at the top for its internal use as thread local storage. Depending on the exact memory layout, this might corrupt pthread or wine internal structures like debug_info... ;)

April 19, 2016

Re: [PATCH] Added Nvidia GT 9700M

by Kim Malmo

You are correct. I've cleaned up the patch using your suggested formatting. I also did some extra digging and added the corresponding Mesa driver. Den 19. april 2016 14:51, skrev Henri Verbeet: > On 19 April 2016 at 13:53, Kim Malmo <berencamlost(a)msn.com> wrote: >> By looking at similar cards in the code I found the GT/GTS description were >> often omitted from mobile (M) cards. I wanted to keep the same text >> formatting. This is indeed the GT version and I can add that to the patch. >> > The only similar cards I see are the "8600M GT" and the "9400M". The > 8600M has the suffix, the 9400M looks like it may indeed be broken. > More recent cards like e.g. the 8x0M/8x5M series seem to just use a > different convention. Unfortunately NVIDIA's naming scheme isn't all > that easy to follow. That's of course not limited to NVIDIA, AMD > marketing names are a similar mess. > >

April 19, 2016

Re: [PATCH] Added Nvidia GT 9700M

by Henri Verbeet

On 19 April 2016 at 13:53, Kim Malmo <berencamlost(a)msn.com> wrote: > By looking at similar cards in the code I found the GT/GTS description were > often omitted from mobile (M) cards. I wanted to keep the same text > formatting. This is indeed the GT version and I can add that to the patch. > The only similar cards I see are the "8600M GT" and the "9400M". The 8600M has the suffix, the 9400M looks like it may indeed be broken. More recent cards like e.g. the 8x0M/8x5M series seem to just use a different convention. Unfortunately NVIDIA's naming scheme isn't all that easy to follow. That's of course not limited to NVIDIA, AMD marketing names are a similar mess.

April 19, 2016

Re: [PATCH 1/2] d3drm: Implement IDirect3DRM*::CreateObject (v2).

by Henri Verbeet

On 18 April 2016 at 19:00, Aaryaman Vasishta <jem456.vasishta(a)gmail.com> wrote: > diff --git a/dlls/d3drm/tests/d3drm.c b/dlls/d3drm/tests/d3drm.c > index a8f9c40..2b0174d 100644 > --- a/dlls/d3drm/tests/d3drm.c > +++ b/dlls/d3drm/tests/d3drm.c > @@ -1269,7 +1269,8 @@ static void test_destroy_callback(unsigned int test_idx, REFCLSID clsid, REFIID > context.test_idx = test_idx; > context.obj = obj; > > - hr = IDirect3DRMObject_AddDestroyCallback(obj, NULL, &context); > + if ((hr = IDirect3DRMObject_AddDestroyCallback(obj, NULL, &context)) != D3DRMERR_BADVALUE) > + return; I don't think we want that. Doing this means we won't notice when the function starts returning the wrong value, and the following tests get effectively disabled too in that case. > + hr = IDirect3DRM_CreateObject(d3drm1, &CLSID_DirectDraw, NULL, &IID_IDirectDraw, (void **)&unknown); > + ok(hr == CLASSFACTORY_E_FIRST, "Expected hr == CLASSFACTORY_E_FIRST, got %#x.\n", hr); > + ok(!unknown, "Expected object returned == NULL, got %p.\n", unknown); It would be better to initialise "unknown" with some known value before calling CreateObject(). Like this, if CreateObject() doesn't touch the value, the test may randomly pass or fail depending on what the initial value of "unknown" ends up being.

April 19, 2016

Re: [3/3] services: Track services and processes separately.

by Alexandre Julliard

Sebastian Lackner <sebastian(a)fds-team.de> writes: > Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de> > --- > programs/services/rpc.c | 37 ++++--- > programs/services/services.c | 199 ++++++++++++++++++++++++++----------------- > programs/services/services.h | 4 > 3 files changed, 147 insertions(+), 93 deletions(-) It breaks the tests: ../../../tools/runtest -q -P wine -T ../../.. -M taskschd.dll -p taskschd_test.exe.so scheduler && touch scheduler.ok scheduler.c:78: Test failed: Connect error 0x80041315 scheduler.c:101: Test failed: Connect error 0x80041315 scheduler.c:151: Test failed: Connect error 0x80041315 scheduler.c:162: Test failed: GetFolder error 0x800704e3 wine: Unhandled page fault on read access to 0x00000000 at address 0x7eff3a5e (thread 0009), starting debugger... -- Alexandre Julliard julliard(a)winehq.org

April 19, 2016

Re: [PATCH 04/10] wined3d: Add support for rendering to 2D array textures.

by Henri Verbeet

On 19 April 2016 at 00:01, Józef Kucia <jkucia(a)codeweavers.com> wrote: > Layered rendering is not supported yet. > > Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> > --- > dlls/wined3d/context.c | 84 +++++++++++++++++++++++++----------------- > dlls/wined3d/directx.c | 6 +++ > dlls/wined3d/wined3d_private.h | 5 ++- > 3 files changed, 60 insertions(+), 35 deletions(-) > This one conflicts with 121430.

April 19, 2016

[PATCH] Added Nvidia GT 9700M

by Kim Malmo

Thanks for your feedback Henri. By looking at similar cards in the code I found the GT/GTS description were often omitted from mobile (M) cards. I wanted to keep the same text formatting. This is indeed the GT version and I can add that to the patch. I will sign off the next patch, still getting to grips with git. -- Date: Mon, 18 Apr 2016 19:00:33 +0200 From: Henri Verbeet<hverbeet(a)gmail.com> To: wine-devel<wine-devel(a)winehq.org> Cc: Kim Malmo<kimmalmo(a)protonmail.ch> Subject: Re: [PATCH] Added Nvidia GT 9700M Message-ID: <CAOsNvwyqyR1swwYaPUhiOpu7+TtBRuC9yg33Zi4+KYE1J0EyEw(a)mail.gmail.com> Content-Type: text/plain; charset=UTF-8 On 18 April 2016 at 18:39, Kim Malmo<berencamlost(a)msn.com> wrote: > From: Kim Malmo<kimmalmo(a)protonmail.ch> > > --- > dlls/wined3d/directx.c | 2 ++ > dlls/wined3d/wined3d_private.h | 1 + > 2 files changed, 3 insertions(+) > You're missing the Signed-off-by line. Passing -s to format-patch will add it. > + {HW_VENDOR_NVIDIA, CARD_NVIDIA_GEFORCE_9700M, "NVIDIA GeForce 9700M", DRIVER_NVIDIA_GEFORCE8, 512 }, Is that the correct description string for the card? I'm only finding references to the 9700M GT and 9700M GTS.

April 19, 2016