April 2016 - Wine-Devel - list.winehq.org

Re: [PATCH v2] kernel32/tests: Add more tests for GetConsoleFontInfo

by Hugh McMaster

On Friday, 29 April 2016 9:37 PM, Marvin wrote: Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22732 Your paranoid android. === w8 (32 bit console) === console.c:1445: Test failed: [13] Expected output count to be 0, got 3589215353 console.c:1445: Test failed: [15] Expected output count to be 0, got 3589215353 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 3589215353 console.c:1689: Test failed: [13] Expected output count to be 0, got 3589215353 console.c:1689: Test failed: [15] Expected output count to be 0, got 3589215353 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 3589215353 === w864 (32 bit console) === console.c:1445: Test failed: [13] Expected output count to be 0, got 216706042 console.c:1445: Test failed: [15] Expected output count to be 0, got 216706042 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 216706042 console.c:1689: Test failed: [13] Expected output count to be 0, got 216706042 console.c:1689: Test failed: [15] Expected output count to be 0, got 216706042 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 216706042 === w1064 (32 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [13] Expected output count to be 0, got 1066250053 console.c:1445: Test failed: [15] Expected output count to be 0, got 1066250053 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 1066250053 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [13] Expected output count to be 0, got 1066250053 console.c:1689: Test failed: [15] Expected output count to be 0, got 1066250053 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 1066250053 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1 === w864 (64 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1 === w1064 (64 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1 These are existing failures.

April 29, 2016

Re: [PATCH v2] kernel32/tests: Add more tests for GetConsoleFontInfo

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22732 Your paranoid android. === w8 (32 bit console) === console.c:1445: Test failed: [13] Expected output count to be 0, got 3589215353 console.c:1445: Test failed: [15] Expected output count to be 0, got 3589215353 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 3589215353 console.c:1689: Test failed: [13] Expected output count to be 0, got 3589215353 console.c:1689: Test failed: [15] Expected output count to be 0, got 3589215353 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 3589215353 === w864 (32 bit console) === console.c:1445: Test failed: [13] Expected output count to be 0, got 216706042 console.c:1445: Test failed: [15] Expected output count to be 0, got 216706042 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 216706042 console.c:1689: Test failed: [13] Expected output count to be 0, got 216706042 console.c:1689: Test failed: [15] Expected output count to be 0, got 216706042 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 216706042 === w1064 (32 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [13] Expected output count to be 0, got 1066250053 console.c:1445: Test failed: [15] Expected output count to be 0, got 1066250053 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 1066250053 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [13] Expected output count to be 0, got 1066250053 console.c:1689: Test failed: [15] Expected output count to be 0, got 1066250053 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 1066250053 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1 === w864 (64 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1 === w1064 (64 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1

April 29, 2016

Re: [PATCH 2/4] d3drm: Implement IDirect3DRMTexture{2-3}_InitFromImage.

by Nikolay Sivov

On 29.04.2016 12:16, Aaryaman Vasishta wrote: > On Fri, Apr 29, 2016 at 12:56 PM, Stefan Dösinger > <stefandoesinger(a)gmail.com <mailto:stefandoesinger(a)gmail.com>> wrote: > > > > Am 28.04.2016 um 20:17 schrieb Aaryaman Vasishta <jem456.vasishta(a)gmail.com <mailto:jem456.vasishta(a)gmail.com>>: > > > > + if (texture->d3drm && texture->initialized) > > + IDirect3DRM_Release(texture->d3drm); > I thought the idea was to use AddDestroyCallback instead of a flag > to control the Release call. Do I remember this incorrectly, or > what's the reason for going back to a flag? > > Also, what's the difference between image != NULL and initialized? > Or, in a later stage when you have initFromTexture or what it is > called, image != NULL || ddraw_texture != NULL? > > AddDestroyCallback would be used to destroy the image struct, which will > be used when InitFromFile will be implemented. Since the image here is > provided by the application, there wasn't any need to use a destroy > callback right now. > > texture->initialized is only used to indicate whether InitFrom* was > called on texture or not. As you can see from the tests, d3drm AddRef's > IDirect3DRM only after InitFrom* is called. (I had initially thought > that CreateObject would do that, but the tests say otherwise). > > Since we needed the reference to IDirect3DRM when AddRefing it during > the InitFrom* calls, I decided to initialize texture->d3drm at > CreateObject without AddRefing it there. So if someone decides to > release a texture created using CreateObject but not initialized using > InitFrom*, the texture->initialized member will prevent d3drm from > releasing texture->d3drm. What will happen if you release IDirect3DRM before calling InitFrom*, and then call InitFrom* expecting already released IDirect3DRM to be valid? > > > > > IDirect3DRM_AddRef(texture->d3drm); > > + > > + if (texture->image) > > + return D3DRMERR_BADOBJECT; > Afair the ref leak here is intentional. If it is, I think it's > worth adding a comment. > > Right, I will add comments above the related test as well. > > Cheers, > Aaryaman > > > >

April 29, 2016

Re: user32/tests: Add additional test for window station name.

by Alexandre Julliard

Sebastian Lackner <sebastian(a)fds-team.de> writes: > Before I resend, may I ask why this patch is pending? If its because of the hardcoded "0x0", > I can change that of course. The main point is to show that window stations without a name > get assigned one by the operating system. Applications depend on this when they "manually" > implement window station inheritance (query name and later pass it to CreateProcess). Sorry, I wanted to look more into this behavior, but haven't found the time yet. But the test is fine, I should have applied it. -- Alexandre Julliard julliard(a)winehq.org

April 29, 2016

Re: user32: Implement SetCoalescableTimer and add basic tests.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22731 Your paranoid android. === w1064 (32 bit msg) === msg.c:6484: Test failed: Update region shouldn't be empty msg.c:6718: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6720: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different === w864 (64 bit msg) === msg.c:6484: Test failed: Update region shouldn't be empty msg.c:6718: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6720: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different === w1064 (64 bit msg) === msg.c:6484: Test failed: Update region shouldn't be empty msg.c:6718: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6720: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different

April 29, 2016

Re: user32/tests: Add additional test for window station name.

by Sebastian Lackner

On 25.04.2016 23:25, Sebastian Lackner wrote: > Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de> > --- > dlls/user32/tests/winstation.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/dlls/user32/tests/winstation.c b/dlls/user32/tests/winstation.c > index e49420b..94be4c9 100644 > --- a/dlls/user32/tests/winstation.c > +++ b/dlls/user32/tests/winstation.c > @@ -114,6 +114,8 @@ static void test_handles(void) > DWORD id, flags, le; > ATOM atom; > char buffer[20]; > + DWORD size; > + BOOL ret; > > /* win stations */ > > @@ -215,6 +217,12 @@ static void test_handles(void) > w2 = CreateWindowStationA( "", 0, WINSTA_ALL_ACCESS, NULL ); > ok( w2 != 0, "create station failed err %u\n", GetLastError() ); > > + memset( buffer, 0, sizeof(buffer) ); > + ret = GetUserObjectInformationA( w2, UOI_NAME, buffer, sizeof(buffer), &size ); > + ok( ret, "GetUserObjectInformationA failed with error %u\n", GetLastError() ); > + todo_wine ok( !memcmp(buffer, "Service-0x0-", 12), "unexpected window station name '%s'\n", buffer ); > + todo_wine ok( buffer[strlen(buffer) - 1] == '$', "unexpected window station name '%s'\n", buffer ); > + > SetLastError( 0xdeadbeef ); > w3 = OpenWindowStationA( "", TRUE, WINSTA_ALL_ACCESS ); > todo_wine > Before I resend, may I ask why this patch is pending? If its because of the hardcoded "0x0", I can change that of course. The main point is to show that window stations without a name get assigned one by the operating system. Applications depend on this when they "manually" implement window station inheritance (query name and later pass it to CreateProcess). Regards, Sebastian

April 29, 2016

Re: [PATCH 3/4] d3drm: Implement IDirect3DRM*_CreateTexture.

by Aaryaman Vasishta

Not really, I thought that since InitFromImage doesn't exist for version 1, I wasn't sure if it's a good idea to use it within CreateTexture for version 1. Is it fine, though?. I'll use InitFromImage if it's a better approach. Besides, since they behave the same so far, there's no reason to not use it anyways. I agree with thunking version 2's CreateTexture to version 3, I'll resend the patch for the same, after I get to know your opinion for the above question. Cheers, Aaryaman On Fri, Apr 29, 2016 at 1:06 PM, Stefan Dösinger <stefandoesinger(a)gmail.com> wrote: > > > Am 28.04.2016 um 20:17 schrieb Aaryaman Vasishta < > jem456.vasishta(a)gmail.com>: > > > > @@ -198,13 +198,24 @@ static HRESULT WINAPI > d3drm1_CreateTexture(IDirect3DRM *iface, > > struct d3drm_texture *object; > > HRESULT hr; > > > > - FIXME("iface %p, image %p, texture %p partial stub.\n", iface, > image, texture); > > + TRACE("iface %p, image %p, texture %p.\n", iface, image, texture); > > + > > + if (!d3drm_validate_image(image)) > > + return D3DRMERR_BADVALUE; > > > > if (FAILED(hr = d3drm_texture_create(&object))) > > + { > > + d3drm_texture_destroy(object); > > return hr; > > + } > > + object->d3drm = iface; > > + object->initialized = TRUE; > > + object->image = image; > > > > *texture = &object->IDirect3DRMTexture_iface; > > > > + IDirect3DRM_AddRef(iface); > > + > > return D3DRM_OK; > > } > > > Is there anything wrong with calling Texture3::InitFromImage here, or even > calling IDirect3DRM3::CreateTexture? in D3DRM1::CreateTexture and > D3DRM2::CreateTexture? >

April 29, 2016

Re: [PATCH 2/4] d3drm: Implement IDirect3DRMTexture{2-3}_InitFromImage.

by Aaryaman Vasishta

On Fri, Apr 29, 2016 at 12:56 PM, Stefan Dösinger <stefandoesinger(a)gmail.com > wrote: > > > Am 28.04.2016 um 20:17 schrieb Aaryaman Vasishta < > jem456.vasishta(a)gmail.com>: > > > > + if (texture->d3drm && texture->initialized) > > + IDirect3DRM_Release(texture->d3drm); > I thought the idea was to use AddDestroyCallback instead of a flag to > control the Release call. Do I remember this incorrectly, or what's the > reason for going back to a flag? > > Also, what's the difference between image != NULL and initialized? Or, in > a later stage when you have initFromTexture or what it is called, image != > NULL || ddraw_texture != NULL? > AddDestroyCallback would be used to destroy the image struct, which will be used when InitFromFile will be implemented. Since the image here is provided by the application, there wasn't any need to use a destroy callback right now. texture->initialized is only used to indicate whether InitFrom* was called on texture or not. As you can see from the tests, d3drm AddRef's IDirect3DRM only after InitFrom* is called. (I had initially thought that CreateObject would do that, but the tests say otherwise). Since we needed the reference to IDirect3DRM when AddRefing it during the InitFrom* calls, I decided to initialize texture->d3drm at CreateObject without AddRefing it there. So if someone decides to release a texture created using CreateObject but not initialized using InitFrom*, the texture->initialized member will prevent d3drm from releasing texture->d3drm. > > > IDirect3DRM_AddRef(texture->d3drm); > > + > > + if (texture->image) > > + return D3DRMERR_BADOBJECT; > Afair the ref leak here is intentional. If it is, I think it's worth > adding a comment. > Right, I will add comments above the related test as well. Cheers, Aaryaman

April 29, 2016

Re: kernel32: Improve the stub for GetThreadPreferredUILanguages.

by Hans Leidekker

On Fri, 2016-04-29 at 03:26 -0500, Marvin wrote: > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > https://testbot.winehq.org/JobDetails.pl?Key=22718 > > Your paranoid android. > > > === w1064 (32 bit locale) === > locale.c:2367: Test failed: LCMapStringEx should fail with bad locale name > locale.c:2368: Test failed: unexpected error code -559038737 > locale.c:2459: Test failed: Expected lcid == 0, got got 00001000, error -559038737 > locale.c:4177: Test failed: IsValidLocaleName should have failed > locale.c:4179: Test failed: IsValidLocaleName should have failed > locale.c:4544: Test failed: For id 7, expected ret == 4, got 1, error 87 > locale.c:4546: Test failed: For id 7, Expected IVC, got '' > > === w1064 (64 bit locale) === > locale.c:2367: Test failed: LCMapStringEx should fail with bad locale name > locale.c:2368: Test failed: unexpected error code -559038737 > locale.c:2459: Test failed: Expected lcid == 0, got got 00001000, error -559038737 > locale.c:4177: Test failed: IsValidLocaleName should have failed > locale.c:4179: Test failed: IsValidLocaleName should have failed > locale.c:4544: Test failed: For id 7, expected ret == 4, got 1, error 87 > locale.c:4546: Test failed: For id 7, Expected IVC, got '' These are old failures: http://test.winehq.org/data/179137c259ffed546fb6f2c88c0d4df0e140cc4c/win10_…

April 29, 2016

Re: kernel32: Improve the stub for GetThreadPreferredUILanguages.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22718 Your paranoid android. === w1064 (32 bit locale) === locale.c:2367: Test failed: LCMapStringEx should fail with bad locale name locale.c:2368: Test failed: unexpected error code -559038737 locale.c:2459: Test failed: Expected lcid == 0, got got 00001000, error -559038737 locale.c:4177: Test failed: IsValidLocaleName should have failed locale.c:4179: Test failed: IsValidLocaleName should have failed locale.c:4544: Test failed: For id 7, expected ret == 4, got 1, error 87 locale.c:4546: Test failed: For id 7, Expected IVC, got '' === w1064 (64 bit locale) === locale.c:2367: Test failed: LCMapStringEx should fail with bad locale name locale.c:2368: Test failed: unexpected error code -559038737 locale.c:2459: Test failed: Expected lcid == 0, got got 00001000, error -559038737 locale.c:4177: Test failed: IsValidLocaleName should have failed locale.c:4179: Test failed: IsValidLocaleName should have failed locale.c:4544: Test failed: For id 7, expected ret == 4, got 1, error 87 locale.c:4546: Test failed: For id 7, Expected IVC, got ''

April 29, 2016