April 2016 - Wine-Devel - list.winehq.org

Re: [PATCH 3/5] user32: Don't enable owner in DIALOG_DoDialogBox.

by Jacek Caban

On 04/11/16 01:06, Dmitry Timoshkov wrote: > Jacek Caban <jacek(a)codeweavers.com> wrote: > >> On 04/06/16 15:24, Jacek Caban wrote: >>> Could you share those tests (WIP is fine) or run my patches against them? >> Ping. Did you have a chance to run those tests? > No. But since you already know that removing DF_OWNERENABLED handling > is wrong it shouldn't be too hard to add appropriate tests. No, as far as I know removing is right and I added tests that reach EnableWindow() in every possible code path. I know only that you said it's wrong with no prove to back that. I guess that you misinterpreted results of your own tests and the fact that you claim you didn't bother to run my patches against those tests tells pretty much all about quality and intentions of your reviews. Jacek

April 11, 2016

Re: Assorted comment, trace and ok() message spelling fixes.

by Francois Gouget

On Sun, 10 Apr 2016, Marvin wrote: [...] > === w1064 (64 bit device) === > device.c:4317: Test failed: cw is 0xf60, expected 0x7f. > device.c:4326: Test failed: Callback cw is 0xf60, expected 0x7f. These failures were already there. Here's a run of the essentially unmodified d3d9:device test failing in the same way: https://testbot.winehq.org/JobDetails.pl?Key=22054 (unfortunately we don't have regular Windows 10 WineTest results because ntdll:exception crashes the VM) -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Advice is what we ask for when we already know the answer but wish we didn't -- Eric Jong

April 11, 2016

Re: Assorted comment, trace and ok() message spelling fixes.

by Francois Gouget

On Sun, 10 Apr 2016, Marvin wrote: [...] > === wvistau64 (32 bit action) === > The test timed out > > === wvistau64 (64 bit action) === > The test timed out This test times out from time to time on one platform or another. I claim my patch is not responsible for these two. https://test.winehq.org/data/tests/msi:action.html -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ You can have my guns when you pry them from my kids cold, dead hands.

April 11, 2016

Re: Assorted comment, trace and ok() message spelling fixes.

by Francois Gouget

On Sun, 10 Apr 2016, Marvin wrote: [...] > === w1064 (32 bit uri) === > uri.c:7615: Test failed: Expected google.com.uk but got L"com.uk" on uri_tests[71].str_props[3]. > uri.c:7615: Test failed: Expected google.uk.1 but got L"uk.1" on uri_tests[73].str_props[3]. > uri.c:7613: Test failed: GetPropertyBSTR returned 0x00000000, expected 0x00000001. On uri_tests[76].str_props[3]. > uri.c:7615: Test failed: Expected but got L".uk" on uri_tests[76].str_props[3]. > uri.c:7615: Test failed: Expected google.com.[] but got L"com.[]" on uri_tests[77].str_props[3]. > uri.c:7800: Test failed: Error: Expected google.com.uk but got L"com.uk" on uri_tests[71]. > uri.c:7800: Test failed: Error: Expected google.uk.1 but got L"uk.1" on uri_tests[73]. > uri.c:7798: Test failed: Error: GetDomain returned 0x00000000, expected 0x00000001 on uri_tests[76]. > uri.c:7800: Test failed: Error: Expected but got L".uk" on uri_tests[76]. > uri.c:7800: Test failed: Error: Expected google.com.[] but got L"com.[]" on uri_tests[77]. > uri.c:8080: Test failed: Error: Expected a length of 13 but got 6 on uri_tests[71].str_props[3]. > uri.c:8080: Test failed: Error: Expected a length of 11 but got 4 on uri_tests[73].str_props[3]. > uri.c:8078: Test failed: Error: GetPropertyLength returned 0x00000000, expected 0x00000001 on uri_tests[76].str_props[3]. > uri.c:8080: Test failed: Error: Expected a length of 0 but got 3 on uri_tests[76].str_props[3]. > uri.c:8080: Test failed: Error: Expected a length of 13 but got 6 on uri_tests[77].str_props[3]. > uri.c:8147: Test failed: Error: Received flag for property 3 when not expected on uri_tests[76]. > uri.c:8197: Test failed: Error: Wasn't expecting to have property 3 on uri_tests[76]. > uri.c:10487: Test failed: Error: Expected google.com.uk but got L"com.uk" instead on uri_parse_tests[42]. > uri.c:10490: Test failed: Error: Expected 13, but got 6 instead on uri_parse_tests[42]. > > === w1064 (64 bit uri) === > uri.c:7615: Test failed: Expected google.com.uk but got L"com.uk" on uri_tests[71].str_props[3]. > uri.c:7615: Test failed: Expected google.uk.1 but got L"uk.1" on uri_tests[73].str_props[3]. > uri.c:7613: Test failed: GetPropertyBSTR returned 0x00000000, expected 0x00000001. On uri_tests[76].str_props[3]. > uri.c:7615: Test failed: Expected but got L".uk" on uri_tests[76].str_props[3]. > uri.c:7615: Test failed: Expected google.com.[] but got L"com.[]" on uri_tests[77].str_props[3]. > uri.c:7800: Test failed: Error: Expected google.com.uk but got L"com.uk" on uri_tests[71]. > uri.c:7800: Test failed: Error: Expected google.uk.1 but got L"uk.1" on uri_tests[73]. > uri.c:7798: Test failed: Error: GetDomain returned 0x00000000, expected 0x00000001 on uri_tests[76]. > uri.c:7800: Test failed: Error: Expected but got L".uk" on uri_tests[76]. > uri.c:7800: Test failed: Error: Expected google.com.[] but got L"com.[]" on uri_tests[77]. > uri.c:8080: Test failed: Error: Expected a length of 13 but got 6 on uri_tests[71].str_props[3]. > uri.c:8080: Test failed: Error: Expected a length of 11 but got 4 on uri_tests[73].str_props[3]. > uri.c:8078: Test failed: Error: GetPropertyLength returned 0x00000000, expected 0x00000001 on uri_tests[76].str_props[3]. > uri.c:8080: Test failed: Error: Expected a length of 0 but got 3 on uri_tests[76].str_props[3]. > uri.c:8080: Test failed: Error: Expected a length of 13 but got 6 on uri_tests[77].str_props[3]. > uri.c:8147: Test failed: Error: Received flag for property 3 when not expected on uri_tests[76]. > uri.c:8197: Test failed: Error: Wasn't expecting to have property 3 on uri_tests[76]. > uri.c:10487: Test failed: Error: Expected google.com.uk but got L"com.uk" instead on uri_parse_tests[42]. > uri.c:10490: Test failed: Error: Expected 13, but got 6 instead on uri_parse_tests[42]. These test failures were already there (so many preexisting failures :-( ). https://test.winehq.org/data/ad7cb436571ec66ae7a5687568fca2f5318c7e76/win10… -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ May your Tongue stick to the Roof of your Mouth with the Force of a Thousand Caramels.

April 11, 2016

Re: Assorted comment, trace and ok() message spelling fixes.

by Francois Gouget

On Sun, 10 Apr 2016, Marvin wrote: [...] > === w864 (32 bit security) === > security.c:3964: Test failed: MACHINE\Software owner SID (S-1-5-18) != Administrators SID (S-1-5-32-544). > security.c:4018: Test failed: Builtin Admins ACE has unexpected flags (0xa != 0x0) > > === w1064 (32 bit security) === > security.c:3964: Test failed: MACHINE\Software owner SID (S-1-5-18) != Administrators SID (S-1-5-32-544). > security.c:4005: Test failed: Builtin Users ACE has unexpected flags (0x12 != 0xa) > security.c:4009: Test failed: Builtin Users ACE has unexpected mask (0x20019 != 0x80000000) > security.c:4018: Test failed: Builtin Admins ACE has unexpected flags (0x12 != 0x0) > > === w1064 (64 bit security) === > security.c:4005: Test failed: Builtin Users ACE has unexpected flags (0x2 != 0xa) > security.c:4009: Test failed: Builtin Users ACE has unexpected mask (0x20019 != 0x80000000) > security.c:4018: Test failed: Builtin Admins ACE has unexpected flags (0x2 != 0x0) These test failures are not 100% systematic but were already there on one test machine or another (for instance on win8_cw2-gtx560-t64 and win10_fg-acer64-t32). https://test.winehq.org/data/tests/advapi32:security.html It happened on w864 there for instance: https://test.winehq.org/data/aaddf1365a3371263827206eedf1464a83562c00/win8_… -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ In a world without fences who needs Gates?

April 11, 2016

Re: Assorted comment, trace and ok() message spelling fixes.

by Francois Gouget

On Sun, 10 Apr 2016, Marvin wrote: [...] > === w1064 (32 bit shlfolder) === > shlfolder.c:1591: Test failed: IShellFolder_GetDisplayNameOf(NULL) failed! hr = 80070057 > > === w1064 (64 bit shlfolder) === > shlfolder.c:1591: Test failed: IShellFolder_GetDisplayNameOf(NULL) failed! hr = 80070057 These failures were already present: https://test.winehq.org/data/tests/shell32:shlfolder.html -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Research is the transformation of money to knowledge. Innovation is the transformation of knowledge to money. -- Dr. Hans Meixner

April 11, 2016

Re: Assorted comment, trace and ok() message spelling fixes.

by Francois Gouget

On Sun, 10 Apr 2016, Marvin wrote: [...] > === w864 (32 bit d3d) === > d3d.c:2326: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level > d3d.c:2326: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level > d3d.c:2326: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level > d3d.c:2326: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level > d3d.c:2510: Test failed: Unexpected destination texture level pixels; 257 differences > d3d.c:2657: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level > d3d.c:2657: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level > d3d.c:2657: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level > d3d.c:2657: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level > > === w1064 (32 bit d3d) === > d3d.c:2326: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level > d3d.c:2326: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level > d3d.c:2326: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level > d3d.c:2326: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level > d3d.c:2510: Test failed: Unexpected destination texture level pixels; 257 differences > d3d.c:2657: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level > d3d.c:2657: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level > d3d.c:2657: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level > d3d.c:2657: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level These failures were already present: https://test.winehq.org/data/tests/ddraw:d3d.html -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Hell is empty and all the devils are here. -- Wm. Shakespeare, "The Tempest"

April 11, 2016

Re: Assorted comment, trace and ok() message spelling fixes.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22052 Your paranoid android. === w864 (32 bit d3d) === d3d.c:2326: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level d3d.c:2510: Test failed: Unexpected destination texture level pixels; 257 differences d3d.c:2657: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level === w1064 (32 bit d3d) === d3d.c:2326: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level d3d.c:2510: Test failed: Unexpected destination texture level pixels; 257 differences d3d.c:2657: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level

April 11, 2016

Re: Assorted comment, trace and ok() message spelling fixes.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22051 Your paranoid android. === wvistau64 (32 bit action) === The test timed out === wvistau64 (64 bit action) === The test timed out

April 11, 2016

Re: Assorted comment, trace and ok() message spelling fixes.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22050 Your paranoid android. === w1064 (32 bit uri) === uri.c:7615: Test failed: Expected google.com.uk but got L"com.uk" on uri_tests[71].str_props[3]. uri.c:7615: Test failed: Expected google.uk.1 but got L"uk.1" on uri_tests[73].str_props[3]. uri.c:7613: Test failed: GetPropertyBSTR returned 0x00000000, expected 0x00000001. On uri_tests[76].str_props[3]. uri.c:7615: Test failed: Expected but got L".uk" on uri_tests[76].str_props[3]. uri.c:7615: Test failed: Expected google.com.[] but got L"com.[]" on uri_tests[77].str_props[3]. uri.c:7800: Test failed: Error: Expected google.com.uk but got L"com.uk" on uri_tests[71]. uri.c:7800: Test failed: Error: Expected google.uk.1 but got L"uk.1" on uri_tests[73]. uri.c:7798: Test failed: Error: GetDomain returned 0x00000000, expected 0x00000001 on uri_tests[76]. uri.c:7800: Test failed: Error: Expected but got L".uk" on uri_tests[76]. uri.c:7800: Test failed: Error: Expected google.com.[] but got L"com.[]" on uri_tests[77]. uri.c:8080: Test failed: Error: Expected a length of 13 but got 6 on uri_tests[71].str_props[3]. uri.c:8080: Test failed: Error: Expected a length of 11 but got 4 on uri_tests[73].str_props[3]. uri.c:8078: Test failed: Error: GetPropertyLength returned 0x00000000, expected 0x00000001 on uri_tests[76].str_props[3]. uri.c:8080: Test failed: Error: Expected a length of 0 but got 3 on uri_tests[76].str_props[3]. uri.c:8080: Test failed: Error: Expected a length of 13 but got 6 on uri_tests[77].str_props[3]. uri.c:8147: Test failed: Error: Received flag for property 3 when not expected on uri_tests[76]. uri.c:8197: Test failed: Error: Wasn't expecting to have property 3 on uri_tests[76]. uri.c:10487: Test failed: Error: Expected google.com.uk but got L"com.uk" instead on uri_parse_tests[42]. uri.c:10490: Test failed: Error: Expected 13, but got 6 instead on uri_parse_tests[42]. === w1064 (64 bit uri) === uri.c:7615: Test failed: Expected google.com.uk but got L"com.uk" on uri_tests[71].str_props[3]. uri.c:7615: Test failed: Expected google.uk.1 but got L"uk.1" on uri_tests[73].str_props[3]. uri.c:7613: Test failed: GetPropertyBSTR returned 0x00000000, expected 0x00000001. On uri_tests[76].str_props[3]. uri.c:7615: Test failed: Expected but got L".uk" on uri_tests[76].str_props[3]. uri.c:7615: Test failed: Expected google.com.[] but got L"com.[]" on uri_tests[77].str_props[3]. uri.c:7800: Test failed: Error: Expected google.com.uk but got L"com.uk" on uri_tests[71]. uri.c:7800: Test failed: Error: Expected google.uk.1 but got L"uk.1" on uri_tests[73]. uri.c:7798: Test failed: Error: GetDomain returned 0x00000000, expected 0x00000001 on uri_tests[76]. uri.c:7800: Test failed: Error: Expected but got L".uk" on uri_tests[76]. uri.c:7800: Test failed: Error: Expected google.com.[] but got L"com.[]" on uri_tests[77]. uri.c:8080: Test failed: Error: Expected a length of 13 but got 6 on uri_tests[71].str_props[3]. uri.c:8080: Test failed: Error: Expected a length of 11 but got 4 on uri_tests[73].str_props[3]. uri.c:8078: Test failed: Error: GetPropertyLength returned 0x00000000, expected 0x00000001 on uri_tests[76].str_props[3]. uri.c:8080: Test failed: Error: Expected a length of 0 but got 3 on uri_tests[76].str_props[3]. uri.c:8080: Test failed: Error: Expected a length of 13 but got 6 on uri_tests[77].str_props[3]. uri.c:8147: Test failed: Error: Received flag for property 3 when not expected on uri_tests[76]. uri.c:8197: Test failed: Error: Wasn't expecting to have property 3 on uri_tests[76]. uri.c:10487: Test failed: Error: Expected google.com.uk but got L"com.uk" instead on uri_parse_tests[42]. uri.c:10490: Test failed: Error: Expected 13, but got 6 instead on uri_parse_tests[42].

April 11, 2016