April 2016 - Wine-Devel - list.winehq.org

Re: ntdll: Do not update iosb.Status after FSCTL_PIPE_LISTEN call. (v2)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21959 Your paranoid android. === build (build) === Patch failed to apply

April 7, 2016

Re: [4/4] ntdll: Do not update iosb.Status after FSCTL_PIPE_LISTEN call.

by Alexandre Julliard

Sebastian Lackner <sebastian(a)fds-team.de> writes: > Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de> > --- > > The change only affects FSCTL_PIPE_LISTEN because we probably want > more tests before changing the rest. Indeed we do, so you should probably move this out of the default case. -- Alexandre Julliard julliard(a)winehq.org

April 7, 2016

Re: [4/4] ntdll: Do not update iosb.Status after FSCTL_PIPE_LISTEN call.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21958 Your paranoid android. === w864 (32 bit pipe) === pipe.c:240: Test failed: CreateFile failed for sharing 1, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 1, access: 80000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 2, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 2, access: 40000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 80000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 40000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: c0000000, GetLastError: 231 === w1064 (32 bit pipe) === pipe.c:240: Test failed: CreateFile failed for sharing 1, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 1, access: 80000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 2, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 2, access: 40000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 80000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 40000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: c0000000, GetLastError: 231 === w864 (64 bit pipe) === pipe.c:240: Test failed: CreateFile failed for sharing 1, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 1, access: 80000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 2, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 2, access: 40000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 80000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 40000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: c0000000, GetLastError: 231 === w1064 (64 bit pipe) === pipe.c:240: Test failed: CreateFile failed for sharing 1, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 1, access: 80000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 2, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 2, access: 40000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 80000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 40000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: c0000000, GetLastError: 231

April 7, 2016

Re: [2/4] ntdll/tests: Add tests for iosb.Status value after pending FSCTL_PIPE_LISTEN call.

by Sebastian Lackner

Those are all existing test failures. On 07.04.2016 09:12, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > https://testbot.winehq.org/JobDetails.pl?Key=21955 > > Your paranoid android. > > > === w864 (32 bit pipe) === > pipe.c:240: Test failed: CreateFile failed for sharing 1, access: 0, GetLastError: 231 > pipe.c:240: Test failed: CreateFile failed for sharing 1, access: 80000000, GetLastError: 231 > pipe.c:240: Test failed: CreateFile failed for sharing 2, access: 0, GetLastError: 231 > pipe.c:240: Test failed: CreateFile failed for sharing 2, access: 40000000, GetLastError: 231 > pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 0, GetLastError: 231 > pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 80000000, GetLastError: 231 > pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 40000000, GetLastError: 231 > pipe.c:240: Test failed: CreateFile failed for sharing 3, access: c0000000, GetLastError: 231 > > === w1064 (32 bit pipe) === > pipe.c:240: Test failed: CreateFile failed for sharing 1, access: 0, GetLastError: 231 > pipe.c:240: Test failed: CreateFile failed for sharing 1, access: 80000000, GetLastError: 231 > pipe.c:240: Test failed: CreateFile failed for sharing 2, access: 0, GetLastError: 231 > pipe.c:240: Test failed: CreateFile failed for sharing 2, access: 40000000, GetLastError: 231 > pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 0, GetLastError: 231 > pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 80000000, GetLastError: 231 > pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 40000000, GetLastError: 231 > pipe.c:240: Test failed: CreateFile failed for sharing 3, access: c0000000, GetLastError: 231 > > === w864 (64 bit pipe) === > pipe.c:240: Test failed: CreateFile failed for sharing 1, access: 0, GetLastError: 231 > pipe.c:240: Test failed: CreateFile failed for sharing 1, access: 80000000, GetLastError: 231 > pipe.c:240: Test failed: CreateFile failed for sharing 2, access: 0, GetLastError: 231 > pipe.c:240: Test failed: CreateFile failed for sharing 2, access: 40000000, GetLastError: 231 > pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 0, GetLastError: 231 > pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 80000000, GetLastError: 231 > pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 40000000, GetLastError: 231 > pipe.c:240: Test failed: CreateFile failed for sharing 3, access: c0000000, GetLastError: 231 > > === w1064 (64 bit pipe) === > pipe.c:240: Test failed: CreateFile failed for sharing 1, access: 0, GetLastError: 231 > pipe.c:240: Test failed: CreateFile failed for sharing 1, access: 80000000, GetLastError: 231 > pipe.c:240: Test failed: CreateFile failed for sharing 2, access: 0, GetLastError: 231 > pipe.c:240: Test failed: CreateFile failed for sharing 2, access: 40000000, GetLastError: 231 > pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 0, GetLastError: 231 > pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 80000000, GetLastError: 231 > pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 40000000, GetLastError: 231 > pipe.c:240: Test failed: CreateFile failed for sharing 3, access: c0000000, GetLastError: 231 >

April 7, 2016

Re: [2/4] ntdll/tests: Add tests for iosb.Status value after pending FSCTL_PIPE_LISTEN call.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21955 Your paranoid android. === w864 (32 bit pipe) === pipe.c:240: Test failed: CreateFile failed for sharing 1, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 1, access: 80000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 2, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 2, access: 40000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 80000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 40000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: c0000000, GetLastError: 231 === w1064 (32 bit pipe) === pipe.c:240: Test failed: CreateFile failed for sharing 1, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 1, access: 80000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 2, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 2, access: 40000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 80000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 40000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: c0000000, GetLastError: 231 === w864 (64 bit pipe) === pipe.c:240: Test failed: CreateFile failed for sharing 1, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 1, access: 80000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 2, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 2, access: 40000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 80000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 40000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: c0000000, GetLastError: 231 === w1064 (64 bit pipe) === pipe.c:240: Test failed: CreateFile failed for sharing 1, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 1, access: 80000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 2, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 2, access: 40000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 80000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 40000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: c0000000, GetLastError: 231

April 7, 2016

Re: [1/4] ntdll/tests: Fix some test failures on Win 8+.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21954 Your paranoid android. === w864 (32 bit pipe) === pipe.c:240: Test failed: CreateFile failed for sharing 1, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 1, access: 80000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 2, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 2, access: 40000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 80000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 40000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: c0000000, GetLastError: 231 === w1064 (32 bit pipe) === pipe.c:240: Test failed: CreateFile failed for sharing 1, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 1, access: 80000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 2, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 2, access: 40000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 80000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 40000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: c0000000, GetLastError: 231 === w864 (64 bit pipe) === pipe.c:240: Test failed: CreateFile failed for sharing 1, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 1, access: 80000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 2, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 2, access: 40000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 80000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 40000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: c0000000, GetLastError: 231 === w1064 (64 bit pipe) === pipe.c:240: Test failed: CreateFile failed for sharing 1, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 1, access: 80000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 2, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 2, access: 40000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 80000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 40000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: c0000000, GetLastError: 231

April 7, 2016

Winegstreamer entry on Wine FAQ Wiki Page

by NP-Hardass

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Hello, About a month ago, I created a Wine Wiki account and requested that it be activated, explicitly so that I could add an entry to the FAQ page [1]. After going to reference this new entry to someone today, I noticed that my changes were reverted soon after my submission and the page was subsequently locked [2]. This submission was made after consulting wine developer, Sebastian Lackner. I think this information would be very useful to users starting to adopt Winegstreamer, now that Andrew Eikum has updated it to gstreamer 1.0 and it is functioning again. I'd like to inquire why the change was reverted, if my content is deemed unnecessary, and if not, why it was not moved elsewhere. - -- NP-Hardass Gentoo Wine maintainer [1] https://wiki.winehq.org/index.php?title=FAQ [2] https://wiki.winehq.org/index.php?title=FAQ&action=history -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXBgQkAAoJEBzZQR2yrxj7Q6gP/27bv0ZQSiRYVgaoWu4SUOsu TXeZyPLTbKs+KbYuScyMmE1fv8d6FetSNdubUw0ZYKyryu7qUqm/19hhhrs3T6Oo j7hXa7QPmsejtRkM3kCWNItPS6M5olEEqBJq2Ics84DrfFiEaUxPdeJwFgiJLwvX erNgf5600OJHzhDxSCa0UfMdEBWBs7DsdVFncgAWyv3s4dnp4L7aaYGgv2vlpkXI QrhbUCzqWy5grjf9HOsmix4Zz9SSwk6xvEMBjRi9RHiAAOTx2f9Gussiwq2N1Dbe VYoZpxtGaEFt+UKtNJds5vZXaSQlWFg+IT8aeh/VglJJp7avM8Hi6gGFQ22CvwUr M31oU3t/adH3EzyKC0eVBrNjiicnRyzFbrTrkWwokKV+LjV/C8/SfexzHqzn40Vi T4yQrMBoHZcjT6YhLXFjVIE4RSIXbmT5TrCA6oAqKgbueGcfiEvLaz8ti/XUnsyO fgiCNrdSV1hPvAi+5yI2l+BE9xxxhrS2DOXyJlxYMflxXctbRnQ0KFjBzs24x4Qj CXXrXavrP8MhMoemzMuBZMEt7hui0+z4WUGZdjc+oT0Cso8VLrdnE93wJdBJOlbD G/K3cQb6hNr387pKcUXTEq1KDTyrH5LCzxOAjS4TOuhFti8jMbSdKRea9flfR2bp pVoJARXzVNeQla7n7+ox =3Bex -----END PGP SIGNATURE-----

April 7, 2016

Re: [PATCH v2] kernel32: Use setprogname(3) to set the program name if available.

by Theodore Dubois

I CC’d him on the original email. It would be neat if the wine program name could show up in Activity Monitor on OSX, so I can tell one wine process apart from another. There is a way to do it (http://stackoverflow.com/questions/4217947/setting-process-name-on-mac-os-x…) but it requires undocumented APIs. (Damn.) ~Theodore > On Apr 6, 2016, at 3:35 PM, Ken Thomases <ken(a)codeweavers.com> wrote: > > Ah, I see. Yeah, that's weird. Have you tried asking Chip directly? I'm CC'ing him. > > -Ken > >> On Apr 6, 2016, at 4:53 PM, Theodore Dubois <tblodt(a)icloud.com> wrote: >> >> Yes, I did. The problem is that the code assumes that argv[0] - argv[1] (= offset) is a meaningful quantity, which it isn’t because each string in the argv array came from strdup. >> >> ~Theodore >> >>> On Apr 6, 2016, at 2:14 PM, Ken Thomases <ken(a)codeweavers.com> wrote: >>> >>> Did you allocate one more entry in your argv than is needed for actual arguments and put a terminating NULL? You're supposed to. >>> >>> -Ken >>> >>>> On Apr 6, 2016, at 3:41 PM, Theodore Dubois <tblodt(a)icloud.com> wrote: >>>> >>>> This patch causes a segfault in the event that __wine_main_argv is not the argv that got passed to main. This happened in a program I wrote that acts as a custom wine loader. It creates an argv by using malloc, then passes that to wine_init. >>>> >>>> Why wouldn’t setprogname(argv[1]) be adequate? >>>> >>>> ~Theodore >>>> >>>>> On Feb 19, 2016, at 2:33 PM, Charles Davis <cdavis5x(a)gmail.com> wrote: >>>>> >>>>> Signed-off-by: Charles Davis <cdavis5x(a)gmail.com> >>> >> >

April 6, 2016

Re: [PATCH v2] kernel32: Use setprogname(3) to set the program name if available.

by Ken Thomases

Ah, I see. Yeah, that's weird. Have you tried asking Chip directly? I'm CC'ing him. -Ken > On Apr 6, 2016, at 4:53 PM, Theodore Dubois <tblodt(a)icloud.com> wrote: > > Yes, I did. The problem is that the code assumes that argv[0] - argv[1] (= offset) is a meaningful quantity, which it isn’t because each string in the argv array came from strdup. > > ~Theodore > >> On Apr 6, 2016, at 2:14 PM, Ken Thomases <ken(a)codeweavers.com> wrote: >> >> Did you allocate one more entry in your argv than is needed for actual arguments and put a terminating NULL? You're supposed to. >> >> -Ken >> >>> On Apr 6, 2016, at 3:41 PM, Theodore Dubois <tblodt(a)icloud.com> wrote: >>> >>> This patch causes a segfault in the event that __wine_main_argv is not the argv that got passed to main. This happened in a program I wrote that acts as a custom wine loader. It creates an argv by using malloc, then passes that to wine_init. >>> >>> Why wouldn’t setprogname(argv[1]) be adequate? >>> >>> ~Theodore >>> >>>> On Feb 19, 2016, at 2:33 PM, Charles Davis <cdavis5x(a)gmail.com> wrote: >>>> >>>> Signed-off-by: Charles Davis <cdavis5x(a)gmail.com> >> >

April 6, 2016

Re: [PATCH v2] kernel32: Use setprogname(3) to set the program name if available.

by Theodore Dubois

Yes, I did. The problem is that the code assumes that argv[0] - argv[1] (= offset) is a meaningful quantity, which it isn’t because each string in the argv array came from strdup. ~Theodore > On Apr 6, 2016, at 2:14 PM, Ken Thomases <ken(a)codeweavers.com> wrote: > > Did you allocate one more entry in your argv than is needed for actual arguments and put a terminating NULL? You're supposed to. > > -Ken > >> On Apr 6, 2016, at 3:41 PM, Theodore Dubois <tblodt(a)icloud.com> wrote: >> >> This patch causes a segfault in the event that __wine_main_argv is not the argv that got passed to main. This happened in a program I wrote that acts as a custom wine loader. It creates an argv by using malloc, then passes that to wine_init. >> >> Why wouldn’t setprogname(argv[1]) be adequate? >> >> ~Theodore >> >>> On Feb 19, 2016, at 2:33 PM, Charles Davis <cdavis5x(a)gmail.com> wrote: >>> >>> Signed-off-by: Charles Davis <cdavis5x(a)gmail.com> >

April 6, 2016