April 2016 - Wine-Devel - list.winehq.org

Re: [PATCH 2/2] msvcr120: Add remainder

by Piotr Caban

On 04/02/16 02:09, Daniel Lehman wrote: > +/********************************************************************* > + * remainder (MSVCR120.@) > + */ > +double CDECL MSVCR120_remainder(double x, double y) > +{ > +#ifdef HAVE_REMAINDER > + return remainder(x, y); > +#else > + FIXME( "not implemented\n" ); > + return 0.0; > +#endif Please handle y==0 case. Thanks, Piotr

April 4, 2016

Re: [PATCH] wininet: Dont fail on invalid Certificates when masking errors.

by Alistair Leslie-Hughes

Hi Jacek, On 04/04/16 21:50, Jacek Caban wrote: > I don't think we should do that. mask_errors means that we should > combine errors, not ignore them. I don't know what you're trying to fix, Should we rename the variable to make more sense then? > but I'd suggest to concentrate on error source (maybe there shouldn't be > an error in the first place or it should be ignored due to > security_flags). If you think that the error is right, maybe we don't > handle failure correctly. > The scenario: I'm trying to connect to a server via https however this server certificate isn't valid. On Windows, I'm prompted once about the certificate error(s), since the combined error flag is set, and after I accept the certificate, it then connects. However WINE is behaving a little differently. I'm don't remember being prompted about the bad certificate (since errors are combined) and then the connection fails. From memory, if errors aren't combined then security prompts are displayed (one for each error). Maybe there is more then one bug here. Best Regards Alistair

April 4, 2016

Re: [PATCH] wininet: Dont fail on invalid Certificates when masking errors.

by Jacek Caban

Hi Alistair, On 04/04/16 11:48, Alistair Leslie-Hughes wrote: > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > dlls/wininet/netconnection.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/dlls/wininet/netconnection.c b/dlls/wininet/netconnection.c > index 7305860..723705a 100644 > --- a/dlls/wininet/netconnection.c > +++ b/dlls/wininet/netconnection.c > @@ -200,7 +200,10 @@ static DWORD netconn_verify_cert(netconn_t *conn, PCCERT_CONTEXT cert, HCERTSTOR > conn->server->cert_chain = NULL; > } > if(conn->mask_errors) > + { > conn->server->security_flags |= conn->security_flags & _SECURITY_ERROR_FLAGS_MASK; > + err = ERROR_SUCCESS; > + } I don't think we should do that. mask_errors means that we should combine errors, not ignore them. I don't know what you're trying to fix, but I'd suggest to concentrate on error source (maybe there shouldn't be an error in the first place or it should be ignored due to security_flags). If you think that the error is right, maybe we don't handle failure correctly. Cheers, Jacek

April 4, 2016

Re: [PATCH] comctrl32/tooltips: AddTool doesn't fails on empty TTTOOLINFO structure

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21855 Your paranoid android. === wxppro (32 bit tooltips) === tooltips.c:382: Test failed: Adding the tool to the tooltip failed === w2003std (32 bit tooltips) === tooltips.c:382: Test failed: Adding the tool to the tooltip failed === wvistau64 (32 bit tooltips) === tooltips.c:382: Test failed: Adding the tool to the tooltip failed === w2008s64 (32 bit tooltips) === tooltips.c:382: Test failed: Adding the tool to the tooltip failed === w7u (32 bit tooltips) === tooltips.c:382: Test failed: Adding the tool to the tooltip failed === w7pro64 (32 bit tooltips) === tooltips.c:382: Test failed: Adding the tool to the tooltip failed === w8 (32 bit tooltips) === tooltips.c:382: Test failed: Adding the tool to the tooltip failed === w864 (32 bit tooltips) === tooltips.c:382: Test failed: Adding the tool to the tooltip failed === w1064 (32 bit tooltips) === tooltips.c:382: Test failed: Adding the tool to the tooltip failed === wvistau64 (64 bit tooltips) === tooltips.c:382: Test failed: Adding the tool to the tooltip failed === w2008s64 (64 bit tooltips) === tooltips.c:382: Test failed: Adding the tool to the tooltip failed === w7pro64 (64 bit tooltips) === tooltips.c:382: Test failed: Adding the tool to the tooltip failed === w864 (64 bit tooltips) === tooltips.c:382: Test failed: Adding the tool to the tooltip failed === w1064 (64 bit tooltips) === tooltips.c:382: Test failed: Adding the tool to the tooltip failed

April 4, 2016

Re: sfc_os: add SRSetRestorePointA/W stubs

by Alistair Leslie-Hughes

Hi Austin, On 04/04/16 10:24, Austin English wrote: > For https://bugs.winehq.org/show_bug.cgi?id=40397 / > https://bugs.winehq.org/show_bug.cgi?id=40410 > > > +BOOL WINAPI SRSetRestorePointA(RESTOREPOINTINFOA *restorepoint, STATEMGRSTATUS *status) >... > + return 0; > +} > It would be better to return TRUE or FALSE for the BOOL type. Best Regards Alistair

April 4, 2016

Wine Download Server

by Nathan

I am having difficulty downloading the three files: https://dl.winehq.org/wine/wine-appdb-*.tar.gz https://dl.winehq.org/wine/wine-bugzilla-*.tar.gz https://dl.winehq.org/wine/wine-wiki-*.xml.gz * not part of the actual file names.

April 4, 2016

wine-1.8.2-rc2 Available

by Michael Stefaniuc

Hello, I have pushed now wine-1.8.2-rc2 (Warning: forced update). Many thanks to Sebastian for reviewing 1.8.2-rc1. As I've missed 3 dependency patches for the fix for bug #13683 I have rebased the stable branch and added a fix for a fix and two test patches. The 1.8.2-rc1 tag is still available. Missed dependencies: 85faafc user32: Ensure that button responds only to changes in WM_CAPTURECHANGED handler. 0bea2f7 comctl32: Ensure that trackbar respond only to changes in WM_CAPTURECHANGED handler. ff063d9 comctl32: Ensure that toolbar respond only to changes in WM_CAPTURECHANGED handler. Fix: 97c70c8 wined3d: Fix driver version check. Tests 1bebee9 kernel32/tests: Add test to show that CompareStringW aborts on first non-matching character. 32f7298 kernel32/tests: Add tests for RtlInterlockedPushListSList[Ex]. The changes excluding tests are: comctl32/toolbar.c | 1 + comctl32/trackbar.c | 1 + user32/button.c | 1 + wined3d/directx.c | 3 +-- 4 files changed, 4 insertions(+), 2 deletions(-) bye michael

April 3, 2016

Re: [PATCH 2/2] d3drm/tests: Add tests for IDirect3DRMObject::Add/DeleteDestroyCallback (v2).

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Hi, A few questions / suggestions: *) What happens if you register the same callback with different context pointers? *) The test already does some testing of the call order. I think you could extend it a bit if you store arrays of expected callback functions and context pointers in the structure and compare them when the callbacks are invoked. *) Does DeleteDestroyCallback return an error when no matching callback is found? *) The last one is mostly curiosity / a bad feeling: Is there a difference between callbacks added with IDirect3DRMObject (and its derived interfaces) and IDirect3DRMObject2? I am asking because Object2 is a separate interface and might be implemented in a separate object and then aggregated. If Microsoft screwed up (they never do that, right? ;-) ) then it'll have its own list of added callbacks... Stefan Am 2016-04-03 um 20:42 schrieb Aaryaman Vasishta: > v2: Fixed commit message. > > Signed-off-by: Aaryaman Vasishta <jem456.vasishta(a)gmail.com> > --- > dlls/d3drm/tests/d3drm.c | 203 ++++++++++++++++++----------------------------- > 1 file changed, 79 insertions(+), 124 deletions(-) > > diff --git a/dlls/d3drm/tests/d3drm.c b/dlls/d3drm/tests/d3drm.c > index 1abfed3..1f197b8 100644 > --- a/dlls/d3drm/tests/d3drm.c > +++ b/dlls/d3drm/tests/d3drm.c > @@ -1219,6 +1219,7 @@ static void test_Frame(void) > struct destroy_context > { > IDirect3DRMObject *obj; > + unsigned int test_idx; > int called; > }; > > @@ -1238,6 +1239,81 @@ static void CDECL destroy_callback1(IDirect3DRMObject *obj, void *arg) > ctxt->called++; > } > > +static void test_destroy_callback(unsigned int test_idx, REFCLSID clsid, REFIID iid) > +{ > + struct destroy_context context; > + IDirect3DRMObject *obj; > + IUnknown *unknown; > + IDirect3DRM *d3drm; > + HRESULT hr; > + > + hr = Direct3DRMCreate(&d3drm); > + ok(SUCCEEDED(hr), "Test %u: Cannot get IDirect3DRM interface (hr = %x).\n", test_idx, hr); > + > + hr = IDirect3DRM_CreateObject(d3drm, clsid, NULL, iid, (void **)&unknown); > + ok(hr == D3DRM_OK, "Test %u: Cannot get IDirect3DRMObject interface (hr = %x).\n", test_idx, hr); > + hr = IUnknown_QueryInterface(unknown, &IID_IDirect3DRMObject, (void**)&obj); > + ok(hr == D3DRM_OK, "Test %u: expected D3DRM_OK (hr = %x).\n", test_idx, hr); > + IUnknown_Release(unknown); > + > + context.called = 0; > + context.test_idx = test_idx; > + context.obj = obj; > + > + hr = IDirect3DRMObject_AddDestroyCallback(obj, NULL, &context); > + ok(hr == D3DRMERR_BADVALUE, "Test %u: expected D3DRMERR_BADVALUE (hr = %x).\n", test_idx, hr); > + > + hr = IDirect3DRMObject_AddDestroyCallback(obj, destroy_callback, &context); > + ok(hr == D3DRM_OK, "Test %u: expected D3DRM_OK (hr = %x).\n", test_idx, hr); > + > + /* same callback added twice */ > + hr = IDirect3DRMObject_AddDestroyCallback(obj, destroy_callback, &context); > + ok(hr == D3DRM_OK, "Test %u: expected D3DRM_OK (hr = %x).\n", test_idx, hr); > + > + hr = IDirect3DRMObject_DeleteDestroyCallback(obj, destroy_callback1, NULL); > + ok(hr == D3DRM_OK, "Test %u: expected D3DRM_OK (hr = %x).\n", test_idx, hr); > + > + hr = IDirect3DRMObject_DeleteDestroyCallback(obj, destroy_callback1, &context); > + ok(hr == D3DRM_OK, "Test %u: expected D3DRM_OK (hr = %x).\n", test_idx, hr); > + > + /* add one more */ > + hr = IDirect3DRMObject_AddDestroyCallback(obj, destroy_callback1, &context); > + ok(hr == D3DRM_OK, "Test %u: expected D3DRM_OK (hr = %x).\n", test_idx, hr); > + > + hr = IDirect3DRMObject_DeleteDestroyCallback(obj, NULL, NULL); > + ok(hr == D3DRMERR_BADVALUE, "Test %u: expected D3DRM_BADVALUE (hr = %x).\n", test_idx, hr); > + > + context.called = 0; > + IDirect3DRMObject_Release(obj); > + ok(context.called == 3, "Test %u: got %d, expected 3.\n", test_idx, context.called); > + > + /* test this pattern - add cb1, add cb2, add cb1, delete cb1 */ > + hr = IDirect3DRM_CreateObject(d3drm, clsid, NULL, iid, (void **)&unknown); > + ok(hr == D3DRM_OK, "Test %u: Cannot get IDirect3DRMObject interface (hr = %x).\n", test_idx, hr); > + hr = IUnknown_QueryInterface(unknown, &IID_IDirect3DRMObject, (void**)&obj); > + ok(hr == D3DRM_OK, "Test %u: expected D3DRM_OK (hr = %x).\n", test_idx, hr); > + IUnknown_Release(unknown); > + > + hr = IDirect3DRMObject_AddDestroyCallback(obj, destroy_callback, &context); > + ok(hr == D3DRM_OK, "Test %u: expected D3DRM_OK (hr = %x).\n", test_idx, hr); > + > + hr = IDirect3DRMObject_AddDestroyCallback(obj, destroy_callback1, &context); > + ok(hr == D3DRM_OK, "Test %u: expected D3DRM_OK (hr = %x).\n", test_idx, hr); > + > + hr = IDirect3DRMObject_AddDestroyCallback(obj, destroy_callback, &context); > + ok(hr == D3DRM_OK, "Test %u: expected D3DRM_OK (hr = %x).\n", test_idx, hr); > + > + hr = IDirect3DRMObject_DeleteDestroyCallback(obj, destroy_callback, &context); > + ok(hr == D3DRM_OK, "Test %u: expected D3DRM_OK (hr = %x).\n", test_idx, hr); > + > + context.called = 0; > + hr = IDirect3DRMObject_QueryInterface(obj, &IID_IDirect3DRMObject, (void**)&context.obj); > + ok(hr == D3DRM_OK, "Test %u: expected D3DRM_OK (hr = %x).\n", test_idx, hr); > + IDirect3DRMObject_Release(context.obj); > + IUnknown_Release(unknown); > + ok(context.called == 2, "Test %u: got %d, expected 2.\n", test_idx, context.called); > +} > + > static void test_object(void) > { > static const struct > @@ -1292,6 +1368,9 @@ static void test_object(void) > ref2 = get_refcount((IUnknown *)d3drm1); > ok(ref2 == ref1, "Test %u: expected ref2 == ref1, got ref1 = %u, ref2 = %u.\n", i, ref1, ref2); > > + /* test Add/Destroy callbacks */ > + test_destroy_callback(i, tests[i].clsid, tests[i].iid); > + > hr = IDirect3DRM2_CreateObject(d3drm2, tests[i].clsid, NULL, tests[i].iid, (void **)&unknown); > ok(SUCCEEDED(hr), "Test %u: expected hr == D3DRM_OK, got %#x.\n", i, hr); > ref2 = get_refcount((IUnknown *)d3drm1); > @@ -1325,7 +1404,6 @@ static void test_object(void) > > static void test_Viewport(void) > { > - struct destroy_context context; > IDirectDrawClipper *pClipper; > HRESULT hr; > IDirect3DRM *d3drm; > @@ -1411,129 +1489,6 @@ static void test_Viewport(void) > ok(data == 1, "got %x\n", data); > IDirect3DRMViewport2_Release(viewport2); > > - /* destroy callback */ > - context.called = 0; > - hr = IDirect3DRMViewport_QueryInterface(viewport, &IID_IDirect3DRMObject, (void**)&context.obj); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - IDirect3DRMObject_Release(context.obj); > - > - hr = IDirect3DRMViewport_AddDestroyCallback(viewport, NULL, &context); > - ok(hr == D3DRMERR_BADVALUE, "expected D3DRMERR_BADVALUE (hr = %x)\n", hr); > - > - hr = IDirect3DRMViewport_AddDestroyCallback(viewport, destroy_callback, &context); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - > - /* same callback added twice */ > - hr = IDirect3DRMViewport_AddDestroyCallback(viewport, destroy_callback, &context); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - > - hr = IDirect3DRMViewport_DeleteDestroyCallback(viewport, destroy_callback1, NULL); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - > - hr = IDirect3DRMViewport_DeleteDestroyCallback(viewport, destroy_callback1, &context); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - > - /* add one more */ > - hr = IDirect3DRMViewport_AddDestroyCallback(viewport, destroy_callback1, &context); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - > - hr = IDirect3DRMViewport_DeleteDestroyCallback(viewport, NULL, NULL); > - ok(hr == D3DRMERR_BADVALUE, "expected D3DRM_BADVALUE (hr = %x)\n", hr); > - > - context.called = 0; > - IDirect3DRMViewport_Release(viewport); > - ok(context.called == 3, "got %d, expected 3\n", context.called); > - > - /* test this pattern - add cb1, add cb2, add cb1, delete cb1 */ > - hr = IDirect3DRM_CreateViewport(d3drm, device, frame, rc.left, rc.top, rc.right, rc.bottom, &viewport); > - ok(hr == D3DRM_OK, "Cannot get IDirect3DRMViewport interface (hr = %x)\n", hr); > - > - hr = IDirect3DRMViewport_AddDestroyCallback(viewport, destroy_callback, &context); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - > - hr = IDirect3DRMViewport_AddDestroyCallback(viewport, destroy_callback1, &context); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - > - hr = IDirect3DRMViewport_AddDestroyCallback(viewport, destroy_callback, &context); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - > - hr = IDirect3DRMViewport_DeleteDestroyCallback(viewport, destroy_callback, &context); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - > - context.called = 0; > - hr = IDirect3DRMViewport_QueryInterface(viewport, &IID_IDirect3DRMObject, (void**)&context.obj); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - IDirect3DRMObject_Release(context.obj); > - IDirect3DRMViewport_Release(viewport); > - ok(context.called == 2, "got %d, expected 2\n", context.called); > - > - /* destroy from Viewport2 */ > - hr = IDirect3DRM_CreateViewport(d3drm, device, frame, rc.left, rc.top, rc.right, rc.bottom, &viewport); > - ok(hr == D3DRM_OK, "Cannot get IDirect3DRMViewport interface (hr = %x)\n", hr); > - > - hr = IDirect3DRMViewport_QueryInterface(viewport, &IID_IDirect3DRMViewport2, (void**)&viewport2); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - IDirect3DRMViewport_Release(viewport); > - > - context.called = 0; > - hr = IDirect3DRMViewport2_QueryInterface(viewport2, &IID_IDirect3DRMObject, (void**)&context.obj); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - IDirect3DRMObject_Release(context.obj); > - > - hr = IDirect3DRMViewport2_AddDestroyCallback(viewport2, NULL, &context); > - ok(hr == D3DRMERR_BADVALUE, "expected D3DRMERR_BADVALUE (hr = %x)\n", hr); > - > - hr = IDirect3DRMViewport2_AddDestroyCallback(viewport2, destroy_callback, &context); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - > - /* same callback added twice */ > - hr = IDirect3DRMViewport2_AddDestroyCallback(viewport2, destroy_callback, &context); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - > - hr = IDirect3DRMViewport2_DeleteDestroyCallback(viewport2, destroy_callback1, NULL); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - > - hr = IDirect3DRMViewport2_DeleteDestroyCallback(viewport2, destroy_callback1, &context); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - > - /* add one more */ > - hr = IDirect3DRMViewport2_AddDestroyCallback(viewport2, destroy_callback1, &context); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - > - hr = IDirect3DRMViewport2_DeleteDestroyCallback(viewport2, NULL, NULL); > - ok(hr == D3DRMERR_BADVALUE, "expected D3DRM_BADVALUE (hr = %x)\n", hr); > - > - context.called = 0; > - IDirect3DRMViewport2_Release(viewport2); > - ok(context.called == 3, "got %d, expected 3\n", context.called); > - > - /* test this pattern - add cb1, add cb2, add cb1, delete cb1 */ > - hr = IDirect3DRM_CreateViewport(d3drm, device, frame, rc.left, rc.top, rc.right, rc.bottom, &viewport); > - ok(hr == D3DRM_OK, "Cannot get IDirect3DRMViewport interface (hr = %x)\n", hr); > - > - hr = IDirect3DRMViewport_QueryInterface(viewport, &IID_IDirect3DRMViewport2, (void**)&viewport2); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - IDirect3DRMViewport_Release(viewport); > - > - hr = IDirect3DRMViewport2_AddDestroyCallback(viewport2, destroy_callback, &context); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - > - hr = IDirect3DRMViewport2_AddDestroyCallback(viewport2, destroy_callback1, &context); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - > - hr = IDirect3DRMViewport2_AddDestroyCallback(viewport2, destroy_callback, &context); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - > - hr = IDirect3DRMViewport2_DeleteDestroyCallback(viewport2, destroy_callback, &context); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - > - context.called = 0; > - hr = IDirect3DRMViewport2_QueryInterface(viewport2, &IID_IDirect3DRMObject, (void**)&context.obj); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - IDirect3DRMObject_Release(context.obj); > - IDirect3DRMViewport2_Release(viewport2); > - ok(context.called == 2, "got %d, expected 2\n", context.called); > - > IDirect3DRMFrame_Release(frame); > IDirect3DRMDevice_Release(device); > IDirectDrawClipper_Release(pClipper); > -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXAXjPAAoJEN0/YqbEcdMwaCAP/R0jPTn4638NJY+4kpdtREkT pmpe3+RAx7XQXqJd7baFP1Ge5A8+UyH0GC5jraqneelZ4tjIePY9weFtTI0dPlbO W5Ptty2lIqI5e79S9BC9RYn6HOVVcLqWZTbArBwfRLWCDmHFDKIvLzzg1CmgVoZQ rL8pPiqzE0qanj7UnAZXt8/N5Dz8Uy3aY2tXimnn/ao/ET4Tpi2rp6CRuFGXo71I n7ydIj+spggC6GSk1HmOiAsHLOoKwmmxd83XOrQE+awlYJVxe/jrKZu6Du/29eYa /J+xfD9iHvm2oXAvQKNy8Tca3KaynCTB0aLPzZzZ1E/UXZsI3CPYWeEzXNxkyvQv yrSVRWyUjhAegPB3DUB4JWZq8sDiEjZw6y8hRwibN3NCGTZYtjsK2AuFAK5zUmlH H4k6BFtYRyVNvOUARA5UHO+bJ9wzr0nak14DZbiWoDYISLFKm77nieWR4EU03TNh cZWOpQde/CngNRXIr1mth/WAabPm8WN1IXRcayDAh5GfTC3bVLiRvrjT/vlpm8AH G+9qVEUTmH7HRpSXJpQ4vjAnZJkpJa/ixJazz9cxcNYucPD1LMg/ZbvTGLjKRFhF 1yR9UWOFKBAZyKolehBwRuDFFzw0cXpsUJW9gW/CFyoxtoL6qV+BmmZLN2Gy6Yoe XQJAPbjrbZ4oxHyyGsGp =BxYw -----END PGP SIGNATURE-----

April 3, 2016

Re: [PATCH 1/2] d3drm/tests: Add tests for IDirect3DRM*::CreateObject.

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Hi, Some curiosities: Am 2016-04-03 um 20:04 schrieb Aaryaman Vasishta: > + for (i = 0; i < sizeof(tests) / sizeof(*tests); ++i) > + { > + hr = IDirect3DRM_CreateObject(d3drm1, tests[i].clsid, NULL, NULL, NULL); > + todo_wine ok(hr == D3DRMERR_BADVALUE, "Test %u: expected hr == D3DRMERR_BADVALUE, got %#x.\n", i, hr); What does clsid != NULL, refiid == NULL, output object != NULL do? I guess that clsid is the object you create, and iid is the interface to that object that is returned. So I guess in theory you can pass clsid = IDirect3DRMTexture3, iid = IDirect3DRMTexture and you'd get the same result as creating a d3drmtexture3 object and then calling QI(IDirect3DRMTexture). It might be worth adding explicit tests for this in future patches. (And if you use aggregation you'll want to pass iid == IUnknown, otherwise there's no way you get the inner IUnknown and will never be able to release the object) > + ref2 = get_refcount((IUnknown *)d3drm1); > + ok(ref2 == ref1, "Test %u: expected ref2 == ref1, got ref1 = %u, ref2 = %u.\n", i, ref1, ref2); > + IUnknown_Release(unknown); > + ref2 = get_refcount((IUnknown *)d3drm1); > + ok(ref2 == ref1, "Test %u: expected ref2 == ref1, got ref1 = %u, ref2 = %u.\n", i, ref1, ref2); So what will increment the refcount? InitFrom*? > + hr = IDirect3DRM2_CreateObject(d3drm2, tests[i].clsid, NULL, tests[i].iid, (void **)&unknown); > + ok(SUCCEEDED(hr), "Test %u: expected hr == D3DRM_OK, got %#x.\n", i, hr); > + ref2 = get_refcount((IUnknown *)d3drm1); > + ok(ref2 == ref1, "Test %u: expected ref2 == ref1, got ref1 = %u, ref2 = %u.\n", i, ref1, ref2); > + ref3 = get_refcount((IUnknown *)d3drm2); > + ok(ref3 == ref1, "Test %u: expected ref3 == ref1, got ref1 = %u, ref3 = %u.\n", i, ref1, ref3); > ... > + > + hr = IDirect3DRM3_CreateObject(d3drm3, tests[i].clsid, NULL, tests[i].iid, (void **)&unknown); > + ok(SUCCEEDED(hr), "Test %u: expected hr == D3DRM_OK, got %#x.\n", i, hr); > + ref2 = get_refcount((IUnknown *)d3drm1); > + ok(ref2 == ref1, "Test %u: expected ref2 == ref1, got ref1 = %u, ref2 = %u.\n", i, ref1, ref2); > + ref3 = get_refcount((IUnknown *)d3drm3); > + ok(ref3 == ref1, "Test %u: expected ref3 == ref1, got ref1 = %u, ref3 = %u.\n", i, ref1, ref3); Since you're testing the refcounts of 1,2 and 1,3 you might as well test the refcounts of all interfaces in all 3 versions. Cheers, Stefan -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXAXWIAAoJEN0/YqbEcdMwbkIQAI9ItseZE8bef+z24Cisul9g UYxXhve3Ll9Pz5vVB+jG0H0F5iPk4vdmoHIwsJgd018xBnwXc1C0+QkTknsTHcfI LOb1l4PbjherhDNDn+4t95Hy3fdHKrutFkMhYp73m1+0V5GwY7MANCmIxu4b/z+b nW545EvcpPGluZXPcPyWiwGi9qB33VkGRvDkUpii8qQtwC+vsrDuerWcT2V7fbXj 2R0O9QSuvlbd83p16i3nVx2R8ZQRweYQoSKKdLBca07cIt3/xW6lBJOz34yUmupE 5PdKK0wOPWMKXVCuAplWuDGrvgCOtyMcIB1FmsUfxPfLjonfX3UeXoWfTwMmrMBo XkzgZj8S6JTPK2qOegzg8nGz8FZXvsvWkUZWzCtypuuAQ3rGn5p940JwIu3pW+Cq 4Z3K+r7Ka9lYxSJfiliNyhqPIlrGytHbrpN0aTmWJGn79Jqs7Ffd01+ujOQ2NlOf POWffmglWRHoYDZjSOS2JaL597hhna7ktM0xlhTWHT7HFgRB4oCV2DJAHmSeZUME egudzSfSbRgB9u8bQQpfrYr/kV6MJ0OE2d3VoTn8RRJ3RJL5UFp08N7m+YXkQW9T LAzfiyaAjNILLTCj4tpqjEikH2ftGE/hBH+tInXTKlwnf1NyB6iz5/1+dAm+7JYk MKdVO/nQCpGffRqmYNtG =H6sj -----END PGP SIGNATURE-----

April 3, 2016

Re: [PATCH] loader: Fix wld_prctl prototype.

by Qian Hong

On Mon, Apr 4, 2016 at 1:42 AM, Qian Hong <qhong(a)codeweavers.com> wrote: > reserve debugging Typo, should be "Reverse Debugging". One can debug with "backward step in" and "backward next". Maybe useful for Wine developers. -- Regards, Qian Hong - http://www.codeweavers.com

April 3, 2016