May 2016 - Wine-Devel - list.winehq.org

Re: [PATCH 1/1] libwine: Use WINEUSER as user_name, if set

by Lucian Poston

I don't have a specific example app that I can share here, but more generally, it's useful for apps that behaves differently based upon the running user name. A useful scenario is an app that uses the current user name as part of a heuristic to track the user. This patch could help mitigate that. On Tue, May 10, 2016 at 6:51 AM, Bruno Jesus <00cpxxx(a)gmail.com> wrote: > On Mon, May 9, 2016 at 1:01 AM, Lucian Poston <lucian.poston(a)gmail.com> wrote: >> Signed-off-by: Lucian Poston <lucian.poston(a)gmail.com> >> --- >> libs/wine/config.c | 11 ++++++++++- >> 1 file changed, 10 insertions(+), 1 deletion(-) > > Hi, can you describe some useful scenarios and programs where this > could be useful?

May 17, 2016

Re: [PATCH v2 3/6] ddraw: Forbid creating flippable cubemaps.

by Henri Verbeet

On 13 May 2016 at 13:55, Józef Kucia <jkucia(a)codeweavers.com> wrote: > + if (desc->ddsCaps.dwCaps2 & DDSCAPS2_CUBEMAP) > + { > + WARN("Tried to create a flippable cubemap.\n"); > + HeapFree(GetProcessHeap(), 0, texture); > + return DDERR_INVALIDPARAMS; > + } > + > if (desc->ddsCaps.dwCaps & DDSCAPS_TEXTURE) > { > FIXME("Flippable textures not implemented.\n"); > @@ -5748,6 +5755,8 @@ HRESULT ddraw_surface_create(struct ddraw *ddraw, const DDSURFACEDESC2 *surface_ > { > WARN("Tried to specify a back buffer count for a non-flippable surface.\n"); > HeapFree(GetProcessHeap(), 0, texture); > + if (desc->ddsCaps.dwCaps2 & DDSCAPS2_CUBEMAP) > + return DDERR_INVALIDPARAMS; > return DDERR_INVALIDCAPS; > } I suppose it ends up being more or less the same thing, but to me this looks like DDSD_BACKBUFFERCOUNT being disallowed for cubemaps rather than DDSCAPS_FLIP.

May 17, 2016

Re: [PATCH] kernel32/nls: Added SSHORTESTDAYNAME* entries

by Nikolay Sivov

On 17.05.2016 9:21, Henri Verbeet wrote: >> diff --git a/dlls/kernel32/nls/urd.nls b/dlls/kernel32/nls/urd.nls >> index 65b57f7..9ce5689 100644 >> --- a/dlls/kernel32/nls/urd.nls >> +++ b/dlls/kernel32/nls/urd.nls >> @@ -134,6 +134,13 @@ STRINGTABLE LANGUAGE LANG_URDU, SUBLANG_URDU_PAKISTAN >> LOCALE_SPOSITIVESIGN "" >> LOCALE_SSCRIPTS "Arab;" >> LOCALE_SSHORTDATE "dd/MM/yyyy" >> + LOCALE_SSHORTESTDAYNAME1 "پ" >> + LOCALE_SSHORTESTDAYNAME2 "م" >> + LOCALE_SSHORTESTDAYNAME3 "ب" >> + LOCALE_SSHORTESTDAYNAME4 "ج" >> + LOCALE_SSHORTESTDAYNAME5 "ج" > I'm no expert on Urdu, but it seems suspicious to have the same > abbreviation for two different days. > That's what Windows returns for ur-PK, ur, and ur-IN. I don't know if it's a mistake, but it's different from the rest of locales using Arabic script. Same happens for days 5 and 6 for Hindi (hi-IN), days 1 and 2 for Armenian, days 1, 2, 6 for Indonesian id-ID, days 5 and 6 of Kannada kn-IN. So it's not uncommon apparently, but a bit confusing. Probably such names are supposed to be used all together, so context is clear.

May 17, 2016

Re: [PATCH] kernel32/nls: Added SSHORTESTDAYNAME* entries

by Henri Verbeet

> diff --git a/dlls/kernel32/nls/urd.nls b/dlls/kernel32/nls/urd.nls > index 65b57f7..9ce5689 100644 > --- a/dlls/kernel32/nls/urd.nls > +++ b/dlls/kernel32/nls/urd.nls > @@ -134,6 +134,13 @@ STRINGTABLE LANGUAGE LANG_URDU, SUBLANG_URDU_PAKISTAN > LOCALE_SPOSITIVESIGN "" > LOCALE_SSCRIPTS "Arab;" > LOCALE_SSHORTDATE "dd/MM/yyyy" > + LOCALE_SSHORTESTDAYNAME1 "پ" > + LOCALE_SSHORTESTDAYNAME2 "م" > + LOCALE_SSHORTESTDAYNAME3 "ب" > + LOCALE_SSHORTESTDAYNAME4 "ج" > + LOCALE_SSHORTESTDAYNAME5 "ج" I'm no expert on Urdu, but it seems suspicious to have the same abbreviation for two different days.

May 17, 2016

Re: [PATCH 2/2] include: Use inline functions for common RECT helpers.

by Alexandre Julliard

Alexandre Julliard <julliard(a)winehq.org> writes: > Michael Stefaniuc <mstefani(a)redhat.de> writes: > >> Signed-off-by: Michael Stefaniuc <mstefani(a)redhat.de> >> --- >> dlls/user32/tests/uitools.c | 1 + >> dlls/user32/uitools.c | 1 + >> include/winuser.h | 38 +++++++++++++++++++++++++++++++++++--- >> 3 files changed, 37 insertions(+), 3 deletions(-) > > Not really your fault, but this is causing some warnings here: Sorry, Henri pointed out that this is what patch 1/2 was for, I should have checked that one first. -- Alexandre Julliard julliard(a)winehq.org

May 17, 2016

Re: [PATCH] winex11: Send SC_KEYMENU on managed windows.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23042 Your paranoid android. === wvistau64 (32 bit msg) === msg.c:11039: Test failed: expected PeekMessage to return FALSE, got 1 === w864 (32 bit msg) === msg.c:6484: Test failed: Update region shouldn't be empty msg.c:6718: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6720: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different === w1064 (32 bit msg) === msg.c:6484: Test failed: Update region shouldn't be empty msg.c:6718: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6720: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different msg.c:7440: Test failed: destroy child on thread exit: 3: the msg sequence is not complete: expected 0000 - actual 001a === w1064 (64 bit msg) === msg.c:6484: Test failed: Update region shouldn't be empty msg.c:6718: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6720: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different msg.c:7440: Test failed: destroy child on thread exit: 3: the msg sequence is not complete: expected 0000 - actual 001a

May 17, 2016

Re: [PATCH 2/2] include: Use inline functions for common RECT helpers.

by Alexandre Julliard

Michael Stefaniuc <mstefani(a)redhat.de> writes: > Signed-off-by: Michael Stefaniuc <mstefani(a)redhat.de> > --- > dlls/user32/tests/uitools.c | 1 + > dlls/user32/uitools.c | 1 + > include/winuser.h | 38 +++++++++++++++++++++++++++++++++++--- > 3 files changed, 37 insertions(+), 3 deletions(-) Not really your fault, but this is causing some warnings here: gcc -m32 -c -o device.o device.c -I. -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe \ -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers \ -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wvla -Wwrite-strings -Wpointer-arith \ -Wlogical-op -gdwarf-2 -gstrict-dwarf -fno-omit-frame-pointer -Werror -g -O2 -fno-diagnostics-show-caret device.c: In function ‘device_clear_render_targets’: device.c:393:9: error: ‘ds_rect.bottom’ may be used uninitialized in this function [-Werror=maybe-uninitialized] device.c:393:9: error: ‘ds_rect.right’ may be used uninitialized in this function [-Werror=maybe-uninitialized] cc1: all warnings being treated as errors make: *** [device.o] Error 1 -- Alexandre Julliard julliard(a)winehq.org

May 17, 2016

Re: [PATCH 11/11] wininet: Added test of cookies with long URL.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23039 Your paranoid android. === w1064 (32 bit internet) === internet.c:1092: Test failed: expected ret == 0, got 87 === w1064 (64 bit internet) === internet.c:1092: Test failed: expected ret == 0, got 87

May 16, 2016

Re: [PATCH 02/11] wininet: Fixed handing NULL buffer in InternetReadFileExW.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23038 Your paranoid android. === w864 (64 bit http) === http.c:5241: Test failed: HttpSendRequest failed: 8

May 16, 2016

Re: [PATCH 01/11] wininet: Fixed internet tests on win10.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23037 Your paranoid android. === w1064 (32 bit internet) === internet.c:1074: Test failed: expected ret == 0, got 87 === w1064 (64 bit internet) === internet.c:1074: Test failed: expected ret == 0, got 87

May 16, 2016