May 2016 - Wine-Devel - list.winehq.org

ntdll: Store the directory identity and search mask in the directory cache

by Piotr Caban

The patch breaks compilation on mac: directory.c:1973:42: error: expected identifier if (!has_wildcard( dir_data->->mask )) break; ^ directory.c:2164:34: error: use of undeclared identifier 'dir_data' const UNICODE_STRING *mask = dir_data->mask; ^ directory.c:2216:61: error: use of undeclared identifier 'dir_data' union file_directory_info *info = append_entry( dir_data, bu... Thanks, Piotr

May 2, 2016

Re: [PATCH] comctl32/tooltips: Cut tooltip text at first tab char unless TTS_NOPREFIX is used

by Dmitry Timoshkov

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > @@ -316,49 +318,40 @@ static void test_gettext(void) > toolinfoA.lParam = 0xdeadbeef; > GetClientRect(hwnd, &toolinfoA.rect); > r = SendMessageA(hwnd, TTM_ADDTOOLA, 0, (LPARAM)&toolinfoA); > - if (r) > - { > - toolinfoA.hwnd = NULL; > - toolinfoA.uId = 0x1234ABCD; > - toolinfoA.lpszText = bufA; > - SendMessageA(hwnd, TTM_GETTEXTA, 0, (LPARAM)&toolinfoA); > - ok(strcmp(toolinfoA.lpszText, "") == 0, "lpszText should be an empty string\n"); > > - toolinfoA.lpszText = bufA; > - SendMessageA(hwnd, TTM_GETTOOLINFOA, 0, (LPARAM)&toolinfoA); > - ok(toolinfoA.lpszText == NULL, > - "expected NULL, got %p\n", toolinfoA.lpszText); 'r' is assigned but not used. Perhaps it would be a good idea to test return value of every SendMessage() call. -- Dmitry.

May 2, 2016

Re: dwmapi: Return S_OK in DwmSetWindowAttribute stub.

by Sebastian Lackner

On 02.05.2016 15:16, Nikolay Sivov wrote: > > What application is that for? For example this one: https://appdb.winehq.org/objectManager.php?sClass=version&iId=33471

May 2, 2016

Re: dwmapi: Return S_OK in DwmSetWindowAttribute stub.

by Nikolay Sivov

On 02.05.2016 16:06, Sebastian Lackner wrote: > From: Michael Müller <michael(a)fds-team.de> > > Signed-off-by: Michael Müller <michael(a)fds-team.de> > Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de> > --- > dlls/dwmapi/dwmapi_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/dwmapi/dwmapi_main.c b/dlls/dwmapi/dwmapi_main.c > index 155d7d3..8c3472a 100644 > --- a/dlls/dwmapi/dwmapi_main.c > +++ b/dlls/dwmapi/dwmapi_main.c > @@ -126,7 +126,7 @@ HRESULT WINAPI DwmSetWindowAttribute(HWND hwnd, DWORD attributenum, LPCVOID attr > > if (!once++) FIXME("(%p, %x, %p, %x) stub\n", hwnd, attributenum, attribute, size); > > - return E_NOTIMPL; > + return S_OK; > } > > /********************************************************************** > What application is that for?

May 2, 2016

Re: [PATCH 2/2 v2] mshtml: Make it possible to clear timer and interval with any of clearTimeout and clearInterval functions

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22785 Your paranoid android. === wxppro (32 bit events) === events.c:1388: timeout The test timed out === w2003std (32 bit events) === events.c:1388: timeout The test timed out === wvistau64 (32 bit events) === events.c:1388: timeout The test timed out === w2008s64 (32 bit events) === events.c:1388: timeout === w7u (32 bit events) === events.c:1388: timeout === w7pro64 (32 bit events) === events.c:1388: timeout === w8 (32 bit events) === events.c:1388: timeout === w864 (32 bit events) === events.c:1388: timeout events.c:1388: timeout === w1064 (32 bit events) === events.c:1388: timeout events.c:1388: timeout === wvistau64 (64 bit events) === events.c:1388: timeout === w2008s64 (64 bit events) === events.c:1388: timeout === w7pro64 (64 bit events) === events.c:1388: timeout === w864 (64 bit events) === events.c:1388: timeout events.c:1388: timeout === w1064 (64 bit events) === events.c:1388: timeout events.c:1388: timeout

May 2, 2016

Re: [PATCH 1/2 v2] mshtml: Fix HTMLWindow3_setInterval behavior on 0 msec intervals

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22784 Your paranoid android. === wxppro (32 bit events) === events.c:1388: timeout === w2003std (32 bit events) === events.c:1388: timeout === wvistau64 (32 bit events) === events.c:1388: timeout === w2008s64 (32 bit events) === events.c:1388: timeout === w7u (32 bit events) === events.c:1388: timeout === w7pro64 (32 bit events) === events.c:1388: timeout === w8 (32 bit events) === events.c:1388: timeout === w864 (32 bit events) === events.c:1388: timeout events.c:1388: timeout === w1064 (32 bit events) === events.c:1388: timeout events.c:1388: timeout === wvistau64 (64 bit events) === events.c:1388: timeout === w2008s64 (64 bit events) === events.c:1388: timeout === w7pro64 (64 bit events) === events.c:1388: timeout === w864 (64 bit events) === events.c:1388: timeout events.c:1388: timeout === w1064 (64 bit events) === events.c:1388: timeout events.c:1388: timeout

May 2, 2016

Re: [PATCH] po: update Norwegian translation

by Kim Malmo

For v2 I will try to further cut down on quotation marks usage, and in the context of placeholders, use straight double quotes. Apart from the quotation marks, are there other concerns with the translation or does it otherwise look good? Den 01. mai 2016 00:33, skrev Francois Gouget: > On Sat, 30 Apr 2016, Nikolay Sivov wrote: > [...] >> Regarding quotation marks, it's really up to target language to use one >> of several styles of quotation marks and quotation formatting. Original >> English text is only a reference, not something to follow. >> >> User guide you mentioned, mostly tells to omit quotation marks (p. 58), >> and use straight double quotes if they are necessary. >> >> The fact that '«' and '»' are missing from default keyboard layout is >> unfortunate but can't alone be a reason not to use them, if traditional >> typographical rules tell so. > On page 85 the user guide doubles down on their recommendation to avoid > quotation marks, but also seem to recommend straight quotes, at least in > the context of placeholders: > > | Placeholders are often surrounded by single or double quotes in the > | English source text. Quotes should be avoided in the Norwegian Bokmål > | software. If they are needed in order to clarify the string, use > | straight double quotes. > >

May 2, 2016

Re: mode: add stub exe

by Nikolay Sivov

> +MODULE = mode.exe I don't know how important that is, but on Win7 it's called mode.com, just what bug title says. > @@ -3472,6 +3472,7 @@ WINE_CONFIG_PROGRAM(iexplore,,[install]) > WINE_CONFIG_PROGRAM(ipconfig,,[clean,install]) > WINE_CONFIG_PROGRAM(lodctr,,[install]) > WINE_CONFIG_PROGRAM(mofcomp,,[install]) > +WINE_CONFIG_PROGRAM(mode,,[install]) > WINE_CONFIG_PROGRAM(mshta,,[install]) > WINE_CONFIG_PROGRAM(msiexec,,[install,installbin,manpage]) > WINE_CONFIG_PROGRAM(net,,[clean,install]) This is not sorted.

May 2, 2016

Re: [v2 1/2] d3dx9: Add 'exp' preshader opcode.

by Matteo Bruni

2016-04-25 10:52 GMT+02:00 Paul Gofman <gofmanp(a)gmail.com>: > + op_step = 2 + (args_count + 1) * 3; You could instead calculate that in the caller and pass it in place of args_count. Or, probably better, you could pass the entire op_tests[] table entry to the function, you're currently passing all the fields one by one anyway. > + for (i = 0; i < 4; ++i) > + todo_wine_if(todo && todo[i]) > + ok(compare_float(v[i], ((float *)expected_result)[i], ulps), > + "Operation %s, component %u, expected %#x (%g), got %#x (%g).\n", op_mnem, > + i, expected_result[i], ((float *)expected_result)[i], ((unsigned int *)v)[i], v[i]); todo currently can never be NULL. > + for (i = 0; i < ARRAY_SIZE(op_tests); ++i) > + test_preshader_op(device, test_effect_preshader_effect_blob, sizeof test_effect_preshader_effect_blob, > + blob_position[op_tests[i].args_count].pos, blob_position[op_tests[i].args_count].result_index, > + op_tests[i].mnem, op_tests[i].opcode, op_tests[i].args_count, > + op_tests[i].expected_result, &op_tests[i].fvect1, &op_tests[i].fvect2, > + op_tests[i].ulps, op_tests[i].todo); Parenthesis around sizeof operand, please.

May 1, 2016

Re: [PATCH 1/2] d3dx9: Add 'exp' preshader opcode.

by Matteo Bruni

2016-04-22 17:59 GMT+02:00 Paul Gofman <gofmanp(a)gmail.com>: > On 04/22/2016 05:15 PM, Matteo Bruni wrote: >> >>> + float *v; >>> + unsigned int op_pos, op_step, result_index; >>> + D3DXHANDLE param; >>> + >>> + if (args_count == 1) >>> + { >>> + op_pos = TEST_EFFECT_PRESHADER_OP0_POS; >>> + op_step = TEST_EFFECT_PRESHADER_OP0_INS_SIZE; >>> + result_index = 0; >>> + } >>> + else if (args_count == 2) >>> + { >>> + op_pos = TEST_EFFECT_PRESHADER_OPMUL_POS; >>> + op_step = TEST_EFFECT_PRESHADER_OPMUL_INS_SIZE; >>> + result_index = 2; >>> + } >>> + else >>> + { >>> + return; >>> + } >> That doesn't seem particularly nice, especially WRT extending this >> test later on. >> It seems better to have the "original" bytecode and these variables >> you compute here passed in from the caller (maybe stored in a struct >> together with the opcode parameters). > I am not sure I understand how do you see this original bytecode: is it > a pointer inside the effect blob to the code to be altered, the whole > effect blob pointer or something else? I imagined passing a pointer to the whole bytecode, which you then copy and modify here. I.e. pretty much what you did in v2. >> test_effect_preshader_ops() should probably be table-based. At that >> point the *_POS and *_SIZE defines might become unnecessary; if they >> stay they should probably be named after the argument count (which is >> the actually interesting part, the original operation is going to >> change for the test and can be figured out from the light index) >> instead. > I can put it in the array but do we need to make this too generic? I. e. > support other argument counts besides 1 and 2? I know just one opcode > which has more opcodes and we are unlikely to encounter much more. I was > planning to test d3dts_dotswiz separately outside of this > infrastructure. I can get rid of _SIZE define (as actually it can be > computed from arguments count), but how do you see getting rid of _POS? Just putting it in the table without a define, I don't think it would look too bad. Unless you'll need to use the same values in some other test.

May 1, 2016