May 2016 - Wine-Devel - list.winehq.org

Re: [PATCH 3/4] d3drm: Implement IDirect3DRM*_CreateTexture.

by Aaryaman Vasishta

Hi, I've already submitted a patch with the exact same changes. See https://source.winehq.org/patches/data/121990 Cheers, Aaryaman On Mon, May 2, 2016 at 1:42 AM, Stefan Dösinger <stefandoesinger(a)gmail.com> wrote: > Hi, > > I'd thunk CreateTexture1 -> CreateTexture3, CreateTexture2->CreateTexture3 > and implement CreateTexture3 via CreateObject + InitFromImage - unless > there's some behavior difference in those methods that prevents you from > doing this. > > Cheers, > Stefan > > > Am 29.04.2016 um 11:25 schrieb Aaryaman Vasishta < > jem456.vasishta(a)gmail.com>: > > > Not really, I thought that since InitFromImage doesn't exist for version > 1, I wasn't sure if it's a good idea to use it within CreateTexture for > version 1. > > Is it fine, though?. I'll use InitFromImage if it's a better approach. > Besides, since they behave the same so far, there's no reason to not use it > anyways. > > > > I agree with thunking version 2's CreateTexture to version 3, I'll > resend the patch for the same, after I get to know your opinion for the > above question. > > > > Cheers, > > Aaryaman > > > > On Fri, Apr 29, 2016 at 1:06 PM, Stefan Dösinger < > stefandoesinger(a)gmail.com> wrote: > > > >> Am 28.04.2016 um 20:17 schrieb Aaryaman Vasishta < > jem456.vasishta(a)gmail.com>: > >> > >> @@ -198,13 +198,24 @@ static HRESULT WINAPI > d3drm1_CreateTexture(IDirect3DRM *iface, > >> struct d3drm_texture *object; > >> HRESULT hr; > >> > >> - FIXME("iface %p, image %p, texture %p partial stub.\n", iface, > image, texture); > >> + TRACE("iface %p, image %p, texture %p.\n", iface, image, texture); > >> + > >> + if (!d3drm_validate_image(image)) > >> + return D3DRMERR_BADVALUE; > >> > >> if (FAILED(hr = d3drm_texture_create(&object))) > >> + { > >> + d3drm_texture_destroy(object); > >> return hr; > >> + } > >> + object->d3drm = iface; > >> + object->initialized = TRUE; > >> + object->image = image; > >> > >> *texture = &object->IDirect3DRMTexture_iface; > >> > >> + IDirect3DRM_AddRef(iface); > >> + > >> return D3DRM_OK; > >> } > >> > > Is there anything wrong with calling Texture3::InitFromImage here, or > even calling IDirect3DRM3::CreateTexture? in D3DRM1::CreateTexture and > D3DRM2::CreateTexture? > > > >

May 1, 2016

Re: [PATCH 3/4] d3drm: Implement IDirect3DRM*_CreateTexture.

by Stefan Dösinger

Hi, I'd thunk CreateTexture1 -> CreateTexture3, CreateTexture2->CreateTexture3 and implement CreateTexture3 via CreateObject + InitFromImage - unless there's some behavior difference in those methods that prevents you from doing this. Cheers, Stefan Am 29.04.2016 um 11:25 schrieb Aaryaman Vasishta <jem456.vasishta(a)gmail.com>: > Not really, I thought that since InitFromImage doesn't exist for version 1, I wasn't sure if it's a good idea to use it within CreateTexture for version 1. > Is it fine, though?. I'll use InitFromImage if it's a better approach. Besides, since they behave the same so far, there's no reason to not use it anyways. > > I agree with thunking version 2's CreateTexture to version 3, I'll resend the patch for the same, after I get to know your opinion for the above question. > > Cheers, > Aaryaman > > On Fri, Apr 29, 2016 at 1:06 PM, Stefan Dösinger <stefandoesinger(a)gmail.com> wrote: > >> Am 28.04.2016 um 20:17 schrieb Aaryaman Vasishta <jem456.vasishta(a)gmail.com>: >> >> @@ -198,13 +198,24 @@ static HRESULT WINAPI d3drm1_CreateTexture(IDirect3DRM *iface, >> struct d3drm_texture *object; >> HRESULT hr; >> >> - FIXME("iface %p, image %p, texture %p partial stub.\n", iface, image, texture); >> + TRACE("iface %p, image %p, texture %p.\n", iface, image, texture); >> + >> + if (!d3drm_validate_image(image)) >> + return D3DRMERR_BADVALUE; >> >> if (FAILED(hr = d3drm_texture_create(&object))) >> + { >> + d3drm_texture_destroy(object); >> return hr; >> + } >> + object->d3drm = iface; >> + object->initialized = TRUE; >> + object->image = image; >> >> *texture = &object->IDirect3DRMTexture_iface; >> >> + IDirect3DRM_AddRef(iface); >> + >> return D3DRM_OK; >> } >> > Is there anything wrong with calling Texture3::InitFromImage here, or even calling IDirect3DRM3::CreateTexture? in D3DRM1::CreateTexture and D3DRM2::CreateTexture? >

May 1, 2016

Re: comdlg32: check for overflow before dereferencing (resend)

by Pierre Schweitzer

Le 01/05/2016 17:49, Sebastian Lackner a écrit : > On 01.05.2016 17:30, Pierre Schweitzer wrote: >> - while ((lpstrEdit[nStrCharCount]!='"') && (nStrCharCount <= nStrLen)) >> + while ((nStrCharCount <= nStrLen) && (lpstrEdit[nStrCharCount]!='"')) > > The change looks correct, but while you are just it, you might also want to fix > the operator here. It probably should be <, otherwise the loop will also copy > the terminating \0 character. Same for the comparison a couple of lines above. > Hum. Indeed. But given the side effects the proposed can have (off-by-one bugs are rather nasty). I'd rather do it in a second commit. Unless you want all in one Alexandre? Thanks for the review! -- Pierre Schweitzer <pierre at reactos.org> System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V.

May 1, 2016

Re: comdlg32: check for overflow before dereferencing (resend)

by Sebastian Lackner

On 01.05.2016 17:30, Pierre Schweitzer wrote: > - while ((lpstrEdit[nStrCharCount]!='"') && (nStrCharCount <= nStrLen)) > + while ((nStrCharCount <= nStrLen) && (lpstrEdit[nStrCharCount]!='"')) The change looks correct, but while you are just it, you might also want to fix the operator here. It probably should be <, otherwise the loop will also copy the terminating \0 character. Same for the comparison a couple of lines above.

May 1, 2016

Fw: [PATCH 2/2] kernel32/tests: Add tests for SetConsoleFont

by Hugh McMaster

On Sunday, 1 May 2016 10:19 PM, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > https://testbot.winehq.org/JobDetails.pl?Key=22777 > > Your paranoid android. > > === w8 (32 bit console) === > console.c:1445: Test failed: [13] Expected output count to be 0, got 4115832529 > console.c:1445: Test failed: [15] Expected output count to be 0, got 4115832529 > console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 4115832529 > console.c:1689: Test failed: [13] Expected output count to be 0, got 4115832529 > console.c:1689: Test failed: [15] Expected output count to be 0, got 4115832529 > console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 4115832529 > > === w864 (32 bit console) === > console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 > console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 > console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 > console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 > console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed > console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 > console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 > console.c:1445: Test failed: [13] Expected output count to be 0, got 3160603465 > console.c:1445: Test failed: [15] Expected output count to be 0, got 3160603465 > console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 3160603465 > console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 > console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 > console.c:1689: Test failed: [13] Expected output count to be 0, got 3160603465 > console.c:1689: Test failed: [15] Expected output count to be 0, got 3160603465 > console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 3160603465 > console.c:2148: Test failed: [7] Expected count to be 0, got 1 > console.c:2214: Test failed: [7] Expected count to be 0, got 1 > console.c:2280: Test failed: [7] Expected count to be 0, got 1 > > === w1064 (32 bit console) === > console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 > console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 > console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 > console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 > console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed > console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 > console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 > console.c:1445: Test failed: [13] Expected output count to be 0, got 2978365710 > console.c:1445: Test failed: [15] Expected output count to be 0, got 2978365710 > console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 2978365710 > console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 > console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 > console.c:1689: Test failed: [13] Expected output count to be 0, got 2978365710 > console.c:1689: Test failed: [15] Expected output count to be 0, got 2978365710 > console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 2978365710 > console.c:2148: Test failed: [7] Expected count to be 0, got 1 > console.c:2214: Test failed: [7] Expected count to be 0, got 1 > console.c:2280: Test failed: [7] Expected count to be 0, got 1 > > === w864 (64 bit console) === > console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 > console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 > console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 > console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 > console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed > console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 > console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 > console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 0 > console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 > console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 > console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 0 > console.c:2148: Test failed: [7] Expected count to be 0, got 1 > console.c:2214: Test failed: [7] Expected count to be 0, got 1 > console.c:2280: Test failed: [7] Expected count to be 0, got 1 > > === w1064 (64 bit console) === > console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 > console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 > console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 > console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 > console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed > console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 > console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 > console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 0 > console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 > console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 > console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 0 > console.c:2148: Test failed: [7] Expected count to be 0, got 1 > console.c:2214: Test failed: [7] Expected count to be 0, got 1 > console.c:2280: Test failed: [7] Expected count to be 0, got 1 These are existing failures.

May 1, 2016

Fw: [PATCH 1/2] kernel32/tests: Add more tests for GetConsoleFontInfo (v3)

by Hugh McMaster

On Sunday, 1 May 2016 10:09 PM, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > https://testbot.winehq.org/JobDetails.pl?Key=22776 > > Your paranoid android. > > === w8 (32 bit console) === > console.c:1445: Test failed: [13] Expected output count to be 0, got 3531622039 > console.c:1445: Test failed: [15] Expected output count to be 0, got 3531622039 > console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 3531622039 > console.c:1689: Test failed: [13] Expected output count to be 0, got 3531622039 > console.c:1689: Test failed: [15] Expected output count to be 0, got 3531622039 > console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 3531622039 > > === w864 (32 bit console) === > console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 > console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 > console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 > console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 > console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed > console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 > console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 > console.c:1445: Test failed: [13] Expected output count to be 0, got 1438038684 > console.c:1445: Test failed: [15] Expected output count to be 0, got 1438038684 > console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 1438038684 > console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 > console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 > console.c:1689: Test failed: [13] Expected output count to be 0, got 1438038684 > console.c:1689: Test failed: [15] Expected output count to be 0, got 1438038684 > console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 1438038684 > console.c:2148: Test failed: [7] Expected count to be 0, got 1 > console.c:2214: Test failed: [7] Expected count to be 0, got 1 > console.c:2280: Test failed: [7] Expected count to be 0, got 1 > > === w1064 (32 bit console) === > console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 > console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 > console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 > console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 > console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed > console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 > console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 > console.c:1445: Test failed: [13] Expected output count to be 0, got 1797978764 > console.c:1445: Test failed: [15] Expected output count to be 0, got 1797978764 > console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 1797978764 > console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 > console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 > console.c:1689: Test failed: [13] Expected output count to be 0, got 1797978764 > console.c:1689: Test failed: [15] Expected output count to be 0, got 1797978764 > console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 1797978764 > console.c:2148: Test failed: [7] Expected count to be 0, got 1 > console.c:2214: Test failed: [7] Expected count to be 0, got 1 > console.c:2280: Test failed: [7] Expected count to be 0, got 1 > > === w864 (64 bit console) === > console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 > console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 > console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 > console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 > console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed > console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 > console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 > console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 0 > console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 > console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 > console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 0 > console.c:2148: Test failed: [7] Expected count to be 0, got 1 > console.c:2214: Test failed: [7] Expected count to be 0, got 1 > console.c:2280: Test failed: [7] Expected count to be 0, got 1 > > === w1064 (64 bit console) === > console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 > console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 > console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 > console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 > console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed > console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 > console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 > console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 0 > console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 > console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 > console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 0 > console.c:2148: Test failed: [7] Expected count to be 0, got 1 > console.c:2214: Test failed: [7] Expected count to be 0, got 1 > console.c:2280: Test failed: [7] Expected count to be 0, got 1 These are existing failures.

May 1, 2016

Re: [PATCH 2/2] kernel32/tests: Add tests for SetConsoleFont

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22777 Your paranoid android. === w8 (32 bit console) === console.c:1445: Test failed: [13] Expected output count to be 0, got 4115832529 console.c:1445: Test failed: [15] Expected output count to be 0, got 4115832529 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 4115832529 console.c:1689: Test failed: [13] Expected output count to be 0, got 4115832529 console.c:1689: Test failed: [15] Expected output count to be 0, got 4115832529 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 4115832529 === w864 (32 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [13] Expected output count to be 0, got 3160603465 console.c:1445: Test failed: [15] Expected output count to be 0, got 3160603465 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 3160603465 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [13] Expected output count to be 0, got 3160603465 console.c:1689: Test failed: [15] Expected output count to be 0, got 3160603465 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 3160603465 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1 === w1064 (32 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [13] Expected output count to be 0, got 2978365710 console.c:1445: Test failed: [15] Expected output count to be 0, got 2978365710 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 2978365710 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [13] Expected output count to be 0, got 2978365710 console.c:1689: Test failed: [15] Expected output count to be 0, got 2978365710 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 2978365710 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1 === w864 (64 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1 === w1064 (64 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1

May 1, 2016

Re: [PATCH 1/2] kernel32/tests: Add more tests for GetConsoleFontInfo (v3)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22776 Your paranoid android. === w8 (32 bit console) === console.c:1445: Test failed: [13] Expected output count to be 0, got 3531622039 console.c:1445: Test failed: [15] Expected output count to be 0, got 3531622039 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 3531622039 console.c:1689: Test failed: [13] Expected output count to be 0, got 3531622039 console.c:1689: Test failed: [15] Expected output count to be 0, got 3531622039 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 3531622039 === w864 (32 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [13] Expected output count to be 0, got 1438038684 console.c:1445: Test failed: [15] Expected output count to be 0, got 1438038684 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 1438038684 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [13] Expected output count to be 0, got 1438038684 console.c:1689: Test failed: [15] Expected output count to be 0, got 1438038684 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 1438038684 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1 === w1064 (32 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [13] Expected output count to be 0, got 1797978764 console.c:1445: Test failed: [15] Expected output count to be 0, got 1797978764 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 1797978764 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [13] Expected output count to be 0, got 1797978764 console.c:1689: Test failed: [15] Expected output count to be 0, got 1797978764 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 1797978764 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1 === w864 (64 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1 === w1064 (64 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1

May 1, 2016

Re: wintrust/tests: Fix a typo in ok() messages

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22774 Your paranoid android. === w1064 (32 bit crypt) === crypt.c:1024: Test failed: Expected 00010000, got ffffffff crypt.c:1024: Test failed: Expected 00010001, got ffffffff === w1064 (64 bit crypt) === crypt.c:1024: Test failed: Expected 00010000, got ffffffff crypt.c:1024: Test failed: Expected 00010001, got ffffffff

May 1, 2016

Re: ddraw/tests: Fix a typo in ok() message

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22771 Your paranoid android. === w864 (32 bit d3d) === d3d.c:2326: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level d3d.c:2510: Test failed: Unexpected destination texture level pixels; 257 differences d3d.c:2657: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level === w1064 (32 bit d3d) === d3d.c:2326: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level d3d.c:2510: Test failed: Unexpected destination texture level pixels; 257 differences d3d.c:2657: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level

May 1, 2016