May 2016 - Wine-Devel - list.winehq.org

Re: [PATCH 4/5] jscript: Removed obsolete FIXME comments in tests and add relevant tests.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23194 Your paranoid android. === wxppro (32 bit) === Found no trace of the test summary line or of a crash === w2003std (32 bit) === Found no trace of the test summary line or of a crash === wvistau64 (32 bit) === Found no trace of the test summary line or of a crash === w2008s64 (32 bit) === Found no trace of the test summary line or of a crash === w7u (32 bit) === Found no trace of the test summary line or of a crash === w7pro64 (32 bit) === Found no trace of the test summary line or of a crash === w8 (32 bit) === Found no trace of the test summary line or of a crash === w864 (32 bit) === Found no trace of the test summary line or of a crash === w1064 (32 bit) === Found no trace of the test summary line or of a crash === wvistau64 (64 bit) === Found no trace of the test summary line or of a crash === w2008s64 (64 bit) === Found no trace of the test summary line or of a crash === w7pro64 (64 bit) === Found no trace of the test summary line or of a crash === w864 (64 bit) === Found no trace of the test summary line or of a crash === w1064 (64 bit) === Found no trace of the test summary line or of a crash

May 25, 2016

Re: [PATCH 3/5] jscript: Added RegExp.global getter implementation.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23193 Your paranoid android. === wxppro (32 bit) === Found no trace of the test summary line or of a crash === w2003std (32 bit) === Found no trace of the test summary line or of a crash === wvistau64 (32 bit) === Found no trace of the test summary line or of a crash === w2008s64 (32 bit) === Found no trace of the test summary line or of a crash === w7u (32 bit) === Found no trace of the test summary line or of a crash === w7pro64 (32 bit) === Found no trace of the test summary line or of a crash === w8 (32 bit) === Found no trace of the test summary line or of a crash === w864 (32 bit) === Found no trace of the test summary line or of a crash === w1064 (32 bit) === Found no trace of the test summary line or of a crash === wvistau64 (64 bit) === Found no trace of the test summary line or of a crash === w2008s64 (64 bit) === Found no trace of the test summary line or of a crash === w7pro64 (64 bit) === Found no trace of the test summary line or of a crash === w864 (64 bit) === Found no trace of the test summary line or of a crash === w1064 (64 bit) === Found no trace of the test summary line or of a crash

May 25, 2016

Re: [PATCH 2/5] jscript: Added RegExp.multiline getter implementation.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23192 Your paranoid android. === wxppro (32 bit) === Found no trace of the test summary line or of a crash === w2003std (32 bit) === Found no trace of the test summary line or of a crash === wvistau64 (32 bit) === Found no trace of the test summary line or of a crash === w2008s64 (32 bit) === Found no trace of the test summary line or of a crash === w7u (32 bit) === Found no trace of the test summary line or of a crash === w7pro64 (32 bit) === Found no trace of the test summary line or of a crash === w8 (32 bit) === Found no trace of the test summary line or of a crash === w864 (32 bit) === Found no trace of the test summary line or of a crash === w1064 (32 bit) === Found no trace of the test summary line or of a crash === wvistau64 (64 bit) === Found no trace of the test summary line or of a crash === w2008s64 (64 bit) === Found no trace of the test summary line or of a crash === w7pro64 (64 bit) === Found no trace of the test summary line or of a crash === w864 (64 bit) === Found no trace of the test summary line or of a crash === w1064 (64 bit) === Found no trace of the test summary line or of a crash

May 25, 2016

Re: [PATCH 1/5] jscript: Added RegExp.ignoreCase getter implementation.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23191 Your paranoid android. === wxppro (32 bit) === Found no trace of the test summary line or of a crash === w2003std (32 bit) === Found no trace of the test summary line or of a crash === wvistau64 (32 bit) === Found no trace of the test summary line or of a crash === w2008s64 (32 bit) === Found no trace of the test summary line or of a crash === w7u (32 bit) === Found no trace of the test summary line or of a crash === w7pro64 (32 bit) === Found no trace of the test summary line or of a crash === w8 (32 bit) === Found no trace of the test summary line or of a crash === w864 (32 bit) === Found no trace of the test summary line or of a crash === w1064 (32 bit) === Found no trace of the test summary line or of a crash === wvistau64 (64 bit) === Found no trace of the test summary line or of a crash === w2008s64 (64 bit) === Found no trace of the test summary line or of a crash === w7pro64 (64 bit) === Found no trace of the test summary line or of a crash === w864 (64 bit) === Found no trace of the test summary line or of a crash === w1064 (64 bit) === Found no trace of the test summary line or of a crash

May 25, 2016

Re: [PATCH 5/5] reg: Simplify syntax and help logic

by Hugh McMaster

On Tuesday, 24 May 2016 11:35 PM, Alexandre Julliard wrote: >Hugh McMaster writes: > >> @@ -907,19 +915,16 @@ int wmain(int argc, WCHAR *argvW[]) >> return 0; >> } >> >> + option_help = (!lstrcmpW(argvW[2], slashHelpW) || !lstrcmpiW(argvW[2], slashHW)); > >You should check argc first. Ah, yes, I missed that. >> - if (argc < 3) >> - { >> - output_message(STRING_INVALID_SYNTAX); >> - output_message(STRING_FUNC_HELP, struprW(argvW[1])); >> - return 1; >> - } >> - else if (argc == 3 && (!lstrcmpW(argvW[2], slashHelpW) || >> - !lstrcmpiW(argvW[2], slashHW))) >> + if (argc < 3 || (argc > 3 && option_help)) >> + return invalid_syntax(argvW[1]); >> + else if (option_help) >> { > >This doesn't feel like much of an improvement. You could probably come >up with more useful helper functions. Ideally, I'd like to move all of that logic out of the 'if' block string comparisons. One major issue I see is that users may pass invalid operation names, e.g. abc, so we need to ensure that we only continue with valid strings. I believe this will also cause problems when functions like sane_path() are moved into wmain() as well, so it's better to deal with this now. One solution is to iterate over an array of WCHAR * and return a BOOL indicating whether the string is valid or not. As for passing output_message() the correct help string ID, leaving that code where it is now is probably best, particularly if I can use the BOOL option_help. If not, we'd have to look up the message ID information in a function or a struct. I'm not if you think this change would have any benefit.

May 25, 2016

Re: [PATCH 6/7] d3drm: Partially implement IDirect3DRMTexture*::InitFromFile. (v5)

by Aaryaman Vasishta

On Tue, May 24, 2016 at 8:32 PM, Henri Verbeet <hverbeet(a)gmail.com> wrote: > On 24 May 2016 at 16:49, Aaryaman Vasishta <jem456.vasishta(a)gmail.com> > wrote: > > Hi, > > > > Now that the first 5 patches in the series are committed, I was > wondering if > > there's any changes required in this patch (and 7/7) ? > > > Possibly, but this one is a bit more complicated than the 5 that came > before, and I haven't reviewed it in detail yet. > Sure, I will wait for your review :) Cheers, Aaryaman

May 24, 2016

Re: [PATCH] jscript: Date.parse: make "UTC"/"GMT" optional before the timezone offset

by Jacek Caban

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com>

May 24, 2016

Re: [PATCH 6/7] d3drm: Partially implement IDirect3DRMTexture*::InitFromFile. (v5)

by Henri Verbeet

On 24 May 2016 at 16:49, Aaryaman Vasishta <jem456.vasishta(a)gmail.com> wrote: > Hi, > > Now that the first 5 patches in the series are committed, I was wondering if > there's any changes required in this patch (and 7/7) ? > Possibly, but this one is a bit more complicated than the 5 that came before, and I haven't reviewed it in detail yet.

May 24, 2016

Re: [PATCH 6/7] d3drm: Partially implement IDirect3DRMTexture*::InitFromFile. (v5)

by Aaryaman Vasishta

Hi, Now that the first 5 patches in the series are committed, I was wondering if there's any changes required in this patch (and 7/7) ? Cheers, Aaryaman On Mon, May 23, 2016 at 8:58 PM, Marvin <testbot(a)winehq.org> wrote: > Thank you for your contribution to Wine! > > This is an automated notification to let you know that your patch has > been reviewed and its status set to "Assigned". > > This means that the patch has been assigned to a reviewer. If the > reviewer signs off on the patch, it will be committed, otherwise > you'll receive advice on how to improve it. If you don't hear anything > after a couple of weeks, please resend the patch. >

May 24, 2016

Re: [PATCH 5/5] reg: Simplify syntax and help logic

by Alexandre Julliard

Hugh McMaster <hugh.mcmaster(a)outlook.com> writes: > @@ -907,19 +915,16 @@ int wmain(int argc, WCHAR *argvW[]) > return 0; > } > > + option_help = (!lstrcmpW(argvW[2], slashHelpW) || !lstrcmpiW(argvW[2], slashHW)); You should check argc first. > - if (argc < 3) > - { > - output_message(STRING_INVALID_SYNTAX); > - output_message(STRING_FUNC_HELP, struprW(argvW[1])); > - return 1; > - } > - else if (argc == 3 && (!lstrcmpW(argvW[2], slashHelpW) || > - !lstrcmpiW(argvW[2], slashHW))) > + if (argc < 3 || (argc > 3 && option_help)) > + return invalid_syntax(argvW[1]); > + else if (option_help) > { This doesn't feel like much of an improvement. You could probably come up with more useful helper functions. -- Alexandre Julliard julliard(a)winehq.org

May 24, 2016