June 2016 - Wine-Devel - list.winehq.org

Re: [PATCH 2/6] d3d11: Normalize more fields in SRV descriptions.

by Henri Verbeet

On 6 June 2016 at 11:39, Józef Kucia <jkucia(a)codeweavers.com> wrote: > + case D3D11_SRV_DIMENSION_TEXTURE2DARRAY: > + if (desc->u.Texture2DArray.MipLevels == -1 && desc->u.Texture2DArray.MostDetailedMip < miplevel_count) > + desc->u.Texture2DArray.MipLevels = miplevel_count - desc->u.Texture2DArray.MostDetailedMip; > + if (desc->u.Texture2DArray.ArraySize == -1 && desc->u.Texture2DArray.FirstArraySlice < layer_count) > + desc->u.Texture2DArray.ArraySize = layer_count - desc->u.Texture2DArray.FirstArraySlice; > + break; Does that work for render target views as well?

June 6, 2016

Re: [PATCH 2/3] d3drm/tests: Add tests for IDirect3DRM*::CreateViewport.

by Aaryaman Vasishta

On Mon, Jun 6, 2016 at 3:41 AM, Stefan Dösinger <stefandoesinger(a)gmail.com> wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 > > Am 2016-06-05 um 19:28 schrieb Aaryaman Vasishta: > > + hr = IDirect3DRM_CreateViewport(d3drm1, device1, frame, 0, 0, 0, 0, > &viewport); > > + ok(SUCCEEDED(hr), "Cannot get IDirect3DRMViewport interface (hr = > %x)\n", hr); > > + ref4 = get_refcount((IUnknown *)d3drm1); > > + todo_wine ok(ref4 > ref1, "Expected ref4 > ref1, got ref1 = %u, > ref4 = %u.\n", ref1, ref4); > > + ref4 = get_refcount((IUnknown *)d3drm2); > > + ok(ref4 == ref2, "Expected ref4 == ref2, got ref2 = %u, ref4 = > %u.\n", ref2, ref4); > > + ref4 = get_refcount((IUnknown *)d3drm3); > > + ok(ref4 == ref3, "Expected ref4 == ref3, got ref3 = %u, ref4 = > %u.\n", ref3, ref4); > Does creating the viewport have any influence of the device's or the > frame's refcount? > It does increase the frame's refcount by 1, but it doesn't affect the device's refcount. I'll add tests to reflect this. > > + hr = IDirect3DRM_CreateViewport(d3drm1, device1, frame, -1, 0, 0, > 0, &viewport); > > + todo_wine ok(hr == D3DRMERR_BADVALUE, "Expected hr == > D3DRMERR_BADVALUE, got %#x.\n", hr); > x, y, width and height are DWORDs. -1 only makes limited sense here. It is > probably better to test width and height = 0 and test x and (x + width) > against the device's render target size. (smaller, matching, larger. Also > obviously the same with y + height). > Right, the documentation states that the call fails if the size of viewport > than size of the physical device. I've used the window rect's right and bottom for width and height respectively. So I could probably test for right +1, bottom +1, which should fail. Or is there some other way you want me to use x and y? Currently, x and y are always 0, since the window rect is set that way. Cheers, Aaryaman > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v2 > > iQIcBAEBCAAGBQJXVKOEAAoJEN0/YqbEcdMwKvsP/jzDXf0eCqtCjXtfEiOlknWL > iaBRAFHJnFz7fhFX1yZDX63HScoksoWw3TAby6LDX8zA0oVMWP7IYLXk+lx4xPTg > mj8+lhvyPNPDl+PQ4feU/1sAwByBVR9qn6kwxgF6nsW0RXqalCeztcMxLOkC5kXZ > bGbt/t4ZaCNVyZLjv5tYOcUHq+MP9Q8cKnbq3cGaivsd/cab4ORfpFccstBqLlL+ > LJD65/oCtq9A+OGORVxuin7CFszSP9OR3/vFiCDMvJFjIFMWSss4gTxF4vvamD9+ > Fie3E85DBWr3fBomKlKEPeky7LW0QBv5NcdzJhLaXiaCkxgKd5s54v70+2C4OSEE > /N1P5v4vCjfJ8ZhFKyXJmTa6NPO0qXTnGY+HREmhva/aemTG706DaS58mWacovr1 > +xx5uvMcuG2dQUGqDjp3KVKz+wLnPovfn3WoEtQ82Tvgq3g2aJbsEKHhFUjkscpG > l/Ck0NcZMnQA7OxREO8+D2R7rSI+WdLyKHTrPmWc8HJ/5EWL2LE2YkdwNvjzpbTI > 7fWHd5PE1NFdw7xzcHajq62485fZe1T+vt1qkMO70qjRkvlGgW/OI1VzVr7GyhSp > UBxXTHrb32rQn3UD36SAYiGh6pF5HAszSAUVeesUx0VEAsP/CazZS0HHOP5fksrc > MmZ1+t0cL04S8q0bGxLc > =9s0i > -----END PGP SIGNATURE----- >

June 6, 2016

Re: user32/tests: Use EqualRect() instead of open coding it.

by Michael Stefaniuc

On 06/06/2016 12:00 PM, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > https://testbot.winehq.org/JobDetails.pl?Key=23360 > > Your paranoid android. > > > === w7u (32 bit msg) === > msg.c:4773: Test failed: ShowWindow(SW_RESTORE):overlapped: 18: the msg sequence is not complete: expected 0000 - actual 0088 This seems to be a fluke as a rerun did not produce it:: https://testbot.winehq.org/JobDetails.pl?Key=23365 The win8 and win10 failures below are pre-existing. > > === w864 (32 bit msg) === > msg.c:6484: Test failed: Update region shouldn't be empty > msg.c:6717: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 > msg.c:6719: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 > msg.c:6490: Test failed: Regions are different > msg.c:6490: Test failed: Regions are different > msg.c:6490: Test failed: Regions are different > > === w1064 (32 bit msg) === > msg.c:6484: Test failed: Update region shouldn't be empty > msg.c:6717: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 > msg.c:6719: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 > msg.c:6490: Test failed: Regions are different > msg.c:6490: Test failed: Regions are different > msg.c:6490: Test failed: Regions are different > > === w864 (64 bit msg) === > msg.c:6484: Test failed: Update region shouldn't be empty > msg.c:6717: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 > msg.c:6719: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 > msg.c:6490: Test failed: Regions are different > msg.c:6490: Test failed: Regions are different > msg.c:6490: Test failed: Regions are different > > === w1064 (64 bit msg) === > msg.c:6484: Test failed: Update region shouldn't be empty > msg.c:6717: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 > msg.c:6719: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 > msg.c:6490: Test failed: Regions are different > msg.c:6490: Test failed: Regions are different > msg.c:6490: Test failed: Regions are different bye michael

June 6, 2016

Re: [PATCH] wined3d: Add #defines and logs for missing new SM5 modifiers.

by Józef Kucia

This patch isn't very useful on its own. It just changes FIXME() messages. It would be much better to save the decoded modifiers in wined3d_shader_instruction and print them in the shader tracing backend (see shader_trace_init() in shader.c). Other than that, the patch has some coding style issues. On Thu, Jun 2, 2016 at 3:49 PM, Guillaume Charifi <guillaume.charifi(a)sfr.fr> wrote: > Signed-off-by: Guillaume Charifi <guillaume.charifi(a)sfr.fr> > --- > dlls/wined3d/shader_sm4.c | 78 ++++++++++++++++++++++++++++++++--------------- > 1 file changed, 54 insertions(+), 24 deletions(-) > > diff --git a/dlls/wined3d/shader_sm4.c b/dlls/wined3d/shader_sm4.c > index eb8e4e5..3adaf70 100644 > --- a/dlls/wined3d/shader_sm4.c > +++ b/dlls/wined3d/shader_sm4.c > @@ -25,6 +25,7 @@ WINE_DEFAULT_DEBUG_CHANNEL(d3d_shader); > WINE_DECLARE_DEBUG_CHANNEL(d3d_bytecode); > > #define WINED3D_SM4_INSTRUCTION_MODIFIER (0x1u << 31) > +#define WINED3D_SM4_MODIFIER_TYPE_MASK 0x3f > > #define WINED3D_SM4_MODIFIER_AOFFIMMI 0x1 > #define WINED3D_SM4_AOFFIMMI_U_SHIFT 9 > @@ -34,6 +35,22 @@ WINE_DECLARE_DEBUG_CHANNEL(d3d_bytecode); > #define WINED3D_SM4_AOFFIMMI_W_SHIFT 17 > #define WINED3D_SM4_AOFFIMMI_W_MASK (0xfu << WINED3D_SM4_AOFFIMMI_W_SHIFT) > > +#define WINED3D_SM5_MODIFIER_RESDIM 0x2 > +#define WINED3D_SM5_RESDIM_RES_TYPE_SHIFT 6 > +#define WINED3D_SM5_RESDIM_RES_TYPE_MASK (0x1fu << WINED3D_SM5_RESDIM_RES_TYPE_SHIFT) > +#define WINED3D_SM5_RESDIM_BUF_STRIDE_SHIFT 11 > +#define WINED3D_SM5_RESDIM_BUF_STRIDE_MASK (0xfffu << WINED3D_SM5_RESDIM_BUF_STRIDE_SHIFT) > + > +#define WINED3D_SM5_MODIFIER_RETTYPE 0x3 > +#define WINED3D_SM5_RETTYPE_X_SHIFT 6 > +#define WINED3D_SM5_RETTYPE_X_MASK (0xfu << WINED3D_SM5_RETTYPE_X_SHIFT) > +#define WINED3D_SM5_RETTYPE_Y_SHIFT 10 > +#define WINED3D_SM5_RETTYPE_Y_MASK (0xfu << WINED3D_SM5_RETTYPE_Y_SHIFT) > +#define WINED3D_SM5_RETTYPE_Z_SHIFT 14 > +#define WINED3D_SM5_RETTYPE_Z_MASK (0xfu << WINED3D_SM5_RETTYPE_Z_SHIFT) > +#define WINED3D_SM5_RETTYPE_W_SHIFT 18 > +#define WINED3D_SM5_RETTYPE_W_MASK (0xfu << WINED3D_SM5_RETTYPE_W_SHIFT) > + > #define WINED3D_SM4_INSTRUCTION_LENGTH_SHIFT 24 > #define WINED3D_SM4_INSTRUCTION_LENGTH_MASK (0x1fu << WINED3D_SM4_INSTRUCTION_LENGTH_SHIFT) > > @@ -1163,32 +1180,45 @@ static BOOL shader_sm4_read_dst_param(struct wined3d_sm4_data *priv, const DWORD > > static void shader_sm4_read_instruction_modifier(DWORD modifier, struct wined3d_shader_instruction *ins) > { > - static const DWORD recognized_bits = WINED3D_SM4_INSTRUCTION_MODIFIER > - | WINED3D_SM4_MODIFIER_AOFFIMMI > - | WINED3D_SM4_AOFFIMMI_U_MASK > - | WINED3D_SM4_AOFFIMMI_V_MASK > - | WINED3D_SM4_AOFFIMMI_W_MASK; > - > - if (modifier & ~recognized_bits) > + switch (modifier & WINED3D_SM4_MODIFIER_TYPE_MASK) > { > - FIXME("Unhandled modifier 0x%08x.\n", modifier); > - } > - else > - { > - /* Bit fields are used for sign extension */ > - struct > + case WINED3D_SM4_MODIFIER_AOFFIMMI: > { > - int u : 4; > - int v : 4; > - int w : 4; > - } > - aoffimmi; > - aoffimmi.u = (modifier & WINED3D_SM4_AOFFIMMI_U_MASK) >> WINED3D_SM4_AOFFIMMI_U_SHIFT; > - aoffimmi.v = (modifier & WINED3D_SM4_AOFFIMMI_V_MASK) >> WINED3D_SM4_AOFFIMMI_V_SHIFT; > - aoffimmi.w = (modifier & WINED3D_SM4_AOFFIMMI_W_MASK) >> WINED3D_SM4_AOFFIMMI_W_SHIFT; > - ins->texel_offset.u = aoffimmi.u; > - ins->texel_offset.v = aoffimmi.v; > - ins->texel_offset.w = aoffimmi.w; > + /* Bit fields are used for sign extension */ > + struct { > + int u : 4; > + int v : 4; > + int w : 4; > + } aoffimmi; Generally, in wined3d, curly braces should be put on their own line, i.e. struct { ... } aoffimmi; The unnamed structs seem to be an exception. The following formatting is acceptable as well: struct { ... } aofimmi; > + > + aoffimmi.u = (modifier & WINED3D_SM4_AOFFIMMI_U_MASK) >> WINED3D_SM4_AOFFIMMI_U_SHIFT; > + aoffimmi.v = (modifier & WINED3D_SM4_AOFFIMMI_V_MASK) >> WINED3D_SM4_AOFFIMMI_V_SHIFT; > + aoffimmi.w = (modifier & WINED3D_SM4_AOFFIMMI_W_MASK) >> WINED3D_SM4_AOFFIMMI_W_SHIFT; > + ins->texel_offset.u = aoffimmi.u; > + ins->texel_offset.v = aoffimmi.v; > + ins->texel_offset.w = aoffimmi.w; > + break; > + }; Please remove stray ";". > + > + case WINED3D_SM5_MODIFIER_RESDIM: > + FIXME("Unhandled modifier 0x%08x (WINED3D_SM5_MODIFIER_RESDIM, res_type=0x%02x).\n", > + modifier, > + (modifier & WINED3D_SM5_RESDIM_RES_TYPE_MASK) >> WINED3D_SM5_RESDIM_RES_TYPE_SHIFT > + ); Please avoid leaving ");" on its own line. > + break; > + > + case WINED3D_SM5_MODIFIER_RETTYPE: > + FIXME("Unhandled modifier 0x%08x (WINED3D_SM5_MODIFIER_RETTYPE, x=0x%01x, y=0x%01x, z=0x%01x, w=0x%01x).\n", > + modifier, > + (modifier & WINED3D_SM5_RETTYPE_X_MASK) >> WINED3D_SM5_RETTYPE_X_SHIFT, > + (modifier & WINED3D_SM5_RETTYPE_Y_MASK) >> WINED3D_SM5_RETTYPE_Y_SHIFT, > + (modifier & WINED3D_SM5_RETTYPE_Z_MASK) >> WINED3D_SM5_RETTYPE_Z_SHIFT, > + (modifier & WINED3D_SM5_RETTYPE_W_MASK) >> WINED3D_SM5_RETTYPE_W_SHIFT > + ); > + break; > + > + default: > + FIXME("Unhandled modifier 0x%08x.\n", modifier); > } > } > > -- > 2.7.4 > > > Thanks for working on this.

June 6, 2016

Re: [PATCH resend] wined3d : Set texture target of WINED3DFMT_NULL to 0

by Józef Kucia

On Sun, Jun 5, 2016 at 2:02 AM, Max Qian <public(a)maxqia.com> wrote: > This fixes https://bugs.winehq.org/show_bug.cgi?id=40624 > Signed-off-by: Max Qian <public(a)maxqia.com> > --- > dlls/wined3d/context.c | 4 ++-- > dlls/wined3d/wined3d_private.h | 5 +++++ > 2 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/dlls/wined3d/context.c b/dlls/wined3d/context.c > index 845ca1d..323e7ac 100644 > --- a/dlls/wined3d/context.c > +++ b/dlls/wined3d/context.c > @@ -397,14 +397,14 @@ static inline void context_set_fbo_key_for_surface(const struct wined3d_context > { > case WINED3D_LOCATION_TEXTURE_RGB: > key->objects[idx].object = surface_get_texture_name(surface, context, FALSE); > - key->objects[idx].target = surface->texture_target; > + key->objects[idx].target = surface_get_texture_target(surface); > key->objects[idx].level = surface->texture_level; > key->objects[idx].layer = surface->texture_layer; > break; > > case WINED3D_LOCATION_TEXTURE_SRGB: > key->objects[idx].object = surface_get_texture_name(surface, context, TRUE); > - key->objects[idx].target = surface->texture_target; > + key->objects[idx].target = surface_get_texture_target(surface); > key->objects[idx].level = surface->texture_level; > key->objects[idx].layer = surface->texture_layer; > break; > diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h > index f9a8ffa..00d46c0 100644 > --- a/dlls/wined3d/wined3d_private.h > +++ b/dlls/wined3d/wined3d_private.h > @@ -3600,6 +3600,11 @@ static inline struct wined3d_surface *context_get_rt_surface(const struct wined3 > return texture->sub_resources[context->current_rt.sub_resource_idx].u.surface; > } > > +static inline GLuint surface_get_texture_target(const struct wined3d_surface *surface) > +{ > + return surface->container->resource.format->id == WINED3DFMT_NULL ? 0 : surface->texture_target; > +} > + > /* The WNDCLASS-Name for the fake window which we use to retrieve the GL capabilities */ > #define WINED3D_OPENGL_WINDOW_CLASS_NAME "WineD3D_OpenGL" > > -- > 2.8.3 > > This produces a GL error when glFramebufferTexture2D() is called.

June 6, 2016

Re: user32/tests: Use EqualRect() instead of open coding it.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23360 Your paranoid android. === w7u (32 bit msg) === msg.c:4773: Test failed: ShowWindow(SW_RESTORE):overlapped: 18: the msg sequence is not complete: expected 0000 - actual 0088 === w864 (32 bit msg) === msg.c:6484: Test failed: Update region shouldn't be empty msg.c:6717: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6719: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different === w1064 (32 bit msg) === msg.c:6484: Test failed: Update region shouldn't be empty msg.c:6717: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6719: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different === w864 (64 bit msg) === msg.c:6484: Test failed: Update region shouldn't be empty msg.c:6717: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6719: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different === w1064 (64 bit msg) === msg.c:6484: Test failed: Update region shouldn't be empty msg.c:6717: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6719: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different

June 6, 2016

wine-1.8.3-rc1 Available

by Michael Stefaniuc

grrr... subject copy and paste fail Hello guys, I have pushed yesterday night an informal wine-1.8.3-rc1 (with tag) to https://github.com/mstefani/wine-stable https://static-winehq.rhcloud.com/stable/ As 1.8.2 was "too big" Alexandre wanted a smaller stable release, "around 50 commits". So I've limited myself to bugs fixed up to 1.9.9. But please let me know if you have a pet bug fixed afterwards that should go into 1.8.3. Even with the limit to bugs fixed up to 1.9.9 these release still got big: - 88 commits, but a good part of them are trivial: - 16 commits to the GPU description table - 10 commits adding stubs - 15 commits to the NLS files - 55 bugs fixed of which 5 are regressions - Bigger patch series: - xaudio2 - t2embed/fontsub (includes a regression with the fix for it) - The first true backported patch (Thanks to Henri for the tip): - wined3d: Sanitise map flags in wined3d_surface_map(). - The NLS file changes skew the the diffstat numbers so here is just the dirstat: 68.5% dlls/kernel32/nls/ 5.1% dlls/kernel32/ 3.2% dlls/user32/ 5.9% dlls/xaudio2_7/ 13.2% dlls/ For the release I would follow the same procedure like the last time: Have this week for feedback, tests, etc with a hopefully final rc on Sunday so Alexandre can push out the release early / mid next week. And last but not least an excerpt from the ANNOUNCE file: What's new in this release (see below for details): - Various bug fixes. - A lot of NVidia cards added to the GPU description table. - Updates to the National Language Support files. ---------------------------------------------------------------- Bugs fixed in 1.8.3 (total 55): 10063 wineconsole run fail on korean locale. 16971 Windows Movie Maker 2.x needs ole32.dll.StgOpenPropStg 17257 TeX2Word will not install 20695 Cannot scroll documents being compared in winmerge 23768 winhelp: Some images not shown in certain 16-bit Help files 24421 MJ's Help Diagnostics crashes on startup (app provided MonitorEnumProc callback relies on ECX = lprcMonitor) 25790 WM_SETTEXT handler for the user32 buttons generates WM_CTLCOLOR* inconsistent with Windows user32 26978 tokenadmin.exe crash : Unimplemented function winscard.dll.SCardListReadersA 27680 Multiple 64-bit applications crash on startup (violation of the Windows 64-bit ABI, stack pointer (RSP) must be 16-byte aligned when making a call to Win64 API) 28082 OCCT Perestroïka needs hal.dll.READ_PORT_ULONG 28177 Adventure games from Kheops Studio hang after the logo screen (Safecracker, Destination: Treasure Island, Nostradamus: Lost Prophecy, Dracula 3, Return to Mysterious Island 2) 28825 Mystic Diary - Haunted Island: Multiple sprite-related bugs in hidden object scenes 29979 ElsterFormular crashes when trying to print already sent income tax return 31662 Office 2010 font embedding when exporting to PDF 32451 Multiple GOG.com installer bundles show a broken/unresponsive dialog window during installation (installer process running out of wndproc slots) 32979 Metal Gear Solid Crash 34070 Simutronics 'StormFront.exe' runs out of wndproc slots (ActiveSkin control) 34851 Multiple applications need kernel32 GetFinalPathNameByHandleA/W (64-bit Autodesk Fusion 360, Microsoft OneDrive) 35054 Dragon Age 2 system diagnostics tool fails to recognize GeForce GT 425M 35092 Multiple 64-bit applications need __CxxFrameHandler implementation (Ableton Live 9.1, Adobe Cloud apps) 35711 Winelib: compile error in wincon.h if NOGDI is defined before #include <windows.h> 36031 GeForce 9700M incorrectly detected as 9400 37087 Gothic 2 english demo fails with 'Conflict: a hook process was found. Please deactivate all Antivirus and Anti-Trojan programs and debuggers.' 38102 Process Hacker 2.x needs winsta.dll.WinStationEnumerateW 39092 Regression introduced with xaudio2_8 39215 Nvidia GeForce GTX960M detected as GTX470 39543 Multiple games and applications crash on unimplemented function KERNEL32.dll.FreeUserPhysicalPages (Microsoft Office 2007 diagnosis service, Eden Eternal) 39657 Tencent QQ 7.6 crashes on unimplemented function ntoskrnl.exe.PsRemoveLoadImageNotifyRoutine 39667 dinput: MotoGP 3 demo launcher crashes on leaving key configuration dialog. 39681 Unimplemented function crypt32.dll.CryptMsgVerifyCountersignatureEncoded 39730 FillRect() confuses 16bit brush handles with color constants 39759 Add support for detect Nvidia TITAN Black in wine3d/device list 39786 GoodSync crashes, needs oleaut32.OleLoadPictureFile 39796 SCP Containment Breach page fault 39918 Mail.Ru GameCenter installer does not work 39940 Stars! tooltips have wrong background color 40048 Camtasia Studio 8 : crashes on unimplemented function dwmapi.dll.DwmSetPresentParameters 40081 CLM Explorer needs fontsub.dll.CreateFontPackage 40108 kernel32:process regression 40135 msvcirt.c:1386:5: warning: comparison of unsigned expression < 0 is always false 40244 PostThreadMessage with WM_NOTIFY message should succeed 40246 Please document WINEBUILD in the winegcc manpage 40286 Geforce 980 maxwell card is not properly detected 40297 Multiple app crashes in macdrv_EnumDisplayMonitors 40304 EveHQ2 crashes with builtin gdiplus 40348 Nvidia 800 series cards not detected correctly 40389 cmd.exe (native): Unimplemented function KERNEL32.dll.GetConsoleAliasExesLengthW 40396 Windows SDK DirectWrite sample crashes on uninitialized parameter 40456 NFS MW + NFS Carbon: Car is flying above/under the track (D3DXVec3Transform needs arguments aliasing) 40466 Midnight Commander needs KERNEL32.dll.GetConsoleFontInfo 40473 wine fails to compile with >=glibc-2.23 40487 3dmark Vantage Benchmark: unimplemented functions hal.dll.READ and WRITE PORT 40493 Prison Tycoon 4 crashes on start up needing msvcp71.dll.??$?5DU?$char_traits(a)D@std@@@std@@YAAAV?$basic_istream(a)DU?$char_traits(a)D@std@@@0(a)AAV10@AAC(a)Z 40517 Office 2007 shows error message "Unexpected error during export" when trying to export document as PDF file 40525 schannel:main does not recognize package version 0x400000 ---------------------------------------------------------------- Changes since 1.8.2: Alex Henrie (2): ole32: Implement StgCreatePropStg. ole32: Implement StgOpenPropStg. Alexander Lakhin (2): user32: Send the correct WM_CTLCOLOR* message in button WM_SETTEXT handler. user32: Send WM_CTLCOLOR* message only for visible buttons. Alexandre Julliard (2): wineconsole: If necessary, fallback to a font without the right properties instead of failing. kernel32/nls: Convert remaining files to UTF-8. Alistair Leslie-Hughes (2): wined3d: Add detection for NVIDIA GTX TITAN. wined3d: Add detection for NVIDIA GTX TITAN Series. Andrew Eikum (6): xaudio2: Explicitly version the 2.7 coclasses. xaudio2_8: Use shared source. xaudio2: Remove run-time version checks for XAudio2 object. xaudio2: Report incoming underruns to the application. xaudio2: Protect access to source voice during creation (Coverity). xaudio2: Protect access to submix voice during creation (Coverity). Andrey Gusev (1): kernel32/nls: Update currency name and fix a typo. André Hentschel (2): xaudio2_7: Check return of IAudioClient_Start (Coverity). shell32: Provide helper function a buffer of correct size. Aurimas Fišeras (1): kernel32/nls: Update currency for Baltic states. Austin English (8): include: Fix GetCurrentConsoleFontEx/SetCurrentConsoleFontEx definition. oleaut32: Add OleLoadPictureFile stub. wine.inf: Create Microsoft Shared/TextConv directory. kernel32: Add GetConsoleFontInfo stub. winscard: Add stubs for SCardListReadersA/W. crypt32: Add CryptMsgVerifyCountersignatureEncoded stub. ntoskrnl.exe: Add PsRemoveLoadImageNotifyRoutine stub. ntoskrnl.exe: Add KeDelayExecutionThread stub. Bernhard Übelacker (1): dinput: Implement device property DIPROP_USERNAME. Caron Wills (9): wined3d: Add Nvidia GeForce GTX 860. wined3d: Add Nvidia GeForce 820M. wined3d: Add Nvidia GeForce 830M. wined3d: Add Nvidia GeForce 840M. wined3d: Add Nvidia GeForce 845M. wined3d: Add Nvidia GeForce GTX 850M. wined3d: Add Nvidia GeForce GTX 870M. wined3d: Add Nvidia GeForce GTX 880M. wined3d: Add Nvidia GeForce GT 730M. François Gouget (1): schannel: Add declarations for SECPKG version 7. Henri Verbeet (11): wined3d: Sanitise map flags in wined3d_surface_map(). wined3d: Recognise Intel Ivybridge on MacOS. kernel32/nls: Persian uses a right-to-left writing system. kernel32/nls: Use Persian characters to write Persian. kernel32/nls: Use ZWNJ where appropriate in far.nls. kernel32/nls: Persian is called Persian in English. kernel32/nls: Store LOCALE_SNATIVEDIGITS as UTF-8 in far.nls. kernel32/nls: Use Persian punctuation for LANG_PERSIAN. kernel32/nls: Fix LOCALE_IFIRSTDAYOFWEEK for LANG_PERSIAN. kernel32/nls: Return CAL_GREGORIAN_XLIT_FRENCH for LOCALE_ICALENDARTYPE for LANG_PERSIAN. kernel32/nls: Fix LOCALE_SMONTHNAME5/LOCALE_SABBREVMONTHNAME5 for LANG_PERSIAN. Iván Matellanes (1): msvcirt: Avoid superfluous comparison in some compilers. Jarkko Korpi (1): wined3d: Add detection for NVIDIA GeForce 425M. Jean-Christophe Cardot (1): winhlp32: Fix some images not shown in certain 16-bit help files. Jens Reyer (2): winegcc: Document WINEBUILD in the manpage. msiexec: Fix a typo in the manpage. Ken Thomases (1): user32: Call the EnumDisplayMonitors callback using a wrapper. Kerstin Noa (1): wined3d: Add NVIDIA GeForce GTX 980 GPU information. Kim Malmo (1): wined3d: Add Nvidia 9700M GT. Louis Lenders (4): gdiplus: GdipTransformPath should return Ok if matrix = NULL. ntdll: Add stub for RtlAddAuditAccessObjectAce and forward to AddAuditAccessObjectAce in advapi32. ntdll: Add stub for RtlAddAccessAllowedObjectAce and forward to AddAccessAllowedObjectAce in advapi32. ntdll: Add stub for RtlAddAccessDeniedObjectAce and forward to AddAccessDeniedObjectAce in advapi32. Michael Müller (2): winex11: Add 320x240 as supported resolution in desktop mode. kernel32: Implement GetFinalPathNameByHandle. Nikolay Sivov (11): user32: For EnableScrollBar() always go through EnableWindow() in SB_CTL case. t2embed: Implement TTGetEmbeddingType(). fontsub: Added CreateFontPackage() stub. fontsub: Improve CreateFontPackage() stub for TTFCFP_SUBSET case. t2embed: Implement TTIsEmbeddingEnabledForFacename(). t2embed: Implement TTIsEmbeddingEnabled(). gdi32: Increase first gdi handle value. dwrite: Always initialize context and font table pointers. kernel32/nls: Convert most of the locale data files to UTF-8. kernel32/nls: Added SSHORTESTDAYNAME* entries. kernel32/nls: Fix shortest day names for Thai and Vietnamese. Paul Gofman (1): d3dx9: D3DXVec3Transform should support input and output parameter overlap. Piotr Caban (4): msvcrt: Dump exception information in x86_64 __CxxFrameHandler. msvcrt: Handle frames with CXX_FRAME_MAGIC_VC6 and CXX_FRAME_MAGIC_VC7 magic value. user32: Call window procedure even if we're out of winproc handles. msvcp71: Add basic_istream<char>::operator>> export. Rob Walker (1): wined3d: Add Nvidia GPU SKUs 950,950M,960,960M. Sebastian Lackner (8): xaudio2_7: Unset DebugInfo->Spare[0] before destroying critical sections. user32: Set %ecx to address of rect in EnumDisplayMonitors callback. user32/tests: Add tests for button WM_CTLCOLOR* messages. user32: Do not block sending/posting WM_NOTIFY messages. kernel32/tests: Add test for process object destruction. kernel32/tests: Disable Windows version dependent test for pcPriClassBase. server: Do not hold reference on parent process. ntoskrnl.exe: Add missing linebreak to FIXME in KeDelayExecutionThread. Seong-ho Cho (1): configure: Add AC_HEADER_MAJOR to find where major() is defined. bye michael -- Michael Stefaniuc mstefani(a)winehq.org

June 6, 2016

wine-1.8.2-rc1 Available

by Michael Stefaniuc

Hello guys, I have pushed yesterday night an informal wine-1.8.3-rc1 (with tag) to https://github.com/mstefani/wine-stable https://static-winehq.rhcloud.com/stable/ As 1.8.2 was "too big" Alexandre wanted a smaller stable release, "around 50 commits". So I've limited myself to bugs fixed up to 1.9.9. But please let me know if you have a pet bug fixed afterwards that should go into 1.8.3. Even with the limit to bugs fixed up to 1.9.9 these release still got big: - 88 commits, but a good part of them are trivial: - 16 commits to the GPU description table - 10 commits adding stubs - 15 commits to the NLS files - 55 bugs fixed of which 5 are regressions - Bigger patch series: - xaudio2 - t2embed/fontsub (includes a regression with the fix for it) - The first true backported patch (Thanks to Henri for the tip): - wined3d: Sanitise map flags in wined3d_surface_map(). - The NLS file changes skew the the diffstat numbers so here is just the dirstat: 68.5% dlls/kernel32/nls/ 5.1% dlls/kernel32/ 3.2% dlls/user32/ 5.9% dlls/xaudio2_7/ 13.2% dlls/ For the release I would follow the same procedure like the last time: Have this week for feedback, tests, etc with a hopefully final rc on Sunday so Alexandre can push out the release early / mid next week. And last but not least an excerpt from the ANNOUNCE file: What's new in this release (see below for details): - Various bug fixes. - A lot of NVidia cards added to the GPU description table. - Updates to the National Language Support files. ---------------------------------------------------------------- Bugs fixed in 1.8.3 (total 55): 10063 wineconsole run fail on korean locale. 16971 Windows Movie Maker 2.x needs ole32.dll.StgOpenPropStg 17257 TeX2Word will not install 20695 Cannot scroll documents being compared in winmerge 23768 winhelp: Some images not shown in certain 16-bit Help files 24421 MJ's Help Diagnostics crashes on startup (app provided MonitorEnumProc callback relies on ECX = lprcMonitor) 25790 WM_SETTEXT handler for the user32 buttons generates WM_CTLCOLOR* inconsistent with Windows user32 26978 tokenadmin.exe crash : Unimplemented function winscard.dll.SCardListReadersA 27680 Multiple 64-bit applications crash on startup (violation of the Windows 64-bit ABI, stack pointer (RSP) must be 16-byte aligned when making a call to Win64 API) 28082 OCCT Perestroïka needs hal.dll.READ_PORT_ULONG 28177 Adventure games from Kheops Studio hang after the logo screen (Safecracker, Destination: Treasure Island, Nostradamus: Lost Prophecy, Dracula 3, Return to Mysterious Island 2) 28825 Mystic Diary - Haunted Island: Multiple sprite-related bugs in hidden object scenes 29979 ElsterFormular crashes when trying to print already sent income tax return 31662 Office 2010 font embedding when exporting to PDF 32451 Multiple GOG.com installer bundles show a broken/unresponsive dialog window during installation (installer process running out of wndproc slots) 32979 Metal Gear Solid Crash 34070 Simutronics 'StormFront.exe' runs out of wndproc slots (ActiveSkin control) 34851 Multiple applications need kernel32 GetFinalPathNameByHandleA/W (64-bit Autodesk Fusion 360, Microsoft OneDrive) 35054 Dragon Age 2 system diagnostics tool fails to recognize GeForce GT 425M 35092 Multiple 64-bit applications need __CxxFrameHandler implementation (Ableton Live 9.1, Adobe Cloud apps) 35711 Winelib: compile error in wincon.h if NOGDI is defined before #include <windows.h> 36031 GeForce 9700M incorrectly detected as 9400 37087 Gothic 2 english demo fails with 'Conflict: a hook process was found. Please deactivate all Antivirus and Anti-Trojan programs and debuggers.' 38102 Process Hacker 2.x needs winsta.dll.WinStationEnumerateW 39092 Regression introduced with xaudio2_8 39215 Nvidia GeForce GTX960M detected as GTX470 39543 Multiple games and applications crash on unimplemented function KERNEL32.dll.FreeUserPhysicalPages (Microsoft Office 2007 diagnosis service, Eden Eternal) 39657 Tencent QQ 7.6 crashes on unimplemented function ntoskrnl.exe.PsRemoveLoadImageNotifyRoutine 39667 dinput: MotoGP 3 demo launcher crashes on leaving key configuration dialog. 39681 Unimplemented function crypt32.dll.CryptMsgVerifyCountersignatureEncoded 39730 FillRect() confuses 16bit brush handles with color constants 39759 Add support for detect Nvidia TITAN Black in wine3d/device list 39786 GoodSync crashes, needs oleaut32.OleLoadPictureFile 39796 SCP Containment Breach page fault 39918 Mail.Ru GameCenter installer does not work 39940 Stars! tooltips have wrong background color 40048 Camtasia Studio 8 : crashes on unimplemented function dwmapi.dll.DwmSetPresentParameters 40081 CLM Explorer needs fontsub.dll.CreateFontPackage 40108 kernel32:process regression 40135 msvcirt.c:1386:5: warning: comparison of unsigned expression < 0 is always false 40244 PostThreadMessage with WM_NOTIFY message should succeed 40246 Please document WINEBUILD in the winegcc manpage 40286 Geforce 980 maxwell card is not properly detected 40297 Multiple app crashes in macdrv_EnumDisplayMonitors 40304 EveHQ2 crashes with builtin gdiplus 40348 Nvidia 800 series cards not detected correctly 40389 cmd.exe (native): Unimplemented function KERNEL32.dll.GetConsoleAliasExesLengthW 40396 Windows SDK DirectWrite sample crashes on uninitialized parameter 40456 NFS MW + NFS Carbon: Car is flying above/under the track (D3DXVec3Transform needs arguments aliasing) 40466 Midnight Commander needs KERNEL32.dll.GetConsoleFontInfo 40473 wine fails to compile with >=glibc-2.23 40487 3dmark Vantage Benchmark: unimplemented functions hal.dll.READ and WRITE PORT 40493 Prison Tycoon 4 crashes on start up needing msvcp71.dll.??$?5DU?$char_traits(a)D@std@@@std@@YAAAV?$basic_istream(a)DU?$char_traits(a)D@std@@@0(a)AAV10@AAC(a)Z 40517 Office 2007 shows error message "Unexpected error during export" when trying to export document as PDF file 40525 schannel:main does not recognize package version 0x400000 ---------------------------------------------------------------- Changes since 1.8.2: Alex Henrie (2): ole32: Implement StgCreatePropStg. ole32: Implement StgOpenPropStg. Alexander Lakhin (2): user32: Send the correct WM_CTLCOLOR* message in button WM_SETTEXT handler. user32: Send WM_CTLCOLOR* message only for visible buttons. Alexandre Julliard (2): wineconsole: If necessary, fallback to a font without the right properties instead of failing. kernel32/nls: Convert remaining files to UTF-8. Alistair Leslie-Hughes (2): wined3d: Add detection for NVIDIA GTX TITAN. wined3d: Add detection for NVIDIA GTX TITAN Series. Andrew Eikum (6): xaudio2: Explicitly version the 2.7 coclasses. xaudio2_8: Use shared source. xaudio2: Remove run-time version checks for XAudio2 object. xaudio2: Report incoming underruns to the application. xaudio2: Protect access to source voice during creation (Coverity). xaudio2: Protect access to submix voice during creation (Coverity). Andrey Gusev (1): kernel32/nls: Update currency name and fix a typo. André Hentschel (2): xaudio2_7: Check return of IAudioClient_Start (Coverity). shell32: Provide helper function a buffer of correct size. Aurimas Fišeras (1): kernel32/nls: Update currency for Baltic states. Austin English (8): include: Fix GetCurrentConsoleFontEx/SetCurrentConsoleFontEx definition. oleaut32: Add OleLoadPictureFile stub. wine.inf: Create Microsoft Shared/TextConv directory. kernel32: Add GetConsoleFontInfo stub. winscard: Add stubs for SCardListReadersA/W. crypt32: Add CryptMsgVerifyCountersignatureEncoded stub. ntoskrnl.exe: Add PsRemoveLoadImageNotifyRoutine stub. ntoskrnl.exe: Add KeDelayExecutionThread stub. Bernhard Übelacker (1): dinput: Implement device property DIPROP_USERNAME. Caron Wills (9): wined3d: Add Nvidia GeForce GTX 860. wined3d: Add Nvidia GeForce 820M. wined3d: Add Nvidia GeForce 830M. wined3d: Add Nvidia GeForce 840M. wined3d: Add Nvidia GeForce 845M. wined3d: Add Nvidia GeForce GTX 850M. wined3d: Add Nvidia GeForce GTX 870M. wined3d: Add Nvidia GeForce GTX 880M. wined3d: Add Nvidia GeForce GT 730M. François Gouget (1): schannel: Add declarations for SECPKG version 7. Henri Verbeet (11): wined3d: Sanitise map flags in wined3d_surface_map(). wined3d: Recognise Intel Ivybridge on MacOS. kernel32/nls: Persian uses a right-to-left writing system. kernel32/nls: Use Persian characters to write Persian. kernel32/nls: Use ZWNJ where appropriate in far.nls. kernel32/nls: Persian is called Persian in English. kernel32/nls: Store LOCALE_SNATIVEDIGITS as UTF-8 in far.nls. kernel32/nls: Use Persian punctuation for LANG_PERSIAN. kernel32/nls: Fix LOCALE_IFIRSTDAYOFWEEK for LANG_PERSIAN. kernel32/nls: Return CAL_GREGORIAN_XLIT_FRENCH for LOCALE_ICALENDARTYPE for LANG_PERSIAN. kernel32/nls: Fix LOCALE_SMONTHNAME5/LOCALE_SABBREVMONTHNAME5 for LANG_PERSIAN. Iván Matellanes (1): msvcirt: Avoid superfluous comparison in some compilers. Jarkko Korpi (1): wined3d: Add detection for NVIDIA GeForce 425M. Jean-Christophe Cardot (1): winhlp32: Fix some images not shown in certain 16-bit help files. Jens Reyer (2): winegcc: Document WINEBUILD in the manpage. msiexec: Fix a typo in the manpage. Ken Thomases (1): user32: Call the EnumDisplayMonitors callback using a wrapper. Kerstin Noa (1): wined3d: Add NVIDIA GeForce GTX 980 GPU information. Kim Malmo (1): wined3d: Add Nvidia 9700M GT. Louis Lenders (4): gdiplus: GdipTransformPath should return Ok if matrix = NULL. ntdll: Add stub for RtlAddAuditAccessObjectAce and forward to AddAuditAccessObjectAce in advapi32. ntdll: Add stub for RtlAddAccessAllowedObjectAce and forward to AddAccessAllowedObjectAce in advapi32. ntdll: Add stub for RtlAddAccessDeniedObjectAce and forward to AddAccessDeniedObjectAce in advapi32. Michael Müller (2): winex11: Add 320x240 as supported resolution in desktop mode. kernel32: Implement GetFinalPathNameByHandle. Nikolay Sivov (11): user32: For EnableScrollBar() always go through EnableWindow() in SB_CTL case. t2embed: Implement TTGetEmbeddingType(). fontsub: Added CreateFontPackage() stub. fontsub: Improve CreateFontPackage() stub for TTFCFP_SUBSET case. t2embed: Implement TTIsEmbeddingEnabledForFacename(). t2embed: Implement TTIsEmbeddingEnabled(). gdi32: Increase first gdi handle value. dwrite: Always initialize context and font table pointers. kernel32/nls: Convert most of the locale data files to UTF-8. kernel32/nls: Added SSHORTESTDAYNAME* entries. kernel32/nls: Fix shortest day names for Thai and Vietnamese. Paul Gofman (1): d3dx9: D3DXVec3Transform should support input and output parameter overlap. Piotr Caban (4): msvcrt: Dump exception information in x86_64 __CxxFrameHandler. msvcrt: Handle frames with CXX_FRAME_MAGIC_VC6 and CXX_FRAME_MAGIC_VC7 magic value. user32: Call window procedure even if we're out of winproc handles. msvcp71: Add basic_istream<char>::operator>> export. Rob Walker (1): wined3d: Add Nvidia GPU SKUs 950,950M,960,960M. Sebastian Lackner (8): xaudio2_7: Unset DebugInfo->Spare[0] before destroying critical sections. user32: Set %ecx to address of rect in EnumDisplayMonitors callback. user32/tests: Add tests for button WM_CTLCOLOR* messages. user32: Do not block sending/posting WM_NOTIFY messages. kernel32/tests: Add test for process object destruction. kernel32/tests: Disable Windows version dependent test for pcPriClassBase. server: Do not hold reference on parent process. ntoskrnl.exe: Add missing linebreak to FIXME in KeDelayExecutionThread. Seong-ho Cho (1): configure: Add AC_HEADER_MAJOR to find where major() is defined. bye michael -- Michael Stefaniuc mstefani(a)winehq.org

June 6, 2016

Re: [PATCH v2 1/2] msi/tests: Test for ErrorControl-flag

by Hans Leidekker

On Fri, 2016-06-03 at 19:03 +0200, Andreas Maier wrote: > This test expands a already existing test. > A Service is installed with the special ErrorControl-flag > 0x8000 (msidbServiceInstallErrorControlVital). > The flag should be filtered out be msi. The test checks, > if the service is created without this flag. Looks good. > Besides it fixes a bug in test_delete_services. > TestService was not deleted after testing. Please submit this as a separate patch and resend the whole set labeled [1/3], [2/3] and [3/3]. You also need put the fix first or mark the test todo_wine because tests should never fail on Wine between two patches.

June 6, 2016

Re: [PATCH 5/5] ddraw/tests: Remove p8_primary_test.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23355 Your paranoid android. === w864 (32 bit visual) === visual.c:307: Test failed: Clear rectangle 3(pos, neg) has color 0000ff00 visual.c:309: Test failed: Clear rectangle 1(pos, pos) has color 0000ff00 visual.c:311: Test failed: Clear rectangle 4(NULL) has color 0000ff00 visual.c:313: Test failed: Clear rectangle 4(neg, neg) has color 0000ff00 === w1064 (32 bit visual) === visual.c:307: Test failed: Clear rectangle 3(pos, neg) has color 0000ff00 visual.c:309: Test failed: Clear rectangle 1(pos, pos) has color 0000ff00 visual.c:311: Test failed: Clear rectangle 4(NULL) has color 0000ff00 visual.c:313: Test failed: Clear rectangle 4(neg, neg) has color 0000ff00

June 6, 2016