June 2016 - Wine-Devel - list.winehq.org

Re: [PATCH 1/5] usp10/tests: Add an itemisation test for Persian numerals and punctuation.

by Henri Verbeet

On 5 June 2016 at 20:20, Marvin <testbot(a)winehq.org> wrote: > === w1064 (32 bit usp10) === > usp10.c:1458: Test failed: 0: uJustification incorrect (0) > usp10.c:1458: Test failed: 1: uJustification incorrect (0) > usp10.c:1458: Test failed: 2: uJustification incorrect (0) > usp10.c:1458: Test failed: 3: uJustification incorrect (0) > usp10.c:1458: Test failed: 4: uJustification incorrect (0) > usp10.c:1458: Test failed: 5: uJustification incorrect (0) > usp10.c:1458: Test failed: 6: uJustification incorrect (0) > usp10.c:1458: Test failed: 7: uJustification incorrect (0) > usp10.c:1458: Test failed: 8: uJustification incorrect (0) > usp10.c:1458: Test failed: 9: uJustification incorrect (0) > usp10.c:1474: Test failed: 3: uJustification incorrect (0) > usp10.c:1474: Test failed: 5: fDiacritic incorrect (1) > usp10.c:1474: Test failed: 5: fZeroWidth incorrect (1) > usp10.c:1474: Test failed: 15: fDiacritic incorrect (1) > usp10.c:1474: Test failed: 15: fZeroWidth incorrect (1) > > === w1064 (64 bit usp10) === > usp10.c:1458: Test failed: 0: uJustification incorrect (0) > usp10.c:1458: Test failed: 1: uJustification incorrect (0) > usp10.c:1458: Test failed: 2: uJustification incorrect (0) > usp10.c:1458: Test failed: 3: uJustification incorrect (0) > usp10.c:1458: Test failed: 4: uJustification incorrect (0) > usp10.c:1458: Test failed: 5: uJustification incorrect (0) > usp10.c:1458: Test failed: 6: uJustification incorrect (0) > usp10.c:1458: Test failed: 7: uJustification incorrect (0) > usp10.c:1458: Test failed: 8: uJustification incorrect (0) > usp10.c:1458: Test failed: 9: uJustification incorrect (0) > usp10.c:1474: Test failed: 3: uJustification incorrect (0) > usp10.c:1474: Test failed: 5: fDiacritic incorrect (1) > usp10.c:1474: Test failed: 5: fZeroWidth incorrect (1) > usp10.c:1474: Test failed: 15: fDiacritic incorrect (1) > usp10.c:1474: Test failed: 15: fZeroWidth incorrect (1) > > These are the existing Windows 10 failures.

June 5, 2016

Re: [PATCH 5/5] usp10: Properly check for numeric scripts.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23342 Your paranoid android. === w1064 (32 bit usp10) === usp10.c:1458: Test failed: 0: uJustification incorrect (0) usp10.c:1458: Test failed: 1: uJustification incorrect (0) usp10.c:1458: Test failed: 2: uJustification incorrect (0) usp10.c:1458: Test failed: 3: uJustification incorrect (0) usp10.c:1458: Test failed: 4: uJustification incorrect (0) usp10.c:1458: Test failed: 5: uJustification incorrect (0) usp10.c:1458: Test failed: 6: uJustification incorrect (0) usp10.c:1458: Test failed: 7: uJustification incorrect (0) usp10.c:1458: Test failed: 8: uJustification incorrect (0) usp10.c:1458: Test failed: 9: uJustification incorrect (0) usp10.c:1474: Test failed: 3: uJustification incorrect (0) usp10.c:1474: Test failed: 5: fDiacritic incorrect (1) usp10.c:1474: Test failed: 5: fZeroWidth incorrect (1) usp10.c:1474: Test failed: 15: fDiacritic incorrect (1) usp10.c:1474: Test failed: 15: fZeroWidth incorrect (1) === w1064 (64 bit usp10) === usp10.c:1458: Test failed: 0: uJustification incorrect (0) usp10.c:1458: Test failed: 1: uJustification incorrect (0) usp10.c:1458: Test failed: 2: uJustification incorrect (0) usp10.c:1458: Test failed: 3: uJustification incorrect (0) usp10.c:1458: Test failed: 4: uJustification incorrect (0) usp10.c:1458: Test failed: 5: uJustification incorrect (0) usp10.c:1458: Test failed: 6: uJustification incorrect (0) usp10.c:1458: Test failed: 7: uJustification incorrect (0) usp10.c:1458: Test failed: 8: uJustification incorrect (0) usp10.c:1458: Test failed: 9: uJustification incorrect (0) usp10.c:1474: Test failed: 3: uJustification incorrect (0) usp10.c:1474: Test failed: 5: fDiacritic incorrect (1) usp10.c:1474: Test failed: 5: fZeroWidth incorrect (1) usp10.c:1474: Test failed: 15: fDiacritic incorrect (1) usp10.c:1474: Test failed: 15: fZeroWidth incorrect (1)

June 5, 2016

Re: [PATCH 4/5] usp10: Set the base embedding level for Script_Persian to 2.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23341 Your paranoid android. === w1064 (32 bit usp10) === usp10.c:1458: Test failed: 0: uJustification incorrect (0) usp10.c:1458: Test failed: 1: uJustification incorrect (0) usp10.c:1458: Test failed: 2: uJustification incorrect (0) usp10.c:1458: Test failed: 3: uJustification incorrect (0) usp10.c:1458: Test failed: 4: uJustification incorrect (0) usp10.c:1458: Test failed: 5: uJustification incorrect (0) usp10.c:1458: Test failed: 6: uJustification incorrect (0) usp10.c:1458: Test failed: 7: uJustification incorrect (0) usp10.c:1458: Test failed: 8: uJustification incorrect (0) usp10.c:1458: Test failed: 9: uJustification incorrect (0) usp10.c:1474: Test failed: 3: uJustification incorrect (0) usp10.c:1474: Test failed: 5: fDiacritic incorrect (1) usp10.c:1474: Test failed: 5: fZeroWidth incorrect (1) usp10.c:1474: Test failed: 15: fDiacritic incorrect (1) usp10.c:1474: Test failed: 15: fZeroWidth incorrect (1) === w1064 (64 bit usp10) === usp10.c:1458: Test failed: 0: uJustification incorrect (0) usp10.c:1458: Test failed: 1: uJustification incorrect (0) usp10.c:1458: Test failed: 2: uJustification incorrect (0) usp10.c:1458: Test failed: 3: uJustification incorrect (0) usp10.c:1458: Test failed: 4: uJustification incorrect (0) usp10.c:1458: Test failed: 5: uJustification incorrect (0) usp10.c:1458: Test failed: 6: uJustification incorrect (0) usp10.c:1458: Test failed: 7: uJustification incorrect (0) usp10.c:1458: Test failed: 8: uJustification incorrect (0) usp10.c:1458: Test failed: 9: uJustification incorrect (0) usp10.c:1474: Test failed: 3: uJustification incorrect (0) usp10.c:1474: Test failed: 5: fDiacritic incorrect (1) usp10.c:1474: Test failed: 5: fZeroWidth incorrect (1) usp10.c:1474: Test failed: 15: fDiacritic incorrect (1) usp10.c:1474: Test failed: 15: fZeroWidth incorrect (1)

June 5, 2016

Re: [PATCH 3/5] usp10: Persian numerals are written left-to-right.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23340 Your paranoid android. === w1064 (32 bit usp10) === usp10.c:1458: Test failed: 0: uJustification incorrect (0) usp10.c:1458: Test failed: 1: uJustification incorrect (0) usp10.c:1458: Test failed: 2: uJustification incorrect (0) usp10.c:1458: Test failed: 3: uJustification incorrect (0) usp10.c:1458: Test failed: 4: uJustification incorrect (0) usp10.c:1458: Test failed: 5: uJustification incorrect (0) usp10.c:1458: Test failed: 6: uJustification incorrect (0) usp10.c:1458: Test failed: 7: uJustification incorrect (0) usp10.c:1458: Test failed: 8: uJustification incorrect (0) usp10.c:1458: Test failed: 9: uJustification incorrect (0) usp10.c:1474: Test failed: 3: uJustification incorrect (0) usp10.c:1474: Test failed: 5: fDiacritic incorrect (1) usp10.c:1474: Test failed: 5: fZeroWidth incorrect (1) usp10.c:1474: Test failed: 15: fDiacritic incorrect (1) usp10.c:1474: Test failed: 15: fZeroWidth incorrect (1) === w1064 (64 bit usp10) === usp10.c:1458: Test failed: 0: uJustification incorrect (0) usp10.c:1458: Test failed: 1: uJustification incorrect (0) usp10.c:1458: Test failed: 2: uJustification incorrect (0) usp10.c:1458: Test failed: 3: uJustification incorrect (0) usp10.c:1458: Test failed: 4: uJustification incorrect (0) usp10.c:1458: Test failed: 5: uJustification incorrect (0) usp10.c:1458: Test failed: 6: uJustification incorrect (0) usp10.c:1458: Test failed: 7: uJustification incorrect (0) usp10.c:1458: Test failed: 8: uJustification incorrect (0) usp10.c:1458: Test failed: 9: uJustification incorrect (0) usp10.c:1474: Test failed: 3: uJustification incorrect (0) usp10.c:1474: Test failed: 5: fDiacritic incorrect (1) usp10.c:1474: Test failed: 5: fZeroWidth incorrect (1) usp10.c:1474: Test failed: 15: fDiacritic incorrect (1) usp10.c:1474: Test failed: 15: fZeroWidth incorrect (1)

June 5, 2016

Re: [PATCH 2/5] usp10: Fix the script tag and fallback font for Script_Persian.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23339 Your paranoid android. === w1064 (32 bit usp10) === usp10.c:1458: Test failed: 0: uJustification incorrect (0) usp10.c:1458: Test failed: 1: uJustification incorrect (0) usp10.c:1458: Test failed: 2: uJustification incorrect (0) usp10.c:1458: Test failed: 3: uJustification incorrect (0) usp10.c:1458: Test failed: 4: uJustification incorrect (0) usp10.c:1458: Test failed: 5: uJustification incorrect (0) usp10.c:1458: Test failed: 6: uJustification incorrect (0) usp10.c:1458: Test failed: 7: uJustification incorrect (0) usp10.c:1458: Test failed: 8: uJustification incorrect (0) usp10.c:1458: Test failed: 9: uJustification incorrect (0) usp10.c:1474: Test failed: 3: uJustification incorrect (0) usp10.c:1474: Test failed: 5: fDiacritic incorrect (1) usp10.c:1474: Test failed: 5: fZeroWidth incorrect (1) usp10.c:1474: Test failed: 15: fDiacritic incorrect (1) usp10.c:1474: Test failed: 15: fZeroWidth incorrect (1) === w1064 (64 bit usp10) === usp10.c:1458: Test failed: 0: uJustification incorrect (0) usp10.c:1458: Test failed: 1: uJustification incorrect (0) usp10.c:1458: Test failed: 2: uJustification incorrect (0) usp10.c:1458: Test failed: 3: uJustification incorrect (0) usp10.c:1458: Test failed: 4: uJustification incorrect (0) usp10.c:1458: Test failed: 5: uJustification incorrect (0) usp10.c:1458: Test failed: 6: uJustification incorrect (0) usp10.c:1458: Test failed: 7: uJustification incorrect (0) usp10.c:1458: Test failed: 8: uJustification incorrect (0) usp10.c:1458: Test failed: 9: uJustification incorrect (0) usp10.c:1474: Test failed: 3: uJustification incorrect (0) usp10.c:1474: Test failed: 5: fDiacritic incorrect (1) usp10.c:1474: Test failed: 5: fZeroWidth incorrect (1) usp10.c:1474: Test failed: 15: fDiacritic incorrect (1) usp10.c:1474: Test failed: 15: fZeroWidth incorrect (1)

June 5, 2016

Re: [PATCH 1/5] usp10/tests: Add an itemisation test for Persian numerals and punctuation.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23338 Your paranoid android. === w1064 (32 bit usp10) === usp10.c:1458: Test failed: 0: uJustification incorrect (0) usp10.c:1458: Test failed: 1: uJustification incorrect (0) usp10.c:1458: Test failed: 2: uJustification incorrect (0) usp10.c:1458: Test failed: 3: uJustification incorrect (0) usp10.c:1458: Test failed: 4: uJustification incorrect (0) usp10.c:1458: Test failed: 5: uJustification incorrect (0) usp10.c:1458: Test failed: 6: uJustification incorrect (0) usp10.c:1458: Test failed: 7: uJustification incorrect (0) usp10.c:1458: Test failed: 8: uJustification incorrect (0) usp10.c:1458: Test failed: 9: uJustification incorrect (0) usp10.c:1474: Test failed: 3: uJustification incorrect (0) usp10.c:1474: Test failed: 5: fDiacritic incorrect (1) usp10.c:1474: Test failed: 5: fZeroWidth incorrect (1) usp10.c:1474: Test failed: 15: fDiacritic incorrect (1) usp10.c:1474: Test failed: 15: fZeroWidth incorrect (1) === w1064 (64 bit usp10) === usp10.c:1458: Test failed: 0: uJustification incorrect (0) usp10.c:1458: Test failed: 1: uJustification incorrect (0) usp10.c:1458: Test failed: 2: uJustification incorrect (0) usp10.c:1458: Test failed: 3: uJustification incorrect (0) usp10.c:1458: Test failed: 4: uJustification incorrect (0) usp10.c:1458: Test failed: 5: uJustification incorrect (0) usp10.c:1458: Test failed: 6: uJustification incorrect (0) usp10.c:1458: Test failed: 7: uJustification incorrect (0) usp10.c:1458: Test failed: 8: uJustification incorrect (0) usp10.c:1458: Test failed: 9: uJustification incorrect (0) usp10.c:1474: Test failed: 3: uJustification incorrect (0) usp10.c:1474: Test failed: 5: fDiacritic incorrect (1) usp10.c:1474: Test failed: 5: fZeroWidth incorrect (1) usp10.c:1474: Test failed: 15: fDiacritic incorrect (1) usp10.c:1474: Test failed: 15: fZeroWidth incorrect (1)

June 5, 2016

Re: [PATCH v2 1/2] msi/tests: Test for ErrorControl-flag

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23331 Your paranoid android. === w1064 (64 bit action) === The test timed out

June 4, 2016

Re: [PATCH] shell32: fix out of memory errors and their underlying cause

by Nikolay Sivov

Thanks. Could you please also fix buffer and 'assoc' leaks in the same patch?

June 4, 2016

Re: gdiplus: Fix a typo in struct GpAdjustableArrowCap

by Vincent Povirk

We'll need it when we implement adjustable arrow caps. On Jun 3, 2016 8:34 PM, "Ken Thomases" <ken(a)codeweavers.com> wrote: On Jun 3, 2016, at 10:12 AM, Andrey Gusev <andrey.goosev(a)gmail.com> wrote: > > diff --git a/dlls/gdiplus/gdiplus_private.h b/dlls/gdiplus/gdiplus_private.h > index 10092f1..9b29d88 100644 > --- a/dlls/gdiplus/gdiplus_private.h > +++ b/dlls/gdiplus/gdiplus_private.h > @@ -314,7 +314,7 @@ struct GpCustomLineCap{ > REAL scale; > }; > > -struct GpAdustableArrowCap{ > +struct GpAdjustableArrowCap{ > GpCustomLineCap cap; > }; > Nothing uses this struct, which is evident by the fact that there are no other changes necessary along with the above change. So, why is this here, at all? Shouldn't it just be removed? -Ken

June 4, 2016

Re: gdiplus: Fix a typo in struct GpAdjustableArrowCap

by Ken Thomases

On Jun 3, 2016, at 10:12 AM, Andrey Gusev <andrey.goosev(a)gmail.com> wrote: > > diff --git a/dlls/gdiplus/gdiplus_private.h b/dlls/gdiplus/gdiplus_private.h > index 10092f1..9b29d88 100644 > --- a/dlls/gdiplus/gdiplus_private.h > +++ b/dlls/gdiplus/gdiplus_private.h > @@ -314,7 +314,7 @@ struct GpCustomLineCap{ > REAL scale; > }; > > -struct GpAdustableArrowCap{ > +struct GpAdjustableArrowCap{ > GpCustomLineCap cap; > }; > Nothing uses this struct, which is evident by the fact that there are no other changes necessary along with the above change. So, why is this here, at all? Shouldn't it just be removed? -Ken

June 4, 2016