June 2016 - Wine-Devel - list.winehq.org

Re: [PATCH] d3dx9_36: Stop crash when displaying effect errors

by Matteo Bruni

2016-06-02 9:56 GMT+02:00 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>: > On 02/06/16 07:18, Matteo Bruni wrote: >> 2016-06-01 12:18 GMT+02:00 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>: >> >> What effect / application is crashing because of this and what are the errors? >> >> > The Game is Battlefield 1225 Demo. I was investigating issue > https://bugs.winehq.org/show_bug.cgi?id=39652 > > I have > d3dcompiler_43 set to native. > d3d9_* set to buildin. > > The errors generated are > "Shaders/commonVertexLight.fx(30,9): warning X3205: conversion from > larger type to smaller, possible loss of > data\nShaders/commonVertexLight.fx(31,7): warning X3205: conversion from > larger type to smaller, possible loss of > data\nShaders/commonVertexLight.fx(40,9): warning X3205: conversion from > larger"... Thanks. I think a better way to fix this is to break the TRACE message over multiple lines. Maybe break on '\n' or every ~80 characters (whichever comes first)? > > Best Regards > Alistair Leslie-Hughes

June 2, 2016

Re: [PATCH 5/5] wined3d: User clip planes emulation for core profile contexts.

by Henri Verbeet

On 1 June 2016 at 23:16, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > + if (update_mask & WINED3D_SHADER_CONST_VS_CLIP_PLANES) > + { > + for (i = 0; i < gl_info->limits.clipplanes; ++i) > + shader_glsl_clip_plane_uniform(context, state, i, prog); > + } It's not wrong, but it seems somewhat arbitrary to use the legacy/fixed function clip plane limit.

June 2, 2016

Re: [PATCH] Tell dosbox to read the current user's config

by shankao＠gmail.com

Reconverted to use a different argument for the userconf option. On Thu, Jun 2, 2016 at 5:18 PM shankao(a)gmail.com <shankao(a)gmail.com> wrote: > I can change it to a different argument. It may be more readable too > > > > Yes, looks good, thanks. > Does that work? It seems somewhat > suspicious to combine the -userconf and -conf options into a single > argument. >

June 2, 2016

[PATCH] Tell dosbox to read the current user's config

by shankao＠gmail.com

I can change it to a different argument. It may be more readable too > > Yes, looks good, thanks. > Does that work? It seems somewhat suspicious to combine the -userconf and -conf options into a single argument.

June 2, 2016

Re: [PATCH] Tell dosbox to read the current user's config

by Henri Verbeet

On 2 June 2016 at 05:50, Austin English <austinenglish(a)gmail.com> wrote: > On 06/01/2016 10:48 PM, shankao(a)gmail.com wrote: >> Thanks, sending again. Please, let me know if it's correct. > > Yes, looks good, thanks. > Does that work? It seems somewhat suspicious to combine the -userconf and -conf options into a single argument.

June 2, 2016

Re: [PATCH] d3dx9_36: Stop crash when displaying effect errors

by Alistair Leslie-Hughes

Hi Matteo, On 02/06/16 07:18, Matteo Bruni wrote: > 2016-06-01 12:18 GMT+02:00 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>: > > What effect / application is crashing because of this and what are the errors? > > The Game is Battlefield 1225 Demo. I was investigating issue https://bugs.winehq.org/show_bug.cgi?id=39652 I have d3dcompiler_43 set to native. d3d9_* set to buildin. The errors generated are "Shaders/commonVertexLight.fx(30,9): warning X3205: conversion from larger type to smaller, possible loss of data\nShaders/commonVertexLight.fx(31,7): warning X3205: conversion from larger type to smaller, possible loss of data\nShaders/commonVertexLight.fx(40,9): warning X3205: conversion from larger"... Best Regards Alistair Leslie-Hughes

June 2, 2016

Re: [PATCH] Tell dosbox to read the current user's config

by shankao＠gmail.com

Great. Should I send it in a new email or something like that? I still see the previous unsigned patch at https://source.winehq.org/patches/ On Thu, Jun 2, 2016 at 11:51 AM Austin English <austinenglish(a)gmail.com> wrote: > On 06/01/2016 10:48 PM, shankao(a)gmail.com wrote: > > Thanks, sending again. Please, let me know if it's correct. > > > > On Thu, Jun 2, 2016 at 11:37 AM Austin English <austinenglish(a)gmail.com > > <mailto:austinenglish(a)gmail.com>> wrote: > > > > On Wed, Jun 1, 2016 at 8:46 PM, shankao(a)gmail.com > > <mailto:shankao(a)gmail.com> <shankao(a)gmail.com > > <mailto:shankao(a)gmail.com>> wrote: > > > Fixes https://bugs.winehq.org/show_bug.cgi?id=40380 > > > > Hi, > > > > Thanks for the patch, but please see > > https://wiki.winehq.org/Submitting_Patches for how to submit a patch > > (sorry for not linking originally). > > > > In particular, you need a real name on the patch and to add a > sign-off. > > > > -- > > -Austin > > > > Yes, looks good, thanks. > > -- > -Austin > GPG: 14FB D7EA A041 937B > >

June 2, 2016

Re: [PATCH] Tell dosbox to read the current user's config

by Austin English

On 06/01/2016 10:48 PM, shankao(a)gmail.com wrote: > Thanks, sending again. Please, let me know if it's correct. > > On Thu, Jun 2, 2016 at 11:37 AM Austin English <austinenglish(a)gmail.com > <mailto:austinenglish(a)gmail.com>> wrote: > > On Wed, Jun 1, 2016 at 8:46 PM, shankao(a)gmail.com > <mailto:shankao(a)gmail.com> <shankao(a)gmail.com > <mailto:shankao(a)gmail.com>> wrote: > > Fixes https://bugs.winehq.org/show_bug.cgi?id=40380 > > Hi, > > Thanks for the patch, but please see > https://wiki.winehq.org/Submitting_Patches for how to submit a patch > (sorry for not linking originally). > > In particular, you need a real name on the patch and to add a sign-off. > > -- > -Austin > Yes, looks good, thanks. -- -Austin GPG: 14FB D7EA A041 937B

June 2, 2016

Re: [PATCH] Tell dosbox to read the current user's config

by shankao＠gmail.com

Thanks, sending again. Please, let me know if it's correct. On Thu, Jun 2, 2016 at 11:37 AM Austin English <austinenglish(a)gmail.com> wrote: > On Wed, Jun 1, 2016 at 8:46 PM, shankao(a)gmail.com <shankao(a)gmail.com> > wrote: > > Fixes https://bugs.winehq.org/show_bug.cgi?id=40380 > > Hi, > > Thanks for the patch, but please see > https://wiki.winehq.org/Submitting_Patches for how to submit a patch > (sorry for not linking originally). > > In particular, you need a real name on the patch and to add a sign-off. > > -- > -Austin >

June 2, 2016

Re: [PATCH] Tell dosbox to read the current user's config

by Austin English

On Wed, Jun 1, 2016 at 8:46 PM, shankao(a)gmail.com <shankao(a)gmail.com> wrote: > Fixes https://bugs.winehq.org/show_bug.cgi?id=40380 Hi, Thanks for the patch, but please see https://wiki.winehq.org/Submitting_Patches for how to submit a patch (sorry for not linking originally). In particular, you need a real name on the patch and to add a sign-off. -- -Austin

June 2, 2016