June 2016 - Wine-Devel - list.winehq.org

Re: [PATCH 6/7] d3drm: Implement IDirect3DRMViewport*::Init.

by Aaryaman Vasishta

On Monday, June 27, 2016, Stefan Dösinger <stefandoesinger(a)gmail.com> wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 > > Am 2016-06-24 um 22:49 schrieb Aaryaman Vasishta: > > + if (FAILED(hr = IDirect3DRMDevice_QueryInterface(device, > &IID_IDirect3DRMDevice3, (void **)&device3))) > > + return hr; > > + > > + if (FAILED(hr = IDirect3DRMFrame_QueryInterface(camera, > &IID_IDirect3DRMFrame3, (void **)&camera3))) > > + { > > + IDirect3DRMDevice3_Release(device3); > > + return hr; > > + } > > + IDirect3DRMDevice_Release(device); > > + IDirect3DRMFrame_Release(camera); > > + > > + return d3drm_viewport2_Init(&viewport->IDirect3DRMViewport2_iface, > device3, camera3, x, y, width, height); > This has the same problem as the first version of your frame thunks: You > get "device3", but then you release "device", to which you don't hold a > reference. Right, I should probably release device3 after calling d3drm_viewport2_init. Cheers, Aaryaman

June 27, 2016

Re: [PATCH 7/7] d3drm: Implement IDirect3DRM*::CreateViewport.

by Aaryaman Vasishta

On Monday, June 27, 2016, Stefan Dösinger <stefandoesinger(a)gmail.com> wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 > > Am 2016-06-24 um 22:49 schrieb Aaryaman Vasishta: > > + hr = IDirect3DRM3_CreateViewport(d3drm3, device3, frame3, rc.left, > rc.top, rc.right, rc.bottom + 1, &viewport2); > > + ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got > %#x.\n", hr); > > + if (FAILED(hr)) > > + { > > + hr = IDirect3DRM3_CreateViewport(d3drm3, device3, frame3, > rc.left, rc.top, rc.right, rc.bottom, NULL); > > + ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, > got %#x.\n", hr); > > + } > Afaics the if (FAILED(hr)) isn't necessary here. > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v2 > > iQIcBAEBCAAGBQJXcFm2AAoJEN0/YqbEcdMwbewP/11c9oFcbQjek33cW30miUka > fO/BIk3qk6xpsz/CMF/DRmwQvqPObSnG5zsAXn4j1hsJM2y3EBRjLeZx1/CqyR9s > uQ9JyN85zB2rEDkSpLFNaOIW0hnX7bFFnOmZlIlZPYRH1cqQSJcg5gcAq8EnLeIl > ioWW0qK3ZREeRDZXEe0YxuwGqWE+HouUNzS/En9OrlZ9b76zfuRcH2rrGSw+2BPo > Az8PzllV8v3Df/HxqYyeG9JxgjWElk2aQGfHP5BPUE/JF5+Ky2xEb6RvHVGJQ64P > G/HKJGlKZT/VgQGCbJx6s5bNazBiJSyD4a6dj5IbEbWmnySJIbwW2DNXrcxKT9MO > oz0NNyjMQAVkJx45QVvtxm+5QsJIbO6V/38h+zsPW0F6dGrYoqBXXSFbsbp4ge2G > S2EC+bJVHsUwc2en52BaqJCRDYLSgxNaD2kL8ovZjLYBVi3jlfTP/OcIXYjam2I7 > 67b8VEeV7xBILU2uvhFxwpwLIgtVJ1b2QUyH3TjrKfClGu5lbe/VbASsrDjBaJV1 > ZZMqcmn1JU/P24wQVWb2gfqN12ktvhEnnYznwz8zw7OKdpOUoKlOXr/06tlrMmei > YfuGMZmJyxMJQSsfIVtoFH1HmqlZuk5QUjnjyShYDDf4TlKWZAtn4o4JJbt4n1J0 > bOobnKLPsEGKSNhoZbnm > =xbZw > -----END PGP SIGNATURE----- > Right, they're not needed now that this method is implemented. Cheers, Aaryaman

June 27, 2016

Host_Quit implementation in wscript

by Thiago Barbato

I tried running a .js with a WScript.Quit() call and noticed it isn't implemented yet in programs/wscript/host.c. Would a simple ExitProcess( ExitCode ) do the job or are there cases where this would be the wrong thing to do?

June 27, 2016

Re: [PATCH 7/7] d3drm: Implement IDirect3DRM*::CreateViewport.

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Am 2016-06-24 um 22:49 schrieb Aaryaman Vasishta: > + hr = IDirect3DRM3_CreateViewport(d3drm3, device3, frame3, rc.left, rc.top, rc.right, rc.bottom + 1, &viewport2); > + ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got %#x.\n", hr); > + if (FAILED(hr)) > + { > + hr = IDirect3DRM3_CreateViewport(d3drm3, device3, frame3, rc.left, rc.top, rc.right, rc.bottom, NULL); > + ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got %#x.\n", hr); > + } Afaics the if (FAILED(hr)) isn't necessary here. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXcFm2AAoJEN0/YqbEcdMwbewP/11c9oFcbQjek33cW30miUka fO/BIk3qk6xpsz/CMF/DRmwQvqPObSnG5zsAXn4j1hsJM2y3EBRjLeZx1/CqyR9s uQ9JyN85zB2rEDkSpLFNaOIW0hnX7bFFnOmZlIlZPYRH1cqQSJcg5gcAq8EnLeIl ioWW0qK3ZREeRDZXEe0YxuwGqWE+HouUNzS/En9OrlZ9b76zfuRcH2rrGSw+2BPo Az8PzllV8v3Df/HxqYyeG9JxgjWElk2aQGfHP5BPUE/JF5+Ky2xEb6RvHVGJQ64P G/HKJGlKZT/VgQGCbJx6s5bNazBiJSyD4a6dj5IbEbWmnySJIbwW2DNXrcxKT9MO oz0NNyjMQAVkJx45QVvtxm+5QsJIbO6V/38h+zsPW0F6dGrYoqBXXSFbsbp4ge2G S2EC+bJVHsUwc2en52BaqJCRDYLSgxNaD2kL8ovZjLYBVi3jlfTP/OcIXYjam2I7 67b8VEeV7xBILU2uvhFxwpwLIgtVJ1b2QUyH3TjrKfClGu5lbe/VbASsrDjBaJV1 ZZMqcmn1JU/P24wQVWb2gfqN12ktvhEnnYznwz8zw7OKdpOUoKlOXr/06tlrMmei YfuGMZmJyxMJQSsfIVtoFH1HmqlZuk5QUjnjyShYDDf4TlKWZAtn4o4JJbt4n1J0 bOobnKLPsEGKSNhoZbnm =xbZw -----END PGP SIGNATURE-----

June 26, 2016

Re: [PATCH 6/7] d3drm: Implement IDirect3DRMViewport*::Init.

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Am 2016-06-24 um 22:49 schrieb Aaryaman Vasishta: > + if (FAILED(hr = IDirect3DRMDevice_QueryInterface(device, &IID_IDirect3DRMDevice3, (void **)&device3))) > + return hr; > + > + if (FAILED(hr = IDirect3DRMFrame_QueryInterface(camera, &IID_IDirect3DRMFrame3, (void **)&camera3))) > + { > + IDirect3DRMDevice3_Release(device3); > + return hr; > + } > + IDirect3DRMDevice_Release(device); > + IDirect3DRMFrame_Release(camera); > + > + return d3drm_viewport2_Init(&viewport->IDirect3DRMViewport2_iface, device3, camera3, x, y, width, height); This has the same problem as the first version of your frame thunks: You get "device3", but then you release "device", to which you don't hold a reference. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXcFfoAAoJEN0/YqbEcdMweH8P/RBg+lEvXxGES0C1Uo5aN6Ht E0TOftji/AaGrVcaoHLWMsl30/GUpmh+iRdM19ZHwL0vey3yKKdTmFlt4tMrG5aP LLHLlxRqcJt1h+MREvMYb7JJjCAMcR/2Bn63nxWZpZ+PncQo1H90ZsBHCrd4Y707 JukrA3QfPm9cyXiX/ER8cj7QgpnNsk5y8ZXgbdtDDGOzShf2OSoslU5ivQQsmZ4W 2fiJWOeWdpi3P9Fh6EUTDOwUf5Rnj7mBYb3KFASc9o0VZXHuI/f35LGG9AdNkSxs lf6RbPDcXxPQqUxlz0VnmS/31/oGb0pDczESx+alDU9n29tWPANY+yBGUmDStyJ0 /RHl2qpZJMs/lQpk9UQ/RpvuVdZfLVxgftqyZuoWT4EfW5iseOlCytmsJEG1AVpd BKAMFRbueGhPYfUcuLAH1GL4keRg7P3QUd36MlR0wWVdYGtMWrbQL+6SrHT6r75C QmXU9mTJMTleA/Yzskenm71Tz9/wbwavYjUMaEQp3+7OKrG0Zqnt4foh2GpNUT+6 M7jxfSSng4+irWvxf3ZKdpjfGNHRn1ZhRKrEpxKQptiGlFvYSMDy7tHtyybK2MbB h8CO19YAzcVjfFHj5sRSYtZIHdVm5aG5FJLfVm9UPBA7xT2l9b6EgqXEhLTVLYC6 /TSyEFgT5j+DkKf6DCm+ =0tcs -----END PGP SIGNATURE-----

June 26, 2016

Re: WineHQ upgrade breaking dinput8:dinput?

by André Hentschel

Am 24.04.2016 um 21:12 schrieb Francois Gouget: > > I have added binaries compiled with my MinGW with -O2 and -O0, and > compiled with the TestBot compiler. I also added assembly files and > compiler version information. All of this is available at: > > http://fgouget.free.fr/tmp/dinput8-dinput.tar.xz > > > For immediate reference: > My compiler is the Debian Testing compiler (buggy): > $ i686-w64-mingw32-gcc --version > i686-w64-mingw32-gcc (GCC) 5.3.1 20160205 > Copyright (C) 2015 Free Software Foundation, Inc. > This is free software; see the source for copying conditions. There is NO > warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. > > The TestBot compiler is the Debian 7.4 compiler (not buggy): > $ i686-w64-mingw32-gcc --version > i686-w64-mingw32-gcc (GCC) 4.6.3 > Copyright (C) 2011 Free Software Foundation, Inc. > This is free software; see the source for copying conditions. There is NO > warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. > > > And the WineTest.exe binary is compiled with the Debian 8 compiler > which is presumably close to the current Debian Testing one. What happens if we compile it using Clang? (totally easy to do so by using wclang [1] to generate a wrapper around clang and mingw-w64) Or for me to try it, what's the best way to verify? does it depend on the wine version somewhat? [1] https://github.com/tpoechtrager/wclang

June 26, 2016

Vacation

by Alexandre Julliard

Folks, I'll be out on vacation next week, so there won't be any commits. Feel free to keep sending patches, I'll try to catch up when I get back, and make the next release on schedule two weeks from now. -- Alexandre Julliard julliard(a)winehq.org

June 25, 2016

Re: [PATCH 1/3] comdlg32: Optimize FILEDLG95_FILENAME_FillFromSelection.

by Lauri Kenttä

On 2016-06-23 16:44, Henri Verbeet wrote: > On 23 June 2016 at 13:29, Lauri Kenttä <lauri.kentta(a)gmail.com> wrote: >> This trades some memory for speed, but since currently selecting >> 1000 files takes over a minute but the required memory for those >> 1000 filenames is only 262 kB (worst case), this seems a reasonable >> trade-off. >> > That's probably fine, but is there any reason this can't use the > standard approach of just doubling the buffer size when you run out of > space? No reason. I'll fix that. > If this is performance critical code, the multiple copies of the > string related to GetName() probably don't help either. I'll fix that too, although it doesn't make much of a difference. Thanks, -- Lauri Kenttä

June 25, 2016

Re: [PATCH] winex11: fix destroying of top-level windows

by Miklós Máté

On 06/23/2016 09:00 AM, Henri Verbeet wrote: > On 22 June 2016 at 12:31, Miklós Máté <mtmkls(a)gmail.com> wrote: >> The v2 I sent to the list fixes the test, but I'm fairly sure that the >> critical section is wrong. I tried to run the d3d11 test to see if it better >> exercises multithreading, but it skipped all tests ("None of the requested >> D3D feature levels is supported on this GPU with the current shader >> backend." even though Mesa 11.2 supports GL 4.1 core profile on my hw). >> > You'll need to set "MaxVersionGL" to 0x00030002 to enable wined3d core > profile support. The d3d11 tests mostly pass with core profiles, but > test_draw_depth_only() for example fails. Alternatively, you can hack > the "shader_model" value in shader_glsl_get_caps(). The d3d11 tests > don't do much for multithreading however. The "CSMT" patch set > (https://github.com/stefand/wine/tree/master) is much better for that, > and unfortunately still fails with the latest version of the patch. > That patch set is not currently part of proper Wine, but I can send > you a version rebased onto either 1.9.12 or current git if you're > interested. Hi, I couldn't reproduce that test failure. I cloned Stefan's repository (master branch), applied my glx 1.3 patches that are in 1.9.12, and v2 of this patch, and I set the registry keys for CSMT (csmt=enabled, strictdrawordering=disabled). The d3d9 tests all pass. Did I miss something? Is there a way to tell if CSMT is in use? MM

June 24, 2016

Re: [PATCH 7/9] d3d11: Implement ID3D11UnorderedAccessView interface.

by Henri Verbeet

On 24 June 2016 at 13:23, Józef Kucia <joseph.kucia(a)gmail.com> wrote: > On Fri, Jun 24, 2016 at 12:56 PM, Henri Verbeet <hverbeet(a)gmail.com> wrote: >> On 24 June 2016 at 11:46, Józef Kucia <jkucia(a)codeweavers.com> wrote: >>> + switch (desc->ViewDimension) >>> + { >>> + case D3D11_UAV_DIMENSION_TEXTURE1DARRAY: >>> + if (desc->u.Texture1DArray.ArraySize == -1 && desc->u.Texture1DArray.FirstArraySlice < layer_count) >> I noticed too late for the other normalisation functions, but >> "ArraySize" is unsigned. > > Should I use 0xffffffff in tests as well? I'd say ~0u.

June 24, 2016