June 2016 - Wine-Devel - list.winehq.org

Re: [v2 4/7] msvcirt: Implement ostream::operator<< for floats

by Piotr Caban

On 06/22/16 14:23, Iván Matellanes wrote: > On 22/06/16 12:25, Piotr Caban wrote: >> On 06/22/16 11:53, Iván Matellanes wrote: >>> + str_length += _scprintf(sprintf_fmt, prec, d); /* number >>> representation */ >>> + if (str_length > 24) { >>> + /* too long to output */ >>> + ostream_writepad(ostr, "", ""); >> Could you please add a test for it? Also a comment saying that this is >> expected behavior would be useful. > Thanks for the feedback. > This is the expected behavior on Vista+. XP/2k3 crashes though, so I > ended up removing the related tests. What's the proper way to handle this? I think that you can just change the comment to make clear this is not incomplete implementation. Thanks, Piotr

June 22, 2016

Re: [v2 4/7] msvcirt: Implement ostream::operator<< for floats

by Iván Matellanes

On 22/06/16 12:25, Piotr Caban wrote: > On 06/22/16 11:53, Iván Matellanes wrote: >> + str_length += _scprintf(sprintf_fmt, prec, d); /* number >> representation */ >> + if (str_length > 24) { >> + /* too long to output */ >> + ostream_writepad(ostr, "", ""); > Could you please add a test for it? Also a comment saying that this is > expected behavior would be useful. Thanks for the feedback. This is the expected behavior on Vista+. XP/2k3 crashes though, so I ended up removing the related tests. What's the proper way to handle this? Cheers, Iván

June 22, 2016

Re: user32/tests: Avoid using CopyRect().

by Michael Stefaniuc

On 06/22/2016 12:06 PM, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > https://testbot.winehq.org/JobDetails.pl?Key=23786 > > Your paranoid android. > > > === w864 (64 bit win) === > win.c:8733: Test failed: msg.message = 320 A fluke as a rerun didn't produce it: https://testbot.winehq.org/JobDetails.pl?Key=23793 bye michael

June 22, 2016

Re: [v2 4/7] msvcirt: Implement ostream::operator<< for floats

by Piotr Caban

On 06/22/16 11:53, Iván Matellanes wrote: > + str_length += _scprintf(sprintf_fmt, prec, d); /* number representation */ > + if (str_length > 24) { > + /* too long to output */ > + ostream_writepad(ostr, "", ""); Could you please add a test for it? Also a comment saying that this is expected behavior would be useful. > + float param_float[] = {1.0f, 0.0f, 4.25f, 3.999f, 12.0005f, 15.33582f, 15.0f, 15.22f, 21.123f, 0.1f, > + 13.14159f, 0.00013f, 0.000013f, 1.0f / 0.0f, -1.0f / 0.0f, 0.0f / 0.0f}; Please do something similar as in dlls/msvcrt/tests/misc.c to define INFINITY/NAN in tests. Thanks, Piotr

June 22, 2016

Re: [v2 1/7] msvcirt: Implement ostream::operator<< for characters

by Piotr Caban

On 06/22/16 11:53, Iván Matellanes wrote: > + enum { CHAR } type; It's better to avoid using enum values identical as Windows types. It will make it impossible to use CHAR type. Thanks, Piotr

June 22, 2016

Re: [v2 3/7] msvcirt: Implement ostream::operator<< for integers

by Piotr Caban

On 06/22/16 11:53, Iván Matellanes wrote: > int param_int[] = {0, 7, 10, 24 ,55, 1024, 1023, 65536, 2147483647, 2147483648, 4294967295, -20}; It causes compilation warning: ../../../../wine_src/dlls/msvcirt/tests/msvcirt.c:3023:5: warning: this decimal constant is unsigned only in ISO C90 int param_int[] = {0, 7, 10, 24 ,55, 1024, 1023, 65536, 2147483647, 2147483648, 4294967295, -20}; ^ ../../../../wine_src/dlls/msvcirt/tests/msvcirt.c:3023:5: warning: this decimal constant is unsigned only in ISO C90 Thanks, Piotr

June 22, 2016

Re: [PATCH] winex11: fix destroying of top-level windows

by Miklós Máté

On 06/20/2016 04:42 PM, Alexandre Julliard wrote: > Miklós Máté <mtmkls(a)gmail.com> writes: > >> Fixes https://bugs.winehq.org/show_bug.cgi?id=40767 >> >> Signed-off-by: Miklós Máté <mtmkls(a)gmail.com> >> --- >> dlls/winex11.drv/opengl.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/dlls/winex11.drv/opengl.c b/dlls/winex11.drv/opengl.c >> index d89a193..27ddd79 100644 >> --- a/dlls/winex11.drv/opengl.c >> +++ b/dlls/winex11.drv/opengl.c >> @@ -1314,6 +1314,9 @@ static void free_gl_drawable( struct gl_drawable *gl ) >> { >> switch (gl->type) >> { >> + case DC_GL_WINDOW: >> + pglXDestroyWindow( gdi_display, gl->drawable ); >> + break; > Actually this one has some issues too: > > ../../../tools/runtest -q -P wine -T ../../.. -M d3d9.dll -p d3d9_test.exe.so device && touch device.ok > device.c:2250: Tests skipped: could not create device, IDirect3D9_CreateDevice returned 0x8876086c > device.c:6312: Tests skipped: This GPU supports SM3, skipping unsupported shader test. > device.c:6724: Tests skipped: D3DFMT_A32B32G32R32F supports filtering, skipping tests. > device.c:7747: Tests skipped: Failed to create cube texture for format R8G8B8 (hr 0x8876086c), skipping tests. > device.c:8450: Tests skipped: Dynamic D3DFMT_YUY2 textures not supported, skipping mipmap test. > device.c:8450: Tests skipped: Dynamic D3DFMT_UYVY textures not supported, skipping mipmap test. > X Error of failed request: GLXBadWindow > Major opcode of failed request: 155 (GLX) > Minor opcode of failed request: 32 (X_GLXDestroyWindow) > Serial number of failed request: 8900 > Current serial number in output stream: 8901 > Makefile:208: recipe for target 'device.ok' failed > The v2 I sent to the list fixes the test, but I'm fairly sure that the critical section is wrong. I tried to run the d3d11 test to see if it better exercises multithreading, but it skipped all tests ("None of the requested D3D feature levels is supported on this GPU with the current shader backend." even though Mesa 11.2 supports GL 4.1 core profile on my hw). Is it an acceptable solution to not leave the critical section until the XSaveContext line? MM

June 22, 2016

Re: user32/tests: Avoid using CopyRect().

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23786 Your paranoid android. === w864 (64 bit win) === win.c:8733: Test failed: msg.message = 320

June 22, 2016

Re: [PATCH 5/5] wined3d: Send query destruction through the command stream.

by Henri Verbeet

On 22 June 2016 at 10:39, Henri Verbeet <hverbeet(a)codeweavers.com> wrote: > Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> > --- > dlls/wined3d/palette.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > The subject should of course read "wined3d: Send palette destruction through the command stream."

June 22, 2016

Re: include: Add an inline version of CopyRect() too.

by Michael Stefaniuc

On 06/21/2016 05:01 PM, Alexandre Julliard wrote: > Michael Stefaniuc <mstefani(a)redhat.de> writes: > >> Signed-off-by: Michael Stefaniuc <mstefani(a)redhat.de> >> --- >> Around 95 use cases. >> No, I do *not* want to do change RECT struct assignments to CopyRect(). > > Good, but how about changing CopyRect to assignments? ;-) Actually I lied! ;) I wanted to write a script to check for code similar to: if (!r1 || !r2) goto END; *r1 = *r2; and replace it with if (!CopyRect(r1, r2)) goto END; Mainly because it is an interesting coccinelle exercise. Of course I would have tried to make it more palatable by replacing those cases where memcpy() is used instead of the assignment... But the explicit code is not such a big eyesore. So I can instead remove CopyRect() and mark it as verboten when __WINESOURCE__ is defined. bye michael

June 21, 2016