July 2016 - Wine-Devel - list.winehq.org

Re: wine-1.8.4-rc1

by André Hentschel

Am 30.07.2016 um 22:49 schrieb Michael Stefaniuc: > Hello guys, > > I have pushed wine-1.8.4-rc1 (with tag) to > https://github.com/mstefani/wine-stable > https://static-winehq.rhcloud.com/stable/ It builds fine in buildroot, but then thinks it's a 1.8.3 build (./wine --version told me so), despite "Wine version 1.8.4" in the VERSION file

July 31, 2016

Re: [PATCH] Fix some its vs it's typos

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=24626 Your paranoid android. === w864 (32 bit d3d) === d3d.c:2326: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level d3d.c:2510: Test failed: Unexpected destination texture level pixels; 257 differences d3d.c:2657: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level === w1064 (32 bit d3d) === d3d.c:2326: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level d3d.c:2510: Test failed: Unexpected destination texture level pixels; 257 differences d3d.c:2657: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level

July 31, 2016

wine-1.8.4-rc1

by Michael Stefaniuc

Hello guys, I have pushed wine-1.8.4-rc1 (with tag) to https://github.com/mstefani/wine-stable https://static-winehq.rhcloud.com/stable/ Getting nearer to the goal of "around 50" commits for a stable release as this one contains only 66 commits. Nothing fancy though: - Stubs - More GPUs added - One wined3d fix backported (thanks again to Henri) - One original patch aka not cherry-picked, see below. Should somebody look at the release commit he'll notice that 7 of the bugs were already included in wine-1.8.3. That was a mistake as I had deferred those for a later release. So I've modified tools/make_announce to avoid that mistake in the future. For the release I would follow the same process: one week for feedback followed by another rc if needed with the final release 3-4 days later. Lets see how this works out as I'm on vacation travelling and Alexandre will travel too. And last but not least an excerpt from the ANNOUNCE file: What's new in this release (see below for details): - Various bug fixes. - A few more cards added to the GPU description table. ---------------------------------------------------------------- Bugs fixed in 1.8.4 (total 49): 18745 64-bit Mortal Kombat X crashes on unimplemented function KERNEL32.dll.GetLargePageMinimum 20977 Bad hlp table rendering 22819 Some applications like Heroes of Might and Magic 2 display loopback. 25396 Safrosoft RoX freezes at start. 26268 Multiple applications need ntdll.ZwSetLdtEntries stub (kwiksupport.me, Ragnarok Online patcher) 26965 Dragon Age 2 demo - sound in cutscenes is muffled 27680 Multiple 64-bit applications crash on startup (violation of the Windows 64-bit ABI, stack pointer (RSP) must be 16-byte aligned when making a call to Win64 API) 28082 OCCT Perestroïka needs hal.dll.READ_PORT_ULONG 34052 The Witcher: Character models are sometimes invisible 36556 valgrind shows a definite leak in comctl32/tests/syslink.c 36838 TOCA Touring Car Championship: installer copies one file from CD and then shows an error 37063 NTLM EncryptMessage/DecryptMessage failure 37090 Multiple applications crash with built-in amstream (Shogun: Total War, Medieval: Total War) 37271 Applications get IP address of 127.12.34.56 when lo0 is up on OSX 38102 Process Hacker 2.x needs winsta.dll.WinStationEnumerateW 38137 WBaduk: "Could not obtain OLE control window handle" regression 38811 Java JRE 8 installer 'jre-8uXX-windows-i586.exe' crashes on startup (GetThreadPreferredUILanguages is a stub) 38962 expr.c:234 and 235 attempted computation of 1 << 31 should be 1u << 31 39543 Multiple games and applications crash on unimplemented function KERNEL32.dll.FreeUserPhysicalPages (Microsoft Office 2007 diagnosis service, Eden Eternal) 39579 iNode 3.6 client needs ndis.sys.NdisAllocateMemoryWithTag 39842 Skype for windows doesn't work (needs ndis.sys.NdisSystemProcessorCount) 39911 dxd9 PresentationInterval not propagated on device Reset 39933 iNode 3.6 client needs ndis.sys.NdisAllocateSpinLock 40048 Camtasia Studio 8 : crashes on unimplemented function dwmapi.dll.DwmSetPresentParameters 40301 wxDatePickerCtrl (wxWidgets) generates an assert on DTM_GETRANGE message result 40380 Wine should take dosbox's configuration instead of creating a new one 40389 cmd.exe (native): Unimplemented function KERNEL32.dll.GetConsoleAliasExesLengthW 40487 3dmark Vantage Benchmark: unimplemented functions hal.dll.READ and WRITE PORT 40497 "Trainz: A New Era" needs msvcr120.dll.?__ExceptionPtrToBool@@YA_NPEBX(a)Z 40511 Application that copies files from one place to another stoped working in wine versions greater then 1.6.2 40532 Microsoft Word Viewer 11.8 does not show text on file properties dialog until the text is selected 40557 KSP Trajectory Optimization Tool (MATLAB Runtime (MCR)) crashes at launch 40562 AkelPad: [ToolBar plugin] tooltips for toolbar buttons have some extra text 40581 Regression: dsound input recording from microphone lags with 2 seconds delay 40614 Cisco Jabber 11.6 crashes due to missing dbghelp.dll.EnumerateLoadedModulesExW 40618 Autodesk 123D Design needs msvcr100.dll.mbsrtowcs_s 40659 Window with CS_OWNDC style cause DC leak when GetDC/ReleaseDC is used. 40691 DVDFab 9.2.4.4 pre-check FabCheck.exe executable fails, needs setupapi.dll.CM_Get_DevNode_Status 40745 Python 3.5.1 interpreter crashes, needs _set_thread_local_invalid_parameter_handler 40747 Microsoft Expression Web 4 crashes on startup, needs gdiplus.dll.GdipGetImageAttributesAdjustedPalette 40754 GOG Galaxy crashes with unimplemented function api-ms-win-crt-locale-l1-1-0.dll._lock_locales 40755 GOG Galaxy crashes with unimplemented function ucrtbase.dll._lock_locales 40756 GOG Galaxy crashes with unimplemented function api-ms-win-crt-heap-l1-1-0.dll._calloc_base 40770 Nvidia GeForce GT 730 not recognized properly 40796 Python 3.5.1 interpreter crashes when importing pyqtSlot 40830 Conflict between kVK_RightCommand and macOS 10.12 Sierra in carbon framework 40833 Batman: Arkham Origins Blackgate no sound during gameplay (except cutscenes) 40851 macOS 10.12 Build Failure in winspool.drv with cupsGetPPD 40923 Alone in the Dark (2008) crashes on launch with msvcrt assertion ---------------------------------------------------------------- Changes since 1.8.3: Alex Henrie (6): msvcrt: Stub out _(get|set)_thread_local_invalid_parameter_handler. ucrtbase: Implement _(un)lock_locales. ucrtbase: Implement _calloc_base. ucrtbase: Implement _malloc_base. ucrtbase: Implement _free_base. riched20: Don't call UpdateWindow after setting the background color. Alexandre Julliard (1): user32: Completely free owned DCEs when the corresponding window/class is destroyed. Alistair Leslie-Hughes (2): wininet: Free socket when connection is freed. wined3d: Correct memory size for Geforce 9600 GT. Andrew Eikum (3): dsound: Support downmixing 5.1 to stereo. dsound: Capture all available data on each period callback. xaudio2: Always set current OpenAL context before making AL calls. André Hentschel (1): ndis.sys: Implement NdisSystemProcessorCount. Austin English (12): hal: Add READ_PORT_ULONG stub. hal: Add READ_PORT_UCHAR stub. hal: Add WRITE_PORT_ULONG stub. kernel32: Add FreeUserPhysicalPages stub. winsta: Add a stub for WinStationEnumerateW. dwmapi: Add DwmSetPresentParameters stub. kernel32: Add GetConsoleAliasExesLengthA/W stubs. ntdll: Add NtSetLdtEntries/ZwSetLdtEntries stub. dbghelp: Add forwards for EnumerateLoadedModulesEx/EnumerateLoadedModulesExW. kernel32: Implement GetLargePageMinimum. ndis.sys: Add NdisAllocateMemoryWithTag stub. ndis.sys: Add NdisAllocateSpinLock stub. Benjamin Hodgetts (1): wined3d: Add Intel Iris chips to identification list. Bruno Jesus (1): ws2_32: Ensure default route IP addresses are returned first in gethostbyname. Béla Gyebrószki (2): wined3d: Add Nvidia GeForce GTS 250. wined3d: Add Nvidia GeForce GT 730 (GK208). David Woodhouse (1): secur32: Fix handling of ANSI NTLM credentials. Fabian Maurer (1): msacm32: Added converter for ADPCM to PCM 8 bit mono. Grazvydas Ignotas (3): wined3d: Use Intel data returned by Windows driver. wined3d: Add some more Intel GPUs. wined3d: Add a fallback for Skylake. Hans Leidekker (1): kernel32: Improve the stub for GetThreadPreferredUILanguages. Henri Verbeet (1): wined3d: Also update the swap interval when not recreating the context in wined3d_device_reset(). Jarkko Korpi (1): widl: Fix overflow when left-shifting. Jean-Christophe Cardot (6): winhlp32: Replace magic numbers by symbols. winhlp32: Add some trace calls. winhlp32: Add a warning trace. winhlp32: Prepare winhlp32 for more font types. winhlp32: Rework and rename HLPFILE_HalfPointsToTwips. winhlp32: Fix table formatting. Justas Lavišius (1): include: Force stack alignment on x86_64. Ken Thomases (2): winspool.drv: Include <cups/ppd.h> to fix building against the macOS 10.12 SDK. winemac: Don't define kVK_RightCommand when building against the macOS 10.12 SDK. Luis Sahagun (1): winevdm: Tell dosbox to read the current user's config. Matteo Bruni (1): wined3d: Add a setting to check relative addressing indices when accessing uniforms. Michael Müller (1): amstream: Implement IDirectDrawMediaStream::GetMultiMediaStream. Michael Stefaniuc (1): tools: Get the bug list for ANNOUNCE from the stable-notes git notes. Nikolay Sivov (2): comctl32/datetime: Use MCM_GETRANGE result directly in DTM_GETRANGE. comctl32/tooltips: Cut tooltip text at first tab char unless TTS_NOPREFIX is used. Olivier F. R. Dierick (1): shell32: Set last error explicitly in SHFileOperation(). Piotr Caban (6): msvcrt: Add mbsrtowcs_s implementation. msvcp110: Fix num_put<char> structure layout. msvcrt: Fix mbtowc behavior for buffers containing more than one character. ieframe: Restore closed IOleClientSite in DoVerb. msvcr120: Add __ExceptionPtrToBool implementation. msvcrt: Return error when previously parsed type is accessed while demangling simple data type. Rob Walker (1): setupapi: Add stub for setupapi.dll.CM_Get_DevNode_Status. Sebastian Lackner (3): comctl32/syslink: Fix a blocks leak (Valgrind). amstream/tests: Add tests for GetMultiMediaStream methods. server: Fix assignment of primary_group in token_duplicate. Stefan Leichter (3): kernel32: Add stub for GetSystemPreferredUILanguages. kernel32/tests: Add tests for GetSystemPreferredUILanguages. kernel32: Return a dummy value in GetSystemPreferredUILanguages. Vincent Povirk (1): gdiplus: Implement GdipGetImageAttributesAdjustedPalette. bye michael -- Michael Stefaniuc mstefani(a)winehq.org

July 30, 2016

Re: comctl32/tests: Avoid using memset() on RECTs.

by Nikolay Sivov

On 30.07.2016 23:18, Michael Stefaniuc wrote: > On 07/30/2016 09:58 PM, Nikolay Sivov wrote: >> On 30.07.2016 22:55, Michael Stefaniuc wrote: >>> - memset(&r1, 0, sizeof r1); >>> - r1.left = LVIR_ICON; >>> + SetRect(&r1, LVIR_ICON, 0, 0, 0); >> >> I don't like this, I think it's better to use SetRect() when actual >> coordinates are used, and LVIR_* has special meaning. > Uhm? I have added 36 of those with commit 87bc2aa6 and you signed of on > that. > Ok, no reason to stop now then. > For me those are still RECTs even though MS uses them for other stuff. > > bye > michael > >

July 30, 2016

Re: comctl32/tests: Avoid using memset() on RECTs.

by Michael Stefaniuc

On 07/30/2016 09:58 PM, Nikolay Sivov wrote: > On 30.07.2016 22:55, Michael Stefaniuc wrote: >> - memset(&r1, 0, sizeof r1); >> - r1.left = LVIR_ICON; >> + SetRect(&r1, LVIR_ICON, 0, 0, 0); > > I don't like this, I think it's better to use SetRect() when actual > coordinates are used, and LVIR_* has special meaning. Uhm? I have added 36 of those with commit 87bc2aa6 and you signed of on that. For me those are still RECTs even though MS uses them for other stuff. bye michael

July 30, 2016

Re: comctl32/tests: Avoid using memset() on RECTs.

by Nikolay Sivov

On 30.07.2016 22:55, Michael Stefaniuc wrote: > - memset(&r1, 0, sizeof r1); > - r1.left = LVIR_ICON; > + SetRect(&r1, LVIR_ICON, 0, 0, 0); I don't like this, I think it's better to use SetRect() when actual coordinates are used, and LVIR_* has special meaning.

July 30, 2016

Re: Enabling/Disabling Joysticks from registry for the Mac

by Ken Thomases

Hi, On Jul 30, 2016, at 2:15 AM, DavidL <david.dljunk(a)gmail.com> wrote: > > I was looking into how the Linux-dinput code and joy.cpl work and comparing that to the macOS-dinput code. I have some questions about how best to proceed: > > joy.cpl uses joy->instance.tszInstanceName to name the joysticks in the control panel. In Linux-dinput code, they pass the joystick_devices[id].name to both tszInstanceName and tszProductName In the macOS-dinput code, they pass the name "Joystick #" where # is the index in the joystick array to the instance name and the joystick's actual name to the product name. When looking at the Microsoft guidelines for dinput, it does indeed say that the instance name *can* be joystick + position in the array, but doesn't specify that it *has* to be (https://msdn.microsoft.com/en-us/library/windows/desktop/microsoft.directx_…) Also, I've confirmed that in the Windows 10 joystick control panel the joysticks are listed by their name, not by joystick number (and in my memory of earlier Windows OSes it's the same). > > So, should I change the macOS-dinput code to set both tszInstanceName and tszProductName to the product name (as in Linux) or should I change joy.cpl to use tszProductName instead of tszInstanceName? This will also make it easier in the registry to know which joystick is being enabled/disabled. We need to distinguish between an object's internal identifier and what's displayed in UI. It seems to me that joy.cpl and dinput ought to use the guidInstance field to determine which devices are enabled or disabled. That would require that the backends actually provide a guidInstance that's unique among devices but stable across runs and attachment/detachment of devices. Unfortunately, I'm not sure how practical that is. Some devices seem to provide kIOHIDSerialNumberKey, but not all do. kIOHIDLocationIDKey is stable so long as the USB topology doesn't change, but it can change, of course. An experiment shows that the location ID changes if you just plug the device into a different point in the topology (a USB port on the computer vs. one on the keyboard, which is a hub). Also, if you change how this works, everybody's existing registry settings will break. So, perhaps a decent compromise would be for joy.cpl to display both the instance and the product name (e.g. "Joystick 1 - Logitech Extreme 3D Pro") but record the instance name in the registry. On Linux, I guess that may make the name looked doubled, if the instance and product names are the same. On the Mac, we should probably change the instance name to something that's really associated with the device. The index in the device array is not stable. If you disconnect the first joystick, all other joysticks will get renumbered in that scheme. Probably, the location ID is the closest we have to a stable ID (which is why you've used it for sorting). It's just too bad that it's an ugly number, whether formatted decimal or hexadecimal. Another approach would be for the Mac code to basically build a dynamic database of every game controller it ever encounters, storing all of the available stable identifying information about each, and assigning a permanent identifier. So, location ID would not be used because it's not truly stable, but vendor ID, product ID, manufacturer, product name, serial number, version number, usage pairs, and maybe even the report descriptor could be. As it enumerates devices, it would look through the database to find one that matches all of the these available pieces of metadata. If it does, it will reuse the previously-generated identifier. Otherwise, it will generate a new identifier and add the device to the database. There would have to be a check, in case there are two exactly identical devices attached, to not use the same identifier for both. In practice, the database should never grow very large since one system should never have very many devices connected to it over its history. > Further, while joy.cpl correctly is a dinput control panel, enabling/disabling joystick should be for both dinput and winmm games - e.g. X-wing vs Tie Fighter even has the joystick control panel in the game's loader window*, but, once in the game, joystick control is handled by winmm. I believe the joystick registry entry is under dinput, but the winmm wine joystick driver should read that as well. > > Is it acceptable for wine joystick driver to read the dinput registry? Or should two registry entries be created? or should a single general joystick registry entry not under dinput or winmm control both? Well, the registry key is actually Wine-specific. It's got "DirectInput" in the path, but we can play a little fast and lose with it. No Windows app is sensitive to what's under that key, for example. I see no problem with having winmm check it. There's work underway to implement proper HID support and then reimplement lots of different APIs (dinput, winmm joystick, xinput, raw input) on top of that. When that happens, a lot of this will probably have to change and redundancy will hopefully be eliminated. (If it's going to break people's settings, it may be a good time to switch to using guidInstance or the equivalent, too.) -Ken

July 30, 2016

Enabling/Disabling Joysticks from registry for the Mac

by DavidL

Hi Ken, I was looking into how the Linux-dinput code and joy.cpl work and comparing that to the macOS-dinput code. I have some questions about how best to proceed: joy.cpl uses joy->instance.tszInstanceName to name the joysticks in the control panel. In Linux-dinput code, they pass the joystick_devices[id].name to both tszInstanceName and tszProductName In the macOS-dinput code, they pass the name "Joystick #" where # is the index in the joystick array to the instance name and the joystick's actual name to the product name. When looking at the Microsoft guidelines for dinput, it does indeed say that the instance name *can* be joystick + position in the array, but doesn't specify that it *has* to be ( https://msdn.microsoft.com/en-us/library/windows/desktop/microsoft.directx_…) Also, I've confirmed that in the Windows 10 joystick control panel the joysticks are listed by their name, not by joystick number (and in my memory of earlier Windows OSes it's the same). So, should I change the macOS-dinput code to set both tszInstanceName and tszProductName to the product name (as in Linux) or should I change joy.cpl to use tszProductName instead of tszInstanceName? This will also make it easier in the registry to know which joystick is being enabled/disabled. Further, while joy.cpl correctly is a dinput control panel, enabling/disabling joystick should be for both dinput and winmm games - e.g. X-wing vs Tie Fighter even has the joystick control panel in the game's loader window*, but, once in the game, joystick control is handled by winmm. I believe the joystick registry entry is under dinput, but the winmm wine joystick driver should read that as well. Is it acceptable for wine joystick driver to read the dinput registry? Or should two registry entries be created? or should a single general joystick registry entry not under dinput or winmm control both? I may have more questions, but we'll start off with these. :) Cheers, David *Interestingly, the game's sequel X-wing: Alliance says I need to install DirectX to access joystick options in the loader window. I'm not sure why the older title brings up the joystick control panel just fine, but the later one does not.

July 30, 2016

Re: [PATCH 1/4] mpr: Implement local name automatic redirection for disks.

by Pierre Schweitzer

Is there anything left to fix? Le 28/07/2016 à 10:44, Pierre Schweitzer a écrit : > I also modified 2nd patch of the patch, because it was suffering the > same issue and wasn't applying any longer. > Both have been resent. > > Le 28/07/2016 à 10:12, Alexandre Julliard a écrit : >> Pierre Schweitzer <pierre(a)reactos.org> writes: >> >>> Hi, >>> >>> I wanted to avoid yet another recopy (in the ANSI case) especially since >>> input is well-known: user necessarily provided NULL ptr to reach that point. >>> But, if you prefer, I can do another copy. But in the ANSI case, it will >>> mean that NETRESOURCE structure has been copied twice (rather expensive). >> >> It's not expensive, it's a small structure, and you don't need to >> duplicate the pointers. >> > > > > > -- Pierre Schweitzer <pierre at reactos.org> System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V.

July 29, 2016

Re: [PATCH 08/10] gdi32: Where possible directly access the DC instead of using GetCurrentObject().

by Alexandre Julliard

Huw Davies <huw(a)codeweavers.com> writes: > On Fri, Jul 29, 2016 at 09:22:43PM +0900, Alexandre Julliard wrote: >> Huw Davies <huw(a)codeweavers.com> writes: >> >> > @@ -1039,7 +1039,7 @@ INT WINAPI SetGraphicsMode( HDC hdc, INT mode ) >> > } >> > release_dc_ptr( dc ); >> > /* font metrics depend on the graphics mode */ >> > - if (ret) SelectObject(dc->hSelf, GetCurrentObject(dc->hSelf, OBJ_FONT)); >> > + if (ret) SelectObject(dc->hSelf, dc->hFont); >> >> The bug was already present, but we shouldn't be accessing the dc after >> release. > > Good catch (although it was originally your bug ;-) ) Then it can't be a bug. There are no bugs in my code. -- Alexandre Julliard julliard(a)winehq.org

July 29, 2016

Re: [PATCH 08/10] gdi32: Where possible directly access the DC instead of using GetCurrentObject().

by Huw Davies

On Fri, Jul 29, 2016 at 09:22:43PM +0900, Alexandre Julliard wrote: > Huw Davies <huw(a)codeweavers.com> writes: > > > @@ -1039,7 +1039,7 @@ INT WINAPI SetGraphicsMode( HDC hdc, INT mode ) > > } > > release_dc_ptr( dc ); > > /* font metrics depend on the graphics mode */ > > - if (ret) SelectObject(dc->hSelf, GetCurrentObject(dc->hSelf, OBJ_FONT)); > > + if (ret) SelectObject(dc->hSelf, dc->hFont); > > The bug was already present, but we shouldn't be accessing the dc after > release. Good catch (although it was originally your bug ;-) ) I've resent the entire series with an additional patch [8/11] which fixes this. It also only reselects the font if the mode changes. The other patches in the series are essentially the same as v1. Huw.

July 29, 2016

Re: comctl32: Avoid using memset on RECTs.

by Michael Stefaniuc

On 07/29/2016 01:14 PM, Nikolay Sivov wrote: > On 29.07.2016 13:24, Michael Stefaniuc wrote: >> Signed-off-by: Michael Stefaniuc <mstefani(a)redhat.de> >> --- >> dlls/comctl32/status.c | 4 ++-- >> dlls/comctl32/tab.c | 7 ++----- >> 2 files changed, 4 insertions(+), 7 deletions(-) >> >> diff --git a/dlls/comctl32/status.c b/dlls/comctl32/status.c >> index 738c33b..08ca158 100644 >> --- a/dlls/comctl32/status.c >> +++ b/dlls/comctl32/status.c >> @@ -127,8 +127,8 @@ STATUSBAR_ComputeHeight(STATUS_INFO *infoPtr) >> * textHeight pixels large */ >> HDC hdc = GetDC(infoPtr->Self); >> RECT r; >> - memset (&r, 0, sizeof (r)); >> - r.bottom = max(infoPtr->minHeight, tm.tmHeight); >> + >> + SetRect(&r, 0, 0, 0, max(infoPtr->minHeight, tm.tmHeight)); >> if (SUCCEEDED(GetThemeBackgroundExtent(theme, hdc, SP_PANE, 0, &r, &r))) >> { >> height = r.bottom - r.top; >> diff --git a/dlls/comctl32/tab.c b/dlls/comctl32/tab.c >> index 0ed9152..62e34f9 100644 >> --- a/dlls/comctl32/tab.c >> +++ b/dlls/comctl32/tab.c >> @@ -373,12 +373,9 @@ static BOOL TAB_InternalGetItemRect( >> TRACE("Not Visible\n"); >> /* need to initialize these to empty rects */ >> if (itemRect) >> - { >> - memset(itemRect,0,sizeof(RECT)); >> - itemRect->bottom = infoPtr->tabHeight; >> - } >> + SetRect(itemRect, 0, 0, 0, infoPtr->tabHeight); >> if (selectedRect) >> - memset(selectedRect,0,sizeof(RECT)); >> + SetRectEmpty(selectedRect); >> return FALSE; >> } >> >> > > You probably can remove null rect checks as well. Probably? That isn't obvious from the context. Those two are input parameters to TAB_InternalGetItemRect() that aren't checked beforehand. bye micheal

July 29, 2016

Re: [PATCH 08/10] gdi32: Where possible directly access the DC instead of using GetCurrentObject().

by Alexandre Julliard

Huw Davies <huw(a)codeweavers.com> writes: > @@ -1039,7 +1039,7 @@ INT WINAPI SetGraphicsMode( HDC hdc, INT mode ) > } > release_dc_ptr( dc ); > /* font metrics depend on the graphics mode */ > - if (ret) SelectObject(dc->hSelf, GetCurrentObject(dc->hSelf, OBJ_FONT)); > + if (ret) SelectObject(dc->hSelf, dc->hFont); The bug was already present, but we shouldn't be accessing the dc after release. -- Alexandre Julliard julliard(a)winehq.org

July 29, 2016

Re: comctl32: Avoid using memset on RECTs.

by Nikolay Sivov

On 29.07.2016 13:24, Michael Stefaniuc wrote: > Signed-off-by: Michael Stefaniuc <mstefani(a)redhat.de> > --- > dlls/comctl32/status.c | 4 ++-- > dlls/comctl32/tab.c | 7 ++----- > 2 files changed, 4 insertions(+), 7 deletions(-) > > diff --git a/dlls/comctl32/status.c b/dlls/comctl32/status.c > index 738c33b..08ca158 100644 > --- a/dlls/comctl32/status.c > +++ b/dlls/comctl32/status.c > @@ -127,8 +127,8 @@ STATUSBAR_ComputeHeight(STATUS_INFO *infoPtr) > * textHeight pixels large */ > HDC hdc = GetDC(infoPtr->Self); > RECT r; > - memset (&r, 0, sizeof (r)); > - r.bottom = max(infoPtr->minHeight, tm.tmHeight); > + > + SetRect(&r, 0, 0, 0, max(infoPtr->minHeight, tm.tmHeight)); > if (SUCCEEDED(GetThemeBackgroundExtent(theme, hdc, SP_PANE, 0, &r, &r))) > { > height = r.bottom - r.top; > diff --git a/dlls/comctl32/tab.c b/dlls/comctl32/tab.c > index 0ed9152..62e34f9 100644 > --- a/dlls/comctl32/tab.c > +++ b/dlls/comctl32/tab.c > @@ -373,12 +373,9 @@ static BOOL TAB_InternalGetItemRect( > TRACE("Not Visible\n"); > /* need to initialize these to empty rects */ > if (itemRect) > - { > - memset(itemRect,0,sizeof(RECT)); > - itemRect->bottom = infoPtr->tabHeight; > - } > + SetRect(itemRect, 0, 0, 0, infoPtr->tabHeight); > if (selectedRect) > - memset(selectedRect,0,sizeof(RECT)); > + SetRectEmpty(selectedRect); > return FALSE; > } > > You probably can remove null rect checks as well.

July 29, 2016

Re: [PATCH] msxml3: Implement IXMLParser GetParserState

by Alistair Leslie-Hughes

On 29/07/16 20:36, Nikolay Sivov wrote: > On 29.07.2016 12:43, Alistair Leslie-Hughes wrote: > > Do you have SDK headers for that interface? Having HRESULT for a state > looks a bit weird. > > No, but all the Document on msdn state that it returns HRESULT. I had to double check myself. https://msdn.microsoft.com/en-us/library/ms757816%28v=vs.85%29.aspx Best Regards Alistair Leslie-Hughes

July 29, 2016

Re: [PATCH] msxml3: Implement IXMLParser GetParserState

by Nikolay Sivov

On 29.07.2016 12:43, Alistair Leslie-Hughes wrote: > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > dlls/msxml3/tests/xmlparser.c | 3 +++ > dlls/msxml3/xmlparser.c | 6 ++++-- > 2 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/dlls/msxml3/tests/xmlparser.c b/dlls/msxml3/tests/xmlparser.c > index 51f2a27..32514e3 100644 > --- a/dlls/msxml3/tests/xmlparser.c > +++ b/dlls/msxml3/tests/xmlparser.c > @@ -144,6 +144,9 @@ static void create_test(void) > hr = IXMLParser_SetFlags(parser, 0); > ok(hr == S_OK, "Expected S_OK got 0x%08x\n", hr); > > + hr = IXMLParser_GetParserState(parser); > + ok(hr == XMLPARSER_IDLE, "got 0x%08x\n", hr); > + > IXMLParser_Release(parser); > } > > diff --git a/dlls/msxml3/xmlparser.c b/dlls/msxml3/xmlparser.c > index ca40b22..6fcdb82 100644 > --- a/dlls/msxml3/xmlparser.c > +++ b/dlls/msxml3/xmlparser.c > @@ -51,6 +51,7 @@ typedef struct _xmlparser > LONG ref; > > int flags; > + XML_PARSER_STATE state; > } xmlparser; > > static inline xmlparser *impl_from_IXMLParser( IXMLParser *iface ) > @@ -345,9 +346,9 @@ static HRESULT WINAPI xmlparser_GetParserState(IXMLParser *iface) > { > xmlparser *This = impl_from_IXMLParser( iface ); > > - FIXME("(%p)\n", This); > + TRACE("(%p)\n", This); > > - return E_NOTIMPL; > + return This->state; > } > > static HRESULT WINAPI xmlparser_Suspend(IXMLParser *iface) > @@ -447,6 +448,7 @@ HRESULT XMLParser_create(void **ppObj) > This->nodefactory = NULL; > This->input = NULL; > This->flags = 0; > + This->state = XMLPARSER_IDLE; > This->ref = 1; > > *ppObj = &This->IXMLParser_iface; > Do you have SDK headers for that interface? Having HRESULT for a state looks a bit weird.

July 29, 2016

Re: [PATCH 2/6] d3d9/tests: Add visual tests for locking vertexbuffers

by Henri Verbeet

On 28 July 2016 at 18:41, Patrick Rudolph <siro(a)das-labor.org> wrote: > Am Thu, 28 Jul 2016 14:04:56 +0200 > schrieb Henri Verbeet <hverbeet(a)gmail.com>: >> I assume the broken() is for the testbot, but the way this is written, >> half the cases aren't really tested on Windows. Also, what makes these >> fail on the testbot? >> > I can replace some of the broken test results with another flag for AMD > behaviour. AMD allows D3DLOCK_NOOVERWRITE for non dynamic buffers on > d3d9, too. > I guess the WARP driver filters D3DLOCK_NOOVERWRITE | D3DLOCK_DISCARD > calls. You can make the check more specific by using adapter_is_warp(). Wrt. D3DLOCK_NOOVERWRITE on non-dynamic buffers, if the behaviour is not consistent between AMD and NVIDIA, it's probably best to drop those tests while keeping the comment. >> Does this work reliably? GetTickCount() has very limited resolution, I >> think there's a real chance that the draw will take only a fraction of >> GetTickCount()'s resolution. > > Yes it does. > I first thought about using timestamp queries, but those aren't > supported on ddraw and d3d8 and are broken on my AMD test system, so > I'm using GetTickCount instead. It allows to test to pass on fast > systems (Intel Core i5 + HD6870) and slow systems (Intel Atom + Nvidia > ION). The buffersize can't be hardcoded as the Windows driver nukes the > display driver whenever a draw call takes more than a few seconds, > which is the case when using huge buffers to make them pass on fast > systems. > Measuring CPU time is fine, but I'd feel a little better if this used QueryPerformanceCounter() instead of GetTickCount().

July 29, 2016

Re: wined3d: Add Nvidia GT 740M to the GPU list

by Henri Verbeet

On 28 July 2016 at 22:42, Jeremy Audiger <audiger(a)live.fr> wrote: > @@ -2158,6 +2160,7 @@ cards_nvidia_mesa[] = > {"NVF0", CARD_NVIDIA_GEFORCE_GTX780}, > {"NVE6", CARD_NVIDIA_GEFORCE_GTX770M}, > {"NVE4", CARD_NVIDIA_GEFORCE_GTX680}, > + {"NV108", CARD_NVIDIA_GEFORCE_GT740M}, > /* Fermi */ > {"NVD9", CARD_NVIDIA_GEFORCE_GT520}, > {"NVD7", CARD_NVIDIA_GEFORCE_820M}, The patch seems fine, but could you please add "NV108" above "NVF1" instead of below "NVE4"?

July 29, 2016

Re: [PATCH 2/2] DInput : Use vendor and product ids to generate product GUID like it's done on Windows

by DavidL

Thanks! In that case, I will add it to my list of needed patches for the OS X dinput joysticks ... unless one of you gents would like to take a crack at it? :) Cheers, David On Thu, Jul 28, 2016 at 8:44 AM, Bruno Jesus <00cpxxx(a)gmail.com> wrote: > On Thu, Jul 28, 2016 at 6:08 AM, DavidL <david.dljunk(a)gmail.com> wrote: > > I'm not really familiar with the intricacies of the guid generation ... > but > > looking at the Mac dinput code ... should a similar patch be applied > there? > > Hi, IMO yes in order to sync the output of all drivers to be the same > independent of host OS. You can test using the ditool.exe from: > https://sourceforge.net/projects/x360ce/files/ditool.zip > > Best wishes, > Bruno >

July 28, 2016

Re: [PATCH 1/6] wined3d/resource: Add flag WINED3D_MAP_WRITEONLY

by Patrick Rudolph

Am Thu, 28 Jul 2016 14:04:48 +0200 schrieb Henri Verbeet <hverbeet(a)gmail.com>: > On 26 July 2016 at 19:09, Patrick Rudolph <siro(a)das-labor.org> wrote: > > #define WINED3D_MAP_READONLY > > 0x0010 +#define > > WINED3D_MAP_WRITEONLY 0x0020 > But now the API is weird. What happens when both READONLY and > WRITEONLY are set? I think the d3d11 model makes more sense. Yes you are right. The patch is required to fix some of the d3d11 TODOs introduced in my tests, but you can ignore it for now. I'll add additional tests for it.

July 28, 2016

Re: [PATCH 2/6] d3d9/tests: Add visual tests for locking vertexbuffers

by Patrick Rudolph

Am Thu, 28 Jul 2016 14:04:56 +0200 schrieb Henri Verbeet <hverbeet(a)gmail.com>: > On 26 July 2016 at 19:09, Patrick Rudolph <siro(a)das-labor.org> wrote: > > + static const struct > > + { > > + const char *flags_s; > > + unsigned int flags; > > + DWORD usage; > > + BOOL unsyncronized; > > + BOOL todo; > > + BOOL broken; > > + } > > + /* Nvidia ignores D3DLOCK_NOOVERWRITE on non dynamic buffers, > > + * while AMD always accepts D3DLOCK_NOOVERWRITE on all > > buffers. */ > > + tests[] = > > + { > > + {"0", 0, 0, FALSE, FALSE, FALSE}, > > + {"0", 0, D3DUSAGE_DYNAMIC, FALSE, FALSE, FALSE}, > > + {"D3DLOCK_NOOVERWRITE", D3DLOCK_NOOVERWRITE, 0, FALSE, > > FALSE, TRUE}, > > + {"D3DLOCK_NOOVERWRITE", D3DLOCK_NOOVERWRITE, > > D3DUSAGE_DYNAMIC, TRUE, FALSE, FALSE}, > > + {"D3DLOCK_DISCARD", D3DLOCK_DISCARD, 0, FALSE, FALSE, > > FALSE}, > > + {"D3DLOCK_DISCARD", D3DLOCK_DISCARD, D3DUSAGE_DYNAMIC, > > FALSE, FALSE, FALSE}, > > + {"D3DLOCK_NOOVERWRITE | D3DLOCK_DISCARD", > > + D3DLOCK_NOOVERWRITE | D3DLOCK_DISCARD, 0, FALSE, > > FALSE, TRUE}, > > + {"D3DLOCK_NOOVERWRITE | D3DLOCK_DISCARD", > > + D3DLOCK_NOOVERWRITE | D3DLOCK_DISCARD, > > D3DUSAGE_DYNAMIC, TRUE, TRUE, TRUE}, > > + {"D3DLOCK_NOOVERWRITE | D3DLOCK_READONLY", > > + D3DLOCK_NOOVERWRITE | D3DLOCK_READONLY, 0, FALSE, > > FALSE, TRUE}, > > + {"D3DLOCK_NOOVERWRITE | D3DLOCK_READONLY", > > + D3DLOCK_NOOVERWRITE | D3DLOCK_READONLY, > > D3DUSAGE_DYNAMIC, TRUE, TRUE, TRUE}, > > + }; > [...] > > + todo_wine_if (tests[i].todo) > > + { > > + ok(tests[i].unsyncronized == unsyncronized || > > broken(tests[i].broken), > > + "Expected buffer mapped %s. Flags = %s. Usage > > = %#x.\n", > > + tests[i].unsyncronized ? "unsyncronized" : > > "syncronized", tests[i].flags_s, tests[i].usage); > > + } > I assume the broken() is for the testbot, but the way this is written, > half the cases aren't really tested on Windows. Also, what makes these > fail on the testbot? > I can replace some of the broken test results with another flag for AMD behaviour. AMD allows D3DLOCK_NOOVERWRITE for non dynamic buffers on d3d9, too. I guess the WARP driver filters D3DLOCK_NOOVERWRITE | D3DLOCK_DISCARD calls. > > + timestamp1 = GetTickCount(); > > + > > + hr = IDirect3DDevice9_BeginScene(device); > > + ok(SUCCEEDED(hr), "Failed to begin scene, hr %#x.\n", hr); > > + hr = IDirect3DDevice9_DrawPrimitive(device, > > D3DPT_TRIANGLESTRIP, 0, tri); > > + ok(SUCCEEDED(hr), "Failed to draw, hr %#x.\n", hr); > > + hr = IDirect3DDevice9_EndScene(device); > > + ok(SUCCEEDED(hr), "Failed to end scene, hr %#x.\n", hr); > > + > > + /* dummy read to wait for GPU being done */ > > + color = getPixelColor(device, 160, 360); > > + > > + timestamp2 = GetTickCount(); > > + > > + /* Adjust buffer size for 1 second draw call duration */ > > + size = (size * 1000UL) / (timestamp2 - timestamp1 + 1); > Does this work reliably? GetTickCount() has very limited resolution, I > think there's a real chance that the draw will take only a fraction of > GetTickCount()'s resolution. Yes it does. I first thought about using timestamp queries, but those aren't supported on ddraw and d3d8 and are broken on my AMD test system, so I'm using GetTickCount instead. It allows to test to pass on fast systems (Intel Core i5 + HD6870) and slow systems (Intel Atom + Nvidia ION). The buffersize can't be hardcoded as the Windows driver nukes the display driver whenever a draw call takes more than a few seconds, which is the case when using huge buffers to make them pass on fast systems. Regards, Patrick

July 28, 2016

Re: wine-devel Digest, Vol 132, Issue 55

by Anton Baskanov

On Wed, Jul 27, 2016 at 11:07 PM, <wine-devel-request(a)winehq.org> wrote: > ---------- Forwarded message ---------- > From: Nikolay Sivov <bunglehead(a)gmail.com> > To: wine-devel(a)winehq.org > Cc: > Date: Wed, 27 Jul 2016 17:39:26 +0300 > Subject: Re: [PATCH 1/6] amstream: Fix AMAudioData::QueryInterface. > On 27.07.2016 15:51, Anton Baskanov wrote: > > Signed-off-by: Anton Baskanov <baskanov(a)gmail.com> > > --- > > dlls/amstream/audiodata.c | 1 - > > dlls/amstream/tests/Makefile.in | 3 +- > > dlls/amstream/tests/audiodata.c | 67 > +++++++++++++++++++++++++++++++++++++++++ > > 3 files changed, 69 insertions(+), 2 deletions(-) > > create mode 100755 dlls/amstream/tests/audiodata.c > > Hi, Anton. > > Please keep tests in existing amstream.c file. > > + > > +static void test_query_interface(void) > > +{ > > + IUnknown *unknown = create_audio_data(); > > + IMemoryData *memory_data = NULL; > > + IAudioData *audio_data = NULL; > > + > > + HRESULT result = S_OK; > > result initialization is not needed; > > > + > > + result = IUnknown_QueryInterface(unknown, &IID_IMemoryData, (void > **)&memory_data); > > + ok(E_NOINTERFACE == result, "got 0x%08x\n", result); > > + if (S_OK == result) > > + { > > + IMemoryData_Release(memory_data); > > + } > > If it always fails, there's no reason add conditional Release. > > > + > > + result = IUnknown_QueryInterface(unknown, &IID_IAudioData, (void > **)&audio_data); > > + ok(S_OK == result, "got 0x%08x\n", result); > > + if (S_OK == result) > > + { > > + IAudioData_Release(audio_data); > > + } > > + > > + IUnknown_Release(unknown); > > +} > > Could you check if you can query IMemoryData from IAudioData? It seems > really weird if parent interface is not supported at all. > Hi, Nikolay. Thanks for the review! I've checked QueryInterface from IAudioData, and it also fails with IID_IMemoryData. I've fixed the issues and sent the updated patches.

July 28, 2016

Re: [PATCH 2/2] DInput : Use vendor and product ids to generate product GUID like it's done on Windows

by Bruno Jesus

On Thu, Jul 28, 2016 at 6:08 AM, DavidL <david.dljunk(a)gmail.com> wrote: > I'm not really familiar with the intricacies of the guid generation ... but > looking at the Mac dinput code ... should a similar patch be applied there? Hi, IMO yes in order to sync the output of all drivers to be the same independent of host OS. You can test using the ditool.exe from: https://sourceforge.net/projects/x360ce/files/ditool.zip Best wishes, Bruno

July 28, 2016

Re: [PATCH 2/2 v4] ucrtbase: Add _get_narrow_winmain_command_line tests

by Dmitry Timoshkov

Piotr Caban <piotr(a)codeweavers.com> wrote: > >>>>>>>>>> + sprintf(cmd, "\"\"%c\"\"\"%s\" \t \"misc\" cmd", name[0], name+1); > >>>>>>>>>> + memset(&startup, 0, sizeof(startup)); > >>>>>>>>>> + startup.cb = sizeof(startup); > >>>>>>>>>> + CreateProcessA(path, cmd, NULL, NULL, TRUE, > >>>>>>>>>> + CREATE_DEFAULT_ERROR_MODE|NORMAL_PRIORITY_CLASS, > >>>>>>>>>> + NULL, NULL, &startup, &proc); > >>>>>>>>>> + winetest_wait_child_process(proc.hProcess); > >>>>>>>>> > >>>>>>>>> Thanks for adding the tests. It shouldn't be too hard to also test other > >>>>>>>>> white space characters, at least testing '\r' and '\n' would be nice to > >>>>>>>>> have. > >>>>>>>>> > >>>>>>>> CreateProcess will fail in case of '\r' or '\n' characters. > >>>>>>> > >>>>>>> In a simple test CreateProcess() works just fine here under Windows 7 when a > >>>>>>> passed in command line contains '\r' and/or '\n', where does it fail for you? > >>>>>>> > >>>>>> I'll try to be a little more precise - '\r' is treated as another > >>>>>> argument so it can't be used before first argument (misc in this case). > >>>>> > >>>>> Then it clearly deserves an additional test case. And a test for '\n' since > >>>>> it doesn't break anything. > >>>> '\n' behaves the same as '\r' according to my test. > >>>> > >>>> I think I have already explained you while '\r' case can't be tested in > >>>> reasonable way. > >>> > >>> I don't see why '\r' and '\n' can't be tested. If CreateProcess() call doesn't > >>> fail, what you need to test is the resulting command line that the child process > >>> receives. It's clear and simple. > >>> > >> I've already wrote you that '\r' is treated as argument - because of > >> that it can't be added before "misc" argument (the test executable needs > >> first argument to be "misc"). The function > >> _get_narrow_winmain_command_line only interprets part of the command > >> line before first argument. > > > > How about adding '\r' after "misc" or at whatever place you think appropriate > > and simply test both the resulting command line and the result of narrow one? > > Just execute the process and test whatever it gets as the command line and > > the narrow one? What is so hard with that? > > > Such test will be useless. It's already shown that > _get_narrow_winmain_command_line returns substring of GetCommandLineA. > It also doesn't touch anything past the beginning of first argument. There is no such a thing as a useless test IMHO, any test exercises the API and shows its result preventing possible regressions in future. -- Dmitry.

July 28, 2016

Re: [PATCH 2/2 v4] ucrtbase: Add _get_narrow_winmain_command_line tests

by Piotr Caban

On 07/28/16 17:25, Dmitry Timoshkov wrote: > Piotr Caban <piotr(a)codeweavers.com> wrote: > >>>>>>>>>> + sprintf(cmd, "\"\"%c\"\"\"%s\" \t \"misc\" cmd", name[0], name+1); >>>>>>>>>> + memset(&startup, 0, sizeof(startup)); >>>>>>>>>> + startup.cb = sizeof(startup); >>>>>>>>>> + CreateProcessA(path, cmd, NULL, NULL, TRUE, >>>>>>>>>> + CREATE_DEFAULT_ERROR_MODE|NORMAL_PRIORITY_CLASS, >>>>>>>>>> + NULL, NULL, &startup, &proc); >>>>>>>>>> + winetest_wait_child_process(proc.hProcess); >>>>>>>>> >>>>>>>>> Thanks for adding the tests. It shouldn't be too hard to also test other >>>>>>>>> white space characters, at least testing '\r' and '\n' would be nice to >>>>>>>>> have. >>>>>>>>> >>>>>>>> CreateProcess will fail in case of '\r' or '\n' characters. >>>>>>> >>>>>>> In a simple test CreateProcess() works just fine here under Windows 7 when a >>>>>>> passed in command line contains '\r' and/or '\n', where does it fail for you? >>>>>>> >>>>>> I'll try to be a little more precise - '\r' is treated as another >>>>>> argument so it can't be used before first argument (misc in this case). >>>>> >>>>> Then it clearly deserves an additional test case. And a test for '\n' since >>>>> it doesn't break anything. >>>> '\n' behaves the same as '\r' according to my test. >>>> >>>> I think I have already explained you while '\r' case can't be tested in >>>> reasonable way. >>> >>> I don't see why '\r' and '\n' can't be tested. If CreateProcess() call doesn't >>> fail, what you need to test is the resulting command line that the child process >>> receives. It's clear and simple. >>> >> I've already wrote you that '\r' is treated as argument - because of >> that it can't be added before "misc" argument (the test executable needs >> first argument to be "misc"). The function >> _get_narrow_winmain_command_line only interprets part of the command >> line before first argument. > > How about adding '\r' after "misc" or at whatever place you think appropriate > and simply test both the resulting command line and the result of narrow one? > Just execute the process and test whatever it gets as the command line and > the narrow one? What is so hard with that? > Such test will be useless. It's already shown that _get_narrow_winmain_command_line returns substring of GetCommandLineA. It also doesn't touch anything past the beginning of first argument.

July 28, 2016

Re: [PATCH 2/2 v4] ucrtbase: Add _get_narrow_winmain_command_line tests

by Dmitry Timoshkov

Piotr Caban <piotr(a)codeweavers.com> wrote: > >>>>>>>> + sprintf(cmd, "\"\"%c\"\"\"%s\" \t \"misc\" cmd", name[0], name+1); > >>>>>>>> + memset(&startup, 0, sizeof(startup)); > >>>>>>>> + startup.cb = sizeof(startup); > >>>>>>>> + CreateProcessA(path, cmd, NULL, NULL, TRUE, > >>>>>>>> + CREATE_DEFAULT_ERROR_MODE|NORMAL_PRIORITY_CLASS, > >>>>>>>> + NULL, NULL, &startup, &proc); > >>>>>>>> + winetest_wait_child_process(proc.hProcess); > >>>>>>> > >>>>>>> Thanks for adding the tests. It shouldn't be too hard to also test other > >>>>>>> white space characters, at least testing '\r' and '\n' would be nice to > >>>>>>> have. > >>>>>>> > >>>>>> CreateProcess will fail in case of '\r' or '\n' characters. > >>>>> > >>>>> In a simple test CreateProcess() works just fine here under Windows 7 when a > >>>>> passed in command line contains '\r' and/or '\n', where does it fail for you? > >>>>> > >>>> I'll try to be a little more precise - '\r' is treated as another > >>>> argument so it can't be used before first argument (misc in this case). > >>> > >>> Then it clearly deserves an additional test case. And a test for '\n' since > >>> it doesn't break anything. > >> '\n' behaves the same as '\r' according to my test. > >> > >> I think I have already explained you while '\r' case can't be tested in > >> reasonable way. > > > > I don't see why '\r' and '\n' can't be tested. If CreateProcess() call doesn't > > fail, what you need to test is the resulting command line that the child process > > receives. It's clear and simple. > > > I've already wrote you that '\r' is treated as argument - because of > that it can't be added before "misc" argument (the test executable needs > first argument to be "misc"). The function > _get_narrow_winmain_command_line only interprets part of the command > line before first argument. How about adding '\r' after "misc" or at whatever place you think appropriate and simply test both the resulting command line and the result of narrow one? Just execute the process and test whatever it gets as the command line and the narrow one? What is so hard with that? -- Dmitry.

July 28, 2016

Re: [PATCH 2/2 v4] ucrtbase: Add _get_narrow_winmain_command_line tests

by Piotr Caban

On 07/28/16 15:43, Dmitry Timoshkov wrote: > Piotr Caban <piotr(a)codeweavers.com> wrote: > >>>>>>>> + sprintf(cmd, "\"\"%c\"\"\"%s\" \t \"misc\" cmd", name[0], name+1); >>>>>>>> + memset(&startup, 0, sizeof(startup)); >>>>>>>> + startup.cb = sizeof(startup); >>>>>>>> + CreateProcessA(path, cmd, NULL, NULL, TRUE, >>>>>>>> + CREATE_DEFAULT_ERROR_MODE|NORMAL_PRIORITY_CLASS, >>>>>>>> + NULL, NULL, &startup, &proc); >>>>>>>> + winetest_wait_child_process(proc.hProcess); >>>>>>> >>>>>>> Thanks for adding the tests. It shouldn't be too hard to also test other >>>>>>> white space characters, at least testing '\r' and '\n' would be nice to >>>>>>> have. >>>>>>> >>>>>> CreateProcess will fail in case of '\r' or '\n' characters. >>>>> >>>>> In a simple test CreateProcess() works just fine here under Windows 7 when a >>>>> passed in command line contains '\r' and/or '\n', where does it fail for you? >>>>> >>>> I'll try to be a little more precise - '\r' is treated as another >>>> argument so it can't be used before first argument (misc in this case). >>> >>> Then it clearly deserves an additional test case. And a test for '\n' since >>> it doesn't break anything. >> '\n' behaves the same as '\r' according to my test. >> >> I think I have already explained you while '\r' case can't be tested in >> reasonable way. > > I don't see why '\r' and '\n' can't be tested. If CreateProcess() call doesn't > fail, what you need to test is the resulting command line that the child process > receives. It's clear and simple. > I've already wrote you that '\r' is treated as argument - because of that it can't be added before "misc" argument (the test executable needs first argument to be "misc"). The function _get_narrow_winmain_command_line only interprets part of the command line before first argument.

July 28, 2016

Re: [PATCH 2/2 v4] ucrtbase: Add _get_narrow_winmain_command_line tests

by Dmitry Timoshkov

Piotr Caban <piotr(a)codeweavers.com> wrote: > >>>>>> + sprintf(cmd, "\"\"%c\"\"\"%s\" \t \"misc\" cmd", name[0], name+1); > >>>>>> + memset(&startup, 0, sizeof(startup)); > >>>>>> + startup.cb = sizeof(startup); > >>>>>> + CreateProcessA(path, cmd, NULL, NULL, TRUE, > >>>>>> + CREATE_DEFAULT_ERROR_MODE|NORMAL_PRIORITY_CLASS, > >>>>>> + NULL, NULL, &startup, &proc); > >>>>>> + winetest_wait_child_process(proc.hProcess); > >>>>> > >>>>> Thanks for adding the tests. It shouldn't be too hard to also test other > >>>>> white space characters, at least testing '\r' and '\n' would be nice to > >>>>> have. > >>>>> > >>>> CreateProcess will fail in case of '\r' or '\n' characters. > >>> > >>> In a simple test CreateProcess() works just fine here under Windows 7 when a > >>> passed in command line contains '\r' and/or '\n', where does it fail for you? > >>> > >> I'll try to be a little more precise - '\r' is treated as another > >> argument so it can't be used before first argument (misc in this case). > > > > Then it clearly deserves an additional test case. And a test for '\n' since > > it doesn't break anything. > '\n' behaves the same as '\r' according to my test. > > I think I have already explained you while '\r' case can't be tested in > reasonable way. I don't see why '\r' and '\n' can't be tested. If CreateProcess() call doesn't fail, what you need to test is the resulting command line that the child process receives. It's clear and simple. -- Dmitry.

July 28, 2016

Re: [PATCH 2/2 v4] ucrtbase: Add _get_narrow_winmain_command_line tests

by Piotr Caban

On 07/28/16 15:27, Dmitry Timoshkov wrote: > Piotr Caban <piotr(a)codeweavers.com> wrote: > >>>>>> + sprintf(cmd, "\"\"%c\"\"\"%s\" \t \"misc\" cmd", name[0], name+1); >>>>>> + memset(&startup, 0, sizeof(startup)); >>>>>> + startup.cb = sizeof(startup); >>>>>> + CreateProcessA(path, cmd, NULL, NULL, TRUE, >>>>>> + CREATE_DEFAULT_ERROR_MODE|NORMAL_PRIORITY_CLASS, >>>>>> + NULL, NULL, &startup, &proc); >>>>>> + winetest_wait_child_process(proc.hProcess); >>>>> >>>>> Thanks for adding the tests. It shouldn't be too hard to also test other >>>>> white space characters, at least testing '\r' and '\n' would be nice to >>>>> have. >>>>> >>>> CreateProcess will fail in case of '\r' or '\n' characters. >>> >>> In a simple test CreateProcess() works just fine here under Windows 7 when a >>> passed in command line contains '\r' and/or '\n', where does it fail for you? >>> >> I'll try to be a little more precise - '\r' is treated as another >> argument so it can't be used before first argument (misc in this case). > > Then it clearly deserves an additional test case. And a test for '\n' since > it doesn't break anything. '\n' behaves the same as '\r' according to my test. I think I have already explained you while '\r' case can't be tested in reasonable way.

July 28, 2016

Re: [PATCH 2/2 v4] ucrtbase: Add _get_narrow_winmain_command_line tests

by Dmitry Timoshkov

Piotr Caban <piotr(a)codeweavers.com> wrote: > >>>> + sprintf(cmd, "\"\"%c\"\"\"%s\" \t \"misc\" cmd", name[0], name+1); > >>>> + memset(&startup, 0, sizeof(startup)); > >>>> + startup.cb = sizeof(startup); > >>>> + CreateProcessA(path, cmd, NULL, NULL, TRUE, > >>>> + CREATE_DEFAULT_ERROR_MODE|NORMAL_PRIORITY_CLASS, > >>>> + NULL, NULL, &startup, &proc); > >>>> + winetest_wait_child_process(proc.hProcess); > >>> > >>> Thanks for adding the tests. It shouldn't be too hard to also test other > >>> white space characters, at least testing '\r' and '\n' would be nice to > >>> have. > >>> > >> CreateProcess will fail in case of '\r' or '\n' characters. > > > > In a simple test CreateProcess() works just fine here under Windows 7 when a > > passed in command line contains '\r' and/or '\n', where does it fail for you? > > > I'll try to be a little more precise - '\r' is treated as another > argument so it can't be used before first argument (misc in this case). Then it clearly deserves an additional test case. And a test for '\n' since it doesn't break anything. -- Dmitry.

July 28, 2016

Re: [PATCH 1/2] msvcp140: Add MSVC 2015 C++ support DLL

by Piotr Caban

On 07/27/16 21:49, Daniel Lehman wrote: > +@ stub ??$_Getvals(a)_W@?$time_get(a)DV?$istreambuf_iterator(a)DU?$char_traits(a)D@std@@@std@@@std@@IAAX_WABV_Locinfo(a)1@@Z > +@ stub ??$_Getvals(a)_W@?$time_get(a)DV?$istreambuf_iterator(a)DU?$char_traits(a)D@std@@@std@@@std@@IAEX_WABV_Locinfo(a)1@@Z > +@ stub ??$_Getvals(a)_W@?$time_get(a)DV?$istreambuf_iterator(a)DU?$char_traits(a)D@std@@@std@@@std@@IEAAX_WAEBV_Locinfo(a)1@@Z > +@ stub ??$_Getvals(a)_W@?$time_get(a)GV?$istreambuf_iterator(a)GU?$char_traits(a)G@std@@@std@@@std@@IAAX_WABV_Locinfo(a)1@@Z > +@ stub ??$_Getvals(a)_W@?$time_get(a)GV?$istreambuf_iterator(a)GU?$char_traits(a)G@std@@@std@@@std@@IAEX_WABV_Locinfo(a)1@@Z > +@ stub ??$_Getvals(a)_W@?$time_get(a)GV?$istreambuf_iterator(a)GU?$char_traits(a)G@std@@@std@@@std@@IEAAX_WAEBV_Locinfo(a)1@@Z > +@ stub ??$_Getvals(a)_W@?$time_get(a)_WV?$istreambuf_iterator(a)_WU?$char_traits(a)_W@std@@@std@@@std@@IAAX_WABV_Locinfo(a)1@@Z > +@ stub ??$_Getvals(a)_W@?$time_get(a)_WV?$istreambuf_iterator(a)_WU?$char_traits(a)_W@std@@@std@@@std@@IAEX_WABV_Locinfo(a)1@@Z > +@ stub ??$_Getvals(a)_W@?$time_get(a)_WV?$istreambuf_iterator(a)_WU?$char_traits(a)_W@std@@@std@@@std@@IEAAX_WAEBV_Locinfo(a)1@@Z Could you please add -arch specifiers to stub entries? Thanks, Piotr

July 28, 2016

Re: avifil32: Use debugstr_a() and debugstr_w() in TRACE() messages.

by Michael Stefaniuc

On 07/28/2016 02:11 PM, Nikolay Sivov wrote: > I see it's Rejected on the patch list, it's indeed wrong, because you're > tracing output parameters. Hehehe, yeah. I run into the same issue with my first version of the debugstr_guid() script. The search and replace programming style can be tricky at times ;) bye michael

July 28, 2016

Re: avifil32: Use debugstr_a() and debugstr_w() in TRACE() messages.

by Nikolay Sivov

I see it's Rejected on the patch list, it's indeed wrong, because you're tracing output parameters.

July 28, 2016

Re: [PATCH 2/6] d3d9/tests: Add visual tests for locking vertexbuffers

by Henri Verbeet

On 26 July 2016 at 19:09, Patrick Rudolph <siro(a)das-labor.org> wrote: > + static const struct > + { > + const char *flags_s; > + unsigned int flags; > + DWORD usage; > + BOOL unsyncronized; > + BOOL todo; > + BOOL broken; > + } > + /* Nvidia ignores D3DLOCK_NOOVERWRITE on non dynamic buffers, > + * while AMD always accepts D3DLOCK_NOOVERWRITE on all buffers. */ > + tests[] = > + { > + {"0", 0, 0, FALSE, FALSE, FALSE}, > + {"0", 0, D3DUSAGE_DYNAMIC, FALSE, FALSE, FALSE}, > + {"D3DLOCK_NOOVERWRITE", D3DLOCK_NOOVERWRITE, 0, FALSE, FALSE, TRUE}, > + {"D3DLOCK_NOOVERWRITE", D3DLOCK_NOOVERWRITE, D3DUSAGE_DYNAMIC, TRUE, FALSE, FALSE}, > + {"D3DLOCK_DISCARD", D3DLOCK_DISCARD, 0, FALSE, FALSE, FALSE}, > + {"D3DLOCK_DISCARD", D3DLOCK_DISCARD, D3DUSAGE_DYNAMIC, FALSE, FALSE, FALSE}, > + {"D3DLOCK_NOOVERWRITE | D3DLOCK_DISCARD", > + D3DLOCK_NOOVERWRITE | D3DLOCK_DISCARD, 0, FALSE, FALSE, TRUE}, > + {"D3DLOCK_NOOVERWRITE | D3DLOCK_DISCARD", > + D3DLOCK_NOOVERWRITE | D3DLOCK_DISCARD, D3DUSAGE_DYNAMIC, TRUE, TRUE, TRUE}, > + {"D3DLOCK_NOOVERWRITE | D3DLOCK_READONLY", > + D3DLOCK_NOOVERWRITE | D3DLOCK_READONLY, 0, FALSE, FALSE, TRUE}, > + {"D3DLOCK_NOOVERWRITE | D3DLOCK_READONLY", > + D3DLOCK_NOOVERWRITE | D3DLOCK_READONLY, D3DUSAGE_DYNAMIC, TRUE, TRUE, TRUE}, > + }; [...] > + todo_wine_if (tests[i].todo) > + { > + ok(tests[i].unsyncronized == unsyncronized || broken(tests[i].broken), > + "Expected buffer mapped %s. Flags = %s. Usage = %#x.\n", > + tests[i].unsyncronized ? "unsyncronized" : "syncronized", tests[i].flags_s, tests[i].usage); > + } I assume the broken() is for the testbot, but the way this is written, half the cases aren't really tested on Windows. Also, what makes these fail on the testbot? > + timestamp1 = GetTickCount(); > + > + hr = IDirect3DDevice9_BeginScene(device); > + ok(SUCCEEDED(hr), "Failed to begin scene, hr %#x.\n", hr); > + hr = IDirect3DDevice9_DrawPrimitive(device, D3DPT_TRIANGLESTRIP, 0, tri); > + ok(SUCCEEDED(hr), "Failed to draw, hr %#x.\n", hr); > + hr = IDirect3DDevice9_EndScene(device); > + ok(SUCCEEDED(hr), "Failed to end scene, hr %#x.\n", hr); > + > + /* dummy read to wait for GPU being done */ > + color = getPixelColor(device, 160, 360); > + > + timestamp2 = GetTickCount(); > + > + /* Adjust buffer size for 1 second draw call duration */ > + size = (size * 1000UL) / (timestamp2 - timestamp1 + 1); Does this work reliably? GetTickCount() has very limited resolution, I think there's a real chance that the draw will take only a fraction of GetTickCount()'s resolution.

July 28, 2016

Re: [PATCH 1/6] wined3d/resource: Add flag WINED3D_MAP_WRITEONLY

by Henri Verbeet

On 26 July 2016 at 19:09, Patrick Rudolph <siro(a)das-labor.org> wrote: > #define WINED3D_MAP_READONLY 0x0010 > +#define WINED3D_MAP_WRITEONLY 0x0020 But now the API is weird. What happens when both READONLY and WRITEONLY are set? I think the d3d11 model makes more sense.

July 28, 2016

Re: [PATCH 2/2 v4] ucrtbase: Add _get_narrow_winmain_command_line tests

by Piotr Caban

On 07/28/16 13:33, Dmitry Timoshkov wrote: > Piotr Caban <piotr(a)codeweavers.com> wrote: > >>>> + sprintf(cmd, "\"\"%c\"\"\"%s\" \t \"misc\" cmd", name[0], name+1); >>>> + memset(&startup, 0, sizeof(startup)); >>>> + startup.cb = sizeof(startup); >>>> + CreateProcessA(path, cmd, NULL, NULL, TRUE, >>>> + CREATE_DEFAULT_ERROR_MODE|NORMAL_PRIORITY_CLASS, >>>> + NULL, NULL, &startup, &proc); >>>> + winetest_wait_child_process(proc.hProcess); >>> >>> Thanks for adding the tests. It shouldn't be too hard to also test other >>> white space characters, at least testing '\r' and '\n' would be nice to >>> have. >>> >> CreateProcess will fail in case of '\r' or '\n' characters. > > In a simple test CreateProcess() works just fine here under Windows 7 when a > passed in command line contains '\r' and/or '\n', where does it fail for you? > I'll try to be a little more precise - '\r' is treated as another argument so it can't be used before first argument (misc in this case).

July 28, 2016

Re: [PATCH 2/2 v4] ucrtbase: Add _get_narrow_winmain_command_line tests

by Dmitry Timoshkov

Piotr Caban <piotr(a)codeweavers.com> wrote: > >> + sprintf(cmd, "\"\"%c\"\"\"%s\" \t \"misc\" cmd", name[0], name+1); > >> + memset(&startup, 0, sizeof(startup)); > >> + startup.cb = sizeof(startup); > >> + CreateProcessA(path, cmd, NULL, NULL, TRUE, > >> + CREATE_DEFAULT_ERROR_MODE|NORMAL_PRIORITY_CLASS, > >> + NULL, NULL, &startup, &proc); > >> + winetest_wait_child_process(proc.hProcess); > > > > Thanks for adding the tests. It shouldn't be too hard to also test other > > white space characters, at least testing '\r' and '\n' would be nice to > > have. > > > CreateProcess will fail in case of '\r' or '\n' characters. In a simple test CreateProcess() works just fine here under Windows 7 when a passed in command line contains '\r' and/or '\n', where does it fail for you? -- Dmitry.

July 28, 2016

Re: [PATCH 2/2 v4] ucrtbase: Add _get_narrow_winmain_command_line tests

by Piotr Caban

On 07/28/16 13:08, Dmitry Timoshkov wrote: > Piotr Caban <piotr(a)codeweavers.com> wrote: > >> + sprintf(cmd, "\"\"%c\"\"\"%s\" \t \"misc\" cmd", name[0], name+1); >> + memset(&startup, 0, sizeof(startup)); >> + startup.cb = sizeof(startup); >> + CreateProcessA(path, cmd, NULL, NULL, TRUE, >> + CREATE_DEFAULT_ERROR_MODE|NORMAL_PRIORITY_CLASS, >> + NULL, NULL, &startup, &proc); >> + winetest_wait_child_process(proc.hProcess); > > Thanks for adding the tests. It shouldn't be too hard to also test other > white space characters, at least testing '\r' and '\n' would be nice to > have. > CreateProcess will fail in case of '\r' or '\n' characters.

July 28, 2016

Re: [PATCH 2/2 v4] ucrtbase: Add _get_narrow_winmain_command_line tests

by Dmitry Timoshkov

Piotr Caban <piotr(a)codeweavers.com> wrote: > + sprintf(cmd, "\"\"%c\"\"\"%s\" \t \"misc\" cmd", name[0], name+1); > + memset(&startup, 0, sizeof(startup)); > + startup.cb = sizeof(startup); > + CreateProcessA(path, cmd, NULL, NULL, TRUE, > + CREATE_DEFAULT_ERROR_MODE|NORMAL_PRIORITY_CLASS, > + NULL, NULL, &startup, &proc); > + winetest_wait_child_process(proc.hProcess); Thanks for adding the tests. It shouldn't be too hard to also test other white space characters, at least testing '\r' and '\n' would be nice to have. -- Dmitry.

July 28, 2016

Re: [PATCH 2/2] DInput : Use vendor and product ids to generate product GUID like it's done on Windows

by DavidL

I'm not really familiar with the intricacies of the guid generation ... but looking at the Mac dinput code ... should a similar patch be applied there? Cheers, David On Sun, Jul 24, 2016 at 3:15 AM, Corentin Rossignon <corossig(a)gmail.com> wrote: > Done, thanks for taking some times and helping me doing a proper patch. > > > > On 07/24/2016 12:03 AM, Bruno Jesus wrote: > >> On Sat, Jul 23, 2016 at 8:01 AM, Corentin Rossignon <corossig(a)gmail.com> >> wrote: >> >>> Signed-off-by: Corentin Rossignon <corossig(a)gmail.com> >>> --- >>> dlls/dinput/joystick_linux.c | 34 >>> +++++++++++++++++++++++++++++++--- >>> dlls/dinput/joystick_linuxinput.c | 27 +++++++++++++++++++++++++-- >>> 2 files changed, 56 insertions(+), 5 deletions(-) >>> >> Formatting problem: >> >> bruno(a)Note:~/programs/wine$ git apply dinput2 >> dinput2:31: trailing whitespace. >> /* >> dinput2:35: trailing whitespace. >> * Data4 seems to be a constant. >> dinput2:104: trailing whitespace. >> /* >> dinput2:108: trailing whitespace. >> * Data4 seems to be a constant. >> warning: 4 lines add whitespace errors. >> >> diff --git a/dlls/dinput/joystick_linux.c b/dlls/dinput/joystick_linux.c >>> index 90b7280..f8499ca 100644 >>> --- a/dlls/dinput/joystick_linux.c >>> +++ b/dlls/dinput/joystick_linux.c >>> @@ -77,6 +77,7 @@ struct JoyDev >>> { >>> char device[MAX_PATH]; >>> char name[MAX_PATH]; >>> + GUID guid_product; >>> >>> BYTE axis_count; >>> BYTE button_count; >>> @@ -122,6 +123,21 @@ static const GUID DInput_Wine_Joystick_GUID = { /* >>> 9e573ed9-7734-11d2-8d4a-23903 >>> {0x8d, 0x4a, 0x23, 0x90, 0x3f, 0xb6, 0xbd, 0xf7} >>> }; >>> >>> + >>> +/* >>> + * Construct the GUID in the same way of Windows doing this. >>> + * Data1 is concatenation of productid and vendorid. >>> + * Data2 and Data3 are NULL. >>> + * Data4 seems to be a constant. >>> + */ >>> +static const GUID DInput_Wine_Joystick_Constant_Part_GUID = { >>> + 0x000000000, >>> + 0x0000, >>> + 0x0000, >>> + {0x00, 0x00, 0x50, 0x49, 0x44, 0x56, 0x49, 0x44} >>> +}; >>> + >>> + >>> >> Please remove all double blank lines in your changes in order to be >> more compatible with the surrounding code style. >> > > > >

July 28, 2016

Re: [PATCH 1/4] mpr: Implement local name automatic redirection for disks.

by Pierre Schweitzer

I also modified 2nd patch of the patch, because it was suffering the same issue and wasn't applying any longer. Both have been resent. Le 28/07/2016 à 10:12, Alexandre Julliard a écrit : > Pierre Schweitzer <pierre(a)reactos.org> writes: > >> Hi, >> >> I wanted to avoid yet another recopy (in the ANSI case) especially since >> input is well-known: user necessarily provided NULL ptr to reach that point. >> But, if you prefer, I can do another copy. But in the ANSI case, it will >> mean that NETRESOURCE structure has been copied twice (rather expensive). > > It's not expensive, it's a small structure, and you don't need to > duplicate the pointers. > -- Pierre Schweitzer <pierre at reactos.org> System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V.

July 28, 2016

Re: [PATCH 1/4] mpr: Implement local name automatic redirection for disks.

by Alexandre Julliard

Pierre Schweitzer <pierre(a)reactos.org> writes: > Hi, > > I wanted to avoid yet another recopy (in the ANSI case) especially since > input is well-known: user necessarily provided NULL ptr to reach that point. > But, if you prefer, I can do another copy. But in the ANSI case, it will > mean that NETRESOURCE structure has been copied twice (rather expensive). It's not expensive, it's a small structure, and you don't need to duplicate the pointers. -- Alexandre Julliard julliard(a)winehq.org

July 28, 2016

Re: [PATCH 3/4] mpr: Implement WNetCancelConnection2W().

by Nikolay Sivov

On 27.07.2016 16:16, Pierre Schweitzer wrote: > > DWORD WINAPI WNetCancelConnection2W( LPCWSTR lpName, DWORD dwFlags, BOOL fForce ) > { > - FIXME( "(%s, %08X, %d), stub\n", debugstr_w(lpName), dwFlags, fForce ); I think it's better to keep this as TRACE, also maybe change lpName -> name, dwFlags -> flags, fForce -> force. Flags are unused, so maybe some fixme message for them is appropriate. > + DWORD ret = WN_NO_NETWORK; > + DWORD index; > > - return WN_SUCCESS; > + if (providerTable != NULL) > + { > + for (index = 0; index < providerTable->numProviders; index++) > + { > + if(providerTable->table[index].getCaps(WNNC_CONNECTION) & > + WNNC_CON_GETCONNECTIONS) Shouldn't this be WNNC_CON_CANCELCONNECTION? > + { > + if (providerTable->table[index].cancelConnection) > + ret = providerTable->table[index].cancelConnection((LPWSTR)lpName, fForce); > + else > + ret = WN_NO_NETWORK; > + if (ret == WN_SUCCESS || ret == WN_OPEN_FILES) > + break; > + } According to docs, WN_OPEN_FILES happens when force == FALSE, does it make sense to handle it only in this case? Of course we have no easy way to test any of that. > + } > + } > + return ret; > }

July 28, 2016

Re: [PATCH 1/4] mpr: Implement local name automatic redirection for disks.

by Pierre Schweitzer

Hi, I wanted to avoid yet another recopy (in the ANSI case) especially since input is well-known: user necessarily provided NULL ptr to reach that point. But, if you prefer, I can do another copy. But in the ANSI case, it will mean that NETRESOURCE structure has been copied twice (rather expensive). Cheers, Le 28/07/2016 à 09:50, Alexandre Julliard a écrit : > Pierre Schweitzer <pierre(a)reactos.org> writes: > >> +done: >> + if (redirect) >> + ctxt->resource->lpLocalName = NULL; > > It looks quite suspicious to modify that input parameter and restore it > at the end. You should probably use a copy instead. > -- Pierre Schweitzer <pierre at reactos.org> System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V.

July 28, 2016

Re: [PATCH 1/4] mpr: Implement local name automatic redirection for disks.

by Alexandre Julliard

Pierre Schweitzer <pierre(a)reactos.org> writes: > +done: > + if (redirect) > + ctxt->resource->lpLocalName = NULL; It looks quite suspicious to modify that input parameter and restore it at the end. You should probably use a copy instead. -- Alexandre Julliard julliard(a)winehq.org

July 28, 2016

Re: [PATCH 2/2] msvcp140: add sprintf

by Nikolay Sivov

> +#if _MSVCP_VER >= 140 > +int __cdecl sprintf(char *buf, const char *fmt, ...) > +{ > + int ret; > + __ms_va_list valist; > + __ms_va_start(valist, fmt); > + ret = __stdio_common_vsprintf(2, buf, -1, fmt, NULL, valist); > + __ms_va_end(valist); > + return ret; > +} > +#endif Are we missing patch 1/2 that adds msvcp140? Also won't it work the same if you forward it to MSVCRT_sprintf? If _common_ functions should actually be used, options should use existing private defines.

July 28, 2016

Re: [PATCH 3/3] ntdll: For Mac 64-bit, poke NtCurrentTeb()->ThreadLocalStoragePointer to the corresponding offset from %gs.

by Alexandre Julliard

Sebastian Lackner <sebastian(a)fds-team.de> writes: > It looks like RtlRunOnceExecuteOnce is not safe to use (keyed_event not initialized yet). > You could use pthread (like used before in init_teb_key), but probably moving to > a function is sufficient to improve code readability. By avoiding the heavily indented > code it would already look a bit less hacky. ;) Simplifying the error handling would probably also help. For instance, pthread_setspecific() is not going to fail in any meaningful way. -- Alexandre Julliard julliard(a)winehq.org

July 27, 2016

Re: [PATCH 2/6] d3drm: Implement IDirect3DRM*::CreateViewport. (v2 resend)

by Stefan Dösinger

On 2016-07-27 20:27, Aaryaman Vasishta wrote: > > > On Thu, Jul 28, 2016 at 12:21 AM, Stefan Dösinger > <stefandoesinger(a)gmail.com <mailto:stefandoesinger(a)gmail.com>> wrote: > > > + if (!device || !camera) > > + return D3DRMERR_BADOBJECT; > > + if (!viewport) > > + return D3DRMERR_BADVALUE; > These checks are redundant, Init() does that as well. > > Agreed for version 3 of CreateViewport, but this this apply for version > 1/2 as well? Since I'm dereferencing these interfaces there I thought > the checks were justified. No, in 1 and 2 you need them as you say. Otherwise you'll crash when you try to call QI.

July 27, 2016

Re: [PATCH 1/6] d3drm: Implement IDirect3DRMViewport*::Init. (v7)

by Aaryaman Vasishta

On Thu, Jul 28, 2016 at 12:53 AM, Henri Verbeet <hverbeet(a)gmail.com> wrote: > On 27 July 2016 at 21:09, Aaryaman Vasishta <jem456.vasishta(a)gmail.com> > wrote: > > On Thu, Jul 28, 2016 at 12:13 AM, Stefan Dösinger > >> > + if (material) > >> > + IDirect3DMaterial_Release(material); > >> This will destroy the material, viewport::SetBackground doesn't addref > it. > > > > Right, henri suggested the same. I'll move this outside the cleanup > label. > I did say the sequence was odd, but it does work because "material" is > set to NULL on successful viewport initialisation. On the other hand, > I just noticed you'll also leak the material if > IDirect3DViewport_SetBackground() fails. > Right, sorry to not mention about the sequence. I also noticed the leak while fixing the same. Cheers, Aaryaman

July 27, 2016

Re: [PATCH 2/6] d3drm: Implement IDirect3DRM*::CreateViewport. (v2 resend)

by Aaryaman Vasishta

On Thu, Jul 28, 2016 at 12:21 AM, Stefan Dösinger <stefandoesinger(a)gmail.com > wrote: > > + if (!device || !camera) > > + return D3DRMERR_BADOBJECT; > > + if (!viewport) > > + return D3DRMERR_BADVALUE; > These checks are redundant, Init() does that as well. > Agreed for version 3 of CreateViewport, but this this apply for version 1/2 as well? Since I'm dereferencing these interfaces there I thought the checks were justified. > > > + ok(ref4 == frame_ref, "Expected ref4 == frame_ref, got frame_ref = > %u, ref4 = %u.\n", frame_ref, ref4); > > + > > + device_ref = get_refcount((IUnknown *)device1); > > + frame_ref = get_refcount((IUnknown *)frame); > The get_refcount here seems redundant because you've just shown that it is > back to where it used to be. > Right, these are definitely redundant. Thanks for the review! Cheers, Aaryaman

July 27, 2016

Re: [PATCH 1/6] d3drm: Implement IDirect3DRMViewport*::Init. (v7)

by Henri Verbeet

On 27 July 2016 at 21:09, Aaryaman Vasishta <jem456.vasishta(a)gmail.com> wrote: > On Thu, Jul 28, 2016 at 12:13 AM, Stefan Dösinger >> > + if (material) >> > + IDirect3DMaterial_Release(material); >> This will destroy the material, viewport::SetBackground doesn't addref it. > > Right, henri suggested the same. I'll move this outside the cleanup label. I did say the sequence was odd, but it does work because "material" is set to NULL on successful viewport initialisation. On the other hand, I just noticed you'll also leak the material if IDirect3DViewport_SetBackground() fails.

July 27, 2016

Re: [PATCH 3/6] d3drm: Implement IDirect3DRMViewport::GetDirect3DViewport. (resend)

by Stefan Dösinger

On 2016-07-27 20:08, Stefan Dösinger wrote: > You have some lines > 120 characters in here. Otherwise looks good to me. Actually, I accidentally counted the + from the patch, so it's exactly 120.

July 27, 2016

Re: [PATCH 1/6] d3drm: Implement IDirect3DRMViewport*::Init. (v7)

by Aaryaman Vasishta

On Thu, Jul 28, 2016 at 12:13 AM, Stefan Dösinger <stefandoesinger(a)gmail.com > wrote: > On 2016-07-19 19:08, Aaryaman Vasishta wrote: > > + memset(&mat, 0, sizeof(mat)); > > + mat.dwSize = sizeof(mat); > > + mat.diffuse.r = RGBA_GETRED(color) / 255.0f; > > + mat.diffuse.g = RGBA_GETGREEN(color) / 255.0f; > > + mat.diffuse.b = RGBA_GETBLUE(color) / 255.0f; > > + mat.diffuse.a = RGBA_GETALPHA(color) / 255.0f; > Doing this here seems questionable. What happens if the camera's > background is changed after the viewport is created? You'll probably want > to update the material property in viewport::clear(), or maybe in > camera::SetSceneBackground. > Right, that'll be added in the implementation of Clear. The camera frame itself doesn't contain a reference to the viewport so I doubt SetSceneBackground has any effect on it. (See the tests I wrote for Clear). > > > + if (material) > > + IDirect3DMaterial_Release(material); > This will destroy the material, viewport::SetBackground doesn't addref it. > Right, henri suggested the same. I'll move this outside the cleanup label. > > > + IDirect3DRMDevice3_Release(device3); > > + IDirect3DRMDevice_Release(device1); > > + ref4 = get_refcount((IUnknown *)d3drm1); > > + todo_wine ok(ref4 > initial_ref1, "Expected ref4 > initial_ref1, > got initial_ref1 = %u, ref4 = %u.\n", initial_ref1, ref4); > The ref4 > inital_ref1 check isn't all too surprising because frame3 still > holds a reference to its d3drm parent. Though it seems the leaked reference > added by the second Viewport::Init call gets released somewhere. The test > doesn't exactly show where. It is possible that releasing the device frees > it, or releasing the frame does it. > The leaked references created by the second Init call are all released when the device is destroyed. This suggests that the device is using some sort of destroy callback and keeping track of all leaked references. See the ref4 == initial_ref1 test below it. I'll resend the patch with the fixes you mentioned. Thanks for the review! Cheers, Aaryaman

July 27, 2016

Re: [PATCH 3/6] d3drm: Implement IDirect3DRMViewport::GetDirect3DViewport. (resend)

by Stefan Dösinger

You have some lines > 120 characters in here. Otherwise looks good to me. On 2016-07-19 19:08, Aaryaman Vasishta wrote: > Signed-off-by: Aaryaman Vasishta <jem456.vasishta(a)gmail.com> > --- > dlls/d3drm/tests/d3drm.c | 67 +++++++++++++++++++++++++++++++++++++++++++++++- > dlls/d3drm/viewport.c | 18 ++++++++++--- > 2 files changed, 80 insertions(+), 5 deletions(-) > > diff --git a/dlls/d3drm/tests/d3drm.c b/dlls/d3drm/tests/d3drm.c > index 17cf2dd..fc0b6b4 100644 > --- a/dlls/d3drm/tests/d3drm.c > +++ b/dlls/d3drm/tests/d3drm.c > @@ -1474,12 +1474,13 @@ static void test_Viewport(void) > IDirect3DRMFrame3 *frame3; > IDirect3DRMViewport *viewport; > IDirect3DRMViewport2 *viewport2; > + IDirect3DViewport *d3d_viewport; > IDirect3DRMObject *obj, *obj2; > GUID driver; > HWND window; > RECT rc; > DWORD size, data, ref1, ref2, ref3, ref4; > - DWORD initial_ref1, initial_ref2, initial_ref3, device_ref, frame_ref, frame_ref2; > + DWORD initial_ref1, initial_ref2, initial_ref3, device_ref, frame_ref, frame_ref2, viewport_ref; > CHAR cname[64] = {0}; > > window = CreateWindowA("static", "d3drm_test", WS_OVERLAPPEDWINDOW, 0, 0, 300, 200, 0, 0, 0, 0); > @@ -1641,13 +1642,47 @@ static void test_Viewport(void) > > hr = IDirect3DRM2_CreateViewport(d3drm2, device1, frame, rc.left, rc.top, rc.right, rc.bottom, &viewport); > ok(hr == D3DRM_OK, "Cannot get IDirect3DRMViewport interface (hr = %x)\n", hr); > + hr = IDirect3DRMViewport_GetDirect3DViewport(viewport, &d3d_viewport); > + ok(SUCCEEDED(hr), "Cannot get IDirect3DViewport interface (hr = %#x).\n", hr); > + viewport_ref = get_refcount((IUnknown *)d3d_viewport); > + hr = IDirect3DRMViewport_GetDirect3DViewport(viewport, &d3d_viewport); > + ok(SUCCEEDED(hr), "Cannot get IDirect3DViewport interface (hr = %#x).\n", hr); > + ref4 = get_refcount((IUnknown *)d3d_viewport); > + ok(ref4 > viewport_ref, "Expected ref4 > viewport_ref, got ref4 = %u, viewport_ref = %u.\n", ref4, viewport_ref); > + IDirect3DViewport_Release(d3d_viewport); > + ref4 = get_refcount((IUnknown *)d3d_viewport); > + ok(ref4 == viewport_ref, "Expected ref4 == viewport_ref, got ref4 = %u, viewport_ref = %u.\n", ref4, viewport_ref); > + IDirect3DViewport_Release(d3d_viewport); > IDirect3DRMViewport_Release(viewport); > + > hr = IDirect3DRM3_CreateViewport(d3drm3, device3, frame3, rc.left, rc.top, rc.right, rc.bottom, &viewport2); > ok(hr == D3DRM_OK, "Cannot get IDirect3DRMViewport2 interface (hr = %x)\n", hr); > + hr = IDirect3DRMViewport2_GetDirect3DViewport(viewport2, &d3d_viewport); > + ok(SUCCEEDED(hr), "Cannot get IDirect3DViewport interface (hr = %#x).\n", hr); > + viewport_ref = get_refcount((IUnknown *)d3d_viewport); > + hr = IDirect3DRMViewport2_GetDirect3DViewport(viewport2, &d3d_viewport); > + ok(SUCCEEDED(hr), "Cannot get IDirect3DViewport interface (hr = %#x).\n", hr); > + ref4 = get_refcount((IUnknown *)d3d_viewport); > + ok(ref4 > viewport_ref, "Expected ref4 > viewport_ref, got ref4 = %u, viewport_ref = %u.\n", ref4, viewport_ref); > + IDirect3DViewport_Release(d3d_viewport); > + ref4 = get_refcount((IUnknown *)d3d_viewport); > + ok(ref4 == viewport_ref, "Expected ref4 == viewport_ref, got ref4 = %u, viewport_ref = %u.\n", ref4, viewport_ref); > + IDirect3DViewport_Release(d3d_viewport); > IDirect3DRMViewport2_Release(viewport2); > > hr = IDirect3DRM_CreateViewport(d3drm1, device1, frame, rc.left, rc.top, rc.right, rc.bottom, &viewport); > ok(hr == D3DRM_OK, "Cannot get IDirect3DRMViewport interface (hr = %x)\n", hr); > + hr = IDirect3DRMViewport_GetDirect3DViewport(viewport, &d3d_viewport); > + ok(SUCCEEDED(hr), "Cannot get IDirect3DViewport interface (hr = %#x).\n", hr); > + viewport_ref = get_refcount((IUnknown *)d3d_viewport); > + hr = IDirect3DRMViewport_GetDirect3DViewport(viewport, &d3d_viewport); > + ok(SUCCEEDED(hr), "Cannot get IDirect3DViewport interface (hr = %#x).\n", hr); > + ref4 = get_refcount((IUnknown *)d3d_viewport); > + ok(ref4 > viewport_ref, "Expected ref4 > viewport_ref, got ref4 = %u, viewport_ref = %u.\n", ref4, viewport_ref); > + IDirect3DViewport_Release(d3d_viewport); > + ref4 = get_refcount((IUnknown *)d3d_viewport); > + ok(ref4 == viewport_ref, "Expected ref4 == viewport_ref, got ref4 = %u, viewport_ref = %u.\n", ref4, viewport_ref); > + IDirect3DViewport_Release(d3d_viewport); > > hr = IDirect3DRMViewport_QueryInterface(viewport, &IID_IDirect3DRMObject, (void**)&obj); > ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > @@ -1713,6 +1748,9 @@ static void test_Viewport(void) > ref4 = get_refcount((IUnknown *)d3drm3); > ok(ref4 == ref3, "Expected ref4 == ref3, got ref3 = %u, ref4 = %u.\n", ref3, ref4); > > + hr = IDirect3DRMViewport_GetDirect3DViewport(viewport, &d3d_viewport); > + ok(hr == D3DRMERR_BADOBJECT, "Expected hr == D3DRMERR_BADOBJECT, got %#x.\n", hr); > + > /* Test all failures together */ > hr = IDirect3DRMViewport_Init(viewport, NULL, frame, rc.left, rc.top, rc.right, rc.bottom); > ok(hr == D3DRMERR_BADOBJECT, "Expected hr == D3DRMERR_BADOBJECT, got %#x.\n", hr); > @@ -1740,6 +1778,18 @@ static void test_Viewport(void) > ref4 = get_refcount((IUnknown *)frame); > ok(ref4 > frame_ref, "Expected ref4 > frame_ref, got frame_ref = %u, ref4 = %u.\n", frame_ref, ref4); > > + hr = IDirect3DRMViewport_GetDirect3DViewport(viewport, &d3d_viewport); > + ok(SUCCEEDED(hr), "Cannot get IDirect3DViewport interface (hr = %#x).\n", hr); > + viewport_ref = get_refcount((IUnknown *)d3d_viewport); > + hr = IDirect3DRMViewport_GetDirect3DViewport(viewport, &d3d_viewport); > + ok(SUCCEEDED(hr), "Cannot get IDirect3DViewport interface (hr = %#x).\n", hr); > + ref4 = get_refcount((IUnknown *)d3d_viewport); > + ok(ref4 > viewport_ref, "Expected ref4 > viewport_ref, got ref4 = %u, viewport_ref = %u.\n", ref4, viewport_ref); > + IDirect3DViewport_Release(d3d_viewport); > + ref4 = get_refcount((IUnknown *)d3d_viewport); > + ok(ref4 == viewport_ref, "Expected ref4 == viewport_ref, got ref4 = %u, viewport_ref = %u.\n", ref4, viewport_ref); > + IDirect3DViewport_Release(d3d_viewport); > + > hr = IDirect3DRMViewport_Init(viewport, device1, frame, rc.left, rc.top, rc.right, rc.bottom); > ok(hr == D3DRMERR_BADOBJECT, "Expected hr == D3DRMERR_BADOBJECT, got %#x.\n", hr); > > @@ -1768,6 +1818,9 @@ static void test_Viewport(void) > ref4 = get_refcount((IUnknown *)d3drm3); > ok(ref4 == ref3, "Expected ref4 == ref3, got ref3 = %u, ref4 = %u.\n", ref3, ref4); > > + hr = IDirect3DRMViewport2_GetDirect3DViewport(viewport2, &d3d_viewport); > + ok(hr == D3DRMERR_BADOBJECT, "Expected hr == D3DRMERR_BADOBJECT, got %#x.\n", hr); > + > hr = IDirect3DRMViewport2_Init(viewport2, NULL, frame3, rc.left, rc.top, rc.right, rc.bottom); > ok(hr == D3DRMERR_BADOBJECT, "Expected hr == D3DRMERR_BADOBJECT, got %#x.\n", hr); > hr = IDirect3DRMViewport2_Init(viewport2, device3, NULL, rc.left, rc.top, rc.right, rc.bottom); > @@ -1788,6 +1841,18 @@ static void test_Viewport(void) > ref4 = get_refcount((IUnknown *)frame3); > ok(ref4 > frame_ref2, "Expected ref4 > frame_ref2, got frame_ref2 = %u, ref4 = %u.\n", frame_ref2, ref4); > > + hr = IDirect3DRMViewport2_GetDirect3DViewport(viewport2, &d3d_viewport); > + ok(SUCCEEDED(hr), "Cannot get IDirect3DViewport interface (hr = %#x).\n", hr); > + viewport_ref = get_refcount((IUnknown *)d3d_viewport); > + hr = IDirect3DRMViewport2_GetDirect3DViewport(viewport2, &d3d_viewport); > + ok(SUCCEEDED(hr), "Cannot get IDirect3DViewport interface (hr = %#x).\n", hr); > + ref4 = get_refcount((IUnknown *)d3d_viewport); > + ok(ref4 > viewport_ref, "Expected ref4 > viewport_ref, got ref4 = %u, viewport_ref = %u.\n", ref4, viewport_ref); > + IDirect3DViewport_Release(d3d_viewport); > + ref4 = get_refcount((IUnknown *)d3d_viewport); > + ok(ref4 == viewport_ref, "Expected ref4 == viewport_ref, got ref4 = %u, viewport_ref = %u.\n", ref4, viewport_ref); > + IDirect3DViewport_Release(d3d_viewport); > + > hr = IDirect3DRMViewport2_Init(viewport2, device3, frame3, rc.left, rc.top, rc.right, rc.bottom); > ok(hr == D3DRMERR_BADOBJECT, "Expected hr == D3DRMERR_BADOBJECT, got %#x.\n", hr); > > diff --git a/dlls/d3drm/viewport.c b/dlls/d3drm/viewport.c > index 730a1f5..09b0e83 100644 > --- a/dlls/d3drm/viewport.c > +++ b/dlls/d3drm/viewport.c > @@ -826,17 +826,27 @@ static D3DRMPROJECTIONTYPE WINAPI d3drm_viewport1_GetProjection(IDirect3DRMViewp > static HRESULT WINAPI d3drm_viewport2_GetDirect3DViewport(IDirect3DRMViewport2 *iface, > IDirect3DViewport **viewport) > { > - FIXME("iface %p, viewport %p stub!\n", iface, viewport); > + struct d3drm_viewport *viewport_object = impl_from_IDirect3DRMViewport2(iface); > > - return E_NOTIMPL; > + TRACE("iface %p, viewport %p.\n", iface, viewport); > + > + if (!viewport_object->d3d_viewport) > + return D3DRMERR_BADOBJECT; > + > + *viewport = viewport_object->d3d_viewport; > + IDirect3DViewport_AddRef(*viewport); > + > + return D3DRM_OK; > } > > static HRESULT WINAPI d3drm_viewport1_GetDirect3DViewport(IDirect3DRMViewport *iface, > IDirect3DViewport **viewport) > { > - FIXME("iface %p, viewport %p stub!\n", iface, viewport); > + struct d3drm_viewport *viewport_object = impl_from_IDirect3DRMViewport(iface); > > - return E_NOTIMPL; > + TRACE("iface %p, viewport %p.\n", iface, viewport); > + > + return d3drm_viewport2_GetDirect3DViewport(&viewport_object->IDirect3DRMViewport2_iface, viewport); > } > > static HRESULT WINAPI d3drm_viewport2_TransformVectors(IDirect3DRMViewport2 *iface, >

July 27, 2016

Re: [PATCH 3/3] ntdll: For Mac 64-bit, poke NtCurrentTeb()->ThreadLocalStoragePointer to the corresponding offset from %gs.

by Sebastian Lackner

On 27.07.2016 20:25, Ken Thomases wrote: > On Jul 27, 2016, at 12:53 PM, Sebastian Lackner <sebastian(a)fds-team.de> wrote: >> >> I have only two suggestions: >> - gsbase_offset == 0 (key == i) could also be valid, so it would be useful to distinguish this case. > > It can't be valid because that would put the TLS at the beginning of struct _pthread, but the ABI actually reveals the first couple of fields. pthread_t is a typedef for __darwin_pthread_t which is a typedef for struct _opaque_pthread_t which is defined (not just declared) in the headers (/usr/include/sys/_pthread/_pthread_types.h in the 10.11 SDK) and is less opaque than its name would suggest. Comments in the definition of struct _pthread in libpthread make note of the ABI compatibility factor. > > In practice, the TLS array is at the end of the struct and I think Apple told us it has to be there. When you are sure that this is always true you can start searching at (key + 1). > >> - the logic could be moved to a helper function, for example using the init once mechanism > > I suppose, but it will be called for the first thread before there's a chance of creating secondary threads. So, there's no race. Also, I haven't looked, but I'm not sure what thread setup has to have been completed before RtlRunOnceExecuteOnce() can safely be used. It looks like RtlRunOnceExecuteOnce is not safe to use (keyed_event not initialized yet). You could use pthread (like used before in init_teb_key), but probably moving to a function is sufficient to improve code readability. By avoiding the heavily indented code it would already look a bit less hacky. ;) > > -Ken >

July 27, 2016

Re: [PATCH 2/6] d3drm: Implement IDirect3DRM*::CreateViewport. (v2 resend)

by Stefan Dösinger

On 2016-07-19 19:08, Aaryaman Vasishta wrote: > + if (FAILED(hr = IDirect3DRMDevice_QueryInterface(device, &IID_IDirect3DRMDevice3, (void **)&device3))) > + return hr; > + > + if (FAILED(hr = IDirect3DRMFrame_QueryInterface(camera, &IID_IDirect3DRMFrame3, (void **)&camera3))) > + { > + IDirect3DRMDevice3_Release(device3); > + return hr; > + } > + IDirect3DRMDevice_Release(device); > + IDirect3DRMFrame_Release(camera); This releases references you don't own. Same in the V2 -> V3 thunk. > + if (!device || !camera) > + return D3DRMERR_BADOBJECT; > + if (!viewport) > + return D3DRMERR_BADVALUE; These checks are redundant, Init() does that as well. > + ok(ref4 == frame_ref, "Expected ref4 == frame_ref, got frame_ref = %u, ref4 = %u.\n", frame_ref, ref4); > + > + device_ref = get_refcount((IUnknown *)device1); > + frame_ref = get_refcount((IUnknown *)frame); The get_refcount here seems redundant because you've just shown that it is back to where it used to be.

July 27, 2016

Re: [PATCH 1/6] d3drm: Implement IDirect3DRMViewport*::Init. (v7)

by Stefan Dösinger

On 2016-07-19 19:08, Aaryaman Vasishta wrote: > + memset(&mat, 0, sizeof(mat)); > + mat.dwSize = sizeof(mat); > + mat.diffuse.r = RGBA_GETRED(color) / 255.0f; > + mat.diffuse.g = RGBA_GETGREEN(color) / 255.0f; > + mat.diffuse.b = RGBA_GETBLUE(color) / 255.0f; > + mat.diffuse.a = RGBA_GETALPHA(color) / 255.0f; Doing this here seems questionable. What happens if the camera's background is changed after the viewport is created? You'll probably want to update the material property in viewport::clear(), or maybe in camera::SetSceneBackground. > + if (material) > + IDirect3DMaterial_Release(material); This will destroy the material, viewport::SetBackground doesn't addref it. > + hr = IDirect3DRMViewport_Init(viewport, device1, frame, rc.left, rc.top, rc.right + 1, rc.bottom + 1); > + ok(hr == D3DRMERR_BADOBJECT, "Expected hr == D3DRMERR_BADOBJECT, got %#x.\n", hr); > + hr = IDirect3DRMViewport_Init(viewport, device1, frame, rc.left, rc.top, rc.right + 1, rc.bottom); > + ok(hr == D3DRMERR_BADOBJECT, "Expected hr == D3DRMERR_BADOBJECT, got %#x.\n", hr); > + hr = IDirect3DRMViewport_Init(viewport, device1, frame, rc.left, rc.top, rc.right + 1, rc.bottom + 1); > + ok(hr == D3DRMERR_BADOBJECT, "Expected hr == D3DRMERR_BADOBJECT, got %#x.\n", hr); The first and third test are identical. > + IDirect3DRMDevice3_Release(device3); > + IDirect3DRMDevice_Release(device1); > + ref4 = get_refcount((IUnknown *)d3drm1); > + todo_wine ok(ref4 > initial_ref1, "Expected ref4 > initial_ref1, got initial_ref1 = %u, ref4 = %u.\n", initial_ref1, ref4); The ref4 > inital_ref1 check isn't all too surprising because frame3 still holds a reference to its d3drm parent. Though it seems the leaked reference added by the second Viewport::Init call gets released somewhere. The test doesn't exactly show where. It is possible that releasing the device frees it, or releasing the frame does it.

July 27, 2016

Re: [PATCH 3/3] ntdll: For Mac 64-bit, poke NtCurrentTeb()->ThreadLocalStoragePointer to the corresponding offset from %gs.

by Ken Thomases

On Jul 27, 2016, at 12:53 PM, Sebastian Lackner <sebastian(a)fds-team.de> wrote: > > I have only two suggestions: > - gsbase_offset == 0 (key == i) could also be valid, so it would be useful to distinguish this case. It can't be valid because that would put the TLS at the beginning of struct _pthread, but the ABI actually reveals the first couple of fields. pthread_t is a typedef for __darwin_pthread_t which is a typedef for struct _opaque_pthread_t which is defined (not just declared) in the headers (/usr/include/sys/_pthread/_pthread_types.h in the 10.11 SDK) and is less opaque than its name would suggest. Comments in the definition of struct _pthread in libpthread make note of the ABI compatibility factor. In practice, the TLS array is at the end of the struct and I think Apple told us it has to be there. > - the logic could be moved to a helper function, for example using the init once mechanism I suppose, but it will be called for the first thread before there's a chance of creating secondary threads. So, there's no race. Also, I haven't looked, but I'm not sure what thread setup has to have been completed before RtlRunOnceExecuteOnce() can safely be used. -Ken

July 27, 2016

Re: [PATCH 3/3] ntdll: For Mac 64-bit, poke NtCurrentTeb()->ThreadLocalStoragePointer to the corresponding offset from %gs.

by Sebastian Lackner

On 27.07.2016 19:42, Ken Thomases wrote: >> >> Hm, I see. Do you know if the offset really changed in the past? > > Yes, it has changed in the past. > >> I am asking >> because I assume the bruteforcing is an attempt to make the code more reliable, >> however on the other hand you still make the assumption that pthread keys >> directly correspond to indices into the %gs segment, which could also change. > > Well, we made various proposals to Apple to get a more comprehensive, less kludgy fix and they were rejected because of binary compatibility. Basically, they were unwilling to change how pthread_getspecific() works. Mono depends on it, for example. So, it seems pretty reliable. > >> A check that it matches expected behavior is probably sufficient. >> >> Besides that, if the gsbase cannot be located, it probably would be preferred >> to skip this code on following attempts. > > It already does that. gsbase_offset is static. It will only be negative on the first call. Sorry, I missed the "gsbase_offset = 0;" call. You are probably right that there is not much to improve unless Apple offers a better interface. I have only two suggestions: - gsbase_offset == 0 (key == i) could also be valid, so it would be useful to distinguish this case. - the logic could be moved to a helper function, for example using the init once mechanism > > -Ken >

July 27, 2016

Re: [PATCH 3/3] ntdll: For Mac 64-bit, poke NtCurrentTeb()->ThreadLocalStoragePointer to the corresponding offset from %gs.

by Ken Thomases

On Jul 27, 2016, at 12:14 PM, Sebastian Lackner <sebastian(a)fds-team.de> wrote: > > On 27.07.2016 18:27, Ken Thomases wrote: >> On Jul 27, 2016, at 11:06 AM, Sebastian Lackner <sebastian(a)fds-team.de> wrote: >>> >>> On 27.07.2016 17:42, Ken Thomases wrote: >>>> 64-bit Windows apps have hard-coded accesses to %gs:0x58 baked into them. They >>>> need to find the ThreadLocalStoragePointer there. >>>> >>>> Technically, the gsbase register and the memory it points to belong to the >>>> pthread implementation on macOS. It's used for the pthread TLS implementation. >>>> Slot 11 (offset 0x58) is currently used for the implementation of the ttyname() >>>> system library function. We do not anticipate that Wine or any of the system >>>> libraries or frameworks it uses will call ttyname(). Furthermore, Apple has >>>> made it so that future releases of macOS will no longer use that slot. So, we >>>> hijack it for our purposes. >>>> >>>> Signed-off-by: Ken Thomases <ken(a)codeweavers.com> >>>> --- >>>> dlls/ntdll/loader.c | 11 +++++++- >>>> dlls/ntdll/signal_x86_64.c | 62 ++++++++++++++++++++++++++++++++++++++++++++++ >>>> 2 files changed, 72 insertions(+), 1 deletion(-) >>> >>> I'm not sure if I correctly understand the purpose of this patch. If you have to >>> set %gs:0x58 to some specific value, why not just use an assembly instruction for that? >>> >> >> alloc_tls_slot() is setting ThreadLocalStoragePointer for all threads, not just the current one. >> >> -Ken >> > > Hm, I see. Do you know if the offset really changed in the past? Yes, it has changed in the past. > I am asking > because I assume the bruteforcing is an attempt to make the code more reliable, > however on the other hand you still make the assumption that pthread keys > directly correspond to indices into the %gs segment, which could also change. Well, we made various proposals to Apple to get a more comprehensive, less kludgy fix and they were rejected because of binary compatibility. Basically, they were unwilling to change how pthread_getspecific() works. Mono depends on it, for example. So, it seems pretty reliable. > A check that it matches expected behavior is probably sufficient. > > Besides that, if the gsbase cannot be located, it probably would be preferred > to skip this code on following attempts. It already does that. gsbase_offset is static. It will only be negative on the first call. -Ken

July 27, 2016

Re: [PATCH 3/3] ntdll: For Mac 64-bit, poke NtCurrentTeb()->ThreadLocalStoragePointer to the corresponding offset from %gs.

by Sebastian Lackner

On 27.07.2016 18:27, Ken Thomases wrote: > On Jul 27, 2016, at 11:06 AM, Sebastian Lackner <sebastian(a)fds-team.de> wrote: >> >> On 27.07.2016 17:42, Ken Thomases wrote: >>> 64-bit Windows apps have hard-coded accesses to %gs:0x58 baked into them. They >>> need to find the ThreadLocalStoragePointer there. >>> >>> Technically, the gsbase register and the memory it points to belong to the >>> pthread implementation on macOS. It's used for the pthread TLS implementation. >>> Slot 11 (offset 0x58) is currently used for the implementation of the ttyname() >>> system library function. We do not anticipate that Wine or any of the system >>> libraries or frameworks it uses will call ttyname(). Furthermore, Apple has >>> made it so that future releases of macOS will no longer use that slot. So, we >>> hijack it for our purposes. >>> >>> Signed-off-by: Ken Thomases <ken(a)codeweavers.com> >>> --- >>> dlls/ntdll/loader.c | 11 +++++++- >>> dlls/ntdll/signal_x86_64.c | 62 ++++++++++++++++++++++++++++++++++++++++++++++ >>> 2 files changed, 72 insertions(+), 1 deletion(-) >> >> I'm not sure if I correctly understand the purpose of this patch. If you have to >> set %gs:0x58 to some specific value, why not just use an assembly instruction for that? >> > > alloc_tls_slot() is setting ThreadLocalStoragePointer for all threads, not just the current one. > > -Ken > Hm, I see. Do you know if the offset really changed in the past? I am asking because I assume the bruteforcing is an attempt to make the code more reliable, however on the other hand you still make the assumption that pthread keys directly correspond to indices into the %gs segment, which could also change. A check that it matches expected behavior is probably sufficient. Besides that, if the gsbase cannot be located, it probably would be preferred to skip this code on following attempts.

July 27, 2016

Re: [PATCH 1/3] ntdll: For Mac 64-bit, poke the TEB address to %gs:0x30 and re-enable the inlining of NtCurrentTeb().

by Ken Thomases

On Jul 27, 2016, at 11:38 AM, Sebastian Lackner <sebastian(a)fds-team.de> wrote: > > On 27.07.2016 18:30, Ken Thomases wrote: >> On Jul 27, 2016, at 11:08 AM, Sebastian Lackner <sebastian(a)fds-team.de> wrote: >>> >>> On 27.07.2016 17:42, Ken Thomases wrote: >>>> 64-bit Windows apps have hard-coded accesses to %gs:0x30 baked into them. They >>>> need to find the TEB self pointer there. >>>> >>>> Technically, the gsbase register and the memory it points to belong to the >>>> pthread implementation on macOS. It's used for the pthread TLS implementation. >>>> However, study of the sources and experimentation reveal that TLS slot 6 >>>> (offset 0x30) is not currently used. Furthermore, Apple has promised to not >>>> use that slot in the future. So, we hijack it for our purposes. >>>> >>>> This removes the implementation of NtCurrentTeb() based on pthread_key_create() >>>> and pthread_set/getspecific(). >>>> >>>> Signed-off-by: Ken Thomases <ken(a)codeweavers.com> >>>> --- >>>> dlls/ntdll/ntdll.spec | 2 +- >>>> dlls/ntdll/signal_x86_64.c | 34 +++------------------------------- >>>> include/winnt.h | 2 +- >>>> 3 files changed, 5 insertions(+), 33 deletions(-) >>> >>> Nice to hear that Apple agreed to keep that slot reserved. Would it make sense to >>> keep the NtCurrentTeb export neverthless, for compatibility with libraries compiled >>> against old Wine? >> >> Hmm. I don't know. I hadn't considered it. What sorts of libraries? Did you have some use case in mind? I guess I'd be surprised if there were such libraries around. >> >> -Ken >> > > I'm not sure if there are any important examples, but all libraries / executables > compiled with the old Wine headers will have references to the NtCurrentTeb export. > If users should still be able to use any previously compiled code, it would be > necessary to keep them. Thats also why we decided to keep it in our Staging patchset. Previously compiled code other than Wine itself, right? I.e. winelib apps. Which call NtCurrentTeb(). Built for Mac 64-bit. I guess I don't think that's an important case, but if others disagree I can change the patch. -Ken

July 27, 2016

Re: [PATCH 1/3] ntdll: For Mac 64-bit, poke the TEB address to %gs:0x30 and re-enable the inlining of NtCurrentTeb().

by Sebastian Lackner

On 27.07.2016 18:30, Ken Thomases wrote: > On Jul 27, 2016, at 11:08 AM, Sebastian Lackner <sebastian(a)fds-team.de> wrote: >> >> On 27.07.2016 17:42, Ken Thomases wrote: >>> 64-bit Windows apps have hard-coded accesses to %gs:0x30 baked into them. They >>> need to find the TEB self pointer there. >>> >>> Technically, the gsbase register and the memory it points to belong to the >>> pthread implementation on macOS. It's used for the pthread TLS implementation. >>> However, study of the sources and experimentation reveal that TLS slot 6 >>> (offset 0x30) is not currently used. Furthermore, Apple has promised to not >>> use that slot in the future. So, we hijack it for our purposes. >>> >>> This removes the implementation of NtCurrentTeb() based on pthread_key_create() >>> and pthread_set/getspecific(). >>> >>> Signed-off-by: Ken Thomases <ken(a)codeweavers.com> >>> --- >>> dlls/ntdll/ntdll.spec | 2 +- >>> dlls/ntdll/signal_x86_64.c | 34 +++------------------------------- >>> include/winnt.h | 2 +- >>> 3 files changed, 5 insertions(+), 33 deletions(-) >> >> Nice to hear that Apple agreed to keep that slot reserved. Would it make sense to >> keep the NtCurrentTeb export neverthless, for compatibility with libraries compiled >> against old Wine? > > Hmm. I don't know. I hadn't considered it. What sorts of libraries? Did you have some use case in mind? I guess I'd be surprised if there were such libraries around. > > -Ken > I'm not sure if there are any important examples, but all libraries / executables compiled with the old Wine headers will have references to the NtCurrentTeb export. If users should still be able to use any previously compiled code, it would be necessary to keep them. Thats also why we decided to keep it in our Staging patchset.

July 27, 2016

Re: [PATCH 1/3] ntdll: For Mac 64-bit, poke the TEB address to %gs:0x30 and re-enable the inlining of NtCurrentTeb().

by Ken Thomases

On Jul 27, 2016, at 11:08 AM, Sebastian Lackner <sebastian(a)fds-team.de> wrote: > > On 27.07.2016 17:42, Ken Thomases wrote: >> 64-bit Windows apps have hard-coded accesses to %gs:0x30 baked into them. They >> need to find the TEB self pointer there. >> >> Technically, the gsbase register and the memory it points to belong to the >> pthread implementation on macOS. It's used for the pthread TLS implementation. >> However, study of the sources and experimentation reveal that TLS slot 6 >> (offset 0x30) is not currently used. Furthermore, Apple has promised to not >> use that slot in the future. So, we hijack it for our purposes. >> >> This removes the implementation of NtCurrentTeb() based on pthread_key_create() >> and pthread_set/getspecific(). >> >> Signed-off-by: Ken Thomases <ken(a)codeweavers.com> >> --- >> dlls/ntdll/ntdll.spec | 2 +- >> dlls/ntdll/signal_x86_64.c | 34 +++------------------------------- >> include/winnt.h | 2 +- >> 3 files changed, 5 insertions(+), 33 deletions(-) > > Nice to hear that Apple agreed to keep that slot reserved. Would it make sense to > keep the NtCurrentTeb export neverthless, for compatibility with libraries compiled > against old Wine? Hmm. I don't know. I hadn't considered it. What sorts of libraries? Did you have some use case in mind? I guess I'd be surprised if there were such libraries around. -Ken

July 27, 2016

Re: [PATCH 3/3] ntdll: For Mac 64-bit, poke NtCurrentTeb()->ThreadLocalStoragePointer to the corresponding offset from %gs.

by Ken Thomases

On Jul 27, 2016, at 11:06 AM, Sebastian Lackner <sebastian(a)fds-team.de> wrote: > > On 27.07.2016 17:42, Ken Thomases wrote: >> 64-bit Windows apps have hard-coded accesses to %gs:0x58 baked into them. They >> need to find the ThreadLocalStoragePointer there. >> >> Technically, the gsbase register and the memory it points to belong to the >> pthread implementation on macOS. It's used for the pthread TLS implementation. >> Slot 11 (offset 0x58) is currently used for the implementation of the ttyname() >> system library function. We do not anticipate that Wine or any of the system >> libraries or frameworks it uses will call ttyname(). Furthermore, Apple has >> made it so that future releases of macOS will no longer use that slot. So, we >> hijack it for our purposes. >> >> Signed-off-by: Ken Thomases <ken(a)codeweavers.com> >> --- >> dlls/ntdll/loader.c | 11 +++++++- >> dlls/ntdll/signal_x86_64.c | 62 ++++++++++++++++++++++++++++++++++++++++++++++ >> 2 files changed, 72 insertions(+), 1 deletion(-) > > I'm not sure if I correctly understand the purpose of this patch. If you have to > set %gs:0x58 to some specific value, why not just use an assembly instruction for that? > alloc_tls_slot() is setting ThreadLocalStoragePointer for all threads, not just the current one. -Ken

July 27, 2016

Re: [PATCH 1/3] ntdll: For Mac 64-bit, poke the TEB address to %gs:0x30 and re-enable the inlining of NtCurrentTeb().

by Sebastian Lackner

On 27.07.2016 17:42, Ken Thomases wrote: > 64-bit Windows apps have hard-coded accesses to %gs:0x30 baked into them. They > need to find the TEB self pointer there. > > Technically, the gsbase register and the memory it points to belong to the > pthread implementation on macOS. It's used for the pthread TLS implementation. > However, study of the sources and experimentation reveal that TLS slot 6 > (offset 0x30) is not currently used. Furthermore, Apple has promised to not > use that slot in the future. So, we hijack it for our purposes. > > This removes the implementation of NtCurrentTeb() based on pthread_key_create() > and pthread_set/getspecific(). > > Signed-off-by: Ken Thomases <ken(a)codeweavers.com> > --- > dlls/ntdll/ntdll.spec | 2 +- > dlls/ntdll/signal_x86_64.c | 34 +++------------------------------- > include/winnt.h | 2 +- > 3 files changed, 5 insertions(+), 33 deletions(-) Nice to hear that Apple agreed to keep that slot reserved. Would it make sense to keep the NtCurrentTeb export neverthless, for compatibility with libraries compiled against old Wine?

July 27, 2016

Re: [PATCH 3/3] ntdll: For Mac 64-bit, poke NtCurrentTeb()->ThreadLocalStoragePointer to the corresponding offset from %gs.

by Sebastian Lackner

On 27.07.2016 17:42, Ken Thomases wrote: > 64-bit Windows apps have hard-coded accesses to %gs:0x58 baked into them. They > need to find the ThreadLocalStoragePointer there. > > Technically, the gsbase register and the memory it points to belong to the > pthread implementation on macOS. It's used for the pthread TLS implementation. > Slot 11 (offset 0x58) is currently used for the implementation of the ttyname() > system library function. We do not anticipate that Wine or any of the system > libraries or frameworks it uses will call ttyname(). Furthermore, Apple has > made it so that future releases of macOS will no longer use that slot. So, we > hijack it for our purposes. > > Signed-off-by: Ken Thomases <ken(a)codeweavers.com> > --- > dlls/ntdll/loader.c | 11 +++++++- > dlls/ntdll/signal_x86_64.c | 62 ++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 72 insertions(+), 1 deletion(-) I'm not sure if I correctly understand the purpose of this patch. If you have to set %gs:0x58 to some specific value, why not just use an assembly instruction for that?

July 27, 2016

Re: [v2 PATCH] ucrtbase: Implement _get_narrow_winmain_command_line/_get_wide_winmain_command_line

by Dmitry Timoshkov

Piotr Caban <piotr.caban(a)gmail.com> wrote: > >>> Once again: > >>> Where did you get an idea of such an implementation? Is this copied from > >>> some place or based on some other implementation? Why for instance simple > >>> 'return GetCommandLineA()' is not enough as an initial implementation? > >> > >> Probably I'm just stating obvious but the function skips executable name > >> from the command line. That's why returning what GetCommandLineA returns > >> is incorrect. > > > > From what documentation/description is that obvious? That's not a common > > practice to send patches for not very obvious things without any tests. > > Why this implementation treats specially tabs and spaces but not other > > white space characters? Is that also obvious? How about the tests for > > quotes/embedded quotes? > > > I was not asking Nikolay for the tests because I think it's not easy to > write them. Some interesting tests needs executable name with ' ' in its > name. I also don't like the idea of starting many processes just to test > the function. On the other hand the initial test executable may be > started in many different ways (like e.g. passing first argument quoted > makes it impossible to check the return with simple comparison). > > That doesn't mean that I'm against adding a test or 2 for that. Anyway I > think this implementation is good after doing some tests myself. Testing on your own is good, however that doesn't count like an answer to my questions above which still left unanswered. If Wine development would follow this kind of quality control it wouldn't get that far as it is now. -- Dmitry.

July 27, 2016

Re: [v2 PATCH] ucrtbase: Implement _get_narrow_winmain_command_line/_get_wide_winmain_command_line

by Piotr Caban

On 07/27/16 15:29, Dmitry Timoshkov wrote: > Piotr Caban <piotr.caban(a)gmail.com> wrote: > >>> Once again: >>> Where did you get an idea of such an implementation? Is this copied from >>> some place or based on some other implementation? Why for instance simple >>> 'return GetCommandLineA()' is not enough as an initial implementation? >> >> Probably I'm just stating obvious but the function skips executable name >> from the command line. That's why returning what GetCommandLineA returns >> is incorrect. > > From what documentation/description is that obvious? That's not a common > practice to send patches for not very obvious things without any tests. > Why this implementation treats specially tabs and spaces but not other > white space characters? Is that also obvious? How about the tests for > quotes/embedded quotes? > I was not asking Nikolay for the tests because I think it's not easy to write them. Some interesting tests needs executable name with ' ' in its name. I also don't like the idea of starting many processes just to test the function. On the other hand the initial test executable may be started in many different ways (like e.g. passing first argument quoted makes it impossible to check the return with simple comparison). That doesn't mean that I'm against adding a test or 2 for that. Anyway I think this implementation is good after doing some tests myself.

July 27, 2016

Re: [PATCH 1/6] amstream: Fix AMAudioData::QueryInterface.

by Nikolay Sivov

On 27.07.2016 15:51, Anton Baskanov wrote: > Signed-off-by: Anton Baskanov <baskanov(a)gmail.com> > --- > dlls/amstream/audiodata.c | 1 - > dlls/amstream/tests/Makefile.in | 3 +- > dlls/amstream/tests/audiodata.c | 67 +++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 69 insertions(+), 2 deletions(-) > create mode 100755 dlls/amstream/tests/audiodata.c Hi, Anton. Please keep tests in existing amstream.c file. + > +static void test_query_interface(void) > +{ > + IUnknown *unknown = create_audio_data(); > + IMemoryData *memory_data = NULL; > + IAudioData *audio_data = NULL; > + > + HRESULT result = S_OK; result initialization is not needed; > + > + result = IUnknown_QueryInterface(unknown, &IID_IMemoryData, (void **)&memory_data); > + ok(E_NOINTERFACE == result, "got 0x%08x\n", result); > + if (S_OK == result) > + { > + IMemoryData_Release(memory_data); > + } If it always fails, there's no reason add conditional Release. > + > + result = IUnknown_QueryInterface(unknown, &IID_IAudioData, (void **)&audio_data); > + ok(S_OK == result, "got 0x%08x\n", result); > + if (S_OK == result) > + { > + IAudioData_Release(audio_data); > + } > + > + IUnknown_Release(unknown); > +} Could you check if you can query IMemoryData from IAudioData? It seems really weird if parent interface is not supported at all.

July 27, 2016

Re: [v2 PATCH] ucrtbase: Implement _get_narrow_winmain_command_line/_get_wide_winmain_command_line

by Dmitry Timoshkov

Piotr Caban <piotr.caban(a)gmail.com> wrote: > > Once again: > > Where did you get an idea of such an implementation? Is this copied from > > some place or based on some other implementation? Why for instance simple > > 'return GetCommandLineA()' is not enough as an initial implementation? > > Probably I'm just stating obvious but the function skips executable name > from the command line. That's why returning what GetCommandLineA returns > is incorrect. >From what documentation/description is that obvious? That's not a common practice to send patches for not very obvious things without any tests. Why this implementation treats specially tabs and spaces but not other white space characters? Is that also obvious? How about the tests for quotes/embedded quotes? -- Dmitry.

July 27, 2016

Re: MPR patches

by Pierre Schweitzer

Thanks for your review. I did a complete resubmission according to your review (3 patches already sent + the missing one). Le 27/07/2016 à 14:31, Hugh McMaster a écrit : > > On Wednesday, 27 July 2016, Pierre Schweitzer wrote: >> Regarding 1. & 3. should I perform a resend with that changed, or should >> I change it in the next patch I submit? >> >> For 2., this is done on purpose. Real implementation will come in a >> later patch (already ready and tested here :-)). > > Personally, I'd submit your real implementation of WNetCancelConnection2W > as patch 1 of 2. Then submit your implementation patch using the WCHAR * style > as the second patch. > > But if you decide to keep to your original order, please change the style before sending. > > You should also rebase your patches on the latest git. Your current patch > has an offset of -87 lines. > > As for your security certificate, although it doesn't prevent the patch from applying, > it would be better removed, if possible. > > Le 27/07/2016 à 13:40, Hugh McMaster a écrit : >> On Wednesday, 27 July 2016 6:40 AM, Pierre Schweitzer wrote: >> >>> Is there any reason why the MPR patches are left abandoned? There are >>> others awaiting in my queue... >> >>> + PWSTR name = strdupAtoW(lpName); >>> + if (!name) >>> + return ERROR_NOT_CONNECTED; >> >> 1. New code should use the WCHAR * style. >> >> 2. All three functions call WNetCancelConnection2W, but that function is a stub: >> >> DWORD WINAPI WNetCancelConnection2W( LPCWSTR lpName, DWORD dwFlags, BOOL fForce ) >> { >> FIXME( "(%s, %08X, %d), stub\n", debugstr_w(lpName), dwFlags, fForce ); >> >> return WN_SUCCESS; >> } >> >> 3. Your mail has a StartCom Secure Digital Certificate attached. This has been mangled, as can be seen at the bottom of your patch: http://source.winehq.org/patches/data/124723 > > -- Pierre Schweitzer <pierre at reactos.org> System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V.

July 27, 2016

RE: MPR patches

by Hugh McMaster

On Wednesday, 27 July 2016, Pierre Schweitzer wrote: > Regarding 1. & 3. should I perform a resend with that changed, or should > I change it in the next patch I submit? > > For 2., this is done on purpose. Real implementation will come in a > later patch (already ready and tested here :-)). Personally, I'd submit your real implementation of WNetCancelConnection2W as patch 1 of 2. Then submit your implementation patch using the WCHAR * style as the second patch. But if you decide to keep to your original order, please change the style before sending. You should also rebase your patches on the latest git. Your current patch has an offset of -87 lines. As for your security certificate, although it doesn't prevent the patch from applying, it would be better removed, if possible. Le 27/07/2016 à 13:40, Hugh McMaster a écrit : > On Wednesday, 27 July 2016 6:40 AM, Pierre Schweitzer wrote: > >> Is there any reason why the MPR patches are left abandoned? There are >> others awaiting in my queue... > >> + PWSTR name = strdupAtoW(lpName); >> + if (!name) >> + return ERROR_NOT_CONNECTED; > > 1. New code should use the WCHAR * style. > > 2. All three functions call WNetCancelConnection2W, but that function is a stub: > > DWORD WINAPI WNetCancelConnection2W( LPCWSTR lpName, DWORD dwFlags, BOOL fForce ) > { > FIXME( "(%s, %08X, %d), stub\n", debugstr_w(lpName), dwFlags, fForce ); > > return WN_SUCCESS; > } > > 3. Your mail has a StartCom Secure Digital Certificate attached. This has been mangled, as can be seen at the bottom of your patch: http://source.winehq.org/patches/data/124723

July 27, 2016

Re: MPR patches

by Pierre Schweitzer

Hi, Thanks for your feedback. Regarding 1. & 3. should I perform a resend with that changed, or should I change it in the next patch I submit? For 2., this is done on purpose. Real implementation will come in a later patch (already ready and tested here :-)). Le 27/07/2016 à 13:40, Hugh McMaster a écrit : > On Wednesday, 27 July 2016 6:40 AM, Pierre Schweitzer wrote: > >> Is there any reason why the MPR patches are left abandoned? There are >> others awaiting in my queue... > >> + PWSTR name = strdupAtoW(lpName); >> + if (!name) >> + return ERROR_NOT_CONNECTED; > > 1. New code should use the WCHAR * style. > > 2. All three functions call WNetCancelConnection2W, but that function is a stub: > > DWORD WINAPI WNetCancelConnection2W( LPCWSTR lpName, DWORD dwFlags, BOOL fForce ) > { > FIXME( "(%s, %08X, %d), stub\n", debugstr_w(lpName), dwFlags, fForce ); > > return WN_SUCCESS; > } > > 3. Your mail has a StartCom Secure Digital Certificate attached. This has been mangled, as can be seen at the bottom of your patch: http://source.winehq.org/patches/data/124723 > > Hugh > -- Pierre Schweitzer <pierre at reactos.org> System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V.

July 27, 2016

Re: MPR patches

by Hugh McMaster

On Wednesday, 27 July 2016 6:40 AM, Pierre Schweitzer wrote: > Is there any reason why the MPR patches are left abandoned? There are > others awaiting in my queue... > + PWSTR name = strdupAtoW(lpName); > + if (!name) > + return ERROR_NOT_CONNECTED; 1. New code should use the WCHAR * style. 2. All three functions call WNetCancelConnection2W, but that function is a stub: DWORD WINAPI WNetCancelConnection2W( LPCWSTR lpName, DWORD dwFlags, BOOL fForce ) { FIXME( "(%s, %08X, %d), stub\n", debugstr_w(lpName), dwFlags, fForce ); return WN_SUCCESS; } 3. Your mail has a StartCom Secure Digital Certificate attached. This has been mangled, as can be seen at the bottom of your patch: http://source.winehq.org/patches/data/124723 Hugh

July 27, 2016

Re: [v2 PATCH] ucrtbase: Implement _get_narrow_winmain_command_line/_get_wide_winmain_command_line

by Piotr Caban

On 07/26/16 04:32, Dmitry Timoshkov wrote: > Once again: > Where did you get an idea of such an implementation? Is this copied from > some place or based on some other implementation? Why for instance simple > 'return GetCommandLineA()' is not enough as an initial implementation? Probably I'm just stating obvious but the function skips executable name from the command line. That's why returning what GetCommandLineA returns is incorrect. Thanks, Piotr

July 27, 2016

Re: [PATCH] ucrtbase: Expose the fabsf function on arm

by Piotr Caban

Hi Martin, On 07/26/16 12:19, Martin Storsjo wrote: > It isn't available in the x86 or x64 versions of ucrtbase.dll > or api-ms-win-crt-math-l1-1-0.dll, but exists (and gets used by > MSVC 2015) on arm. > --- > dlls/api-ms-win-crt-math-l1-1-0/api-ms-win-crt-math-l1-1-0.spec | 1 + > dlls/ucrtbase/ucrtbase.spec | 1 + > 2 files changed, 2 insertions(+) you forgot to sign-off your patch. Except of that it looks good for me. Thanks, Piotr

July 27, 2016

Re: [PATCH 2/3 v2] kernel32/tests/loader: Add tests for fiber-local storage.

by Alexandre Julliard

John Sheu <sheu(a)google.com> writes: > Signed-off-by: John Sheu <sheu(a)google.com> > --- > dlls/kernel32/tests/loader.c | 118 ++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 116 insertions(+), 2 deletions(-) Could you please rebase it against recent changes, and resend with a fixed sequence number so that it can run through the testbot? -- Alexandre Julliard julliard(a)winehq.org

July 26, 2016

Re: WineHQ upgrade breaking dinput8:dinput?

by Bernhard Übelacker

Hello Francois, "DirectX Software Development Kit" offers in "DirectX Control Panel" to increase the "Debug Output Level". That way one can get another hint from dinput: DINPUT8: ERROR IDirectInput8::EnumDevicesBySemantics: arg 2: invalid UNICODE string First I tried to build a dinput8.dll that just dumps the data it gets from dinput-mini.exe, but could not find any difference. So I did some tests with DIACTIONA.lptszActionName member. When the two last characters get replaced by \0 no fault is reported anymore. That way a succeeding exe and the failing differ (nearly) just in the two replaced bytes in lptszActionName. Therefore can we assume that it is not the compilers fault, instead it uncovered a hidden bug either in the test or dinput? Kind regards, Bernhard dinput.c: - { 4, DIMOUSE_YAXIS, 0, { "Y Axis" } } + { 4, DIMOUSE_YAXIS, 0, { "Y Ax\0\0" } } Am 17.07.2016 um 21:02 schrieb Bernhard Übelacker: > Hello, > just tried to find out when this started exactly. > > > First by using old packages from snapshot.debian.org. > That revealed it started between packages: > gcc-mingw-w64-i686_4.6.4-4+9_i386.deb > gcc-mingw-w64-i686_4.8.2-5+10_i386.deb > > > A git bisect of gcc history points to this commit: > https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=ff2a5adaa72fef87cac689a40… > > > ff2a5adaa72fef87cac689a40c23258a30b304c8 is the first bad commit > commit ff2a5adaa72fef87cac689a40c23258a30b304c8 > Author: hubicka <hubicka(a)138bc75d-0d04-0410-961f-82ee72b054a4> > Date: Sun Apr 22 21:28:07 2012 +0000 > > * lto-symtab.c (lto_varpool_replace_node): Do not merge needed flags. > (...much longer commit message...) > > git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk(a)186687 138bc75d-0d04-0410-961f-82ee72b054a4 > > :040000 040000 d706bdeafbddb9f5f02474e39a245dca08f3334a 508082a31919fe9e907f70b3b3278d4f8d953fac M gcc > > > > Testbot runs: > Good: (gcc 62c34bf, last one before ff2a5ad) > https://testbot.winehq.org/JobDetails.pl?Key=24283 > Bad: (gcc ff2a5ad) > https://testbot.winehq.org/JobDetails.pl?Key=24280 > > > > Hope this could be of any help to identify the issue. > > > Kind regards, > Bernhard > > > Notes: > - Did not install gcc build system wide. Instead set the PATH > that i686-w64-mingw32-gcc was taken from there. > - Initial wine configure step was done using Jessie default > gcc-mingw-w64-i686 4.9.1-19+14.3. > Then the iterations were just done by removing objects > from dlls/dinput8/tests and make dinput8_crosstest.exe. > - GCC history before 1e37e371 did segfault while building, > therefore started from there. > > > > > Am 24.04.2016 um 20:30 schrieb Francois Gouget: >> >> I have rechecked this to make sure the test does not have a subtle bug >> that causes it to depend on the stack layout. >> >> >> In the process I have reduced the test to the minimum set necessary to >> reproduce the bug (see attachment). But in the end I did not find >> anything wrong so it does look like a compiler bug. >> >> I don't know how to proceed from there. >> >> * I think it would be better if someone more knowlegeable than me >> reported this bug to the MinGW guys. Maybe someone who could undertand >> what happens in the assembly code? >> >> * On the Wine side it would really be nice to get this test (and >> the three others that are impacted) to stop failing. But removing all >> the static directives really does not feel right. Would it be better >> to arrange for these tests to be compiled with -O0? Any other cleaner >> workaround. >> >> So I'm really hoping someone can step up and move this forward. >> >> >> Here are the relevant bugs: >> * dinput8:dinput regression caused by new compiler >> https://bugs.winehq.org/show_bug.cgi?id=40384 >> >> * usp10:usp10 regression caused by new cross-compiler >> https://bugs.winehq.org/show_bug.cgi?id=40385 >> >> * wininet:url regression caused by new cross-compiler >> https://bugs.winehq.org/show_bug.cgi?id=40386 >> >> * Unexplained new random comctl32:header failure (cross-compiler issue?) >> https://bugs.winehq.org/show_bug.cgi?id=40442 >> >> >> >> > > >

July 26, 2016

MPR patches

by Pierre Schweitzer

Hi, Is there any reason why the MPR patches are left abandoned? There are others awaiting in my queue... Cheers, -- Pierre Schweitzer <pierre at reactos.org> System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V.

July 26, 2016

Re: [PATCH 6/6] d3d11/tests: Add visual tests for locking vertexbuffers

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=24541 Your paranoid android. === wvistau64 (32 bit d3d11) === d3d11: unhandled exception 0000087c at 75A2E743 === w2008s64 (32 bit d3d11) === d3d11: unhandled exception 0000087c at 7680E743 === w7u (32 bit d3d11) === d3d11: unhandled exception c0000005 at 004022D6 === w7pro64 (32 bit d3d11) === d3d11: unhandled exception c0000005 at 004022D6 === w8 (32 bit d3d11) === d3d11: unhandled exception c0000005 at 004022D6 === w864 (32 bit d3d11) === d3d11: unhandled exception c0000005 at 004022D6 === w1064 (32 bit d3d11) === d3d11: unhandled exception c0000005 at 004022D6 === wvistau64 (64 bit d3d11) === d3d11: unhandled exception 0000087c at 000000007765674D === w2008s64 (64 bit d3d11) === d3d11: unhandled exception 0000087c at 0000000076EA674D === w7pro64 (64 bit d3d11) === d3d11: unhandled exception c0000005 at 000000000040217C === w864 (64 bit d3d11) === d3d11: unhandled exception c0000005 at 000000000040217C === w1064 (64 bit d3d11) === d3d11: unhandled exception c0000005 at 000000000040217C

July 26, 2016

Re: [PATCH 5/6] d3d10core/tests: Add visual tests for locking vertexbuffers

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=24540 Your paranoid android. === wvistau64 (32 bit device) === device: unhandled exception 00000879 at 75A2E743 === w2008s64 (32 bit device) === device: unhandled exception 00000879 at 7680E743 === w7u (32 bit device) === device: unhandled exception c0000005 at 00406895 === w7pro64 (32 bit device) === device: unhandled exception c0000005 at 00406895 === w8 (32 bit device) === device: unhandled exception c0000005 at 00406895 === w864 (32 bit device) === device: unhandled exception c0000005 at 00406895 === w1064 (32 bit device) === device: unhandled exception c0000005 at 00406895 === wvistau64 (64 bit device) === device: unhandled exception 00000879 at 000000007765674D === w2008s64 (64 bit device) === device: unhandled exception 00000879 at 0000000076EA674D === w7pro64 (64 bit device) === device: unhandled exception c0000005 at 0000000000405C40 === w864 (64 bit device) === device: unhandled exception c0000005 at 0000000000405C40 === w1064 (64 bit device) === device: unhandled exception c0000005 at 0000000000405C40

July 26, 2016

Re: [PATCH 4/6] ddraw/tests: Add visual tests for locking vertexbuffers

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=24539 Your paranoid android. === w8 (32 bit visual) === visual.c:1688: Test failed: Expected buffer mapped unsyncronized. Flags = DDLOCK_NOOVERWRITE. dwCaps = 0x10000. visual.c:1688: Test failed: Expected buffer mapped unsyncronized. Flags = DDLOCK_NOOVERWRITE | DDLOCK_DISCARDCONTENTS. dwCaps = 0x10000. visual.c:1688: Test failed: Expected buffer mapped unsyncronized. Flags = DDLOCK_NOOVERWRITE | DDLOCK_READONLY. dwCaps = 0x10000. === w864 (32 bit visual) === visual.c:307: Test failed: Clear rectangle 3(pos, neg) has color 0000ff00 visual.c:309: Test failed: Clear rectangle 1(pos, pos) has color 0000ff00 visual.c:311: Test failed: Clear rectangle 4(NULL) has color 0000ff00 visual.c:313: Test failed: Clear rectangle 4(neg, neg) has color 0000ff00 visual.c:1688: Test failed: Expected buffer mapped unsyncronized. Flags = DDLOCK_NOOVERWRITE. dwCaps = 0x10000. visual.c:1688: Test failed: Expected buffer mapped unsyncronized. Flags = DDLOCK_NOOVERWRITE | DDLOCK_DISCARDCONTENTS. dwCaps = 0x10000. visual.c:1688: Test failed: Expected buffer mapped unsyncronized. Flags = DDLOCK_NOOVERWRITE | DDLOCK_READONLY. dwCaps = 0x10000. === w1064 (32 bit visual) === visual.c:307: Test failed: Clear rectangle 3(pos, neg) has color 0000ff00 visual.c:309: Test failed: Clear rectangle 1(pos, pos) has color 0000ff00 visual.c:311: Test failed: Clear rectangle 4(NULL) has color 0000ff00 visual.c:313: Test failed: Clear rectangle 4(neg, neg) has color 0000ff00 visual.c:1688: Test failed: Expected buffer mapped unsyncronized. Flags = DDLOCK_NOOVERWRITE. dwCaps = 0x10000. visual.c:1688: Test failed: Expected buffer mapped unsyncronized. Flags = DDLOCK_NOOVERWRITE | DDLOCK_DISCARDCONTENTS. dwCaps = 0x10000. visual.c:1688: Test failed: Expected buffer mapped unsyncronized. Flags = DDLOCK_NOOVERWRITE | DDLOCK_READONLY. dwCaps = 0x10000.

July 26, 2016

Re: [PATCH] msxml2: Share source with msxml3

by Alexandre Julliard

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > Since msxml2/4/6 all point to msxml3, having to install native > msxml3 will cause all the rest to fail. As an example, mdac28 > requires msxml3 to be installed (msxml3 has an incomplete IXMLParser > implementation, so native has to be used). I would change msxml4/6 as > well, so that installing any of the native msxml DLL wouldn't affect the > others. > > We could just use my previous patch, which would also resolve the issue > of registry entry. That scenario is > 1. Clean prefix. > 2. Install native msxml3 > 3. Force update of bottle (e.g. wine update) > The msxml2.DOMDocument registry entry is now incorrect. That's a corner case that I don't think justifies duplicating such a large dll 4 times. It should be easy to avoid by using native for the other ones too. And of course fixing builtin would be even better... -- Alexandre Julliard julliard(a)winehq.org

July 26, 2016

Re: [PATCH] msxml2: Share source with msxml3

by Alistair Leslie-Hughes

On 26/07/16 20:43, Alexandre Julliard wrote: > Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > >> Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> >> --- >> dlls/msxml2/Makefile.in | 49 ++++++++++++++++++++++++++++++++++++-- >> dlls/msxml2/main.c | 63 ------------------------------------------------- >> dlls/msxml2/msxml2.spec | 2 +- >> 3 files changed, 48 insertions(+), 66 deletions(-) >> delete mode 100644 dlls/msxml2/main.c > > Is there a real need for this? > yes and no. Since msxml2/4/6 all point to msxml3, having to install native msxml3 will cause all the rest to fail. As an example, mdac28 requires msxml3 to be installed (msxml3 has an incomplete IXMLParser implementation, so native has to be used). I would change msxml4/6 as well, so that installing any of the native msxml DLL wouldn't affect the others. We could just use my previous patch, which would also resolve the issue of registry entry. That scenario is 1. Clean prefix. 2. Install native msxml3 3. Force update of bottle (e.g. wine update) The msxml2.DOMDocument registry entry is now incorrect. (this would still fail if you want to create an Msxml2.DOMDocument.4.0 object) Best Regards Alistair Leslie-Hughes

July 26, 2016

Re: [PATCH] msxml2: Share source with msxml3

by Alexandre Julliard

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > dlls/msxml2/Makefile.in | 49 ++++++++++++++++++++++++++++++++++++-- > dlls/msxml2/main.c | 63 ------------------------------------------------- > dlls/msxml2/msxml2.spec | 2 +- > 3 files changed, 48 insertions(+), 66 deletions(-) > delete mode 100644 dlls/msxml2/main.c Is there a real need for this? -- Alexandre Julliard julliard(a)winehq.org

July 26, 2016

Re: [PATCH 3/8] wined3d: Implement SM5 deriv_rtx_coarse instruction.

by Józef Kucia

On Tue, Jul 26, 2016 at 1:41 AM, Matteo Bruni <matteo.mystral(a)gmail.com> wrote: > What about using the generic dFdx()/dFdy() builtins (maybe with a > WARN) for the coarse and fine variants when ARB_derivative_control > isn't supported? > I don't know that it's particularly relevant in practice, it just > seems something we don't need to strictly depend on. I have no idea if this is issue in practice but wined3d currently requires ARB_derivative_control for SM5. I guess we can add a fallback to dFdx()/dFdy() if we find an OpenGL implementation which is otherwise capable to support SM5 but doesn't expose ARB_derivative_control.

July 26, 2016

Re: [PATCH 3/8] wined3d: Implement SM5 deriv_rtx_coarse instruction.

by Józef Kucia

On Mon, Jul 25, 2016 at 12:48 PM, Henri Verbeet <hverbeet(a)gmail.com> wrote: > It doesn't matter that much, but is there any reason > shader_glsl_map2gl() can't handle these? I've introduced shader_glsl_derivative() mostly to make the check for ARB_derivative_control simpler. I could have reordered patches as well to avoid introducing shader_glsl_derivative() at all, but I wasn't sure if someone won't be in favor of replacing the patch 124699 - "wined3d: Require ARB_derivative_control for SM5." with a fallback to dFdx()/dFdy().

July 26, 2016

Re: [v2 PATCH] ucrtbase: Implement _get_narrow_winmain_command_line/_get_wide_winmain_command_line

by Dmitry Timoshkov

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > +char* CDECL _get_narrow_winmain_command_line(void) > +{ > + static char *narrow_command_line; > + char *s; > + > + if (narrow_command_line) > + return narrow_command_line; > + > + s = GetCommandLineA(); > + if (*s == '"') > + { > + /* skip all leading quotes */ > + while (*++s == '"') > + ; > + /* skip everything up to next quote */ > + while (*s && *s++ != '"') > + ; > + } > + else > + { > + while (*s && *s != ' ' && *s != '\t') > + { > + /* allow embedded quoted blocks */ > + if (*s == '"') > + { > + s++; > + while (*s && *s++ != '"') > + ; > + } > + else > + s++; > + } > + } > + while (*s == ' ' || *s == '\t') > + s++; > + > + return narrow_command_line = s; > +} Once again: Where did you get an idea of such an implementation? Is this copied from some place or based on some other implementation? Why for instance simple 'return GetCommandLineA()' is not enough as an initial implementation? -- Dmitry.

July 25, 2016

Re: [PATCH 3/8] wined3d: Implement SM5 deriv_rtx_coarse instruction.

by Matteo Bruni

2016-07-22 12:28 GMT+02:00 Józef Kucia <jkucia(a)codeweavers.com>: > + if (!gl_info->supported[ARB_DERIVATIVE_CONTROL]) > + { > + FIXME("OpenGL implementation does not support ARB_derivative_control.\n"); > + return; > + } What about using the generic dFdx()/dFdy() builtins (maybe with a WARN) for the coarse and fine variants when ARB_derivative_control isn't supported? I don't know that it's particularly relevant in practice, it just seems something we don't need to strictly depend on.

July 25, 2016

Re: d3dx9_36: Fix a typo in TRACE() message.

by Matteo Bruni

2016-07-25 10:24 GMT+02:00 Andrey Gusev <andrey.goosev(a)gmail.com>: > > + TRACE("pout %p, pv %p, pviewport %p, pprojection %p, pview %p, pworld %p\n", pout, pv, pviewport, pprojection, pview, pworld); While you're there, can you please clean up the function? Like dropping all the 'p' prefixes from the function arguments and using the current d3d style for the function body. Also the TRACE line seems a bit too long.

July 25, 2016

Re: include: Fix prototypes of D3DXFillXXXTextureTx for d3dx9.

by Matteo Bruni

2016-07-21 11:06 GMT+02:00 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>: > -HRESULT WINAPI D3DXFillTextureTX(struct IDirect3DTexture9 *texture, const DWORD *function, > - const D3DXVECTOR4 *constants, UINT numconstants); > -HRESULT WINAPI D3DXFillCubeTextureTX(struct IDirect3DCubeTexture9 *cube, const DWORD *function, > - const D3DXVECTOR4 *constants, UINT numconstants); > -HRESULT WINAPI D3DXFillVolumeTextureTX(struct IDirect3DVolumeTexture9 *volume, const DWORD *function, > - const D3DXVECTOR4 *constants, UINT numconstants); > +HRESULT WINAPI D3DXFillTextureTX(struct IDirect3DTexture9 *texture, ID3DXTextureShader *texture_shader); > +HRESULT WINAPI D3DXFillCubeTextureTX(struct IDirect3DCubeTexture9 *cube, ID3DXTextureShader *texture_shader); > +HRESULT WINAPI D3DXFillVolumeTextureTX(struct IDirect3DVolumeTexture9 *volume, ID3DXTextureShader *texture_shader); Do you know where the old prototypes came from? In all the versions of the header I have around (which go back to _30) I see the "new" prototype but it's possible that it changed even further back. It's also possible these have always been wrong, although that seems somewhat unlikely to me.

July 25, 2016

Re: [PATCH] d3dx9: Implement D3DXCreateTextureShader with stubbed ID3DXTextureShader interface.

by Matteo Bruni

2016-07-21 11:06 GMT+02:00 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>: > +HRESULT WINAPI D3DXCreateTextureShader(const DWORD *function, ID3DXTextureShader **texture_shader) > +{ > + struct d3dx9_texture_shader *object; > + > + TRACE("function %p, texture_shader %p.\n", function, texture_shader); > + > + if (!function || !texture_shader) > + return D3DERR_INVALIDCALL; > + > + object = HeapAlloc(GetProcessHeap(), 0, sizeof(*object)); > + if (!object) > + return E_OUTOFMEMORY; > + > + object->ID3DXTextureShader_iface.lpVtbl = &d3dx9_texture_shader_vtbl; > + object->ref = 1; > + > + *texture_shader = &object->ID3DXTextureShader_iface; > + > + return D3D_OK; > +} It would be nice to have a test for this.

July 25, 2016

Re: [PATCH] d3dx10: Add D3DXCpuOptimizations stub

by Matteo Bruni

2016-07-20 7:34 GMT+02:00 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>: > On 20/07/16 15:04, Alex Henrie wrote: >> + * Copyright (C) 2007 David Adam >> + * Copyright (C) 2007 Tony Wasserka >> >> Did these people actually contribute anything to this patch? > No, it was a copy from d3dx9math.h > >> Also, D3DX_CPU_OPTIMIZATION was already defined in d3dx9_30_main.c. I >> would remove the old definition from d3dx9_30_main.c and make it >> include d3dx10math.h instead. >> > To remove the D3DX_CPU_OPTIMIZATION definition would be a separate patch > in it's own right. I will have to workout where it should be > defined for d3dx9. Including a dx10 header in dx9 seems like a bad idea. Yeah. D3DX_CPU_OPTIMIZATION is not defined in "recent" d3dx9 headers AFAICS so it's probably fine as it is. > > Best Regards > Alistair Leslie-Hughes

July 25, 2016

Re: [v3 PATCH] d3dx10: Add D3DXCpuOptimizations stub

by Matteo Bruni

2016-07-20 11:20 GMT+02:00 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>: Hi Alistair, I'm afraid this is going to be a bit nitpicky. It also means the patch is mostly okay though. > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > dlls/d3dx10_43/d3dx10_43.spec | 2 +- > dlls/d3dx10_43/d3dx10_43_main.c | 11 +++++++-- > include/Makefile.in | 1 + > include/d3dx10.h | 1 + > include/d3dx10math.h | 49 +++++++++++++++++++++++++++++++++++++++++ > 5 files changed, 61 insertions(+), 3 deletions(-) > create mode 100644 include/d3dx10math.h > > diff --git a/dlls/d3dx10_43/d3dx10_43.spec b/dlls/d3dx10_43/d3dx10_43.spec > index ab696e8..f410be8 100644 > --- a/dlls/d3dx10_43/d3dx10_43.spec > +++ b/dlls/d3dx10_43/d3dx10_43.spec > @@ -70,7 +70,7 @@ > @ stdcall D3DXColorAdjustSaturation(ptr ptr float) d3dx9_36.D3DXColorAdjustSaturation > @ stdcall D3DXComputeBoundingBox(ptr long long ptr ptr) d3dx9_36.D3DXComputeBoundingBox > @ stdcall D3DXComputeBoundingSphere(ptr long long ptr ptr) d3dx9_36.D3DXComputeBoundingSphere > -@ stub D3DXCpuOptimizations(long) > +@ stdcall D3DXCpuOptimizations(long) > @ stdcall D3DXCreateMatrixStack(long ptr) d3dx9_36.D3DXCreateMatrixStack > @ stdcall D3DXFloat16To32Array(ptr ptr long) d3dx9_36.D3DXFloat16To32Array > @ stdcall D3DXFloat32To16Array(ptr ptr long) d3dx9_36.D3DXFloat32To16Array > diff --git a/dlls/d3dx10_43/d3dx10_43_main.c b/dlls/d3dx10_43/d3dx10_43_main.c > index 0c1ff80..408cf22 100644 > --- a/dlls/d3dx10_43/d3dx10_43_main.c > +++ b/dlls/d3dx10_43/d3dx10_43_main.c > @@ -34,8 +34,8 @@ > #include "objbase.h" > > #include "d3d10_1.h" > -#include "d3dx10core.h" > -#include "d3dx10tex.h" > +#include "d3dx10.h" > + > > WINE_DEFAULT_DEBUG_CHANNEL(d3dx); No reason to add double whitespace lines here. > > @@ -210,3 +210,10 @@ HRESULT WINAPI D3DX10GetImageInfoFromMemory(const void *src_data, SIZE_T src_dat > > return E_NOTIMPL; > } > + > +D3DX_CPU_OPTIMIZATION WINAPI D3DXCpuOptimizations(BOOL enable) > +{ > + FIXME("enable %d stub.\n", enable); Can you please use %#x when tracing BOOL arguments? > +#include "d3dx10.h" > + > +/* This guard is the same as D3DX9 to prevent double-inclusion */ > +#ifndef __D3DX9MATH_H__ > +#define __D3DX9MATH_H__ > + > +#include <math.h> > + > + > +typedef enum _D3DX_CPU_OPTIMIZATION > +{ > + D3DX_NOT_OPTIMIZED = 0, > + D3DX_3DNOW_OPTIMIZED = 1, > + D3DX_SSE2_OPTIMIZED = 2, > + D3DX_SSE_OPTIMIZED = 3 > +} D3DX_CPU_OPTIMIZATION; I would go the other way and drop all the initializers instead. It's fine either way though. Also double whitespace again. > + > +#ifdef __cplusplus > +extern "C" { > +#endif > + > +D3DX_CPU_OPTIMIZATION WINAPI D3DXCpuOptimizations(BOOL enable); > + > +#ifdef __cplusplus > +} > +#endif > + > + > +/*#include <d3dx10math.inl> */ I don't like this. Either introduce d3dx10math.inl and make this an actual include (preferred) or just remove the line for the time being.

July 25, 2016

Re: [PATCH] ucrtbase: Implement _get_narrow_winmain_command_line/_get_wide_winmain_command_line

by Nikolay Sivov

On 25.07.2016 16:13, Piotr Caban wrote: > On 07/24/16 20:40, Nikolay Sivov wrote: >> +/********************************************************************* >> + * _get_narrow_winmain_command_line (UCRTBASE.@) >> + */ >> +char* CDECL _get_narrow_winmain_command_line(void) >> +{ >> + static char *narrow_command_line; >> + char *s; >> + >> + if (narrow_command_line) >> + return narrow_command_line; >> + >> + s = GetCommandLineA(); >> + if (*s == '"') >> + { >> + s++; >> + while (*s) >> + if (*s++ == '"') >> + break; >> + } >> + else >> + { >> + while (*s && *s != ' ' && *s != '\t') >> + s++; >> + } >> + while (*s == ' ' || *s == '\t') >> + s++; >> + >> + return narrow_command_line = s; >> +} > It will not work in following case (executable name "test ws.exe"): > CMD> test" "ws.exe other args > or > CMD> """test ws.exe" other args > Probably there's no real use case for that but it shouldn't be hard to > handle this cases as well. > Thanks for the review, I just sent improved version.

July 25, 2016

Re: [v2] ntdll: Keep drive letter size in RtlGetFullPathName_U when full path is specified

by Alexandre Julliard

Piotr Caban <piotr(a)codeweavers.com> writes: > v2: > - fix cmd test failure Looks like there's another one I missed: ../../../tools/runtest -q -P wine -T ../../.. -M shell32.dll -p shell32_test.exe.so shelllink && touch shelllink.ok shelllink.c:251: Test failed: case doesn't match make: *** [shelllink.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

July 25, 2016

Re: [PATCH] msxml2: Let msxml3 register Msxml2.DOMDocument

by Alexandre Julliard

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > When msxml3 is native, msxml2 forwards to msxml3 which then fails > to create an object. On Windows 8.1, Msxml2.DOMDocument > point to Msxml2.DOMDocument.3.0. That should be the case on Wine too. It sounds like there's something broken with your config. Note that mixing native and builtin is not a good idea. -- Alexandre Julliard julliard(a)winehq.org

July 25, 2016

Re: [PATCH] ucrtbase: Implement _get_narrow_winmain_command_line/_get_wide_winmain_command_line

by Piotr Caban

On 07/24/16 20:40, Nikolay Sivov wrote: > +/********************************************************************* > + * _get_narrow_winmain_command_line (UCRTBASE.@) > + */ > +char* CDECL _get_narrow_winmain_command_line(void) > +{ > + static char *narrow_command_line; > + char *s; > + > + if (narrow_command_line) > + return narrow_command_line; > + > + s = GetCommandLineA(); > + if (*s == '"') > + { > + s++; > + while (*s) > + if (*s++ == '"') > + break; > + } > + else > + { > + while (*s && *s != ' ' && *s != '\t') > + s++; > + } > + while (*s == ' ' || *s == '\t') > + s++; > + > + return narrow_command_line = s; > +} It will not work in following case (executable name "test ws.exe"): CMD> test" "ws.exe other args or CMD> """test ws.exe" other args Probably there's no real use case for that but it shouldn't be hard to handle this cases as well. Thanks, Piotr

July 25, 2016

Re: [PATCH 02/03 v4 ] ntoskrnl.exe: Track drivers created with IoCreateDriver

by Aric Stewart

Thanks! New version sent! -aric On 7/24/16 1:05 PM, Thomas Faber wrote: >> NTSTATUS WINAPI IoCreateDriver( UNICODE_STRING *name, PDRIVER_INITIALIZE init ) >> { >> - DRIVER_OBJECT *driver; >> - DRIVER_EXTENSION *extension; >> + struct wine_driver *driver; >> NTSTATUS status; >> >> TRACE("(%s, %p)\n", debugstr_us(name), init); >> >> if (!(driver = RtlAllocateHeap( GetProcessHeap(), HEAP_ZERO_MEMORY, >> - sizeof(*driver) + sizeof(*extension) ))) >> + sizeof(*driver) ))) >> return STATUS_NO_MEMORY; >> >> - if ((status = RtlDuplicateUnicodeString( 1, name, &driver->DriverName ))) >> + if ((status = RtlDuplicateUnicodeString( 1, name, &driver->driver_obj.DriverName))) > > Missing space before the closing parenthesis here. ;p > >> { >> RtlFreeHeap( GetProcessHeap(), 0, driver ); >> return status; >> } > > > >> @@ -892,13 +959,18 @@ NTSTATUS WINAPI IoCreateDriver( UNICODE_STRING *name, PDRIVER_INITIALIZE init ) >> /*********************************************************************** >> * IoDeleteDriver (NTOSKRNL.EXE.@) >> */ >> -void WINAPI IoDeleteDriver( DRIVER_OBJECT *driver ) >> +void WINAPI IoDeleteDriver( DRIVER_OBJECT *driver_object ) >> { >> - TRACE("(%p)\n", driver); >> + TRACE("(%p)\n", driver_object); >> + >> + EnterCriticalSection( &drivers_cs ); >> + if (wine_drivers) >> + wine_rb_remove( wine_drivers, &driver_object->DriverName ); >> + LeaveCriticalSection( &drivers_cs ); >> >> - RtlFreeUnicodeString( &driver->DriverName ); >> - RtlFreeUnicodeString( &driver->DriverExtension->ServiceKeyName ); >> - RtlFreeHeap( GetProcessHeap(), 0, driver ); >> + RtlFreeUnicodeString( &driver_object->DriverName ); >> + RtlFreeUnicodeString( &driver_object->DriverExtension->ServiceKeyName ); >> + RtlFreeHeap( GetProcessHeap(), 0, driver_object ); >> } > > You need to free the wine_driver now rather than the DRIVER_OBJECT, > i.e. use CONTAINING_RECORD. > > > Thanks, > Thomas > >

July 25, 2016