August 2016 - Wine-Devel - list.winehq.org

Re: [PATCH 1/1] gdiplus: Fix for the "graphics object has no HDC" issue in GdipDrawPath

by Vincent Povirk

>> We really need an implementation that doesn't rely on gdi32. > > Because of performance you mean? Because it seems like a lot of code > duplication to me. Is it really necessary to differentiate between Software > and GDI? Not just because of performance. Gdiplus has some features that gdi32 does not, such as anti-aliasing, semi-transparent brushes, and gradient brushes.

Aug. 30, 2016

Re: [PATCH 1/1] gdiplus: Fix for the "graphics object has no HDC" issue in GdipDrawPath

by Fabian Maurer

On Tuesday, August 30, 2016 4:29:35 PM CEST Vincent Povirk wrote: > We really need an implementation that doesn't rely on gdi32. Because of performance you mean? Because it seems like a lot of code duplication to me. Is it really necessary to differentiate between Software and GDI?

Aug. 30, 2016

Re: [PATCH 1/1] gdiplus: Fix for the "graphics object has no HDC" issue in GdipDrawPath

by Vincent Povirk

We really need an implementation that doesn't rely on gdi32.

Aug. 30, 2016

Re: How to find out the source code function from compiled running address

by Michael Müller

Am 30.08.2016 um 22:09 schrieb Bernhard Übelacker: > $ wine winedbg --gdb d3d8_test.exe.so > ... > 0025:0026: loads DLL C:\windows\system32\wined3d.dll @0x7ec20000 (0<0>) > ... > Wine-gdb> info symbol 0x7ec2EF19 > init_output_registers + 1172 in section .text of /.../dlls/wined3d/wined3d.dll.so > This does not work in case wined3d got relocated. You can either use addr2line or winedbg directly on the target process. For addr2line you need to know the base address of wined3d in the crashed process and then use something like: addr2line -e wined3d.dll.so -j .text 0xdeadbeef where 0xdeadbeef is the address of the crash minus the base address of the ELF section as shown in the crash dump. I think using winedbg is easier. Either directly start the process using winedbg or in case the process detects debuggers, you can also SHIFT + right click on the crash dialog to start winedbg. Then you can just use bt to display the backtrace including the source code lines (although the output should be identical to the crash dialog). For arbitrary addresses, you can just disassemble some instructions, it should also display the filename and line number using x/10i 0xdeadbeef. You can also use registers this way (for example x/10i $eip). If the application sets up its own crash handler, you can either attach to the process when it displays an error by starting winedbg as standalone program and then use "info process" and "attach 0x...". This way you won't get a correct backtrace though, so you might want to edit dlls/ntdll/signal_i386.c instead. I attached a hack to prevent 32 bit applications from catching access violations. In case they call SetUnhandledExceptionFilter, you also need to make this a noop as it replaces the handler to start the debugger. Regards, Michael

Aug. 30, 2016

Re: How to find out the source code function from compiled running address

by Bernhard Übelacker

Am 30.08.2016 um 21:03 schrieb Bruno Jesus: > wined3d.dll:7EBCEF19 mov eax, [ebp+8] > wined3d.dll:7EBCEF1C mov eax, [eax+0EC54h] > wined3d.dll:7EBCEF22 mov edx, [ebp-0Ch] > wined3d.dll:7EBCEF25 shl edx, 2 > wined3d.dll:7EBCEF28 add eax, edx > wined3d.dll:7EBCEF2A mov eax, [eax] > > Is there anyway to find out where is this function in the source code? Hello Bruno, probably you can run your test program with the gdb debugger: $ wine winedbg --gdb d3d8_test.exe.so ... 0025:0026: loads DLL C:\windows\system32\wined3d.dll @0x7ec20000 (0<0>) ... Wine-gdb> info symbol 0x7ec2EF19 init_output_registers + 1172 in section .text of /.../dlls/wined3d/wined3d.dll.so Hope this helps you. Kind regards, Bernhard

Aug. 30, 2016

Re: [PATCH 2/4] ntoskrnl.exe: Use static initializer for device_drivers.

by Sebastian Lackner

On 30.08.2016 21:30, Jacek Caban wrote: > Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> > --- > dlls/ntoskrnl.exe/ntoskrnl.c | 40 ++++++++-------------------------------- > 1 file changed, 8 insertions(+), 32 deletions(-) > Wouldn't it be better to use a macro similar to LIST_INIT() for that (to allow later changes of the internal structure)?

Aug. 30, 2016

Re: [3/3] imm32,user32: Create and destroy the default IME window implicitly. (try 9; resend)

by Sebastian Lackner

On 23.08.2016 15:13, Akihiro Sagawa wrote: > > Try 9: > - Withdraw try 8 changes as we have ImmDisableIME now. > - Rebased and resolve conflicts against ImmDisableIME patch. > > Signed-off-by: Akihiro Sagawa <sagawa.aki(a)gmail.com> > --- > dlls/imm32/imm.c | 99 +++++++++++++++++++++++++++++++++++----------- > dlls/imm32/imm32.spec | 1 + > dlls/imm32/tests/imm32.c | 12 +++--- > dlls/user32/misc.c | 4 +- > dlls/user32/user_private.h | 1 + > dlls/user32/win.c | 26 ++++++++++++ > dlls/user32/win.h | 1 + > 7 files changed, 113 insertions(+), 31 deletions(-) This patch broke various user32 tests in virtual desktop mode, for example: $ (cd dlls/user32/tests/; make broadcast.ok) ../../../tools/runtest -q -P wine -T ../../.. -M user32.dll -p user32_test.exe.so broadcast && touch broadcast.ok broadcast.c:174: Test failed: Asynchronous message sent instead broadcast.c:152: Test failed: Returned: 0 broadcast.c:153: Test failed: Asynchronous message sent instead broadcast.c:174: Test failed: Asynchronous message sent instead broadcast.c:238: Test failed: Returned: 0 broadcast.c:239: Test failed: Asynchronous message sent instead broadcast.c:257: Test failed: Asynchronous message sent instead broadcast.c:238: Test failed: Returned: 0 broadcast.c:239: Test failed: Asynchronous message sent instead broadcast.c:257: Test failed: Asynchronous message sent instead broadcast.c:298: Test failed: Returned: 0 error 1460 broadcast.c:299: Test failed: Asynchronous message sent instead broadcast.c:309: Test failed: Returned: 0 error 1460 broadcast.c:310: Test failed: Asynchronous message sent instead broadcast.c:320: Test failed: Returned: 0 error 1460 broadcast.c:321: Test failed: Asynchronous message sent instead broadcast.c:332: Test failed: Asynchronous message sent instead make: *** [Makefile:197: broadcast.ok] Fehler 17 Could you please take a look?

Aug. 30, 2016

How to find out the source code function from compiled running address

by Bruno Jesus

Hi all. While trying to run a crashing application I used a debugger and found out the crash is inside wined3d, I then started looking for ways to convert that address back into what function it should be so I can breakpoint it and check. At first I got into http://www.nirsoft.net/utils/dll_export_viewer.html and it looked like what I needed but the program does not seem to work in Wine DLLs. Adding +d3d,+relay and checking the calls is awfully verbose, but I'm still trying it. Part of the function showing the addresses, last line crashes: wined3d.dll:7EBCEF19 mov eax, [ebp+8] wined3d.dll:7EBCEF1C mov eax, [eax+0EC54h] wined3d.dll:7EBCEF22 mov edx, [ebp-0Ch] wined3d.dll:7EBCEF25 shl edx, 2 wined3d.dll:7EBCEF28 add eax, edx wined3d.dll:7EBCEF2A mov eax, [eax] Is there anyway to find out where is this function in the source code? Best regards, Bruno

Aug. 30, 2016

Re: [PATCH 1/5] ddraw/tests: Move IDirect3DViewport::TransformVertices tests to ddraw1.c.

by Henri Verbeet

On 29 August 2016 at 23:01, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > + * is transformed, and this vertex is offscreen.· Trailing whitespace. As an aside, those float comparisons are probably safe enough, but perhaps those should use compare_vec4()?

Aug. 30, 2016

Re: kernel32: Stub CAL_RETURN_GENITIVE_NAMES flag.

by David Keijser

Oh, my bad. Didn't even think to check that. I'll post an updated one shortly. On Tue, Aug 30, 2016 at 9:16 AM Nikolay Sivov <bunglehead(a)gmail.com> wrote: > On 29.08.2016 22:24, David Keijser wrote: > > This stops GetCalendarInfoW from reporting unknown caltype when it's > > really a case of unsupported flags. > > > > Signed-off-by: David Keijser <keijser(a)gmail.com> > > --- > > dlls/kernel32/time.c | 4 +++- > > include/winnls.h | 7 ++++--- > > 2 files changed, 7 insertions(+), 4 deletions(-) > > > > diff --git a/dlls/kernel32/time.c b/dlls/kernel32/time.c > > index b7a7918..e1fd107 100644 > > --- a/dlls/kernel32/time.c > > +++ b/dlls/kernel32/time.c > > @@ -860,6 +860,8 @@ int WINAPI GetCalendarInfoW(LCID Locale, CALID > Calendar, CALTYPE CalType, > > FIXME("flag CAL_NOUSEROVERRIDE used, not fully implemented\n"); > > if (CalType & CAL_USE_CP_ACP) > > FIXME("flag CAL_USE_CP_ACP used, not fully implemented\n"); > > + if (CalType & CAL_RETURN_GENITIVE_NAMES) > > + FIXME("flag CAL_RETURN_GENITIVE_NAMES used, not fully > implemented\n"); > > Hi, David. > > LOCALE_RETURN_GENITIVE_NAMES itself is implemented, you should pass it > to GetLocaleInfo instead of stripping it from caltype. > > P.S. anyone working on translations please take another look at > SMONTHNAME* constants for your language, to make sure genitive forms are > there, if applicable. > > > > > if (CalType & CAL_RETURN_NUMBER) { > > if (!lpValue) > > @@ -878,7 +880,7 @@ int WINAPI GetCalendarInfoW(LCID Locale, CALID > Calendar, CALTYPE CalType, > > > > /* FIXME: No verification is made yet wrt Locale > > * for the CALTYPES not requiring GetLocaleInfoA */ > > - switch (CalType & > ~(CAL_NOUSEROVERRIDE|CAL_RETURN_NUMBER|CAL_USE_CP_ACP)) { > > + switch (CalType & > ~(CAL_NOUSEROVERRIDE|CAL_RETURN_NUMBER|CAL_USE_CP_ACP|CAL_RETURN_GENITIVE_NAMES)) > { > > case CAL_ICALINTVALUE: > > if (CalType & CAL_RETURN_NUMBER) > > return GetLocaleInfoW(Locale, LOCALE_RETURN_NUMBER | > LOCALE_ICALENDARTYPE, > > diff --git a/include/winnls.h b/include/winnls.h > > index 1a7baaf..3d950f6 100644 > > --- a/include/winnls.h > > +++ b/include/winnls.h > > @@ -471,9 +471,10 @@ static const WCHAR LOCALE_NAME_SYSTEM_DEFAULT[] = > {'!','s','y','s','-','d','e',' > > #define MAX_DEFAULTCHAR 2 > > > > /* Defines for calendar handling */ > > -#define CAL_NOUSEROVERRIDE LOCALE_NOUSEROVERRIDE > > -#define CAL_USE_CP_ACP LOCALE_USE_CP_ACP > > -#define CAL_RETURN_NUMBER LOCALE_RETURN_NUMBER > > +#define CAL_NOUSEROVERRIDE LOCALE_NOUSEROVERRIDE > > +#define CAL_USE_CP_ACP LOCALE_USE_CP_ACP > > +#define CAL_RETURN_NUMBER LOCALE_RETURN_NUMBER > > +#define CAL_RETURN_GENITIVE_NAMES LOCALE_RETURN_GENITIVE_NAMES > > > > #define CAL_ICALINTVALUE 0x01 > > #define CAL_SCALNAME 0x02 > > > >

Aug. 30, 2016