August 2016 - Wine-Devel - list.winehq.org

Re: Issues if GLX_SWAP_METHOD_OML is not fully supported

by Fabian Maurer

> As such this would be a driver bug and should be fixed in Mesa. Have you > raised a bug report there? I submitted a report just now: https://bugs.freedesktop.org/show_bug.cgi? id=97516 I just don't know if it's maybe a problem with context creation, I'm not too familiar with that yet. Fabian Maurer

Aug. 28, 2016

Re: How to link winreg.h to winejoystick.drv during compilation

by DavidL

Ah, that would explain it ... On Sunday, August 28, 2016, Stefan Dösinger <stefandoesinger(a)gmail.com> wrote: > On 2016-08-27 14:09, DavidL wrote: > > Huh ... this is embarrassing, although pleasantly so: it just compiled > > and linked - I don't know why, I don't think I made any changes - but it > > works now. I will investigate a little bit further to see if the why is > > interesting and report what I might've done if so ... probably something > > stupid :) > If you edit Makefile.in you have to run make from the top level > directory, not just dlls/winejoystick.drv/ to regenerate Makefile. > > >

Aug. 28, 2016

Re: dxdiagn: Do fill DMI information on Linux

by Chris Robinson

On 08/28/2016 02:50 AM, Ruslan Kabatsayev wrote: > This patch makes previously empty fields szSystemManufacturerEnglish, > szSystemManufacturerEnglish and szBIOSEnglish in DxDiag filled with the > DMI information. This is the same information I get on my test Windows > system. > Currently this is only implemented for Linux, on other platforms > the fields remain empty. Are there functions to get this info in the Windows API? If so, it may be worth using/implementing those API calls, instead of reading it directly from the host like this.

Aug. 28, 2016

Re: Issues if GLX_SWAP_METHOD_OML is not fully supported

by Stefan Dösinger

On 2016-08-27 18:31, Fabian Maurer wrote: > Is this a graphics driver issue? I'm using the most recent open source mesa > drivers. > Attached a patch proposal to deal with the issue in wine, but I'm not sure if > this is the right course of action to take. GLX_OML_swap_method doesn't explicitly say if it considers a partial support (e.g. GLX_SWAP_COPY_OML is supported, but GLX_SWAP_EXCHANGE_OML isn't) valid. My interpretation is that both are required if the extension is advertised because the extension lists both as accepted values for glXChooseFBConfig and doesn't have any language saying that an error may be generated if the implementation can't support your choice. As such this would be a driver bug and should be fixed in Mesa. Have you raised a bug report there?

Aug. 28, 2016

Re: How to link winreg.h to winejoystick.drv during compilation

by Stefan Dösinger

On 2016-08-27 14:09, DavidL wrote: > Huh ... this is embarrassing, although pleasantly so: it just compiled > and linked - I don't know why, I don't think I made any changes - but it > works now. I will investigate a little bit further to see if the why is > interesting and report what I might've done if so ... probably something > stupid :) If you edit Makefile.in you have to run make from the top level directory, not just dlls/winejoystick.drv/ to regenerate Makefile.

Aug. 28, 2016

Re: [v1 1/5] winejoystick.drv: Add functionality to disable joystick via registry

by Bruno Jesus

On Sun, Aug 28, 2016 at 3:18 AM, David Lawrie <david.dljunk(a)gmail.com> wrote: > Adds device_disabled_registry, helper functions to shared joystick code Hi, thanks for working on this. The problem with this series is that you are introducing dead code in patches 1, 2 and 3. As the code is not used anywhere until patch 5. Patch 4 also adds dead code that is only used in patch 5. IMO you should merge patches 1,2,3 into a single patch and also 4 and 5 into second patch. This will make the dead code will last a single commit. Best wishes, Bruno

Aug. 28, 2016

Issues if GLX_SWAP_METHOD_OML is not fully supported

by Fabian Maurer

Hello, I have an OpenGL program that tries to use WGL_SWAP_METHOD, but while my graphics card supports GLX_OML_swap_method, no pixelformat supports its value GLX_SWAP_EXCHANGE_OML. Is this a graphics driver issue? I'm using the most recent open source mesa drivers. Attached a patch proposal to deal with the issue in wine, but I'm not sure if this is the right course of action to take. Fabian Maurer

Aug. 27, 2016

Re: Add a GUI for dxdiag program

by Aaryaman Vasishta

On Sat, Aug 27, 2016 at 9:12 PM, Ruslan Kabatsayev <b7.10110111(a)gmail.com> wrote: > On Sat, Aug 27, 2016 at 12:31 PM, Aaryaman Vasishta > <jem456.vasishta(a)gmail.com> wrote: > >> > >> +INT_PTR CALLBACK system_tab_proc(HWND hsystab, UINT msg, WPARAM wparam, > >> LPARAM lparam) > >> +{ > >> + switch(msg) > >> + { > >> + case WM_COMMAND: > >> + switch(HIWORD(wparam)) > >> + { > >> + case BN_CLICKED: > >> + switch(wparam) > >> + { > >> + case IDC_WHQL_CHECKBOX: > >> + { > >> + update_dxdiag_info(); > >> + return TRUE; > >> + } > >> + } > >> + break; > > > > There's an indentation issue here. > Is there? Looking at original main.c I see that "case" labels are also > unindented there. Or do you mean something other? > Ah, my bad. I didn't really look at the whole file. If it's consistent with the rest of the file then it's fine :) Cheers, Aaryaman

Aug. 27, 2016

Re: Add a GUI for dxdiag program

by Ruslan Kabatsayev

On Sat, Aug 27, 2016 at 12:31 PM, Aaryaman Vasishta <jem456.vasishta(a)gmail.com> wrote: >> >> +INT_PTR CALLBACK system_tab_proc(HWND hsystab, UINT msg, WPARAM wparam, >> LPARAM lparam) >> +{ >> + switch(msg) >> + { >> + case WM_COMMAND: >> + switch(HIWORD(wparam)) >> + { >> + case BN_CLICKED: >> + switch(wparam) >> + { >> + case IDC_WHQL_CHECKBOX: >> + { >> + update_dxdiag_info(); >> + return TRUE; >> + } >> + } >> + break; > > There's an indentation issue here. Is there? Looking at original main.c I see that "case" labels are also unindented there. Or do you mean something other?

Aug. 27, 2016

Re: libwine: Do not compare strings "ab-c" and a-bc" as equal.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25415 Your paranoid android. === w1064 (32 bit locale) === locale.c:2562: Test failed: LCMapStringEx should fail with bad locale name locale.c:2563: Test failed: unexpected error code -559038737 locale.c:2654: Test failed: Expected lcid == 0, got 00001000, error -559038737 locale.c:4384: Test failed: IsValidLocaleName should have failed locale.c:4386: Test failed: IsValidLocaleName should have failed locale.c:4769: Test failed: For id 7, expected ret == 4, got 1, error 87 locale.c:4771: Test failed: For id 7, Expected IVC, got '' === w1064 (64 bit locale) === locale.c:2562: Test failed: LCMapStringEx should fail with bad locale name locale.c:2563: Test failed: unexpected error code -559038737 locale.c:2654: Test failed: Expected lcid == 0, got 00001000, error -559038737 locale.c:4384: Test failed: IsValidLocaleName should have failed locale.c:4386: Test failed: IsValidLocaleName should have failed locale.c:4769: Test failed: For id 7, expected ret == 4, got 1, error 87 locale.c:4771: Test failed: For id 7, Expected IVC, got ''

Aug. 27, 2016